[INFO] crate elastic_types_derive_internals 0.20.10 is already in cache [INFO] extracting crate elastic_types_derive_internals 0.20.10 into work/ex/clippy-test-run/sources/stable/reg/elastic_types_derive_internals/0.20.10 [INFO] extracting crate elastic_types_derive_internals 0.20.10 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/elastic_types_derive_internals/0.20.10 [INFO] validating manifest of elastic_types_derive_internals-0.20.10 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of elastic_types_derive_internals-0.20.10 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing elastic_types_derive_internals-0.20.10 [INFO] finished frobbing elastic_types_derive_internals-0.20.10 [INFO] frobbed toml for elastic_types_derive_internals-0.20.10 written to work/ex/clippy-test-run/sources/stable/reg/elastic_types_derive_internals/0.20.10/Cargo.toml [INFO] started frobbing elastic_types_derive_internals-0.20.10 [INFO] finished frobbing elastic_types_derive_internals-0.20.10 [INFO] frobbed toml for elastic_types_derive_internals-0.20.10 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/elastic_types_derive_internals/0.20.10/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting elastic_types_derive_internals-0.20.10 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/elastic_types_derive_internals/0.20.10:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 97c48a8b043bf854213f3044daf53b8695e0ae86a733639b92c77711b74c7d16 [INFO] running `"docker" "start" "-a" "97c48a8b043bf854213f3044daf53b8695e0ae86a733639b92c77711b74c7d16"` [INFO] [stderr] Checking syn v0.11.11 [INFO] [stderr] Checking serde_derive_internals v0.15.1 [INFO] [stderr] Checking elastic_types_derive_internals v0.20.10 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | return Err("Unable to get str from lit"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("Unable to get str from lit")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | return Err("Unable to get str from lit"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("Unable to get str from lit")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/elastic_type/mod.rs:167:5 [INFO] [stderr] | [INFO] [stderr] 167 | / match ctxt.check() { [INFO] [stderr] 168 | | Err(_) => return None, [INFO] [stderr] 169 | | _ => (), [INFO] [stderr] 170 | | }; [INFO] [stderr] | |_____^ help: try this: `if let Err(_) = ctxt.check() { return None }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/date_format/mod.rs:78:1 [INFO] [stderr] | [INFO] [stderr] 78 | / fn get_format_from_attr<'a>(item: &'a syn::MacroInput) -> Option<&'a str> { [INFO] [stderr] 79 | | let val = get_elastic_attr_name_value("date_format", item); [INFO] [stderr] 80 | | [INFO] [stderr] 81 | | val.and_then(|v| get_str_from_lit(v).ok()) [INFO] [stderr] 82 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/date_format/mod.rs:85:1 [INFO] [stderr] | [INFO] [stderr] 85 | / fn get_name_from_attr<'a>(item: &'a syn::MacroInput) -> Option<&'a str> { [INFO] [stderr] 86 | | let val = get_elastic_attr_name_value("date_format_name", item); [INFO] [stderr] 87 | | [INFO] [stderr] 88 | | val.and_then(|v| get_str_from_lit(v).ok()) [INFO] [stderr] 89 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:31:53 [INFO] [stderr] | [INFO] [stderr] 31 | syn::MetaItem::List(ref name, ref items) if name == &"elastic" => Some(items), [INFO] [stderr] | ^^^^^^^^---------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `"elastic"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:54:31 [INFO] [stderr] | [INFO] [stderr] 54 | get_str_from_lit(lit).map(|s| syn::Ident::from(s)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `syn::Ident::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/elastic_type/mod.rs:167:5 [INFO] [stderr] | [INFO] [stderr] 167 | / match ctxt.check() { [INFO] [stderr] 168 | | Err(_) => return None, [INFO] [stderr] 169 | | _ => (), [INFO] [stderr] 170 | | }; [INFO] [stderr] | |_____^ help: try this: `if let Err(_) = ctxt.check() { return None }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/date_format/mod.rs:78:1 [INFO] [stderr] | [INFO] [stderr] 78 | / fn get_format_from_attr<'a>(item: &'a syn::MacroInput) -> Option<&'a str> { [INFO] [stderr] 79 | | let val = get_elastic_attr_name_value("date_format", item); [INFO] [stderr] 80 | | [INFO] [stderr] 81 | | val.and_then(|v| get_str_from_lit(v).ok()) [INFO] [stderr] 82 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/date_format/mod.rs:85:1 [INFO] [stderr] | [INFO] [stderr] 85 | / fn get_name_from_attr<'a>(item: &'a syn::MacroInput) -> Option<&'a str> { [INFO] [stderr] 86 | | let val = get_elastic_attr_name_value("date_format_name", item); [INFO] [stderr] 87 | | [INFO] [stderr] 88 | | val.and_then(|v| get_str_from_lit(v).ok()) [INFO] [stderr] 89 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:31:53 [INFO] [stderr] | [INFO] [stderr] 31 | syn::MetaItem::List(ref name, ref items) if name == &"elastic" => Some(items), [INFO] [stderr] | ^^^^^^^^---------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `"elastic"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:54:31 [INFO] [stderr] | [INFO] [stderr] 54 | get_str_from_lit(lit).map(|s| syn::Ident::from(s)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `syn::Ident::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.71s [INFO] running `"docker" "inspect" "97c48a8b043bf854213f3044daf53b8695e0ae86a733639b92c77711b74c7d16"` [INFO] running `"docker" "rm" "-f" "97c48a8b043bf854213f3044daf53b8695e0ae86a733639b92c77711b74c7d16"` [INFO] [stdout] 97c48a8b043bf854213f3044daf53b8695e0ae86a733639b92c77711b74c7d16