[INFO] crate egg-mode-text 1.14.7 is already in cache [INFO] extracting crate egg-mode-text 1.14.7 into work/ex/clippy-test-run/sources/stable/reg/egg-mode-text/1.14.7 [INFO] extracting crate egg-mode-text 1.14.7 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/egg-mode-text/1.14.7 [INFO] validating manifest of egg-mode-text-1.14.7 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of egg-mode-text-1.14.7 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing egg-mode-text-1.14.7 [INFO] finished frobbing egg-mode-text-1.14.7 [INFO] frobbed toml for egg-mode-text-1.14.7 written to work/ex/clippy-test-run/sources/stable/reg/egg-mode-text/1.14.7/Cargo.toml [INFO] started frobbing egg-mode-text-1.14.7 [INFO] finished frobbing egg-mode-text-1.14.7 [INFO] frobbed toml for egg-mode-text-1.14.7 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/egg-mode-text/1.14.7/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting egg-mode-text-1.14.7 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/egg-mode-text/1.14.7:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7df6e0395c022d5920379fb82aff7b0150b1a92df6f12e6bbb5fba98c41e92ee [INFO] running `"docker" "start" "-a" "7df6e0395c022d5920379fb82aff7b0150b1a92df6f12e6bbb5fba98c41e92ee"` [INFO] [stderr] Checking egg-mode-text v1.14.7 (/opt/crater/workdir) [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:591:9 [INFO] [stderr] | [INFO] [stderr] 591 | / if match_ok { [INFO] [stderr] 592 | | if regexen::RE_END_HASHTAG.is_match(&substr[hashtag_range.1..]) { [INFO] [stderr] 593 | | match_ok = false; [INFO] [stderr] 594 | | } [INFO] [stderr] 595 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 591 | if match_ok && regexen::RE_END_HASHTAG.is_match(&substr[hashtag_range.1..]) { [INFO] [stderr] 592 | match_ok = false; [INFO] [stderr] 593 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:744:5 [INFO] [stderr] | [INFO] [stderr] 744 | len [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:742:15 [INFO] [stderr] | [INFO] [stderr] 742 | let len = text.chars().count() + url_offset; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:591:9 [INFO] [stderr] | [INFO] [stderr] 591 | / if match_ok { [INFO] [stderr] 592 | | if regexen::RE_END_HASHTAG.is_match(&substr[hashtag_range.1..]) { [INFO] [stderr] 593 | | match_ok = false; [INFO] [stderr] 594 | | } [INFO] [stderr] 595 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 591 | if match_ok && regexen::RE_END_HASHTAG.is_match(&substr[hashtag_range.1..]) { [INFO] [stderr] 592 | match_ok = false; [INFO] [stderr] 593 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:744:5 [INFO] [stderr] | [INFO] [stderr] 744 | len [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:742:15 [INFO] [stderr] | [INFO] [stderr] 742 | let len = text.chars().count() + url_offset; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:809:21 [INFO] [stderr] | [INFO] [stderr] 809 | const EXTRACT: &'static str = include_str!("extract.yml"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:810:22 [INFO] [stderr] | [INFO] [stderr] 810 | const VALIDATE: &'static str = include_str!("validate.yml"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:811:18 [INFO] [stderr] | [INFO] [stderr] 811 | const TLDS: &'static str = include_str!("tlds.yml"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:659:9 [INFO] [stderr] | [INFO] [stderr] 659 | / let mut match_ok = true; [INFO] [stderr] 660 | | [INFO] [stderr] 661 | | //check the text after the match to see if it's valid; this is because i can't use [INFO] [stderr] 662 | | //lookahead assertions in the regex crate and this is how it's implemented in the obj-c [INFO] [stderr] ... | [INFO] [stderr] 665 | | match_ok = false; [INFO] [stderr] 666 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let match_ok = if !regexen::RE_END_SYMBOL.is_match(&text[text_range.1..]) { false } else { true };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:659:9 [INFO] [stderr] | [INFO] [stderr] 659 | / let mut match_ok = true; [INFO] [stderr] 660 | | [INFO] [stderr] 661 | | //check the text after the match to see if it's valid; this is because i can't use [INFO] [stderr] 662 | | //lookahead assertions in the regex crate and this is how it's implemented in the obj-c [INFO] [stderr] ... | [INFO] [stderr] 665 | | match_ok = false; [INFO] [stderr] 666 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let match_ok = if !regexen::RE_END_SYMBOL.is_match(&text[text_range.1..]) { false } else { true };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 35 [INFO] [stderr] --> src/lib.rs:826:5 [INFO] [stderr] | [INFO] [stderr] 826 | / fn extract() { [INFO] [stderr] 827 | | let tests = yaml_rust::YamlLoader::load_from_str(EXTRACT).unwrap(); [INFO] [stderr] 828 | | let tests = tests.first().unwrap(); [INFO] [stderr] 829 | | let ref tests = tests["tests"]; [INFO] [stderr] ... | [INFO] [stderr] 1182 | | } [INFO] [stderr] 1183 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:829:13 [INFO] [stderr] | [INFO] [stderr] 829 | let ref tests = tests["tests"]; [INFO] [stderr] | ----^^^^^^^^^------------------ help: try: `let tests = &tests["tests"];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:864:13 [INFO] [stderr] | [INFO] [stderr] 864 | / fn cashtag_entity<'a>(input: Entity, text: &'a str) -> (&'a str, [usize; 2]) { [INFO] [stderr] 865 | | (input.substr(text).trim_matches('$'), [input.range.0, input.range.1]) [INFO] [stderr] 866 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:963:13 [INFO] [stderr] | [INFO] [stderr] 963 | / fn hashtag_entity<'a>(input: Entity, text: &'a str) -> (&'a str, [usize; 2]) { [INFO] [stderr] 964 | | (input.substr(text).trim_matches(is_hash), [INFO] [stderr] 965 | | [byte_to_char(text, input.range.0), byte_to_char(text, input.range.1)]) [INFO] [stderr] 966 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:1034:13 [INFO] [stderr] | [INFO] [stderr] 1034 | / fn mention_entity<'a>(input: Entity, text: &'a str) -> (&'a str, [usize; 2]) { [INFO] [stderr] 1035 | | (input.substr(text).trim_matches(is_at), [INFO] [stderr] 1036 | | [byte_to_char(text, input.range.0), byte_to_char(text, input.range.1)]) [INFO] [stderr] 1037 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:1160:13 [INFO] [stderr] | [INFO] [stderr] 1160 | / fn url_entity<'a>(input: Entity, text: &'a str) -> (&'a str, [usize; 2]) { [INFO] [stderr] 1161 | | (input.substr(text), [INFO] [stderr] 1162 | | [byte_to_char(text, input.range.0), byte_to_char(text, input.range.1)]) [INFO] [stderr] 1163 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:1189:13 [INFO] [stderr] | [INFO] [stderr] 1189 | let ref tests = tests["tests"]; [INFO] [stderr] | ----^^^^^^^^^------------------ help: try: `let tests = &tests["tests"];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:1290:13 [INFO] [stderr] | [INFO] [stderr] 1290 | let ref tests = tests["tests"]; [INFO] [stderr] | ----^^^^^^^^^------------------ help: try: `let tests = &tests["tests"];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.61s [INFO] running `"docker" "inspect" "7df6e0395c022d5920379fb82aff7b0150b1a92df6f12e6bbb5fba98c41e92ee"` [INFO] running `"docker" "rm" "-f" "7df6e0395c022d5920379fb82aff7b0150b1a92df6f12e6bbb5fba98c41e92ee"` [INFO] [stdout] 7df6e0395c022d5920379fb82aff7b0150b1a92df6f12e6bbb5fba98c41e92ee