[INFO] crate eetf 0.3.6 is already in cache [INFO] extracting crate eetf 0.3.6 into work/ex/clippy-test-run/sources/stable/reg/eetf/0.3.6 [INFO] extracting crate eetf 0.3.6 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/eetf/0.3.6 [INFO] validating manifest of eetf-0.3.6 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of eetf-0.3.6 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing eetf-0.3.6 [INFO] finished frobbing eetf-0.3.6 [INFO] frobbed toml for eetf-0.3.6 written to work/ex/clippy-test-run/sources/stable/reg/eetf/0.3.6/Cargo.toml [INFO] started frobbing eetf-0.3.6 [INFO] finished frobbing eetf-0.3.6 [INFO] frobbed toml for eetf-0.3.6 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/eetf/0.3.6/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting eetf-0.3.6 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/eetf/0.3.6:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 06afa9d8de0039d7ce48374aefa46152f0b96b5965c3777834518b7e2fa492c2 [INFO] running `"docker" "start" "-a" "06afa9d8de0039d7ce48374aefa46152f0b96b5965c3777834518b7e2fa492c2"` [INFO] [stderr] Checking eetf v0.3.6 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec.rs:164:13 [INFO] [stderr] | [INFO] [stderr] 164 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec.rs:171:58 [INFO] [stderr] | [INFO] [stderr] 171 | return Err(DecodeError::UnsupportedVersion { version: version }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec.rs:212:48 [INFO] [stderr] | [INFO] [stderr] 212 | _ => Err(DecodeError::UnknownTag { tag: tag }), [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec.rs:291:13 [INFO] [stderr] | [INFO] [stderr] 291 | node: node, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec.rs:308:13 [INFO] [stderr] | [INFO] [stderr] 308 | node: node, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec.rs:316:13 [INFO] [stderr] | [INFO] [stderr] 316 | node: node, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec.rs:330:13 [INFO] [stderr] | [INFO] [stderr] 330 | node: node, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec.rs:331:13 [INFO] [stderr] | [INFO] [stderr] 331 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec.rs:332:13 [INFO] [stderr] | [INFO] [stderr] 332 | creation: creation, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `creation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec.rs:341:13 [INFO] [stderr] | [INFO] [stderr] 341 | module: module, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `module` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec.rs:342:13 [INFO] [stderr] | [INFO] [stderr] 342 | function: function, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `function` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec.rs:343:13 [INFO] [stderr] | [INFO] [stderr] 343 | arity: arity, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `arity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec.rs:357:13 [INFO] [stderr] | [INFO] [stderr] 357 | module: module, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `module` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec.rs:358:13 [INFO] [stderr] | [INFO] [stderr] 358 | pid: pid, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec.rs:380:13 [INFO] [stderr] | [INFO] [stderr] 380 | module: module, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `module` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec.rs:381:13 [INFO] [stderr] | [INFO] [stderr] 381 | arity: arity, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `arity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec.rs:382:13 [INFO] [stderr] | [INFO] [stderr] 382 | pid: pid, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec.rs:384:13 [INFO] [stderr] | [INFO] [stderr] 384 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec.rs:385:13 [INFO] [stderr] | [INFO] [stderr] 385 | uniq: uniq, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `uniq` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec.rs:418:36 [INFO] [stderr] | [INFO] [stderr] 418 | Ok(Term::from(BigInteger { value: value })) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec.rs:426:36 [INFO] [stderr] | [INFO] [stderr] 426 | Ok(Term::from(BigInteger { value: value })) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec.rs:433:30 [INFO] [stderr] | [INFO] [stderr] 433 | Ok(Term::from(Atom { name: name })) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec.rs:440:30 [INFO] [stderr] | [INFO] [stderr] 440 | Ok(Term::from(Atom { name: name })) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec.rs:465:19 [INFO] [stderr] | [INFO] [stderr] 465 | Encoder { writer: writer } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec.rs:732:21 [INFO] [stderr] | [INFO] [stderr] 732 | range: range, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `range` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pattern.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:202:16 [INFO] [stderr] | [INFO] [stderr] 202 | Atom { name: name } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:239:22 [INFO] [stderr] | [INFO] [stderr] 239 | FixInteger { value: value } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:328:17 [INFO] [stderr] | [INFO] [stderr] 328 | Float { value: value } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:346:13 [INFO] [stderr] | [INFO] [stderr] 346 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:347:13 [INFO] [stderr] | [INFO] [stderr] 347 | serial: serial, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `serial` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:348:13 [INFO] [stderr] | [INFO] [stderr] 348 | creation: creation, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `creation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:362:13 [INFO] [stderr] | [INFO] [stderr] 362 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:363:13 [INFO] [stderr] | [INFO] [stderr] 363 | serial: serial, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `serial` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:385:13 [INFO] [stderr] | [INFO] [stderr] 385 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:420:13 [INFO] [stderr] | [INFO] [stderr] 420 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:443:13 [INFO] [stderr] | [INFO] [stderr] 443 | arity: arity, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `arity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:511:18 [INFO] [stderr] | [INFO] [stderr] 511 | Binary { bytes: bytes } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:552:13 [INFO] [stderr] | [INFO] [stderr] 552 | bytes: bytes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:553:13 [INFO] [stderr] | [INFO] [stderr] 553 | tail_bits_size: tail_bits_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tail_bits_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:589:16 [INFO] [stderr] | [INFO] [stderr] 589 | List { elements: elements } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `elements` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:616:13 [INFO] [stderr] | [INFO] [stderr] 616 | elements: elements, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `elements` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:647:17 [INFO] [stderr] | [INFO] [stderr] 647 | Tuple { elements: elements } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `elements` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:671:15 [INFO] [stderr] | [INFO] [stderr] 671 | Map { entries: entries } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `entries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec.rs:164:13 [INFO] [stderr] | [INFO] [stderr] 164 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec.rs:171:58 [INFO] [stderr] | [INFO] [stderr] 171 | return Err(DecodeError::UnsupportedVersion { version: version }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec.rs:212:48 [INFO] [stderr] | [INFO] [stderr] 212 | _ => Err(DecodeError::UnknownTag { tag: tag }), [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec.rs:291:13 [INFO] [stderr] | [INFO] [stderr] 291 | node: node, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec.rs:308:13 [INFO] [stderr] | [INFO] [stderr] 308 | node: node, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec.rs:316:13 [INFO] [stderr] | [INFO] [stderr] 316 | node: node, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec.rs:330:13 [INFO] [stderr] | [INFO] [stderr] 330 | node: node, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec.rs:331:13 [INFO] [stderr] | [INFO] [stderr] 331 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec.rs:332:13 [INFO] [stderr] | [INFO] [stderr] 332 | creation: creation, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `creation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec.rs:341:13 [INFO] [stderr] | [INFO] [stderr] 341 | module: module, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `module` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec.rs:342:13 [INFO] [stderr] | [INFO] [stderr] 342 | function: function, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `function` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec.rs:343:13 [INFO] [stderr] | [INFO] [stderr] 343 | arity: arity, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `arity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec.rs:357:13 [INFO] [stderr] | [INFO] [stderr] 357 | module: module, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `module` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec.rs:358:13 [INFO] [stderr] | [INFO] [stderr] 358 | pid: pid, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec.rs:380:13 [INFO] [stderr] | [INFO] [stderr] 380 | module: module, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `module` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec.rs:381:13 [INFO] [stderr] | [INFO] [stderr] 381 | arity: arity, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `arity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec.rs:382:13 [INFO] [stderr] | [INFO] [stderr] 382 | pid: pid, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec.rs:384:13 [INFO] [stderr] | [INFO] [stderr] 384 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec.rs:385:13 [INFO] [stderr] | [INFO] [stderr] 385 | uniq: uniq, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `uniq` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec.rs:418:36 [INFO] [stderr] | [INFO] [stderr] 418 | Ok(Term::from(BigInteger { value: value })) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec.rs:426:36 [INFO] [stderr] | [INFO] [stderr] 426 | Ok(Term::from(BigInteger { value: value })) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec.rs:433:30 [INFO] [stderr] | [INFO] [stderr] 433 | Ok(Term::from(Atom { name: name })) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec.rs:440:30 [INFO] [stderr] | [INFO] [stderr] 440 | Ok(Term::from(Atom { name: name })) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec.rs:465:19 [INFO] [stderr] | [INFO] [stderr] 465 | Encoder { writer: writer } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec.rs:732:21 [INFO] [stderr] | [INFO] [stderr] 732 | range: range, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `range` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pattern.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:202:16 [INFO] [stderr] | [INFO] [stderr] 202 | Atom { name: name } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:239:22 [INFO] [stderr] | [INFO] [stderr] 239 | FixInteger { value: value } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:328:17 [INFO] [stderr] | [INFO] [stderr] 328 | Float { value: value } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:346:13 [INFO] [stderr] | [INFO] [stderr] 346 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:347:13 [INFO] [stderr] | [INFO] [stderr] 347 | serial: serial, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `serial` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:348:13 [INFO] [stderr] | [INFO] [stderr] 348 | creation: creation, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `creation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:362:13 [INFO] [stderr] | [INFO] [stderr] 362 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:363:13 [INFO] [stderr] | [INFO] [stderr] 363 | serial: serial, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `serial` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:385:13 [INFO] [stderr] | [INFO] [stderr] 385 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:420:13 [INFO] [stderr] | [INFO] [stderr] 420 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:443:13 [INFO] [stderr] | [INFO] [stderr] 443 | arity: arity, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `arity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:511:18 [INFO] [stderr] | [INFO] [stderr] 511 | Binary { bytes: bytes } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:552:13 [INFO] [stderr] | [INFO] [stderr] 552 | bytes: bytes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:553:13 [INFO] [stderr] | [INFO] [stderr] 553 | tail_bits_size: tail_bits_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tail_bits_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:589:16 [INFO] [stderr] | [INFO] [stderr] 589 | List { elements: elements } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `elements` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:616:13 [INFO] [stderr] | [INFO] [stderr] 616 | elements: elements, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `elements` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:647:17 [INFO] [stderr] | [INFO] [stderr] 647 | Tuple { elements: elements } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `elements` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:671:15 [INFO] [stderr] | [INFO] [stderr] 671 | Map { entries: entries } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `entries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/codec.rs:228:55 [INFO] [stderr] | [INFO] [stderr] 228 | elements.push(Term::from(FixInteger::from(try!(self.reader.read_u8()) as i32))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 228 | elements.push(Term::from(FixInteger::from(i32::from(match $ expr { [INFO] [stderr] 229 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 230 | :: Err ( err ) => { [INFO] [stderr] 231 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 232 | $ crate :: convert :: From :: from ( err ) ) } })))); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: The function/method `str::from_utf8` doesn't need a mutable reference [INFO] [stderr] --> src/codec.rs:397:45 [INFO] [stderr] | [INFO] [stderr] 397 | let float_str = try!(str::from_utf8(&mut buf) [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/codec.rs:402:35 [INFO] [stderr] | [INFO] [stderr] 402 | Ok(Term::from(Float::from(value as f64))) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/codec.rs:406:40 [INFO] [stderr] | [INFO] [stderr] 406 | Ok(Term::from(FixInteger::from(value as i32))) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/codec.rs:586:39 [INFO] [stderr] | [INFO] [stderr] 586 | if 0 <= x.value && x.value <= std::u8::MAX as i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(std::u8::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/codec.rs:642:56 [INFO] [stderr] | [INFO] [stderr] 642 | try!(self.encode_fix_integer(&FixInteger::from(x.arity as i32))); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i32::from(x.arity)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/convert.rs:97:14 [INFO] [stderr] | [INFO] [stderr] 97 | Some(self.value as i64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/convert.rs:103:14 [INFO] [stderr] | [INFO] [stderr] 103 | Some(self.value as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `pattern::Any` [INFO] [stderr] --> src/pattern.rs:122:5 [INFO] [stderr] | [INFO] [stderr] 122 | / pub fn new() -> Self { [INFO] [stderr] 123 | | Any(::std::marker::PhantomData) [INFO] [stderr] 124 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 118 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/pattern.rs:239:19 [INFO] [stderr] | [INFO] [stderr] 239 | type Output = (P0::Output, P1::Output, P2::Output, P3::Output, P4::Output); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/pattern.rs:261:19 [INFO] [stderr] | [INFO] [stderr] 261 | type Output = (P0::Output, P1::Output, P2::Output, P3::Output, P4::Output, P5::Output); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/pattern.rs:282:14 [INFO] [stderr] | [INFO] [stderr] 282 | try!((l.elements.len() == 0).as_option().ok_or_else(|| self.unmatched(input))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `l.elements.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/pattern.rs:297:14 [INFO] [stderr] | [INFO] [stderr] 297 | try!((e.len() > 0).as_option().ok_or_else(|| self.unmatched(input))); [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!e.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/pattern.rs:312:14 [INFO] [stderr] | [INFO] [stderr] 312 | try!((t.elements.len() == 0).as_option().ok_or_else(|| self.unmatched(input))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `t.elements.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/pattern.rs:387:19 [INFO] [stderr] | [INFO] [stderr] 387 | type Output = (P0::Output, P1::Output, P2::Output, P3::Output, P4::Output); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/pattern.rs:409:19 [INFO] [stderr] | [INFO] [stderr] 409 | type Output = (P0::Output, P1::Output, P2::Output, P3::Output, P4::Output, P5::Output); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/pattern.rs:441:58 [INFO] [stderr] | [INFO] [stderr] 441 | let e = try_err!((self.0).0.try_match(input).map(|o| Union2::A(o))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `Union2::A` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/pattern.rs:442:58 [INFO] [stderr] | [INFO] [stderr] 442 | let e = try_err!((self.0).1.try_match(input).map(|o| Union2::B(o))).max_depth(e); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `Union2::B` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/pattern.rs:453:58 [INFO] [stderr] | [INFO] [stderr] 453 | let e = try_err!((self.0).0.try_match(input).map(|o| Union3::A(o))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `Union3::A` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/pattern.rs:454:58 [INFO] [stderr] | [INFO] [stderr] 454 | let e = try_err!((self.0).1.try_match(input).map(|o| Union3::B(o))).max_depth(e); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `Union3::B` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/pattern.rs:455:58 [INFO] [stderr] | [INFO] [stderr] 455 | let e = try_err!((self.0).2.try_match(input).map(|o| Union3::C(o))).max_depth(e); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `Union3::C` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/pattern.rs:467:58 [INFO] [stderr] | [INFO] [stderr] 467 | let e = try_err!((self.0).0.try_match(input).map(|o| Union4::A(o))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `Union4::A` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/pattern.rs:468:58 [INFO] [stderr] | [INFO] [stderr] 468 | let e = try_err!((self.0).1.try_match(input).map(|o| Union4::B(o))).max_depth(e); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `Union4::B` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/pattern.rs:469:58 [INFO] [stderr] | [INFO] [stderr] 469 | let e = try_err!((self.0).2.try_match(input).map(|o| Union4::C(o))).max_depth(e); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `Union4::C` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/pattern.rs:470:58 [INFO] [stderr] | [INFO] [stderr] 470 | let e = try_err!((self.0).3.try_match(input).map(|o| Union4::D(o))).max_depth(e); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `Union4::D` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/pattern.rs:481:19 [INFO] [stderr] | [INFO] [stderr] 481 | type Output = Union5; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/pattern.rs:483:58 [INFO] [stderr] | [INFO] [stderr] 483 | let e = try_err!((self.0).0.try_match(input).map(|o| Union5::A(o))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `Union5::A` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/pattern.rs:484:58 [INFO] [stderr] | [INFO] [stderr] 484 | let e = try_err!((self.0).1.try_match(input).map(|o| Union5::B(o))).max_depth(e); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `Union5::B` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/pattern.rs:485:58 [INFO] [stderr] | [INFO] [stderr] 485 | let e = try_err!((self.0).2.try_match(input).map(|o| Union5::C(o))).max_depth(e); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `Union5::C` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/pattern.rs:486:58 [INFO] [stderr] | [INFO] [stderr] 486 | let e = try_err!((self.0).3.try_match(input).map(|o| Union5::D(o))).max_depth(e); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `Union5::D` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/pattern.rs:487:58 [INFO] [stderr] | [INFO] [stderr] 487 | let e = try_err!((self.0).4.try_match(input).map(|o| Union5::E(o))).max_depth(e); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `Union5::E` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/pattern.rs:499:19 [INFO] [stderr] | [INFO] [stderr] 499 | type Output = Union6; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/pattern.rs:501:58 [INFO] [stderr] | [INFO] [stderr] 501 | let e = try_err!((self.0).0.try_match(input).map(|o| Union6::A(o))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `Union6::A` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/pattern.rs:502:58 [INFO] [stderr] | [INFO] [stderr] 502 | let e = try_err!((self.0).1.try_match(input).map(|o| Union6::B(o))).max_depth(e); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `Union6::B` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/pattern.rs:503:58 [INFO] [stderr] | [INFO] [stderr] 503 | let e = try_err!((self.0).2.try_match(input).map(|o| Union6::C(o))).max_depth(e); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `Union6::C` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/pattern.rs:504:58 [INFO] [stderr] | [INFO] [stderr] 504 | let e = try_err!((self.0).3.try_match(input).map(|o| Union6::D(o))).max_depth(e); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `Union6::D` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/pattern.rs:505:58 [INFO] [stderr] | [INFO] [stderr] 505 | let e = try_err!((self.0).4.try_match(input).map(|o| Union6::E(o))).max_depth(e); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `Union6::E` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/pattern.rs:506:58 [INFO] [stderr] | [INFO] [stderr] 506 | let e = try_err!((self.0).5.try_match(input).map(|o| Union6::F(o))).max_depth(e); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `Union6::F` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:219:29 [INFO] [stderr] | [INFO] [stderr] 219 | FixInteger { value: value as i32 } [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:224:29 [INFO] [stderr] | [INFO] [stderr] 224 | FixInteger { value: value as i32 } [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:229:29 [INFO] [stderr] | [INFO] [stderr] 229 | FixInteger { value: value as i32 } [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:234:29 [INFO] [stderr] | [INFO] [stderr] 234 | FixInteger { value: value as i32 } [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:323:24 [INFO] [stderr] | [INFO] [stderr] 323 | Float { value: value as f64 } [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/codec.rs:228:55 [INFO] [stderr] | [INFO] [stderr] 228 | elements.push(Term::from(FixInteger::from(try!(self.reader.read_u8()) as i32))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 228 | elements.push(Term::from(FixInteger::from(i32::from(match $ expr { [INFO] [stderr] 229 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 230 | :: Err ( err ) => { [INFO] [stderr] 231 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 232 | $ crate :: convert :: From :: from ( err ) ) } })))); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: The function/method `str::from_utf8` doesn't need a mutable reference [INFO] [stderr] --> src/codec.rs:397:45 [INFO] [stderr] | [INFO] [stderr] 397 | let float_str = try!(str::from_utf8(&mut buf) [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/codec.rs:402:35 [INFO] [stderr] | [INFO] [stderr] 402 | Ok(Term::from(Float::from(value as f64))) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/codec.rs:406:40 [INFO] [stderr] | [INFO] [stderr] 406 | Ok(Term::from(FixInteger::from(value as i32))) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/codec.rs:586:39 [INFO] [stderr] | [INFO] [stderr] 586 | if 0 <= x.value && x.value <= std::u8::MAX as i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(std::u8::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/codec.rs:642:56 [INFO] [stderr] | [INFO] [stderr] 642 | try!(self.encode_fix_integer(&FixInteger::from(x.arity as i32))); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i32::from(x.arity)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/convert.rs:97:14 [INFO] [stderr] | [INFO] [stderr] 97 | Some(self.value as i64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/convert.rs:103:14 [INFO] [stderr] | [INFO] [stderr] 103 | Some(self.value as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `pattern::Any` [INFO] [stderr] --> src/pattern.rs:122:5 [INFO] [stderr] | [INFO] [stderr] 122 | / pub fn new() -> Self { [INFO] [stderr] 123 | | Any(::std::marker::PhantomData) [INFO] [stderr] 124 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 118 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/pattern.rs:239:19 [INFO] [stderr] | [INFO] [stderr] 239 | type Output = (P0::Output, P1::Output, P2::Output, P3::Output, P4::Output); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/pattern.rs:261:19 [INFO] [stderr] | [INFO] [stderr] 261 | type Output = (P0::Output, P1::Output, P2::Output, P3::Output, P4::Output, P5::Output); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/pattern.rs:282:14 [INFO] [stderr] | [INFO] [stderr] 282 | try!((l.elements.len() == 0).as_option().ok_or_else(|| self.unmatched(input))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `l.elements.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/pattern.rs:297:14 [INFO] [stderr] | [INFO] [stderr] 297 | try!((e.len() > 0).as_option().ok_or_else(|| self.unmatched(input))); [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!e.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/pattern.rs:312:14 [INFO] [stderr] | [INFO] [stderr] 312 | try!((t.elements.len() == 0).as_option().ok_or_else(|| self.unmatched(input))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `t.elements.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/pattern.rs:387:19 [INFO] [stderr] | [INFO] [stderr] 387 | type Output = (P0::Output, P1::Output, P2::Output, P3::Output, P4::Output); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/pattern.rs:409:19 [INFO] [stderr] | [INFO] [stderr] 409 | type Output = (P0::Output, P1::Output, P2::Output, P3::Output, P4::Output, P5::Output); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/pattern.rs:441:58 [INFO] [stderr] | [INFO] [stderr] 441 | let e = try_err!((self.0).0.try_match(input).map(|o| Union2::A(o))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `Union2::A` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/pattern.rs:442:58 [INFO] [stderr] | [INFO] [stderr] 442 | let e = try_err!((self.0).1.try_match(input).map(|o| Union2::B(o))).max_depth(e); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `Union2::B` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/pattern.rs:453:58 [INFO] [stderr] | [INFO] [stderr] 453 | let e = try_err!((self.0).0.try_match(input).map(|o| Union3::A(o))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `Union3::A` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/pattern.rs:454:58 [INFO] [stderr] | [INFO] [stderr] 454 | let e = try_err!((self.0).1.try_match(input).map(|o| Union3::B(o))).max_depth(e); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `Union3::B` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/pattern.rs:455:58 [INFO] [stderr] | [INFO] [stderr] 455 | let e = try_err!((self.0).2.try_match(input).map(|o| Union3::C(o))).max_depth(e); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `Union3::C` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/pattern.rs:467:58 [INFO] [stderr] | [INFO] [stderr] 467 | let e = try_err!((self.0).0.try_match(input).map(|o| Union4::A(o))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `Union4::A` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/pattern.rs:468:58 [INFO] [stderr] | [INFO] [stderr] 468 | let e = try_err!((self.0).1.try_match(input).map(|o| Union4::B(o))).max_depth(e); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `Union4::B` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/pattern.rs:469:58 [INFO] [stderr] | [INFO] [stderr] 469 | let e = try_err!((self.0).2.try_match(input).map(|o| Union4::C(o))).max_depth(e); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `Union4::C` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/pattern.rs:470:58 [INFO] [stderr] | [INFO] [stderr] 470 | let e = try_err!((self.0).3.try_match(input).map(|o| Union4::D(o))).max_depth(e); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `Union4::D` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/pattern.rs:481:19 [INFO] [stderr] | [INFO] [stderr] 481 | type Output = Union5; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/pattern.rs:483:58 [INFO] [stderr] | [INFO] [stderr] 483 | let e = try_err!((self.0).0.try_match(input).map(|o| Union5::A(o))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `Union5::A` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/pattern.rs:484:58 [INFO] [stderr] | [INFO] [stderr] 484 | let e = try_err!((self.0).1.try_match(input).map(|o| Union5::B(o))).max_depth(e); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `Union5::B` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/pattern.rs:485:58 [INFO] [stderr] | [INFO] [stderr] 485 | let e = try_err!((self.0).2.try_match(input).map(|o| Union5::C(o))).max_depth(e); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `Union5::C` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/pattern.rs:486:58 [INFO] [stderr] | [INFO] [stderr] 486 | let e = try_err!((self.0).3.try_match(input).map(|o| Union5::D(o))).max_depth(e); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `Union5::D` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/pattern.rs:487:58 [INFO] [stderr] | [INFO] [stderr] 487 | let e = try_err!((self.0).4.try_match(input).map(|o| Union5::E(o))).max_depth(e); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `Union5::E` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/pattern.rs:499:19 [INFO] [stderr] | [INFO] [stderr] 499 | type Output = Union6; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/pattern.rs:501:58 [INFO] [stderr] | [INFO] [stderr] 501 | let e = try_err!((self.0).0.try_match(input).map(|o| Union6::A(o))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `Union6::A` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/pattern.rs:502:58 [INFO] [stderr] | [INFO] [stderr] 502 | let e = try_err!((self.0).1.try_match(input).map(|o| Union6::B(o))).max_depth(e); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `Union6::B` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/pattern.rs:503:58 [INFO] [stderr] | [INFO] [stderr] 503 | let e = try_err!((self.0).2.try_match(input).map(|o| Union6::C(o))).max_depth(e); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `Union6::C` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/pattern.rs:504:58 [INFO] [stderr] | [INFO] [stderr] 504 | let e = try_err!((self.0).3.try_match(input).map(|o| Union6::D(o))).max_depth(e); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `Union6::D` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/pattern.rs:505:58 [INFO] [stderr] | [INFO] [stderr] 505 | let e = try_err!((self.0).4.try_match(input).map(|o| Union6::E(o))).max_depth(e); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `Union6::E` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/pattern.rs:506:58 [INFO] [stderr] | [INFO] [stderr] 506 | let e = try_err!((self.0).5.try_match(input).map(|o| Union6::F(o))).max_depth(e); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `Union6::F` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:219:29 [INFO] [stderr] | [INFO] [stderr] 219 | FixInteger { value: value as i32 } [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:224:29 [INFO] [stderr] | [INFO] [stderr] 224 | FixInteger { value: value as i32 } [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:229:29 [INFO] [stderr] | [INFO] [stderr] 229 | FixInteger { value: value as i32 } [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:234:29 [INFO] [stderr] | [INFO] [stderr] 234 | FixInteger { value: value as i32 } [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:323:24 [INFO] [stderr] | [INFO] [stderr] 323 | Float { value: value as f64 } [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/lib.rs:64:51 [INFO] [stderr] | [INFO] [stderr] 64 | encode(Term::from(BigInteger::from(10000000000u64)))); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `10_000_000_000u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/lib.rs:134:58 [INFO] [stderr] | [INFO] [stderr] 134 | assert_eq!(Ok(Reference::from(("nonode@nohost", vec![138016, 262145, 0]))), [INFO] [stderr] | ^^^^^^ help: consider: `138_016` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/lib.rs:134:66 [INFO] [stderr] | [INFO] [stderr] 134 | assert_eq!(Ok(Reference::from(("nonode@nohost", vec![138016, 262145, 0]))), [INFO] [stderr] | ^^^^^^ help: consider: `262_145` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/lib.rs:172:19 [INFO] [stderr] | [INFO] [stderr] 172 | old_uniq: 60417627, [INFO] [stderr] | ^^^^^^^^ help: consider: `60_417_627` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> tests/lib.rs:75:31 [INFO] [stderr] | [INFO] [stderr] 75 | assert_eq!(Ok(Float::from("1.23".parse::().unwrap() as f64)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from("1.23".parse::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.58s [INFO] running `"docker" "inspect" "06afa9d8de0039d7ce48374aefa46152f0b96b5965c3777834518b7e2fa492c2"` [INFO] running `"docker" "rm" "-f" "06afa9d8de0039d7ce48374aefa46152f0b96b5965c3777834518b7e2fa492c2"` [INFO] [stdout] 06afa9d8de0039d7ce48374aefa46152f0b96b5965c3777834518b7e2fa492c2