[INFO] crate edn 0.3.0 is already in cache [INFO] extracting crate edn 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/edn/0.3.0 [INFO] extracting crate edn 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/edn/0.3.0 [INFO] validating manifest of edn-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of edn-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing edn-0.3.0 [INFO] finished frobbing edn-0.3.0 [INFO] frobbed toml for edn-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/edn/0.3.0/Cargo.toml [INFO] started frobbing edn-0.3.0 [INFO] finished frobbing edn-0.3.0 [INFO] frobbed toml for edn-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/edn/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting edn-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/edn/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3ed2bafef356d04b1298467e53ee7f48d6ff75d923c4ddb0eca322d7757b7a7a [INFO] running `"docker" "start" "-a" "3ed2bafef356d04b1298467e53ee7f48d6ff75d923c4ddb0eca322d7757b7a7a"` [INFO] [stderr] Checking ordered-float v0.4.0 [INFO] [stderr] Checking edn v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | str: str, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | str: str, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:231:44 [INFO] [stderr] | [INFO] [stderr] 231 | Some(Ok(v)) => return Ok(Value::Tagged(tag.into(), [INFO] [stderr] | ____________________________________________^ [INFO] [stderr] 232 | | Box::new(v))), [INFO] [stderr] | |________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 231 | Some(Ok(v)) => Ok(Value::Tagged(tag.into(), [INFO] [stderr] 232 | Box::new(v))), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:233:40 [INFO] [stderr] | [INFO] [stderr] 233 | Some(e) => return e, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:234:37 [INFO] [stderr] | [INFO] [stderr] 234 | None => return Err(Error { [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 235 | | lo: start, [INFO] [stderr] 236 | | hi: self.str.len(), [INFO] [stderr] 237 | | message: "malformed tagged value".into() [INFO] [stderr] 238 | | }) [INFO] [stderr] | |______________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 234 | None => Err(Error { [INFO] [stderr] 235 | lo: start, [INFO] [stderr] 236 | hi: self.str.len(), [INFO] [stderr] 237 | message: "malformed tagged value".into() [INFO] [stderr] 238 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:231:44 [INFO] [stderr] | [INFO] [stderr] 231 | Some(Ok(v)) => return Ok(Value::Tagged(tag.into(), [INFO] [stderr] | ____________________________________________^ [INFO] [stderr] 232 | | Box::new(v))), [INFO] [stderr] | |________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 231 | Some(Ok(v)) => Ok(Value::Tagged(tag.into(), [INFO] [stderr] 232 | Box::new(v))), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:233:40 [INFO] [stderr] | [INFO] [stderr] 233 | Some(e) => return e, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:234:37 [INFO] [stderr] | [INFO] [stderr] 234 | None => return Err(Error { [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 235 | | lo: start, [INFO] [stderr] 236 | | hi: self.str.len(), [INFO] [stderr] 237 | | message: "malformed tagged value".into() [INFO] [stderr] 238 | | }) [INFO] [stderr] | |______________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 234 | None => Err(Error { [INFO] [stderr] 235 | lo: start, [INFO] [stderr] 236 | hi: self.str.len(), [INFO] [stderr] 237 | message: "malformed tagged value".into() [INFO] [stderr] 238 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/parser.rs:171:46 [INFO] [stderr] | [INFO] [stderr] 171 | .unwrap_or(self.str.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.str.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/parser.rs:171:46 [INFO] [stderr] | [INFO] [stderr] 171 | .unwrap_or(self.str.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.str.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/parser_tests.rs:23:54 [INFO] [stderr] | [INFO] [stderr] 23 | assert_eq!(parser.read(), Some(Ok(Value::Integer(9223372036854775807)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_807` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/parser_tests.rs:24:55 [INFO] [stderr] | [INFO] [stderr] 24 | assert_eq!(parser.read(), Some(Ok(Value::Integer(-9223372036854775808)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_808` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.27s [INFO] running `"docker" "inspect" "3ed2bafef356d04b1298467e53ee7f48d6ff75d923c4ddb0eca322d7757b7a7a"` [INFO] running `"docker" "rm" "-f" "3ed2bafef356d04b1298467e53ee7f48d6ff75d923c4ddb0eca322d7757b7a7a"` [INFO] [stdout] 3ed2bafef356d04b1298467e53ee7f48d6ff75d923c4ddb0eca322d7757b7a7a