[INFO] crate editorconfig 1.0.0 is already in cache
[INFO] extracting crate editorconfig 1.0.0 into work/ex/clippy-test-run/sources/stable/reg/editorconfig/1.0.0
[INFO] extracting crate editorconfig 1.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/editorconfig/1.0.0
[INFO] validating manifest of editorconfig-1.0.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of editorconfig-1.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing editorconfig-1.0.0
[INFO] finished frobbing editorconfig-1.0.0
[INFO] frobbed toml for editorconfig-1.0.0 written to work/ex/clippy-test-run/sources/stable/reg/editorconfig/1.0.0/Cargo.toml
[INFO] started frobbing editorconfig-1.0.0
[INFO] finished frobbing editorconfig-1.0.0
[INFO] frobbed toml for editorconfig-1.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/editorconfig/1.0.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting editorconfig-1.0.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/editorconfig/1.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 96378ed2269f8f93fcc0d4c605bad81d9b75937c537d7e2af490344b2d28ef39
[INFO] running `"docker" "start" "-a" "96378ed2269f8f93fcc0d4c605bad81d9b75937c537d7e2af490344b2d28ef39"`
[INFO] [stderr]     Checking editorconfig v1.0.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/ini.rs:156:13
[INFO] [stderr]     |
[INFO] [stderr] 156 |             ini: ini,
[INFO] [stderr]     |             ^^^^^^^^ help: replace it with: `ini`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/ini.rs:157:13
[INFO] [stderr]     |
[INFO] [stderr] 157 |             section_name: section_name,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `section_name`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/ini.rs:606:13
[INFO] [stderr]     |
[INFO] [stderr] 606 |             rdr: rdr,
[INFO] [stderr]     |             ^^^^^^^^ help: replace it with: `rdr`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/ini.rs:156:13
[INFO] [stderr]     |
[INFO] [stderr] 156 |             ini: ini,
[INFO] [stderr]     |             ^^^^^^^^ help: replace it with: `ini`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/ini.rs:157:13
[INFO] [stderr]     |
[INFO] [stderr] 157 |             section_name: section_name,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `section_name`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/ini.rs:606:13
[INFO] [stderr]     |
[INFO] [stderr] 606 |             rdr: rdr,
[INFO] [stderr]     |             ^^^^^^^^ help: replace it with: `rdr`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/ini.rs:336:21
[INFO] [stderr]     |
[INFO] [stderr] 336 |             None => return None,
[INFO] [stderr]     |                     ^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:32:5
[INFO] [stderr]    |
[INFO] [stderr] 32 |     return Ok(result);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(result)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:49:5
[INFO] [stderr]    |
[INFO] [stderr] 49 |     return depth != 0;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `depth != 0`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:139:5
[INFO] [stderr]     |
[INFO] [stderr] 139 |     return final_regex.is_match(candidate);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `final_regex.is_match(candidate)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/lib.rs:173:9
[INFO] [stderr]     |
[INFO] [stderr] 173 | /         if indent_style == "tab" {
[INFO] [stderr] 174 | |             if result.get("indent_size").is_none() {
[INFO] [stderr] 175 | |                 result.insert("indent_size".to_string(), "tab".to_string());
[INFO] [stderr] 176 | |             }
[INFO] [stderr] 177 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 173 |         if indent_style == "tab" && result.get("indent_size").is_none() {
[INFO] [stderr] 174 |     result.insert("indent_size".to_string(), "tab".to_string());
[INFO] [stderr] 175 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/lib.rs:184:16
[INFO] [stderr]     |
[INFO] [stderr] 184 |           } else {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 185 | |             if let Some(tab_width) = result.clone().get("tab_width") {
[INFO] [stderr] 186 | |                 result.insert("indent_size".to_string(), tab_width.clone());
[INFO] [stderr] 187 | |             }
[INFO] [stderr] 188 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 184 |         } else if let Some(tab_width) = result.clone().get("tab_width") {
[INFO] [stderr] 185 |     result.insert("indent_size".to_string(), tab_width.clone());
[INFO] [stderr] 186 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:272:5
[INFO] [stderr]     |
[INFO] [stderr] 272 |     return Ok(result);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(result)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/ini.rs:336:21
[INFO] [stderr]     |
[INFO] [stderr] 336 |             None => return None,
[INFO] [stderr]     |                     ^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:32:5
[INFO] [stderr]    |
[INFO] [stderr] 32 |     return Ok(result);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(result)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:49:5
[INFO] [stderr]    |
[INFO] [stderr] 49 |     return depth != 0;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `depth != 0`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:139:5
[INFO] [stderr]     |
[INFO] [stderr] 139 |     return final_regex.is_match(candidate);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `final_regex.is_match(candidate)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/lib.rs:173:9
[INFO] [stderr]     |
[INFO] [stderr] 173 | /         if indent_style == "tab" {
[INFO] [stderr] 174 | |             if result.get("indent_size").is_none() {
[INFO] [stderr] 175 | |                 result.insert("indent_size".to_string(), "tab".to_string());
[INFO] [stderr] 176 | |             }
[INFO] [stderr] 177 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 173 |         if indent_style == "tab" && result.get("indent_size").is_none() {
[INFO] [stderr] 174 |     result.insert("indent_size".to_string(), "tab".to_string());
[INFO] [stderr] 175 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/lib.rs:184:16
[INFO] [stderr]     |
[INFO] [stderr] 184 |           } else {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 185 | |             if let Some(tab_width) = result.clone().get("tab_width") {
[INFO] [stderr] 186 | |                 result.insert("indent_size".to_string(), tab_width.clone());
[INFO] [stderr] 187 | |             }
[INFO] [stderr] 188 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 184 |         } else if let Some(tab_width) = result.clone().get("tab_width") {
[INFO] [stderr] 185 |     result.insert("indent_size".to_string(), tab_width.clone());
[INFO] [stderr] 186 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:272:5
[INFO] [stderr]     |
[INFO] [stderr] 272 |     return Ok(result);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(result)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/ini.rs:321:18
[INFO] [stderr]     |
[INFO] [stderr] 321 |             Some(mut prop) => prop.get_mut(key).map(|s| &s[..]),
[INFO] [stderr]     |                  ----^^^^
[INFO] [stderr]     |                  |
[INFO] [stderr]     |                  help: remove this `mut`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/ini.rs:59:22
[INFO] [stderr]    |
[INFO] [stderr] 59 |     fn escape_basics(&self) -> bool {
[INFO] [stderr]    |                      ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/ini.rs:66:24
[INFO] [stderr]    |
[INFO] [stderr] 66 |     fn escape_reserved(&self) -> bool {
[INFO] [stderr]    |                        ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/ini.rs:75:23
[INFO] [stderr]    |
[INFO] [stderr] 75 |     fn escape_unicode(&self) -> bool {
[INFO] [stderr]    |                       ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/ini.rs:86:26
[INFO] [stderr]    |
[INFO] [stderr] 86 |     pub fn should_escape(&self, c: char) -> bool {
[INFO] [stderr]    |                          ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `ini::Ini`
[INFO] [stderr]    --> src/ini.rs:210:5
[INFO] [stderr]     |
[INFO] [stderr] 210 | /     pub fn new() -> Ini {
[INFO] [stderr] 211 | |         Ini { sections: OrderMap::new() }
[INFO] [stderr] 212 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 204 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/ini.rs:215:5
[INFO] [stderr]     |
[INFO] [stderr] 215 | /     pub fn with_section<'b, S>(&'b mut self, section: Option<S>) -> SectionSetter<'b>
[INFO] [stderr] 216 | |         where S: Into<String>
[INFO] [stderr] 217 | |     {
[INFO] [stderr] 218 | |         SectionSetter::new(self, section.map(|s| s.into()))
[INFO] [stderr] 219 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/ini.rs:232:5
[INFO] [stderr]     |
[INFO] [stderr] 232 | /     pub fn section<'a, S>(&'a self, name: Option<S>) -> Option<&'a Properties>
[INFO] [stderr] 233 | |         where S: Into<String>
[INFO] [stderr] 234 | |     {
[INFO] [stderr] 235 | |         self.sections.get(&name.map(|s| s.into()))
[INFO] [stderr] 236 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/ini.rs:239:5
[INFO] [stderr]     |
[INFO] [stderr] 239 | /     pub fn section_mut<'a, S>(&'a mut self, name: Option<S>) -> Option<&'a mut Properties>
[INFO] [stderr] 240 | |         where S: Into<String>
[INFO] [stderr] 241 | |     {
[INFO] [stderr] 242 | |         self.sections.get_mut(&name.map(|s| s.into()))
[INFO] [stderr] 243 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/ini.rs:246:5
[INFO] [stderr]     |
[INFO] [stderr] 246 | /     pub fn entry<'a>(&'a mut self, name: Option<String>) -> Entry<Option<String>, Properties> {
[INFO] [stderr] 247 | |         self.sections.entry(name.map(|s| s.into()))
[INFO] [stderr] 248 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ini.rs:247:42
[INFO] [stderr]     |
[INFO] [stderr] 247 |         self.sections.entry(name.map(|s| s.into()))
[INFO] [stderr]     |                                          ^^^^^^^^ help: consider removing `.into()`: `s`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]    --> src/ini.rs:251:18
[INFO] [stderr]     |
[INFO] [stderr] 251 |     pub fn clear<'a>(&mut self) {
[INFO] [stderr]     |                  ^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::extra_unused_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/ini.rs:256:5
[INFO] [stderr]     |
[INFO] [stderr] 256 | /     pub fn sections<'a>(&'a self) -> Keys<'a, Option<String>, Properties> {
[INFO] [stderr] 257 | |         self.sections.keys()
[INFO] [stderr] 258 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/ini.rs:413:9
[INFO] [stderr]     |
[INFO] [stderr] 413 | /         match self.sections.get(&None) {
[INFO] [stderr] 414 | |             Some(props) => {
[INFO] [stderr] 415 | |                 for (k, v) in props.iter() {
[INFO] [stderr] 416 | |                     let k_str = escape_str(&k[..], policy);
[INFO] [stderr] ...   |
[INFO] [stderr] 422 | |             None => {}
[INFO] [stderr] 423 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 413 |         if let Some(props) = self.sections.get(&None) {
[INFO] [stderr] 414 |     for (k, v) in props.iter() {
[INFO] [stderr] 415 |         let k_str = escape_str(&k[..], policy);
[INFO] [stderr] 416 |         let v_str = escape_str(&v[..], policy);
[INFO] [stderr] 417 |         try!(write!(writer, "{}={}\n", k_str, v_str));
[INFO] [stderr] 418 |     }
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/ini.rs:432:13
[INFO] [stderr]     |
[INFO] [stderr] 432 | /             if let &Some(ref section) = section {
[INFO] [stderr] 433 | |                 try!(write!(writer, "[{}]\n", escape_str(&section[..], policy)));
[INFO] [stderr] 434 | |
[INFO] [stderr] 435 | |                 for (k, v) in props.iter() {
[INFO] [stderr] ...   |
[INFO] [stderr] 439 | |                 }
[INFO] [stderr] 440 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 432 |             if let Some(ref section) = *section {
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^   ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ini.rs:700:38
[INFO] [stderr]     |
[INFO] [stderr] 700 |                             curkey = mkey.into();
[INFO] [stderr]     |                                      ^^^^^^^^^^^ help: consider removing `.into()`: `mkey`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/lib.rs:64:24
[INFO] [stderr]    |
[INFO] [stderr] 64 | fn glob_match(pattern: &String, candidate: &String) -> bool {
[INFO] [stderr]    |                        ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/lib.rs:64:44
[INFO] [stderr]    |
[INFO] [stderr] 64 | fn glob_match(pattern: &String, candidate: &String) -> bool {
[INFO] [stderr]    |                                            ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: trivial regex
[INFO] [stderr]   --> src/lib.rs:98:42
[INFO] [stderr]    |
[INFO] [stderr] 98 |     let leading_slash_regex = Regex::new(r"^/").unwrap();
[INFO] [stderr]    |                                          ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivial_regex)] on by default
[INFO] [stderr]    = help: consider using `str::starts_with`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/ini.rs:321:18
[INFO] [stderr]     |
[INFO] [stderr] 321 |             Some(mut prop) => prop.get_mut(key).map(|s| &s[..]),
[INFO] [stderr]     |                  ----^^^^
[INFO] [stderr]     |                  |
[INFO] [stderr]     |                  help: remove this `mut`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/ini.rs:59:22
[INFO] [stderr]    |
[INFO] [stderr] 59 |     fn escape_basics(&self) -> bool {
[INFO] [stderr]    |                      ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/ini.rs:66:24
[INFO] [stderr]    |
[INFO] [stderr] 66 |     fn escape_reserved(&self) -> bool {
[INFO] [stderr]    |                        ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/ini.rs:75:23
[INFO] [stderr]    |
[INFO] [stderr] 75 |     fn escape_unicode(&self) -> bool {
[INFO] [stderr]    |                       ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/ini.rs:86:26
[INFO] [stderr]    |
[INFO] [stderr] 86 |     pub fn should_escape(&self, c: char) -> bool {
[INFO] [stderr]    |                          ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `ini::Ini`
[INFO] [stderr]    --> src/ini.rs:210:5
[INFO] [stderr]     |
[INFO] [stderr] 210 | /     pub fn new() -> Ini {
[INFO] [stderr] 211 | |         Ini { sections: OrderMap::new() }
[INFO] [stderr] 212 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 204 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/ini.rs:215:5
[INFO] [stderr]     |
[INFO] [stderr] 215 | /     pub fn with_section<'b, S>(&'b mut self, section: Option<S>) -> SectionSetter<'b>
[INFO] [stderr] 216 | |         where S: Into<String>
[INFO] [stderr] 217 | |     {
[INFO] [stderr] 218 | |         SectionSetter::new(self, section.map(|s| s.into()))
[INFO] [stderr] 219 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/ini.rs:232:5
[INFO] [stderr]     |
[INFO] [stderr] 232 | /     pub fn section<'a, S>(&'a self, name: Option<S>) -> Option<&'a Properties>
[INFO] [stderr] 233 | |         where S: Into<String>
[INFO] [stderr] 234 | |     {
[INFO] [stderr] 235 | |         self.sections.get(&name.map(|s| s.into()))
[INFO] [stderr] 236 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/ini.rs:239:5
[INFO] [stderr]     |
[INFO] [stderr] 239 | /     pub fn section_mut<'a, S>(&'a mut self, name: Option<S>) -> Option<&'a mut Properties>
[INFO] [stderr] 240 | |         where S: Into<String>
[INFO] [stderr] 241 | |     {
[INFO] [stderr] 242 | |         self.sections.get_mut(&name.map(|s| s.into()))
[INFO] [stderr] 243 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/ini.rs:246:5
[INFO] [stderr]     |
[INFO] [stderr] 246 | /     pub fn entry<'a>(&'a mut self, name: Option<String>) -> Entry<Option<String>, Properties> {
[INFO] [stderr] 247 | |         self.sections.entry(name.map(|s| s.into()))
[INFO] [stderr] 248 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ini.rs:247:42
[INFO] [stderr]     |
[INFO] [stderr] 247 |         self.sections.entry(name.map(|s| s.into()))
[INFO] [stderr]     |                                          ^^^^^^^^ help: consider removing `.into()`: `s`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]    --> src/ini.rs:251:18
[INFO] [stderr]     |
[INFO] [stderr] 251 |     pub fn clear<'a>(&mut self) {
[INFO] [stderr]     |                  ^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::extra_unused_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/ini.rs:256:5
[INFO] [stderr]     |
[INFO] [stderr] 256 | /     pub fn sections<'a>(&'a self) -> Keys<'a, Option<String>, Properties> {
[INFO] [stderr] 257 | |         self.sections.keys()
[INFO] [stderr] 258 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/ini.rs:413:9
[INFO] [stderr]     |
[INFO] [stderr] 413 | /         match self.sections.get(&None) {
[INFO] [stderr] 414 | |             Some(props) => {
[INFO] [stderr] 415 | |                 for (k, v) in props.iter() {
[INFO] [stderr] 416 | |                     let k_str = escape_str(&k[..], policy);
[INFO] [stderr] ...   |
[INFO] [stderr] 422 | |             None => {}
[INFO] [stderr] 423 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 413 |         if let Some(props) = self.sections.get(&None) {
[INFO] [stderr] 414 |     for (k, v) in props.iter() {
[INFO] [stderr] 415 |         let k_str = escape_str(&k[..], policy);
[INFO] [stderr] 416 |         let v_str = escape_str(&v[..], policy);
[INFO] [stderr] 417 |         try!(write!(writer, "{}={}\n", k_str, v_str));
[INFO] [stderr] 418 |     }
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/ini.rs:432:13
[INFO] [stderr]     |
[INFO] [stderr] 432 | /             if let &Some(ref section) = section {
[INFO] [stderr] 433 | |                 try!(write!(writer, "[{}]\n", escape_str(&section[..], policy)));
[INFO] [stderr] 434 | |
[INFO] [stderr] 435 | |                 for (k, v) in props.iter() {
[INFO] [stderr] ...   |
[INFO] [stderr] 439 | |                 }
[INFO] [stderr] 440 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 432 |             if let Some(ref section) = *section {
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^   ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ini.rs:700:38
[INFO] [stderr]     |
[INFO] [stderr] 700 |                             curkey = mkey.into();
[INFO] [stderr]     |                                      ^^^^^^^^^^^ help: consider removing `.into()`: `mkey`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/lib.rs:64:24
[INFO] [stderr]    |
[INFO] [stderr] 64 | fn glob_match(pattern: &String, candidate: &String) -> bool {
[INFO] [stderr]    |                        ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/lib.rs:64:44
[INFO] [stderr]    |
[INFO] [stderr] 64 | fn glob_match(pattern: &String, candidate: &String) -> bool {
[INFO] [stderr]    |                                            ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: trivial regex
[INFO] [stderr]   --> src/lib.rs:98:42
[INFO] [stderr]    |
[INFO] [stderr] 98 |     let leading_slash_regex = Regex::new(r"^/").unwrap();
[INFO] [stderr]    |                                          ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivial_regex)] on by default
[INFO] [stderr]    = help: consider using `str::starts_with`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3.97s
[INFO] running `"docker" "inspect" "96378ed2269f8f93fcc0d4c605bad81d9b75937c537d7e2af490344b2d28ef39"`
[INFO] running `"docker" "rm" "-f" "96378ed2269f8f93fcc0d4c605bad81d9b75937c537d7e2af490344b2d28ef39"`
[INFO] [stdout] 96378ed2269f8f93fcc0d4c605bad81d9b75937c537d7e2af490344b2d28ef39