[INFO] crate edid 0.2.0 is already in cache [INFO] extracting crate edid 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/edid/0.2.0 [INFO] extracting crate edid 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/edid/0.2.0 [INFO] validating manifest of edid-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of edid-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing edid-0.2.0 [INFO] finished frobbing edid-0.2.0 [INFO] frobbed toml for edid-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/edid/0.2.0/Cargo.toml [INFO] started frobbing edid-0.2.0 [INFO] finished frobbing edid-0.2.0 [INFO] frobbed toml for edid-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/edid/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting edid-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/edid/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6f555f95da4df551daa1e23290bd39e88b5da4d2a496965ffb3edfd0edc12d25 [INFO] running `"docker" "start" "-a" "6f555f95da4df551daa1e23290bd39e88b5da4d2a496965ffb3edfd0edc12d25"` [INFO] [stderr] Checking edid v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cp437.rs:5:23 [INFO] [stderr] | [INFO] [stderr] 5 | const FORWARD_TABLE: &'static [u16] = &[ [INFO] [stderr] | -^^^^^^^------ help: consider removing `'static`: `&[u16]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:22:2 [INFO] [stderr] | [INFO] [stderr] 22 | return [ [INFO] [stderr] | _____^ [INFO] [stderr] 23 | | (((v >> 10) as u8 & mask) + i0) as char, [INFO] [stderr] 24 | | (((v >> 5) as u8 & mask) + i0) as char, [INFO] [stderr] 25 | | (((v >> 0) as u8 & mask) + i0) as char, [INFO] [stderr] 26 | | ] [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 22 | [ [INFO] [stderr] 23 | (((v >> 10) as u8 & mask) + i0) as char, [INFO] [stderr] 24 | (((v >> 5) as u8 & mask) + i0) as char, [INFO] [stderr] 25 | (((v >> 0) as u8 & mask) + i0) as char, [INFO] [stderr] 26 | ] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:219:13 [INFO] [stderr] | [INFO] [stderr] 219 | serial: 1146106418, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_146_106_418` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cp437.rs:5:23 [INFO] [stderr] | [INFO] [stderr] 5 | const FORWARD_TABLE: &'static [u16] = &[ [INFO] [stderr] | -^^^^^^^------ help: consider removing `'static`: `&[u16]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:22:2 [INFO] [stderr] | [INFO] [stderr] 22 | return [ [INFO] [stderr] | _____^ [INFO] [stderr] 23 | | (((v >> 10) as u8 & mask) + i0) as char, [INFO] [stderr] 24 | | (((v >> 5) as u8 & mask) + i0) as char, [INFO] [stderr] 25 | | (((v >> 0) as u8 & mask) + i0) as char, [INFO] [stderr] 26 | | ] [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 22 | [ [INFO] [stderr] 23 | (((v >> 10) as u8 & mask) + i0) as char, [INFO] [stderr] 24 | (((v >> 5) as u8 & mask) + i0) as char, [INFO] [stderr] 25 | (((v >> 0) as u8 & mask) + i0) as char, [INFO] [stderr] 26 | ] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cp437.rs:25:17 [INFO] [stderr] | [INFO] [stderr] 25 | char::from_u32(FORWARD_TABLE[code as usize] as u32).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(FORWARD_TABLE[code as usize])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:21:11 [INFO] [stderr] | [INFO] [stderr] 21 | let i0 = ('A' as u8) - 1; // 0x01 = A [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'A' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `v` [INFO] [stderr] --> src/lib.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | (((v >> 0) as u8 & mask) + i0) as char, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:99:1 [INFO] [stderr] | [INFO] [stderr] 99 | / named!(parse_descriptor<&[u8], Descriptor>, [INFO] [stderr] 100 | | switch!(le_u16, [INFO] [stderr] 101 | | 0 => do_parse!( [INFO] [stderr] 102 | | take!(1) [INFO] [stderr] ... | [INFO] [stderr] 163 | | ) [INFO] [stderr] 164 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:99:1 [INFO] [stderr] | [INFO] [stderr] 99 | / named!(parse_descriptor<&[u8], Descriptor>, [INFO] [stderr] 100 | | switch!(le_u16, [INFO] [stderr] 101 | | 0 => do_parse!( [INFO] [stderr] 102 | | take!(1) [INFO] [stderr] ... | [INFO] [stderr] 163 | | ) [INFO] [stderr] 164 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cp437.rs:25:17 [INFO] [stderr] | [INFO] [stderr] 25 | char::from_u32(FORWARD_TABLE[code as usize] as u32).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(FORWARD_TABLE[code as usize])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:21:11 [INFO] [stderr] | [INFO] [stderr] 21 | let i0 = ('A' as u8) - 1; // 0x01 = A [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'A' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `v` [INFO] [stderr] --> src/lib.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | (((v >> 0) as u8 & mask) + i0) as char, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:99:1 [INFO] [stderr] | [INFO] [stderr] 99 | / named!(parse_descriptor<&[u8], Descriptor>, [INFO] [stderr] 100 | | switch!(le_u16, [INFO] [stderr] 101 | | 0 => do_parse!( [INFO] [stderr] 102 | | take!(1) [INFO] [stderr] ... | [INFO] [stderr] 163 | | ) [INFO] [stderr] 164 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:99:1 [INFO] [stderr] | [INFO] [stderr] 99 | / named!(parse_descriptor<&[u8], Descriptor>, [INFO] [stderr] 100 | | switch!(le_u16, [INFO] [stderr] 101 | | 0 => do_parse!( [INFO] [stderr] 102 | | take!(1) [INFO] [stderr] ... | [INFO] [stderr] 163 | | ) [INFO] [stderr] 164 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.91s [INFO] running `"docker" "inspect" "6f555f95da4df551daa1e23290bd39e88b5da4d2a496965ffb3edfd0edc12d25"` [INFO] running `"docker" "rm" "-f" "6f555f95da4df551daa1e23290bd39e88b5da4d2a496965ffb3edfd0edc12d25"` [INFO] [stdout] 6f555f95da4df551daa1e23290bd39e88b5da4d2a496965ffb3edfd0edc12d25