[INFO] crate ecs 0.23.1 is already in cache [INFO] extracting crate ecs 0.23.1 into work/ex/clippy-test-run/sources/stable/reg/ecs/0.23.1 [INFO] extracting crate ecs 0.23.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ecs/0.23.1 [INFO] validating manifest of ecs-0.23.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ecs-0.23.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ecs-0.23.1 [INFO] finished frobbing ecs-0.23.1 [INFO] frobbed toml for ecs-0.23.1 written to work/ex/clippy-test-run/sources/stable/reg/ecs/0.23.1/Cargo.toml [INFO] started frobbing ecs-0.23.1 [INFO] finished frobbing ecs-0.23.1 [INFO] frobbed toml for ecs-0.23.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ecs/0.23.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ecs-0.23.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ecs/0.23.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8bec55c992b40597e62f89b73a296959fefd5ca305e14b0259b9f45feb1a0908 [INFO] running `"docker" "start" "-a" "8bec55c992b40597e62f89b73a296959fefd5ca305e14b0259b9f45feb1a0908"` [INFO] [stderr] Checking ecs v0.23.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/entity.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | aspect: aspect, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `aspect` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/entity.rs:110:13 [INFO] [stderr] | [INFO] [stderr] 110 | components: components, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `components` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/system/entity.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | aspect: aspect, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `aspect` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/system/entity.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/system/interact.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | aspect_a: aspect_a, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `aspect_a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/system/interact.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | aspect_b: aspect_b, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `aspect_b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/system/interact.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/system/interval.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | interval: interval, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `interval` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/world.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | components: components, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `components` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/world.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | services: services, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `services` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/world.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | entities: entities, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `entities` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/world.rs:167:17 [INFO] [stderr] | [INFO] [stderr] 167 | services: services, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `services` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/entity.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | aspect: aspect, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `aspect` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/entity.rs:110:13 [INFO] [stderr] | [INFO] [stderr] 110 | components: components, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `components` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/system/entity.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | aspect: aspect, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `aspect` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/system/entity.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/system/interact.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | aspect_a: aspect_a, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `aspect_a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/system/interact.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | aspect_b: aspect_b, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `aspect_b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/system/interact.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/system/interval.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | interval: interval, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `interval` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/world.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | components: components, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `components` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/world.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | services: services, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `services` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/world.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | entities: entities, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `entities` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/world.rs:167:17 [INFO] [stderr] | [INFO] [stderr] 167 | services: services, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `services` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/aspect.rs:24:37 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn check<'a>(&self, entity: &EntityData<'a, T>, components: &T) -> bool [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `EntityData<'a, T>` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/component.rs:99:35 [INFO] [stderr] | [INFO] [stderr] 99 | pub fn add(&mut self, entity: &BuildData, component: T) -> Option [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `BuildData` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/component.rs:108:38 [INFO] [stderr] | [INFO] [stderr] 108 | pub fn insert(&mut self, entity: &ModifyData, component: T) -> Option [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider passing by value instead: `ModifyData` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/component.rs:117:38 [INFO] [stderr] | [INFO] [stderr] 117 | pub fn remove(&mut self, entity: &ModifyData) -> Option [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider passing by value instead: `ModifyData` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/component.rs:193:11 [INFO] [stderr] | [INFO] [stderr] 193 | }.expect(&format!("Could not find entry for {:?}", **en.entity())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Could not find entry for {:?}", **en.entity()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/entity.rs:52:15 [INFO] [stderr] | [INFO] [stderr] 52 | pub fn id(&self) -> Id [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: defining a method called `clone` on this type; consider implementing the `std::clone::Clone` trait or choosing a less ambiguous name [INFO] [stderr] --> src/entity.rs:114:5 [INFO] [stderr] | [INFO] [stderr] 114 | / pub fn clone(&self) -> Self { [INFO] [stderr] 115 | | let EntityIter::Map(ref values) = *self; [INFO] [stderr] 116 | | EntityIter::Map(values.clone()) [INFO] [stderr] 117 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `entity::EntityManager` [INFO] [stderr] --> src/entity.rs:194:5 [INFO] [stderr] | [INFO] [stderr] 194 | / pub fn new() -> EntityManager [INFO] [stderr] 195 | | { [INFO] [stderr] 196 | | EntityManager [INFO] [stderr] 197 | | { [INFO] [stderr] ... | [INFO] [stderr] 202 | | } [INFO] [stderr] 203 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 191 | impl Default for entity::EntityManager { [INFO] [stderr] 192 | fn default() -> Self { [INFO] [stderr] 193 | Self::new() [INFO] [stderr] 194 | } [INFO] [stderr] 195 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/entity.rs:267:36 [INFO] [stderr] | [INFO] [stderr] 267 | pub fn is_valid(&self, entity: &Entity) -> bool [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `Entity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/entity.rs:273:38 [INFO] [stderr] | [INFO] [stderr] 273 | pub fn remove(&mut self, entity: &Entity) [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `Entity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/entity.rs:275:9 [INFO] [stderr] | [INFO] [stderr] 275 | self.entities.remove(entity).map(|e| self.indices.return_id(e.index())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(e) = self.entities.remove(entity) { self.indices.return_id(e.index()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `system::lazy::LazySystem` [INFO] [stderr] --> src/system/lazy.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> LazySystem [INFO] [stderr] 16 | | { [INFO] [stderr] 17 | | LazySystem { [INFO] [stderr] 18 | | inner: None, [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/system/lazy.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | self.inner.as_mut().map(|sys| sys.activated(e, c, s)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(sys) = self.inner.as_mut() { sys.activated(e, c, s) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/system/lazy.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | self.inner.as_mut().map(|sys| sys.reactivated(e, c, s)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(sys) = self.inner.as_mut() { sys.reactivated(e, c, s) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/system/lazy.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | self.inner.as_mut().map(|sys| sys.deactivated(e, c, s)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(sys) = self.inner.as_mut() { sys.deactivated(e, c, s) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/system/mod.rs:25:32 [INFO] [stderr] | [INFO] [stderr] 25 | fn activated(&mut self, _: &EntityData, _: &Self::Components, _: &mut Self::Services) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `EntityData` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/system/mod.rs:33:34 [INFO] [stderr] | [INFO] [stderr] 33 | fn reactivated(&mut self, e: &EntityData, c: &Self::Components, s: &mut Self::Services) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `EntityData` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/system/mod.rs:40:34 [INFO] [stderr] | [INFO] [stderr] 40 | fn deactivated(&mut self, _: &EntityData, _: &Self::Components, _: &mut Self::Services) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `EntityData` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/world.rs:89:54 [INFO] [stderr] | [INFO] [stderr] 89 | pub fn with_entity_data(&mut self, entity: &Entity, mut call: F) -> Option [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `Entity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `world::World` [INFO] [stderr] --> src/world.rs:149:5 [INFO] [stderr] | [INFO] [stderr] 149 | / pub fn new() -> World where S::Services: Default [INFO] [stderr] 150 | | { [INFO] [stderr] 151 | | World { [INFO] [stderr] 152 | | systems: S::__new(), [INFO] [stderr] ... | [INFO] [stderr] 158 | | } [INFO] [stderr] 159 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 147 | impl Default for world::World { [INFO] [stderr] 148 | fn default() -> Self { [INFO] [stderr] 149 | Self::new() [INFO] [stderr] 150 | } [INFO] [stderr] 151 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/aspect.rs:24:37 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn check<'a>(&self, entity: &EntityData<'a, T>, components: &T) -> bool [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `EntityData<'a, T>` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/component.rs:99:35 [INFO] [stderr] | [INFO] [stderr] 99 | pub fn add(&mut self, entity: &BuildData, component: T) -> Option [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `BuildData` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/component.rs:108:38 [INFO] [stderr] | [INFO] [stderr] 108 | pub fn insert(&mut self, entity: &ModifyData, component: T) -> Option [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider passing by value instead: `ModifyData` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/component.rs:117:38 [INFO] [stderr] | [INFO] [stderr] 117 | pub fn remove(&mut self, entity: &ModifyData) -> Option [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider passing by value instead: `ModifyData` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/component.rs:193:11 [INFO] [stderr] | [INFO] [stderr] 193 | }.expect(&format!("Could not find entry for {:?}", **en.entity())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Could not find entry for {:?}", **en.entity()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/entity.rs:52:15 [INFO] [stderr] | [INFO] [stderr] 52 | pub fn id(&self) -> Id [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: defining a method called `clone` on this type; consider implementing the `std::clone::Clone` trait or choosing a less ambiguous name [INFO] [stderr] --> src/entity.rs:114:5 [INFO] [stderr] | [INFO] [stderr] 114 | / pub fn clone(&self) -> Self { [INFO] [stderr] 115 | | let EntityIter::Map(ref values) = *self; [INFO] [stderr] 116 | | EntityIter::Map(values.clone()) [INFO] [stderr] 117 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `entity::EntityManager` [INFO] [stderr] --> src/entity.rs:194:5 [INFO] [stderr] | [INFO] [stderr] 194 | / pub fn new() -> EntityManager [INFO] [stderr] 195 | | { [INFO] [stderr] 196 | | EntityManager [INFO] [stderr] 197 | | { [INFO] [stderr] ... | [INFO] [stderr] 202 | | } [INFO] [stderr] 203 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 191 | impl Default for entity::EntityManager { [INFO] [stderr] 192 | fn default() -> Self { [INFO] [stderr] 193 | Self::new() [INFO] [stderr] 194 | } [INFO] [stderr] 195 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/entity.rs:267:36 [INFO] [stderr] | [INFO] [stderr] 267 | pub fn is_valid(&self, entity: &Entity) -> bool [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `Entity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/entity.rs:273:38 [INFO] [stderr] | [INFO] [stderr] 273 | pub fn remove(&mut self, entity: &Entity) [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `Entity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/entity.rs:275:9 [INFO] [stderr] | [INFO] [stderr] 275 | self.entities.remove(entity).map(|e| self.indices.return_id(e.index())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(e) = self.entities.remove(entity) { self.indices.return_id(e.index()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `system::lazy::LazySystem` [INFO] [stderr] --> src/system/lazy.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> LazySystem [INFO] [stderr] 16 | | { [INFO] [stderr] 17 | | LazySystem { [INFO] [stderr] 18 | | inner: None, [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/system/lazy.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | self.inner.as_mut().map(|sys| sys.activated(e, c, s)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(sys) = self.inner.as_mut() { sys.activated(e, c, s) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/system/lazy.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | self.inner.as_mut().map(|sys| sys.reactivated(e, c, s)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(sys) = self.inner.as_mut() { sys.reactivated(e, c, s) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/system/lazy.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | self.inner.as_mut().map(|sys| sys.deactivated(e, c, s)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(sys) = self.inner.as_mut() { sys.deactivated(e, c, s) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/system/mod.rs:25:32 [INFO] [stderr] | [INFO] [stderr] 25 | fn activated(&mut self, _: &EntityData, _: &Self::Components, _: &mut Self::Services) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `EntityData` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/system/mod.rs:33:34 [INFO] [stderr] | [INFO] [stderr] 33 | fn reactivated(&mut self, e: &EntityData, c: &Self::Components, s: &mut Self::Services) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `EntityData` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/system/mod.rs:40:34 [INFO] [stderr] | [INFO] [stderr] 40 | fn deactivated(&mut self, _: &EntityData, _: &Self::Components, _: &mut Self::Services) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `EntityData` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/world.rs:89:54 [INFO] [stderr] | [INFO] [stderr] 89 | pub fn with_entity_data(&mut self, entity: &Entity, mut call: F) -> Option [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `Entity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `world::World` [INFO] [stderr] --> src/world.rs:149:5 [INFO] [stderr] | [INFO] [stderr] 149 | / pub fn new() -> World where S::Services: Default [INFO] [stderr] 150 | | { [INFO] [stderr] 151 | | World { [INFO] [stderr] 152 | | systems: S::__new(), [INFO] [stderr] ... | [INFO] [stderr] 158 | | } [INFO] [stderr] 159 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 147 | impl Default for world::World { [INFO] [stderr] 148 | fn default() -> Self { [INFO] [stderr] 149 | Self::new() [INFO] [stderr] 150 | } [INFO] [stderr] 151 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.32s [INFO] running `"docker" "inspect" "8bec55c992b40597e62f89b73a296959fefd5ca305e14b0259b9f45feb1a0908"` [INFO] running `"docker" "rm" "-f" "8bec55c992b40597e62f89b73a296959fefd5ca305e14b0259b9f45feb1a0908"` [INFO] [stdout] 8bec55c992b40597e62f89b73a296959fefd5ca305e14b0259b9f45feb1a0908