[INFO] crate ecmascript 0.2.0 is already in cache [INFO] extracting crate ecmascript 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/ecmascript/0.2.0 [INFO] extracting crate ecmascript 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ecmascript/0.2.0 [INFO] validating manifest of ecmascript-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ecmascript-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ecmascript-0.2.0 [INFO] finished frobbing ecmascript-0.2.0 [INFO] frobbed toml for ecmascript-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/ecmascript/0.2.0/Cargo.toml [INFO] started frobbing ecmascript-0.2.0 [INFO] finished frobbing ecmascript-0.2.0 [INFO] frobbed toml for ecmascript-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ecmascript/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ecmascript-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ecmascript/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1b8734487125198dd5fd4894cc1b21097c52143a72eff84cfb0788ad996a6614 [INFO] running `"docker" "start" "-a" "1b8734487125198dd5fd4894cc1b21097c52143a72eff84cfb0788ad996a6614"` [INFO] [stderr] Checking ecmascript v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser_unit_test.rs:131:73 [INFO] [stderr] | [INFO] [stderr] 131 | assert_parse_success!(numeric_literal, "0XDEADBEEF", NumericLiteral(3735928559f64)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `3_735_928_559f64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser_unit_test.rs:132:73 [INFO] [stderr] | [INFO] [stderr] 132 | assert_parse_success!(numeric_literal, "0xDEADBEEF", NumericLiteral(3735928559f64)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `3_735_928_559f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/ast.rs:519:5 [INFO] [stderr] | [INFO] [stderr] 519 | / AssignmentProperty { [INFO] [stderr] 520 | | /// The key can still be an id reference, or computed. [INFO] [stderr] 521 | | key: Expression, [INFO] [stderr] 522 | | /// The value however is now another pattern. [INFO] [stderr] 523 | | value: Pattern, [INFO] [stderr] 524 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/ast.rs:519:5 [INFO] [stderr] | [INFO] [stderr] 519 | / AssignmentProperty { [INFO] [stderr] 520 | | /// The key can still be an id reference, or computed. [INFO] [stderr] 521 | | key: Expression, [INFO] [stderr] 522 | | /// The value however is now another pattern. [INFO] [stderr] 523 | | value: Pattern, [INFO] [stderr] 524 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/parser.rs:508:19 [INFO] [stderr] | [INFO] [stderr] 508 | digit as u8 - '0' as u8 [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'0' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/parser.rs:1372:40 [INFO] [stderr] | [INFO] [stderr] 1372 | ).map(|(namespace, token, id)| namespace + &token+ &id) [INFO] [stderr] | ^^^^^^^^^^^^------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `token` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/parser.rs:1372:40 [INFO] [stderr] | [INFO] [stderr] 1372 | ).map(|(namespace, token, id)| namespace + &token+ &id) [INFO] [stderr] | ^^^^^^^^^^^^------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/ast.rs:519:5 [INFO] [stderr] | [INFO] [stderr] 519 | / AssignmentProperty { [INFO] [stderr] 520 | | /// The key can still be an id reference, or computed. [INFO] [stderr] 521 | | key: Expression, [INFO] [stderr] 522 | | /// The value however is now another pattern. [INFO] [stderr] 523 | | value: Pattern, [INFO] [stderr] 524 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/ast.rs:519:5 [INFO] [stderr] | [INFO] [stderr] 519 | / AssignmentProperty { [INFO] [stderr] 520 | | /// The key can still be an id reference, or computed. [INFO] [stderr] 521 | | key: Expression, [INFO] [stderr] 522 | | /// The value however is now another pattern. [INFO] [stderr] 523 | | value: Pattern, [INFO] [stderr] 524 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/parser.rs:508:19 [INFO] [stderr] | [INFO] [stderr] 508 | digit as u8 - '0' as u8 [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'0' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/parser.rs:1372:40 [INFO] [stderr] | [INFO] [stderr] 1372 | ).map(|(namespace, token, id)| namespace + &token+ &id) [INFO] [stderr] | ^^^^^^^^^^^^------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `token` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/parser.rs:1372:40 [INFO] [stderr] | [INFO] [stderr] 1372 | ).map(|(namespace, token, id)| namespace + &token+ &id) [INFO] [stderr] | ^^^^^^^^^^^^------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 18.18s [INFO] running `"docker" "inspect" "1b8734487125198dd5fd4894cc1b21097c52143a72eff84cfb0788ad996a6614"` [INFO] running `"docker" "rm" "-f" "1b8734487125198dd5fd4894cc1b21097c52143a72eff84cfb0788ad996a6614"` [INFO] [stdout] 1b8734487125198dd5fd4894cc1b21097c52143a72eff84cfb0788ad996a6614