[INFO] crate ebustl 0.1.0 is already in cache
[INFO] extracting crate ebustl 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/ebustl/0.1.0
[INFO] extracting crate ebustl 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ebustl/0.1.0
[INFO] validating manifest of ebustl-0.1.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of ebustl-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing ebustl-0.1.0
[INFO] finished frobbing ebustl-0.1.0
[INFO] frobbed toml for ebustl-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/ebustl/0.1.0/Cargo.toml
[INFO] started frobbing ebustl-0.1.0
[INFO] finished frobbing ebustl-0.1.0
[INFO] frobbed toml for ebustl-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ebustl/0.1.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting ebustl-0.1.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ebustl/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] b835f44a27e699fabfd2381bac1f78a23698d848b47a6424429704547e4d7bbc
[INFO] running `"docker" "start" "-a" "b835f44a27e699fabfd2381bac1f78a23698d848b47a6424429704547e4d7bbc"`
[INFO] [stderr]     Checking iso6937 v0.1.0
[INFO] [stderr]     Checking ebustl v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:521:13
[INFO] [stderr]     |
[INFO] [stderr] 521 |             tci: tci,
[INFO] [stderr]     |             ^^^^^^^^ help: replace it with: `tci`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:522:13
[INFO] [stderr]     |
[INFO] [stderr] 522 |             tco: tco,
[INFO] [stderr]     |             ^^^^^^^^ help: replace it with: `tco`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:521:13
[INFO] [stderr]     |
[INFO] [stderr] 521 |             tci: tci,
[INFO] [stderr]     |             ^^^^^^^^ help: replace it with: `tci`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:522:13
[INFO] [stderr]     |
[INFO] [stderr] 522 |             tco: tco,
[INFO] [stderr]     |             ^^^^^^^^ help: replace it with: `tco`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:105:9
[INFO] [stderr]     |
[INFO] [stderr] 105 |         return Err(ParseError::CodePageNumber);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(ParseError::CodePageNumber)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:109:9
[INFO] [stderr]     |
[INFO] [stderr] 109 | /         return match *self {
[INFO] [stderr] 110 | |                    CodePageNumber::CPN_437 => vec![0x34, 0x33, 0x37],
[INFO] [stderr] 111 | |                    CodePageNumber::CPN_850 => vec![0x38, 0x35, 0x30],
[INFO] [stderr] 112 | |                    CodePageNumber::CPN_860 => vec![0x38, 0x36, 0x30],
[INFO] [stderr] 113 | |                    CodePageNumber::CPN_863 => vec![0x38, 0x36, 0x33],
[INFO] [stderr] 114 | |                    CodePageNumber::CPN_865 => vec![0x38, 0x36, 0x35],
[INFO] [stderr] 115 | |                };
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 109 |         match *self {
[INFO] [stderr] 110 |                    CodePageNumber::CPN_437 => vec![0x34, 0x33, 0x37],
[INFO] [stderr] 111 |                    CodePageNumber::CPN_850 => vec![0x38, 0x35, 0x30],
[INFO] [stderr] 112 |                    CodePageNumber::CPN_860 => vec![0x38, 0x36, 0x30],
[INFO] [stderr] 113 |                    CodePageNumber::CPN_863 => vec![0x38, 0x36, 0x33],
[INFO] [stderr] 114 |                    CodePageNumber::CPN_865 => vec![0x38, 0x36, 0x35],
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:130:9
[INFO] [stderr]     |
[INFO] [stderr] 130 | /         return match data {
[INFO] [stderr] 131 | |                    0x20 => Ok(DisplayStandardCode::Blank),
[INFO] [stderr] 132 | |                    0x30 => Ok(DisplayStandardCode::OpenSubtitling),
[INFO] [stderr] 133 | |                    0x31 => Ok(DisplayStandardCode::Level1Teletext),
[INFO] [stderr] 134 | |                    0x32 => Ok(DisplayStandardCode::Level2Teletext),
[INFO] [stderr] 135 | |                    _ => Err(ParseError::DisplayStandardCode),
[INFO] [stderr] 136 | |                };
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 130 |         match data {
[INFO] [stderr] 131 |                    0x20 => Ok(DisplayStandardCode::Blank),
[INFO] [stderr] 132 |                    0x30 => Ok(DisplayStandardCode::OpenSubtitling),
[INFO] [stderr] 133 |                    0x31 => Ok(DisplayStandardCode::Level1Teletext),
[INFO] [stderr] 134 |                    0x32 => Ok(DisplayStandardCode::Level2Teletext),
[INFO] [stderr] 135 |                    _ => Err(ParseError::DisplayStandardCode),
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:140:9
[INFO] [stderr]     |
[INFO] [stderr] 140 | /         return match *self {
[INFO] [stderr] 141 | |                    DisplayStandardCode::Blank => 0x20,
[INFO] [stderr] 142 | |                    DisplayStandardCode::OpenSubtitling => 0x30,
[INFO] [stderr] 143 | |                    DisplayStandardCode::Level1Teletext => 0x31,
[INFO] [stderr] 144 | |                    DisplayStandardCode::Level2Teletext => 0x32,
[INFO] [stderr] 145 | |                };
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 140 |         match *self {
[INFO] [stderr] 141 |                    DisplayStandardCode::Blank => 0x20,
[INFO] [stderr] 142 |                    DisplayStandardCode::OpenSubtitling => 0x30,
[INFO] [stderr] 143 |                    DisplayStandardCode::Level1Teletext => 0x31,
[INFO] [stderr] 144 |                    DisplayStandardCode::Level2Teletext => 0x32,
[INFO] [stderr] 145 |                }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:157:9
[INFO] [stderr]     |
[INFO] [stderr] 157 | /         return match data {
[INFO] [stderr] 158 | |                    0x30 => Ok(TimeCodeStatus::NotIntendedForUse),
[INFO] [stderr] 159 | |                    0x31 => Ok(TimeCodeStatus::IntendedForUse),
[INFO] [stderr] 160 | |                    _ => Err(ParseError::TimeCodeStatus),
[INFO] [stderr] 161 | |                };
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 157 |         match data {
[INFO] [stderr] 158 |                    0x30 => Ok(TimeCodeStatus::NotIntendedForUse),
[INFO] [stderr] 159 |                    0x31 => Ok(TimeCodeStatus::IntendedForUse),
[INFO] [stderr] 160 |                    _ => Err(ParseError::TimeCodeStatus),
[INFO] [stderr] 161 |                }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:165:9
[INFO] [stderr]     |
[INFO] [stderr] 165 | /         return match *self {
[INFO] [stderr] 166 | |                    TimeCodeStatus::NotIntendedForUse => 0x30,
[INFO] [stderr] 167 | |                    TimeCodeStatus::IntendedForUse => 0x31,
[INFO] [stderr] 168 | |                };
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 165 |         match *self {
[INFO] [stderr] 166 |                    TimeCodeStatus::NotIntendedForUse => 0x30,
[INFO] [stderr] 167 |                    TimeCodeStatus::IntendedForUse => 0x31,
[INFO] [stderr] 168 |                }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:201:9
[INFO] [stderr]     |
[INFO] [stderr] 201 | /         return match *self {
[INFO] [stderr] 202 | |                    CharacterCodeTable::Latin => vec![0x30, 0x30],
[INFO] [stderr] 203 | |                    CharacterCodeTable::LatinCyrillic => vec![0x30, 0x31],
[INFO] [stderr] 204 | |                    CharacterCodeTable::LatinArabic => vec![0x30, 0x32],
[INFO] [stderr] 205 | |                    CharacterCodeTable::LatinGreek => vec![0x30, 0x33],
[INFO] [stderr] 206 | |                    CharacterCodeTable::LatinHebrew => vec![0x30, 0x34],
[INFO] [stderr] 207 | |                };
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 201 |         match *self {
[INFO] [stderr] 202 |                    CharacterCodeTable::Latin => vec![0x30, 0x30],
[INFO] [stderr] 203 |                    CharacterCodeTable::LatinCyrillic => vec![0x30, 0x31],
[INFO] [stderr] 204 |                    CharacterCodeTable::LatinArabic => vec![0x30, 0x32],
[INFO] [stderr] 205 |                    CharacterCodeTable::LatinGreek => vec![0x30, 0x33],
[INFO] [stderr] 206 |                    CharacterCodeTable::LatinHebrew => vec![0x30, 0x34],
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:230:9
[INFO] [stderr]     |
[INFO] [stderr] 230 | /         return match *self {
[INFO] [stderr] 231 | |                    DiskFormatCode::STL25_01 => String::from("STL25.01").into_bytes(),
[INFO] [stderr] 232 | |                    DiskFormatCode::STL30_01 => String::from("STL30.01").into_bytes(),
[INFO] [stderr] 233 | |                };
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 230 |         match *self {
[INFO] [stderr] 231 |                    DiskFormatCode::STL25_01 => String::from("STL25.01").into_bytes(),
[INFO] [stderr] 232 |                    DiskFormatCode::STL30_01 => String::from("STL30.01").into_bytes(),
[INFO] [stderr] 233 |                }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:237:9
[INFO] [stderr]     |
[INFO] [stderr] 237 | /         return match self {
[INFO] [stderr] 238 | |                    DiskFormatCode::STL25_01 => 25,
[INFO] [stderr] 239 | |                    DiskFormatCode::STL30_01 => 30,
[INFO] [stderr] 240 | |                };
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 237 |         match self {
[INFO] [stderr] 238 |                    DiskFormatCode::STL25_01 => 25,
[INFO] [stderr] 239 |                    DiskFormatCode::STL30_01 => 30,
[INFO] [stderr] 240 |                }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:396:9
[INFO] [stderr]     |
[INFO] [stderr] 396 |         return res;
[INFO] [stderr]     |         ^^^^^^^^^^^ help: remove `return` as shown: `res`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: All variants have the same postfix: `Set`
[INFO] [stderr]    --> src/lib.rs:414:1
[INFO] [stderr]     |
[INFO] [stderr] 414 | / enum CumulativeStatus {
[INFO] [stderr] 415 | |     NotPartOfASet,
[INFO] [stderr] 416 | |     FirstInSet,
[INFO] [stderr] 417 | |     IntermediateInSet,
[INFO] [stderr] 418 | |     LastInSet,
[INFO] [stderr] 419 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::enum_variant_names)] on by default
[INFO] [stderr]     = help: remove the postfixes and use full paths to the variants instead of glob imports
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:423:9
[INFO] [stderr]     |
[INFO] [stderr] 423 | /         return match d {
[INFO] [stderr] 424 | |                    0 => Ok(CumulativeStatus::NotPartOfASet),
[INFO] [stderr] 425 | |                    1 => Ok(CumulativeStatus::FirstInSet),
[INFO] [stderr] 426 | |                    2 => Ok(CumulativeStatus::IntermediateInSet),
[INFO] [stderr] 427 | |                    3 => Ok(CumulativeStatus::LastInSet),
[INFO] [stderr] 428 | |                    _ => Err(ParseError::CumulativeStatus),
[INFO] [stderr] 429 | |                };
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 423 |         match d {
[INFO] [stderr] 424 |                    0 => Ok(CumulativeStatus::NotPartOfASet),
[INFO] [stderr] 425 |                    1 => Ok(CumulativeStatus::FirstInSet),
[INFO] [stderr] 426 |                    2 => Ok(CumulativeStatus::IntermediateInSet),
[INFO] [stderr] 427 |                    3 => Ok(CumulativeStatus::LastInSet),
[INFO] [stderr] 428 |                    _ => Err(ParseError::CumulativeStatus),
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:433:9
[INFO] [stderr]     |
[INFO] [stderr] 433 | /         return match *self {
[INFO] [stderr] 434 | |                    CumulativeStatus::NotPartOfASet => 0,
[INFO] [stderr] 435 | |                    CumulativeStatus::FirstInSet => 1,
[INFO] [stderr] 436 | |                    CumulativeStatus::IntermediateInSet => 2,
[INFO] [stderr] 437 | |                    CumulativeStatus::LastInSet => 3,
[INFO] [stderr] 438 | |                };
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 433 |         match *self {
[INFO] [stderr] 434 |                    CumulativeStatus::NotPartOfASet => 0,
[INFO] [stderr] 435 |                    CumulativeStatus::FirstInSet => 1,
[INFO] [stderr] 436 |                    CumulativeStatus::IntermediateInSet => 2,
[INFO] [stderr] 437 |                    CumulativeStatus::LastInSet => 3,
[INFO] [stderr] 438 |                }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:578:9
[INFO] [stderr]     |
[INFO] [stderr] 578 |         return result;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `result`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:600:9
[INFO] [stderr]     |
[INFO] [stderr] 600 |         return res;
[INFO] [stderr]     |         ^^^^^^^^^^^ help: remove `return` as shown: `res`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:105:9
[INFO] [stderr]     |
[INFO] [stderr] 105 |         return Err(ParseError::CodePageNumber);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(ParseError::CodePageNumber)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:109:9
[INFO] [stderr]     |
[INFO] [stderr] 109 | /         return match *self {
[INFO] [stderr] 110 | |                    CodePageNumber::CPN_437 => vec![0x34, 0x33, 0x37],
[INFO] [stderr] 111 | |                    CodePageNumber::CPN_850 => vec![0x38, 0x35, 0x30],
[INFO] [stderr] 112 | |                    CodePageNumber::CPN_860 => vec![0x38, 0x36, 0x30],
[INFO] [stderr] 113 | |                    CodePageNumber::CPN_863 => vec![0x38, 0x36, 0x33],
[INFO] [stderr] 114 | |                    CodePageNumber::CPN_865 => vec![0x38, 0x36, 0x35],
[INFO] [stderr] 115 | |                };
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 109 |         match *self {
[INFO] [stderr] 110 |                    CodePageNumber::CPN_437 => vec![0x34, 0x33, 0x37],
[INFO] [stderr] 111 |                    CodePageNumber::CPN_850 => vec![0x38, 0x35, 0x30],
[INFO] [stderr] 112 |                    CodePageNumber::CPN_860 => vec![0x38, 0x36, 0x30],
[INFO] [stderr] 113 |                    CodePageNumber::CPN_863 => vec![0x38, 0x36, 0x33],
[INFO] [stderr] 114 |                    CodePageNumber::CPN_865 => vec![0x38, 0x36, 0x35],
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:130:9
[INFO] [stderr]     |
[INFO] [stderr] 130 | /         return match data {
[INFO] [stderr] 131 | |                    0x20 => Ok(DisplayStandardCode::Blank),
[INFO] [stderr] 132 | |                    0x30 => Ok(DisplayStandardCode::OpenSubtitling),
[INFO] [stderr] 133 | |                    0x31 => Ok(DisplayStandardCode::Level1Teletext),
[INFO] [stderr] 134 | |                    0x32 => Ok(DisplayStandardCode::Level2Teletext),
[INFO] [stderr] 135 | |                    _ => Err(ParseError::DisplayStandardCode),
[INFO] [stderr] 136 | |                };
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 130 |         match data {
[INFO] [stderr] 131 |                    0x20 => Ok(DisplayStandardCode::Blank),
[INFO] [stderr] 132 |                    0x30 => Ok(DisplayStandardCode::OpenSubtitling),
[INFO] [stderr] 133 |                    0x31 => Ok(DisplayStandardCode::Level1Teletext),
[INFO] [stderr] 134 |                    0x32 => Ok(DisplayStandardCode::Level2Teletext),
[INFO] [stderr] 135 |                    _ => Err(ParseError::DisplayStandardCode),
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:140:9
[INFO] [stderr]     |
[INFO] [stderr] 140 | /         return match *self {
[INFO] [stderr] 141 | |                    DisplayStandardCode::Blank => 0x20,
[INFO] [stderr] 142 | |                    DisplayStandardCode::OpenSubtitling => 0x30,
[INFO] [stderr] 143 | |                    DisplayStandardCode::Level1Teletext => 0x31,
[INFO] [stderr] 144 | |                    DisplayStandardCode::Level2Teletext => 0x32,
[INFO] [stderr] 145 | |                };
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 140 |         match *self {
[INFO] [stderr] 141 |                    DisplayStandardCode::Blank => 0x20,
[INFO] [stderr] 142 |                    DisplayStandardCode::OpenSubtitling => 0x30,
[INFO] [stderr] 143 |                    DisplayStandardCode::Level1Teletext => 0x31,
[INFO] [stderr] 144 |                    DisplayStandardCode::Level2Teletext => 0x32,
[INFO] [stderr] 145 |                }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:157:9
[INFO] [stderr]     |
[INFO] [stderr] 157 | /         return match data {
[INFO] [stderr] 158 | |                    0x30 => Ok(TimeCodeStatus::NotIntendedForUse),
[INFO] [stderr] 159 | |                    0x31 => Ok(TimeCodeStatus::IntendedForUse),
[INFO] [stderr] 160 | |                    _ => Err(ParseError::TimeCodeStatus),
[INFO] [stderr] 161 | |                };
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 157 |         match data {
[INFO] [stderr] 158 |                    0x30 => Ok(TimeCodeStatus::NotIntendedForUse),
[INFO] [stderr] 159 |                    0x31 => Ok(TimeCodeStatus::IntendedForUse),
[INFO] [stderr] 160 |                    _ => Err(ParseError::TimeCodeStatus),
[INFO] [stderr] 161 |                }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:165:9
[INFO] [stderr]     |
[INFO] [stderr] 165 | /         return match *self {
[INFO] [stderr] 166 | |                    TimeCodeStatus::NotIntendedForUse => 0x30,
[INFO] [stderr] 167 | |                    TimeCodeStatus::IntendedForUse => 0x31,
[INFO] [stderr] 168 | |                };
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 165 |         match *self {
[INFO] [stderr] 166 |                    TimeCodeStatus::NotIntendedForUse => 0x30,
[INFO] [stderr] 167 |                    TimeCodeStatus::IntendedForUse => 0x31,
[INFO] [stderr] 168 |                }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:201:9
[INFO] [stderr]     |
[INFO] [stderr] 201 | /         return match *self {
[INFO] [stderr] 202 | |                    CharacterCodeTable::Latin => vec![0x30, 0x30],
[INFO] [stderr] 203 | |                    CharacterCodeTable::LatinCyrillic => vec![0x30, 0x31],
[INFO] [stderr] 204 | |                    CharacterCodeTable::LatinArabic => vec![0x30, 0x32],
[INFO] [stderr] 205 | |                    CharacterCodeTable::LatinGreek => vec![0x30, 0x33],
[INFO] [stderr] 206 | |                    CharacterCodeTable::LatinHebrew => vec![0x30, 0x34],
[INFO] [stderr] 207 | |                };
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 201 |         match *self {
[INFO] [stderr] 202 |                    CharacterCodeTable::Latin => vec![0x30, 0x30],
[INFO] [stderr] 203 |                    CharacterCodeTable::LatinCyrillic => vec![0x30, 0x31],
[INFO] [stderr] 204 |                    CharacterCodeTable::LatinArabic => vec![0x30, 0x32],
[INFO] [stderr] 205 |                    CharacterCodeTable::LatinGreek => vec![0x30, 0x33],
[INFO] [stderr] 206 |                    CharacterCodeTable::LatinHebrew => vec![0x30, 0x34],
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:230:9
[INFO] [stderr]     |
[INFO] [stderr] 230 | /         return match *self {
[INFO] [stderr] 231 | |                    DiskFormatCode::STL25_01 => String::from("STL25.01").into_bytes(),
[INFO] [stderr] 232 | |                    DiskFormatCode::STL30_01 => String::from("STL30.01").into_bytes(),
[INFO] [stderr] 233 | |                };
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 230 |         match *self {
[INFO] [stderr] 231 |                    DiskFormatCode::STL25_01 => String::from("STL25.01").into_bytes(),
[INFO] [stderr] 232 |                    DiskFormatCode::STL30_01 => String::from("STL30.01").into_bytes(),
[INFO] [stderr] 233 |                }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:237:9
[INFO] [stderr]     |
[INFO] [stderr] 237 | /         return match self {
[INFO] [stderr] 238 | |                    DiskFormatCode::STL25_01 => 25,
[INFO] [stderr] 239 | |                    DiskFormatCode::STL30_01 => 30,
[INFO] [stderr] 240 | |                };
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 237 |         match self {
[INFO] [stderr] 238 |                    DiskFormatCode::STL25_01 => 25,
[INFO] [stderr] 239 |                    DiskFormatCode::STL30_01 => 30,
[INFO] [stderr] 240 |                }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:396:9
[INFO] [stderr]     |
[INFO] [stderr] 396 |         return res;
[INFO] [stderr]     |         ^^^^^^^^^^^ help: remove `return` as shown: `res`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: All variants have the same postfix: `Set`
[INFO] [stderr]    --> src/lib.rs:414:1
[INFO] [stderr]     |
[INFO] [stderr] 414 | / enum CumulativeStatus {
[INFO] [stderr] 415 | |     NotPartOfASet,
[INFO] [stderr] 416 | |     FirstInSet,
[INFO] [stderr] 417 | |     IntermediateInSet,
[INFO] [stderr] 418 | |     LastInSet,
[INFO] [stderr] 419 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::enum_variant_names)] on by default
[INFO] [stderr]     = help: remove the postfixes and use full paths to the variants instead of glob imports
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:423:9
[INFO] [stderr]     |
[INFO] [stderr] 423 | /         return match d {
[INFO] [stderr] 424 | |                    0 => Ok(CumulativeStatus::NotPartOfASet),
[INFO] [stderr] 425 | |                    1 => Ok(CumulativeStatus::FirstInSet),
[INFO] [stderr] 426 | |                    2 => Ok(CumulativeStatus::IntermediateInSet),
[INFO] [stderr] 427 | |                    3 => Ok(CumulativeStatus::LastInSet),
[INFO] [stderr] 428 | |                    _ => Err(ParseError::CumulativeStatus),
[INFO] [stderr] 429 | |                };
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 423 |         match d {
[INFO] [stderr] 424 |                    0 => Ok(CumulativeStatus::NotPartOfASet),
[INFO] [stderr] 425 |                    1 => Ok(CumulativeStatus::FirstInSet),
[INFO] [stderr] 426 |                    2 => Ok(CumulativeStatus::IntermediateInSet),
[INFO] [stderr] 427 |                    3 => Ok(CumulativeStatus::LastInSet),
[INFO] [stderr] 428 |                    _ => Err(ParseError::CumulativeStatus),
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:433:9
[INFO] [stderr]     |
[INFO] [stderr] 433 | /         return match *self {
[INFO] [stderr] 434 | |                    CumulativeStatus::NotPartOfASet => 0,
[INFO] [stderr] 435 | |                    CumulativeStatus::FirstInSet => 1,
[INFO] [stderr] 436 | |                    CumulativeStatus::IntermediateInSet => 2,
[INFO] [stderr] 437 | |                    CumulativeStatus::LastInSet => 3,
[INFO] [stderr] 438 | |                };
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 433 |         match *self {
[INFO] [stderr] 434 |                    CumulativeStatus::NotPartOfASet => 0,
[INFO] [stderr] 435 |                    CumulativeStatus::FirstInSet => 1,
[INFO] [stderr] 436 |                    CumulativeStatus::IntermediateInSet => 2,
[INFO] [stderr] 437 |                    CumulativeStatus::LastInSet => 3,
[INFO] [stderr] 438 |                }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:578:9
[INFO] [stderr]     |
[INFO] [stderr] 578 |         return result;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `result`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:600:9
[INFO] [stderr]     |
[INFO] [stderr] 600 |         return res;
[INFO] [stderr]     |         ^^^^^^^^^^^ help: remove `return` as shown: `res`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `Stl`
[INFO] [stderr]   --> src/lib.rs:40:5
[INFO] [stderr]    |
[INFO] [stderr] 40 | /     pub fn new() -> Stl {
[INFO] [stderr] 41 | |         Stl {
[INFO] [stderr] 42 | |             gsi: GsiBlock::new(),
[INFO] [stderr] 43 | |             ttis: vec![],
[INFO] [stderr] 44 | |         }
[INFO] [stderr] 45 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 39 | impl Default for Stl {
[INFO] [stderr] 40 |     fn default() -> Self {
[INFO] [stderr] 41 |         Self::new()
[INFO] [stderr] 42 |     }
[INFO] [stderr] 43 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/lib.rs:310:36
[INFO] [stderr]     |
[INFO] [stderr] 310 | fn push_string(v: &mut Vec<u8>, s: &String, len: usize) {
[INFO] [stderr]     |                                    ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `GsiBlock`
[INFO] [stderr]    --> src/lib.rs:318:5
[INFO] [stderr]     |
[INFO] [stderr] 318 | /     pub fn new() -> GsiBlock {
[INFO] [stderr] 319 | |         let date = chrono::Local::now();
[INFO] [stderr] 320 | |         let now = date.format("%y%m%d").to_string();
[INFO] [stderr] 321 | |         GsiBlock {
[INFO] [stderr] ...   |
[INFO] [stderr] 353 | |         }
[INFO] [stderr] 354 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 317 | impl Default for GsiBlock {
[INFO] [stderr] 318 |     fn default() -> Self {
[INFO] [stderr] 319 |         Self::new()
[INFO] [stderr] 320 |     }
[INFO] [stderr] 321 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: some ranges overlap
[INFO] [stderr]    --> src/lib.rs:562:20
[INFO] [stderr]     |
[INFO] [stderr] 562 |                    0x20...0x7f => false,
[INFO] [stderr]     |                    ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_overlapping_arm)] on by default
[INFO] [stderr] note: overlaps with this
[INFO] [stderr]    --> src/lib.rs:563:20
[INFO] [stderr]     |
[INFO] [stderr] 563 |                    0x7f...0x9f => true, // TODO: decode codes
[INFO] [stderr]     |                    ^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `vec!`
[INFO] [stderr]    --> src/parser.rs:150:28
[INFO] [stderr]     |
[INFO] [stderr] 150 |         let empty: &[u8] = &vec![];
[INFO] [stderr]     |                            ^^^^^^^ help: you can use a slice directly: `&[]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_vec)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `Stl`
[INFO] [stderr]   --> src/lib.rs:40:5
[INFO] [stderr]    |
[INFO] [stderr] 40 | /     pub fn new() -> Stl {
[INFO] [stderr] 41 | |         Stl {
[INFO] [stderr] 42 | |             gsi: GsiBlock::new(),
[INFO] [stderr] 43 | |             ttis: vec![],
[INFO] [stderr] 44 | |         }
[INFO] [stderr] 45 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 39 | impl Default for Stl {
[INFO] [stderr] 40 |     fn default() -> Self {
[INFO] [stderr] 41 |         Self::new()
[INFO] [stderr] 42 |     }
[INFO] [stderr] 43 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/lib.rs:310:36
[INFO] [stderr]     |
[INFO] [stderr] 310 | fn push_string(v: &mut Vec<u8>, s: &String, len: usize) {
[INFO] [stderr]     |                                    ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `GsiBlock`
[INFO] [stderr]    --> src/lib.rs:318:5
[INFO] [stderr]     |
[INFO] [stderr] 318 | /     pub fn new() -> GsiBlock {
[INFO] [stderr] 319 | |         let date = chrono::Local::now();
[INFO] [stderr] 320 | |         let now = date.format("%y%m%d").to_string();
[INFO] [stderr] 321 | |         GsiBlock {
[INFO] [stderr] ...   |
[INFO] [stderr] 353 | |         }
[INFO] [stderr] 354 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 317 | impl Default for GsiBlock {
[INFO] [stderr] 318 |     fn default() -> Self {
[INFO] [stderr] 319 |         Self::new()
[INFO] [stderr] 320 |     }
[INFO] [stderr] 321 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: some ranges overlap
[INFO] [stderr]    --> src/lib.rs:562:20
[INFO] [stderr]     |
[INFO] [stderr] 562 |                    0x20...0x7f => false,
[INFO] [stderr]     |                    ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_overlapping_arm)] on by default
[INFO] [stderr] note: overlaps with this
[INFO] [stderr]    --> src/lib.rs:563:20
[INFO] [stderr]     |
[INFO] [stderr] 563 |                    0x7f...0x9f => true, // TODO: decode codes
[INFO] [stderr]     |                    ^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 8.63s
[INFO] running `"docker" "inspect" "b835f44a27e699fabfd2381bac1f78a23698d848b47a6424429704547e4d7bbc"`
[INFO] running `"docker" "rm" "-f" "b835f44a27e699fabfd2381bac1f78a23698d848b47a6424429704547e4d7bbc"`
[INFO] [stdout] b835f44a27e699fabfd2381bac1f78a23698d848b47a6424429704547e4d7bbc