[INFO] crate ebpf 0.0.4 is already in cache [INFO] extracting crate ebpf 0.0.4 into work/ex/clippy-test-run/sources/stable/reg/ebpf/0.0.4 [INFO] extracting crate ebpf 0.0.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ebpf/0.0.4 [INFO] validating manifest of ebpf-0.0.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ebpf-0.0.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ebpf-0.0.4 [INFO] finished frobbing ebpf-0.0.4 [INFO] frobbed toml for ebpf-0.0.4 written to work/ex/clippy-test-run/sources/stable/reg/ebpf/0.0.4/Cargo.toml [INFO] started frobbing ebpf-0.0.4 [INFO] finished frobbing ebpf-0.0.4 [INFO] frobbed toml for ebpf-0.0.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ebpf/0.0.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ebpf-0.0.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ebpf/0.0.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 60d5c9a1b0ad23f685db7e95542d8f23d6b04f1555440bc26942fef5bed85bde [INFO] running `"docker" "start" "-a" "60d5c9a1b0ad23f685db7e95542d8f23d6b04f1555440bc26942fef5bed85bde"` [INFO] [stderr] Checking ioctl-sys v0.5.2 [INFO] [stderr] Checking ebpf v0.0.4 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elf.rs:132:21 [INFO] [stderr] | [INFO] [stderr] 132 | fd: fd, [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `fd` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elf.rs:189:13 [INFO] [stderr] | [INFO] [stderr] 189 | section: section, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `section` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elf.rs:190:13 [INFO] [stderr] | [INFO] [stderr] 190 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elf.rs:212:17 [INFO] [stderr] | [INFO] [stderr] 212 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sys.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | flags: flags, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sys.rs:119:34 [INFO] [stderr] | [INFO] [stderr] 119 | op: bpf_get_op { start_id: start_id }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `start_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sys.rs:130:34 [INFO] [stderr] | [INFO] [stderr] 130 | op: bpf_get_op { start_id: start_id }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `start_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xdp.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | headroom: headroom, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `headroom` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xdp.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | fd: fd, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `fd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xdp.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | rx: rx, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xdp.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | tx: tx, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xdp.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | fr: fr, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `fr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xdp.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | cr: cr, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xdp.rs:175:13 [INFO] [stderr] | [INFO] [stderr] 175 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xdp.rs:176:13 [INFO] [stderr] | [INFO] [stderr] 176 | shared: shared, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `shared` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xdp.rs:347:13 [INFO] [stderr] | [INFO] [stderr] 347 | producer: producer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `producer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xdp.rs:348:13 [INFO] [stderr] | [INFO] [stderr] 348 | consumer: consumer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `consumer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xdp.rs:349:13 [INFO] [stderr] | [INFO] [stderr] 349 | ring: ring, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `ring` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xdp.rs:350:13 [INFO] [stderr] | [INFO] [stderr] 350 | map: map, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] Checking perf v0.0.1 [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ffi.rs:274:51 [INFO] [stderr] | [INFO] [stderr] 274 | pub const XDP_PGOFF_TX_RING: off_t = 0x80000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ffi.rs:275:51 [INFO] [stderr] | [INFO] [stderr] 275 | pub const XDP_UMEM_PGOFF_FILL_RING: off_t = 0x100000000; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0x0001_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ffi.rs:276:51 [INFO] [stderr] | [INFO] [stderr] 276 | pub const XDP_UMEM_PGOFF_COMPLETION_RING: off_t = 0x180000000; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0x0001_8000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/ffi.rs:269:51 [INFO] [stderr] | [INFO] [stderr] 269 | pub const XDP_SHARED_UMEM: u16 = 1 << 0; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/sys.rs:198:5 [INFO] [stderr] | [INFO] [stderr] 198 | &dst.iter_mut().zip(src).for_each(|(d, s)| *d = s); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dst.iter_mut().zip(src).for_each(|(d, s)| *d = s);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/xdp.rs:56:23 [INFO] [stderr] | [INFO] [stderr] 56 | len: size as u64, [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(size)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/xdp.rs:94:12 [INFO] [stderr] | [INFO] [stderr] 94 | Ok(bind(self.fd, &sa)?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 94 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elf.rs:132:21 [INFO] [stderr] | [INFO] [stderr] 132 | fd: fd, [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `fd` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elf.rs:189:13 [INFO] [stderr] | [INFO] [stderr] 189 | section: section, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `section` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elf.rs:190:13 [INFO] [stderr] | [INFO] [stderr] 190 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elf.rs:212:17 [INFO] [stderr] | [INFO] [stderr] 212 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sys.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | flags: flags, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sys.rs:119:34 [INFO] [stderr] | [INFO] [stderr] 119 | op: bpf_get_op { start_id: start_id }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `start_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sys.rs:130:34 [INFO] [stderr] | [INFO] [stderr] 130 | op: bpf_get_op { start_id: start_id }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `start_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xdp.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | headroom: headroom, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `headroom` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xdp.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | fd: fd, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `fd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xdp.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | rx: rx, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xdp.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | tx: tx, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xdp.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | fr: fr, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `fr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xdp.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | cr: cr, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xdp.rs:175:13 [INFO] [stderr] | [INFO] [stderr] 175 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xdp.rs:176:13 [INFO] [stderr] | [INFO] [stderr] 176 | shared: shared, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `shared` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xdp.rs:347:13 [INFO] [stderr] | [INFO] [stderr] 347 | producer: producer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `producer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xdp.rs:348:13 [INFO] [stderr] | [INFO] [stderr] 348 | consumer: consumer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `consumer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xdp.rs:349:13 [INFO] [stderr] | [INFO] [stderr] 349 | ring: ring, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `ring` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xdp.rs:350:13 [INFO] [stderr] | [INFO] [stderr] 350 | map: map, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ffi.rs:274:51 [INFO] [stderr] | [INFO] [stderr] 274 | pub const XDP_PGOFF_TX_RING: off_t = 0x80000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ffi.rs:275:51 [INFO] [stderr] | [INFO] [stderr] 275 | pub const XDP_UMEM_PGOFF_FILL_RING: off_t = 0x100000000; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0x0001_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ffi.rs:276:51 [INFO] [stderr] | [INFO] [stderr] 276 | pub const XDP_UMEM_PGOFF_COMPLETION_RING: off_t = 0x180000000; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0x0001_8000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sys.rs:326:66 [INFO] [stderr] | [INFO] [stderr] 326 | bpf_insn { code: 0xb7, regs: 0x00, off: 0x0000, imm: 0x00000000 }, // mov64 r0, 0x00 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sys.rs:327:66 [INFO] [stderr] | [INFO] [stderr] 327 | bpf_insn { code: 0x95, regs: 0x00, off: 0x0000, imm: 0x00000000 }, // exit [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sys.rs:411:66 [INFO] [stderr] | [INFO] [stderr] 411 | bpf_insn { code: 0xb7, regs: 0x00, off: 0x0000, imm: 0x00000000 }, // mov64 r0, 0x00 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sys.rs:412:66 [INFO] [stderr] | [INFO] [stderr] 412 | bpf_insn { code: 0x95, regs: 0x00, off: 0x0000, imm: 0x00000000 }, // exit [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/ffi.rs:269:51 [INFO] [stderr] | [INFO] [stderr] 269 | pub const XDP_SHARED_UMEM: u16 = 1 << 0; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/sys.rs:198:5 [INFO] [stderr] | [INFO] [stderr] 198 | &dst.iter_mut().zip(src).for_each(|(d, s)| *d = s); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dst.iter_mut().zip(src).for_each(|(d, s)| *d = s);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/sys.rs:450:35 [INFO] [stderr] | [INFO] [stderr] 450 | let line = line.split(" ").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/sys.rs:451:13 [INFO] [stderr] | [INFO] [stderr] 451 | / if let &["bpf", path] = &line[0..2] { [INFO] [stderr] 452 | | return Some(path.to_owned()); [INFO] [stderr] 453 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 451 | if let ["bpf", path] = line[0..2] { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/xdp.rs:56:23 [INFO] [stderr] | [INFO] [stderr] 56 | len: size as u64, [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(size)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/xdp.rs:94:12 [INFO] [stderr] | [INFO] [stderr] 94 | Ok(bind(self.fd, &sa)?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 94 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.43s [INFO] running `"docker" "inspect" "60d5c9a1b0ad23f685db7e95542d8f23d6b04f1555440bc26942fef5bed85bde"` [INFO] running `"docker" "rm" "-f" "60d5c9a1b0ad23f685db7e95542d8f23d6b04f1555440bc26942fef5bed85bde"` [INFO] [stdout] 60d5c9a1b0ad23f685db7e95542d8f23d6b04f1555440bc26942fef5bed85bde