[INFO] crate ebay 0.1.2 is already in cache [INFO] extracting crate ebay 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/ebay/0.1.2 [INFO] extracting crate ebay 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ebay/0.1.2 [INFO] validating manifest of ebay-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ebay-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ebay-0.1.2 [INFO] finished frobbing ebay-0.1.2 [INFO] frobbed toml for ebay-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/ebay/0.1.2/Cargo.toml [INFO] started frobbing ebay-0.1.2 [INFO] finished frobbing ebay-0.1.2 [INFO] frobbed toml for ebay-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ebay/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ebay-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ebay/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e211fe6841b65abe2de4affc7194e7f513ee8267f80842ae8bc31ce9d386df24 [INFO] running `"docker" "start" "-a" "e211fe6841b65abe2de4affc7194e7f513ee8267f80842ae8bc31ce9d386df24"` [INFO] [stderr] Checking ebay v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | Err(err) => return Err(ErrorKind::Deserialize(err.to_string(), body).into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(ErrorKind::Deserialize(err.to_string(), body).into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/client.rs:9:25 [INFO] [stderr] | [INFO] [stderr] 9 | pub const ALL_SCOPES: [&'static str; 10] = [ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | Err(err) => return Err(ErrorKind::Deserialize(err.to_string(), body).into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(ErrorKind::Deserialize(err.to_string(), body).into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/client.rs:9:25 [INFO] [stderr] | [INFO] [stderr] 9 | pub const ALL_SCOPES: [&'static str; 10] = [ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/auth/exchange.rs:45:15 [INFO] [stderr] | [INFO] [stderr] 45 | code: code.as_ref(), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try this: `code` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/client.rs:41:25 [INFO] [stderr] | [INFO] [stderr] 41 | self.inner.scopes = scopes.iter().cloned().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_cloned_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/client.rs:51:15 [INFO] [stderr] | [INFO] [stderr] 51 | scopes: ALL_SCOPES.iter().cloned().collect(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/client.rs:58:3 [INFO] [stderr] | [INFO] [stderr] 58 | / pub fn new(client_id: &str, client_secret: &str, refresh_token: &str) -> EbayClientBuilder { [INFO] [stderr] 59 | | Self::with_http_client(client_id, client_secret, refresh_token, Client::new()) [INFO] [stderr] 60 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/client.rs:77:15 [INFO] [stderr] | [INFO] [stderr] 77 | scopes: ALL_SCOPES.iter().cloned().collect(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/sell/fulfillment/order/shipping_fulfillment/types.rs:55:3 [INFO] [stderr] | [INFO] [stderr] 55 | / pub fn new(carrier_code: &str, tracking: &str) -> ShippingFulfillmentDetailsBuilder { [INFO] [stderr] 56 | | ShippingFulfillmentDetailsBuilder { [INFO] [stderr] 57 | | inner: ShippingFulfillmentDetails { [INFO] [stderr] 58 | | tracking_number: tracking.to_owned().into(), [INFO] [stderr] ... | [INFO] [stderr] 64 | | } [INFO] [stderr] 65 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/auth/exchange.rs:45:15 [INFO] [stderr] | [INFO] [stderr] 45 | code: code.as_ref(), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try this: `code` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/sell/fulfillment/order/mod.rs:115:5 [INFO] [stderr] | [INFO] [stderr] 115 | / match self.last_modified_date.as_ref() { [INFO] [stderr] 116 | | Some(range) => { [INFO] [stderr] 117 | | if !encoded.is_empty() { [INFO] [stderr] 118 | | encoded.push(',') [INFO] [stderr] ... | [INFO] [stderr] 131 | | None => {} [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 115 | if let Some(range) = self.last_modified_date.as_ref() { [INFO] [stderr] 116 | if !encoded.is_empty() { [INFO] [stderr] 117 | encoded.push(',') [INFO] [stderr] 118 | } [INFO] [stderr] 119 | match range { [INFO] [stderr] 120 | DateRange::After(date) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/client.rs:41:25 [INFO] [stderr] | [INFO] [stderr] 41 | self.inner.scopes = scopes.iter().cloned().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_cloned_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/client.rs:51:15 [INFO] [stderr] | [INFO] [stderr] 51 | scopes: ALL_SCOPES.iter().cloned().collect(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/client.rs:58:3 [INFO] [stderr] | [INFO] [stderr] 58 | / pub fn new(client_id: &str, client_secret: &str, refresh_token: &str) -> EbayClientBuilder { [INFO] [stderr] 59 | | Self::with_http_client(client_id, client_secret, refresh_token, Client::new()) [INFO] [stderr] 60 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/client.rs:77:15 [INFO] [stderr] | [INFO] [stderr] 77 | scopes: ALL_SCOPES.iter().cloned().collect(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/sell/fulfillment/order/shipping_fulfillment/types.rs:55:3 [INFO] [stderr] | [INFO] [stderr] 55 | / pub fn new(carrier_code: &str, tracking: &str) -> ShippingFulfillmentDetailsBuilder { [INFO] [stderr] 56 | | ShippingFulfillmentDetailsBuilder { [INFO] [stderr] 57 | | inner: ShippingFulfillmentDetails { [INFO] [stderr] 58 | | tracking_number: tracking.to_owned().into(), [INFO] [stderr] ... | [INFO] [stderr] 64 | | } [INFO] [stderr] 65 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/sell/fulfillment/order/mod.rs:115:5 [INFO] [stderr] | [INFO] [stderr] 115 | / match self.last_modified_date.as_ref() { [INFO] [stderr] 116 | | Some(range) => { [INFO] [stderr] 117 | | if !encoded.is_empty() { [INFO] [stderr] 118 | | encoded.push(',') [INFO] [stderr] ... | [INFO] [stderr] 131 | | None => {} [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 115 | if let Some(range) = self.last_modified_date.as_ref() { [INFO] [stderr] 116 | if !encoded.is_empty() { [INFO] [stderr] 117 | encoded.push(',') [INFO] [stderr] 118 | } [INFO] [stderr] 119 | match range { [INFO] [stderr] 120 | DateRange::After(date) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.04s [INFO] running `"docker" "inspect" "e211fe6841b65abe2de4affc7194e7f513ee8267f80842ae8bc31ce9d386df24"` [INFO] running `"docker" "rm" "-f" "e211fe6841b65abe2de4affc7194e7f513ee8267f80842ae8bc31ce9d386df24"` [INFO] [stdout] e211fe6841b65abe2de4affc7194e7f513ee8267f80842ae8bc31ce9d386df24