[INFO] crate easylog 1.2.0 is already in cache [INFO] extracting crate easylog 1.2.0 into work/ex/clippy-test-run/sources/stable/reg/easylog/1.2.0 [INFO] extracting crate easylog 1.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/easylog/1.2.0 [INFO] validating manifest of easylog-1.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of easylog-1.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing easylog-1.2.0 [INFO] finished frobbing easylog-1.2.0 [INFO] frobbed toml for easylog-1.2.0 written to work/ex/clippy-test-run/sources/stable/reg/easylog/1.2.0/Cargo.toml [INFO] started frobbing easylog-1.2.0 [INFO] finished frobbing easylog-1.2.0 [INFO] frobbed toml for easylog-1.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/easylog/1.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting easylog-1.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/easylog/1.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 62284c76ae7cd1bdf05e3fbb250462b4924b66fefdc5cafd863148ceba732f6e [INFO] running `"docker" "start" "-a" "62284c76ae7cd1bdf05e3fbb250462b4924b66fefdc5cafd863148ceba732f6e"` [INFO] [stderr] Checking easylog v1.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/log_file.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | return Ok(logfile); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(logfile)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/log_file.rs:166:9 [INFO] [stderr] | [INFO] [stderr] 166 | / return LogFile { [INFO] [stderr] 167 | | max_size: self.max_size.clone(), [INFO] [stderr] 168 | | config: self.config.clone(), [INFO] [stderr] 169 | | complete_path: self.complete_path.clone(), [INFO] [stderr] 170 | | counter: self.counter.clone(), [INFO] [stderr] 171 | | file: self.file.try_clone().unwrap(), [INFO] [stderr] 172 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 166 | LogFile { [INFO] [stderr] 167 | max_size: self.max_size.clone(), [INFO] [stderr] 168 | config: self.config.clone(), [INFO] [stderr] 169 | complete_path: self.complete_path.clone(), [INFO] [stderr] 170 | counter: self.counter.clone(), [INFO] [stderr] 171 | file: self.file.try_clone().unwrap(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/log_file.rs:209:9 [INFO] [stderr] | [INFO] [stderr] 209 | return meta.len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `meta.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/log_file.rs:225:9 [INFO] [stderr] | [INFO] [stderr] 225 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/log_file.rs:240:9 [INFO] [stderr] | [INFO] [stderr] 240 | return log_msg; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `log_msg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/log_file.rs:252:5 [INFO] [stderr] | [INFO] [stderr] 252 | / return Ok(LogFile { [INFO] [stderr] 253 | | max_size, [INFO] [stderr] 254 | | config, [INFO] [stderr] 255 | | complete_path: path.clone().to_string(), [INFO] [stderr] 256 | | counter, [INFO] [stderr] 257 | | file: f, [INFO] [stderr] 258 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 252 | Ok(LogFile { [INFO] [stderr] 253 | max_size, [INFO] [stderr] 254 | config, [INFO] [stderr] 255 | complete_path: path.clone().to_string(), [INFO] [stderr] 256 | counter, [INFO] [stderr] 257 | file: f, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/log_file.rs:268:5 [INFO] [stderr] | [INFO] [stderr] 268 | return Ok(f); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/log_file.rs:276:5 [INFO] [stderr] | [INFO] [stderr] 276 | return timestamp; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/log_file.rs:283:5 [INFO] [stderr] | [INFO] [stderr] 283 | return exist; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `exist` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/log_file.rs:295:5 [INFO] [stderr] | [INFO] [stderr] 295 | return path; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/log_file.rs:313:5 [INFO] [stderr] | [INFO] [stderr] 313 | return check; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `check` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/log_file_config.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | / return LogFileConfig { [INFO] [stderr] 27 | | max_size_in_mb: 1, [INFO] [stderr] 28 | | path: String::from("./"), [INFO] [stderr] 29 | | name: String::from("logfile_"), [INFO] [stderr] 30 | | extension: String::from(".log"), [INFO] [stderr] 31 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 26 | LogFileConfig { [INFO] [stderr] 27 | max_size_in_mb: 1, [INFO] [stderr] 28 | path: String::from("./"), [INFO] [stderr] 29 | name: String::from("logfile_"), [INFO] [stderr] 30 | extension: String::from(".log"), [INFO] [stderr] 31 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/log_file_config.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | / return LogFileConfig { [INFO] [stderr] 37 | | max_size_in_mb: self.max_size_in_mb.clone(), [INFO] [stderr] 38 | | path: self.path.clone(), [INFO] [stderr] 39 | | name: self.name.clone(), [INFO] [stderr] 40 | | extension: self.extension.clone(), [INFO] [stderr] 41 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 36 | LogFileConfig { [INFO] [stderr] 37 | max_size_in_mb: self.max_size_in_mb.clone(), [INFO] [stderr] 38 | path: self.path.clone(), [INFO] [stderr] 39 | name: self.name.clone(), [INFO] [stderr] 40 | extension: self.extension.clone(), [INFO] [stderr] 41 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/log_file.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | return Ok(logfile); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(logfile)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/log_file.rs:166:9 [INFO] [stderr] | [INFO] [stderr] 166 | / return LogFile { [INFO] [stderr] 167 | | max_size: self.max_size.clone(), [INFO] [stderr] 168 | | config: self.config.clone(), [INFO] [stderr] 169 | | complete_path: self.complete_path.clone(), [INFO] [stderr] 170 | | counter: self.counter.clone(), [INFO] [stderr] 171 | | file: self.file.try_clone().unwrap(), [INFO] [stderr] 172 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 166 | LogFile { [INFO] [stderr] 167 | max_size: self.max_size.clone(), [INFO] [stderr] 168 | config: self.config.clone(), [INFO] [stderr] 169 | complete_path: self.complete_path.clone(), [INFO] [stderr] 170 | counter: self.counter.clone(), [INFO] [stderr] 171 | file: self.file.try_clone().unwrap(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/log_file.rs:209:9 [INFO] [stderr] | [INFO] [stderr] 209 | return meta.len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `meta.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/log_file.rs:225:9 [INFO] [stderr] | [INFO] [stderr] 225 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/log_file.rs:240:9 [INFO] [stderr] | [INFO] [stderr] 240 | return log_msg; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `log_msg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/log_file.rs:252:5 [INFO] [stderr] | [INFO] [stderr] 252 | / return Ok(LogFile { [INFO] [stderr] 253 | | max_size, [INFO] [stderr] 254 | | config, [INFO] [stderr] 255 | | complete_path: path.clone().to_string(), [INFO] [stderr] 256 | | counter, [INFO] [stderr] 257 | | file: f, [INFO] [stderr] 258 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 252 | Ok(LogFile { [INFO] [stderr] 253 | max_size, [INFO] [stderr] 254 | config, [INFO] [stderr] 255 | complete_path: path.clone().to_string(), [INFO] [stderr] 256 | counter, [INFO] [stderr] 257 | file: f, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/log_file.rs:268:5 [INFO] [stderr] | [INFO] [stderr] 268 | return Ok(f); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/log_file.rs:276:5 [INFO] [stderr] | [INFO] [stderr] 276 | return timestamp; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/log_file.rs:283:5 [INFO] [stderr] | [INFO] [stderr] 283 | return exist; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `exist` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/log_file.rs:295:5 [INFO] [stderr] | [INFO] [stderr] 295 | return path; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/log_file.rs:313:5 [INFO] [stderr] | [INFO] [stderr] 313 | return check; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `check` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/log_file_config.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | / return LogFileConfig { [INFO] [stderr] 27 | | max_size_in_mb: 1, [INFO] [stderr] 28 | | path: String::from("./"), [INFO] [stderr] 29 | | name: String::from("logfile_"), [INFO] [stderr] 30 | | extension: String::from(".log"), [INFO] [stderr] 31 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 26 | LogFileConfig { [INFO] [stderr] 27 | max_size_in_mb: 1, [INFO] [stderr] 28 | path: String::from("./"), [INFO] [stderr] 29 | name: String::from("logfile_"), [INFO] [stderr] 30 | extension: String::from(".log"), [INFO] [stderr] 31 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/log_file_config.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | / return LogFileConfig { [INFO] [stderr] 37 | | max_size_in_mb: self.max_size_in_mb.clone(), [INFO] [stderr] 38 | | path: self.path.clone(), [INFO] [stderr] 39 | | name: self.name.clone(), [INFO] [stderr] 40 | | extension: self.extension.clone(), [INFO] [stderr] 41 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 36 | LogFileConfig { [INFO] [stderr] 37 | max_size_in_mb: self.max_size_in_mb.clone(), [INFO] [stderr] 38 | path: self.path.clone(), [INFO] [stderr] 39 | name: self.name.clone(), [INFO] [stderr] 40 | extension: self.extension.clone(), [INFO] [stderr] 41 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/log_file.rs:167:23 [INFO] [stderr] | [INFO] [stderr] 167 | max_size: self.max_size.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.max_size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/log_file.rs:170:22 [INFO] [stderr] | [INFO] [stderr] 170 | counter: self.counter.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.counter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/log_file.rs:176:9 [INFO] [stderr] | [INFO] [stderr] 176 | self.file.write(&msg.into_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing. [INFO] [stderr] --> src/log_file.rs:181:9 [INFO] [stderr] | [INFO] [stderr] 181 | drop(&self.file); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::drop_ref)] on by default [INFO] [stderr] note: argument has type &std::fs::File [INFO] [stderr] --> src/log_file.rs:181:14 [INFO] [stderr] | [INFO] [stderr] 181 | drop(&self.file); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_ref [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/log_file.rs:255:24 [INFO] [stderr] | [INFO] [stderr] 255 | complete_path: path.clone().to_string(), [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 255 | complete_path: &(*path).clone().to_string(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 255 | complete_path: &str::clone(path).to_string(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `log_file_config::LogFileConfig` [INFO] [stderr] --> src/log_file_config.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | / pub fn new() -> LogFileConfig { [INFO] [stderr] 26 | | return LogFileConfig { [INFO] [stderr] 27 | | max_size_in_mb: 1, [INFO] [stderr] 28 | | path: String::from("./"), [INFO] [stderr] ... | [INFO] [stderr] 31 | | }; [INFO] [stderr] 32 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 2 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/log_file_config.rs:37:29 [INFO] [stderr] | [INFO] [stderr] 37 | max_size_in_mb: self.max_size_in_mb.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.max_size_in_mb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/log_file.rs:167:23 [INFO] [stderr] | [INFO] [stderr] 167 | max_size: self.max_size.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.max_size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/log_file.rs:170:22 [INFO] [stderr] | [INFO] [stderr] 170 | counter: self.counter.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.counter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/log_file.rs:176:9 [INFO] [stderr] | [INFO] [stderr] 176 | self.file.write(&msg.into_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing. [INFO] [stderr] --> src/log_file.rs:181:9 [INFO] [stderr] | [INFO] [stderr] 181 | drop(&self.file); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::drop_ref)] on by default [INFO] [stderr] note: argument has type &std::fs::File [INFO] [stderr] --> src/log_file.rs:181:14 [INFO] [stderr] | [INFO] [stderr] 181 | drop(&self.file); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_ref [INFO] [stderr] [INFO] [stderr] error: Could not compile `easylog`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/log_file.rs:255:24 [INFO] [stderr] | [INFO] [stderr] 255 | complete_path: path.clone().to_string(), [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 255 | complete_path: &(*path).clone().to_string(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 255 | complete_path: &str::clone(path).to_string(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `log_file_config::LogFileConfig` [INFO] [stderr] --> src/log_file_config.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | / pub fn new() -> LogFileConfig { [INFO] [stderr] 26 | | return LogFileConfig { [INFO] [stderr] 27 | | max_size_in_mb: 1, [INFO] [stderr] 28 | | path: String::from("./"), [INFO] [stderr] ... | [INFO] [stderr] 31 | | }; [INFO] [stderr] 32 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 2 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/log_file_config.rs:37:29 [INFO] [stderr] | [INFO] [stderr] 37 | max_size_in_mb: self.max_size_in_mb.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.max_size_in_mb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `easylog`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "62284c76ae7cd1bdf05e3fbb250462b4924b66fefdc5cafd863148ceba732f6e"` [INFO] running `"docker" "rm" "-f" "62284c76ae7cd1bdf05e3fbb250462b4924b66fefdc5cafd863148ceba732f6e"` [INFO] [stdout] 62284c76ae7cd1bdf05e3fbb250462b4924b66fefdc5cafd863148ceba732f6e