[INFO] crate easybench 0.1.4 is already in cache [INFO] extracting crate easybench 0.1.4 into work/ex/clippy-test-run/sources/stable/reg/easybench/0.1.4 [INFO] extracting crate easybench 0.1.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/easybench/0.1.4 [INFO] validating manifest of easybench-0.1.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of easybench-0.1.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing easybench-0.1.4 [INFO] finished frobbing easybench-0.1.4 [INFO] frobbed toml for easybench-0.1.4 written to work/ex/clippy-test-run/sources/stable/reg/easybench/0.1.4/Cargo.toml [INFO] started frobbing easybench-0.1.4 [INFO] finished frobbing easybench-0.1.4 [INFO] frobbed toml for easybench-0.1.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/easybench/0.1.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting easybench-0.1.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/easybench/0.1.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 19fba22e4a05667563f7afe4c93f491b3f87c1c44bfe6604d87472fa01882aa5 [INFO] running `"docker" "start" "-a" "19fba22e4a05667563f7afe4c93f491b3f87c1c44bfe6604d87472fa01882aa5"` [INFO] [stderr] Checking easybench v0.1.4 (/opt/crater/workdir) [INFO] [stderr] warning: the loop variable `i` is only used to index `xs`. [INFO] [stderr] --> lib.rs:236:18 [INFO] [stderr] | [INFO] [stderr] 236 | for i in 0..iters { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 236 | for in xs.iter().take(iters) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> lib.rs:237:17 [INFO] [stderr] | [INFO] [stderr] 237 | let ref mut x = xs[i]; // Lookup the env for this iteration [INFO] [stderr] | ----^^^^^^^^^--------- help: try: `let x = &mut xs[i];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> lib.rs:287:22 [INFO] [stderr] | [INFO] [stderr] 287 | .checked_add(x.subsec_nanos() as u64).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(x.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `xs`. [INFO] [stderr] --> lib.rs:236:18 [INFO] [stderr] | [INFO] [stderr] 236 | for i in 0..iters { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 236 | for in xs.iter().take(iters) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> lib.rs:237:17 [INFO] [stderr] | [INFO] [stderr] 237 | let ref mut x = xs[i]; // Lookup the env for this iteration [INFO] [stderr] | ----^^^^^^^^^--------- help: try: `let x = &mut xs[i];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> lib.rs:287:22 [INFO] [stderr] | [INFO] [stderr] 287 | .checked_add(x.subsec_nanos() as u64).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(x.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.48s [INFO] running `"docker" "inspect" "19fba22e4a05667563f7afe4c93f491b3f87c1c44bfe6604d87472fa01882aa5"` [INFO] running `"docker" "rm" "-f" "19fba22e4a05667563f7afe4c93f491b3f87c1c44bfe6604d87472fa01882aa5"` [INFO] [stdout] 19fba22e4a05667563f7afe4c93f491b3f87c1c44bfe6604d87472fa01882aa5