[INFO] crate easy-bluez 0.1.0 is already in cache [INFO] extracting crate easy-bluez 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/easy-bluez/0.1.0 [INFO] extracting crate easy-bluez 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/easy-bluez/0.1.0 [INFO] validating manifest of easy-bluez-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of easy-bluez-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing easy-bluez-0.1.0 [INFO] finished frobbing easy-bluez-0.1.0 [INFO] frobbed toml for easy-bluez-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/easy-bluez/0.1.0/Cargo.toml [INFO] started frobbing easy-bluez-0.1.0 [INFO] finished frobbing easy-bluez-0.1.0 [INFO] frobbed toml for easy-bluez-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/easy-bluez/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting easy-bluez-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/easy-bluez/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b8340a7f2b4935b3284956bc62ae9b46f0b74c9126c721adb11316c57d404656 [INFO] running `"docker" "start" "-a" "b8340a7f2b4935b3284956bc62ae9b46f0b74c9126c721adb11316c57d404656"` [INFO] [stderr] Checking eui48 v0.3.2 [INFO] [stderr] Checking dbus v0.5.4 [INFO] [stderr] Checking basic_scheduler v0.1.1 [INFO] [stderr] Checking blurz v0.2.2 [INFO] [stderr] Checking easy-bluez v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: lint `unused_doc_comment` has been renamed to `unused_doc_comments` [INFO] [stderr] --> src/errors.rs:1:10 [INFO] [stderr] | [INFO] [stderr] 1 | #![allow(unused_doc_comment)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use the new name: `unused_doc_comments` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | mac: mac, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `mac` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | svc: svc, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `svc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | chrc: chrc, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `chrc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | mac: mac, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `mac` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | svc: svc, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `svc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | chrc: chrc, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `chrc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:185:17 [INFO] [stderr] | [INFO] [stderr] 185 | tx_poll_characs: tx_poll_characs, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tx_poll_characs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:186:17 [INFO] [stderr] | [INFO] [stderr] 186 | tx_write_characs: tx_write_characs, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tx_write_characs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint `unused_doc_comment` has been renamed to `unused_doc_comments` [INFO] [stderr] --> src/errors.rs:1:10 [INFO] [stderr] | [INFO] [stderr] 1 | #![allow(unused_doc_comment)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use the new name: `unused_doc_comments` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | mac: mac, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `mac` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | svc: svc, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `svc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | chrc: chrc, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `chrc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | mac: mac, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `mac` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | svc: svc, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `svc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | chrc: chrc, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `chrc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:185:17 [INFO] [stderr] | [INFO] [stderr] 185 | tx_poll_characs: tx_poll_characs, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tx_poll_characs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:186:17 [INFO] [stderr] | [INFO] [stderr] 186 | tx_write_characs: tx_write_characs, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tx_write_characs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bt_manager/discovery.rs:33:8 [INFO] [stderr] | [INFO] [stderr] 33 | if data.wl.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.wl.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bt_manager/discovery.rs:52:12 [INFO] [stderr] | [INFO] [stderr] 52 | if devs.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `devs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/bt_manager/endpoints.rs:32:12 [INFO] [stderr] | [INFO] [stderr] 32 | if let Ok(_) = data.manage_endpoints() { [INFO] [stderr] | _____- ^^^^^ [INFO] [stderr] 33 | | // data.manage_new_devices(devs); [INFO] [stderr] 34 | | Some(data.endpoint_interval) [INFO] [stderr] 35 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 38 | | None [INFO] [stderr] 39 | | } [INFO] [stderr] | |_____- help: try this: `if data.manage_endpoints().is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bt_manager/endpoints.rs:76:16 [INFO] [stderr] | [INFO] [stderr] 76 | if svcs.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `svcs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the variable `rmvd` is used as a loop counter. Consider using `for (rmvd, item) in rem.enumerate()` or similar iterators [INFO] [stderr] --> src/bt_manager/endpoints.rs:112:18 [INFO] [stderr] | [INFO] [stderr] 112 | for r in rem { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bt_manager/endpoints.rs:136:16 [INFO] [stderr] | [INFO] [stderr] 136 | if svcs.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `svcs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bt_manager/discovery.rs:33:8 [INFO] [stderr] | [INFO] [stderr] 33 | if data.wl.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.wl.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bt_manager/discovery.rs:52:12 [INFO] [stderr] | [INFO] [stderr] 52 | if devs.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `devs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/bt_manager/data_poll.rs:17:12 [INFO] [stderr] | [INFO] [stderr] 17 | if let Ok(_) = data.poll_data() { [INFO] [stderr] | _____- ^^^^^ [INFO] [stderr] 18 | | Some(data.poll_interval) [INFO] [stderr] 19 | | } else { [INFO] [stderr] 20 | | // An error has occurred, bail [INFO] [stderr] 21 | | error!("Error, data_poll_task bailing"); [INFO] [stderr] 22 | | None [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____- help: try this: `if data.poll_data().is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/bt_manager/endpoints.rs:32:12 [INFO] [stderr] | [INFO] [stderr] 32 | if let Ok(_) = data.manage_endpoints() { [INFO] [stderr] | _____- ^^^^^ [INFO] [stderr] 33 | | // data.manage_new_devices(devs); [INFO] [stderr] 34 | | Some(data.endpoint_interval) [INFO] [stderr] 35 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 38 | | None [INFO] [stderr] 39 | | } [INFO] [stderr] | |_____- help: try this: `if data.manage_endpoints().is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/bt_manager/data_write.rs:17:12 [INFO] [stderr] | [INFO] [stderr] 17 | if let Ok(_) = data.write_data() { [INFO] [stderr] | _____- ^^^^^ [INFO] [stderr] 18 | | Some(data.write_interval) [INFO] [stderr] 19 | | } else { [INFO] [stderr] 20 | | // An error has occurred, bail [INFO] [stderr] 21 | | error!("Error, data_write_task bailing"); [INFO] [stderr] 22 | | None [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____- help: try this: `if data.write_data().is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/bt_manager/mod.rs:31:41 [INFO] [stderr] | [INFO] [stderr] 31 | mac_addr: dev.get_address().unwrap_or(String::from("Unknown")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from("Unknown"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/bt_manager/mod.rs:40:16 [INFO] [stderr] | [INFO] [stderr] 40 | if let Ok(_) = self.bluez_handle.connect() { [INFO] [stderr] | _________- ^^^^^ [INFO] [stderr] 41 | | info!("connected to {:?}", self.bluez_handle); [INFO] [stderr] 42 | | self.last_connected = Instant::now(); [INFO] [stderr] 43 | | } [INFO] [stderr] | |_________- help: try this: `if self.bluez_handle.connect().is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bt_manager/endpoints.rs:76:16 [INFO] [stderr] | [INFO] [stderr] 76 | if svcs.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `svcs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the variable `rmvd` is used as a loop counter. Consider using `for (rmvd, item) in rem.enumerate()` or similar iterators [INFO] [stderr] --> src/bt_manager/endpoints.rs:112:18 [INFO] [stderr] | [INFO] [stderr] 112 | for r in rem { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `api::EasyBluez` [INFO] [stderr] --> src/api.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | / pub fn new() -> Self { [INFO] [stderr] 90 | | EasyBluez { [INFO] [stderr] 91 | | scan_interval: Duration::seconds(10), [INFO] [stderr] 92 | | scan_duration: Duration::milliseconds(1000), [INFO] [stderr] ... | [INFO] [stderr] 97 | | } [INFO] [stderr] 98 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 88 | impl Default for api::EasyBluez { [INFO] [stderr] 89 | fn default() -> Self { [INFO] [stderr] 90 | Self::new() [INFO] [stderr] 91 | } [INFO] [stderr] 92 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bt_manager/endpoints.rs:136:16 [INFO] [stderr] | [INFO] [stderr] 136 | if svcs.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `svcs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/api.rs:159:32 [INFO] [stderr] | [INFO] [stderr] 159 | scan_interval: self.scan_interval.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.scan_interval` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/api.rs:160:32 [INFO] [stderr] | [INFO] [stderr] 160 | scan_duration: self.scan_duration.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.scan_duration` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/bt_manager/data_poll.rs:17:12 [INFO] [stderr] | [INFO] [stderr] 17 | if let Ok(_) = data.poll_data() { [INFO] [stderr] | _____- ^^^^^ [INFO] [stderr] 18 | | Some(data.poll_interval) [INFO] [stderr] 19 | | } else { [INFO] [stderr] 20 | | // An error has occurred, bail [INFO] [stderr] 21 | | error!("Error, data_poll_task bailing"); [INFO] [stderr] 22 | | None [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____- help: try this: `if data.poll_data().is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: you are implementing `Hash` explicitly but have derived `PartialEq` [INFO] [stderr] --> src/lib.rs:27:1 [INFO] [stderr] | [INFO] [stderr] 27 | / impl Hash for BtMacAddress { [INFO] [stderr] 28 | | fn hash(&self, state: &mut H) { [INFO] [stderr] 29 | | self.0.as_bytes().hash(state) [INFO] [stderr] 30 | | } [INFO] [stderr] 31 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/lib.rs:50:48 [INFO] [stderr] | [INFO] [stderr] 50 | #[derive(Clone, Deserialize, Serialize, Debug, PartialEq, Eq)] [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/bt_manager/data_write.rs:17:12 [INFO] [stderr] | [INFO] [stderr] 17 | if let Ok(_) = data.write_data() { [INFO] [stderr] | _____- ^^^^^ [INFO] [stderr] 18 | | Some(data.write_interval) [INFO] [stderr] 19 | | } else { [INFO] [stderr] 20 | | // An error has occurred, bail [INFO] [stderr] 21 | | error!("Error, data_write_task bailing"); [INFO] [stderr] 22 | | None [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____- help: try this: `if data.write_data().is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/bt_manager/mod.rs:31:41 [INFO] [stderr] | [INFO] [stderr] 31 | mac_addr: dev.get_address().unwrap_or(String::from("Unknown")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from("Unknown"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/bt_manager/mod.rs:40:16 [INFO] [stderr] | [INFO] [stderr] 40 | if let Ok(_) = self.bluez_handle.connect() { [INFO] [stderr] | _________- ^^^^^ [INFO] [stderr] 41 | | info!("connected to {:?}", self.bluez_handle); [INFO] [stderr] 42 | | self.last_connected = Instant::now(); [INFO] [stderr] 43 | | } [INFO] [stderr] | |_________- help: try this: `if self.bluez_handle.connect().is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `api::EasyBluez` [INFO] [stderr] --> src/api.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | / pub fn new() -> Self { [INFO] [stderr] 90 | | EasyBluez { [INFO] [stderr] 91 | | scan_interval: Duration::seconds(10), [INFO] [stderr] 92 | | scan_duration: Duration::milliseconds(1000), [INFO] [stderr] ... | [INFO] [stderr] 97 | | } [INFO] [stderr] 98 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 88 | impl Default for api::EasyBluez { [INFO] [stderr] 89 | fn default() -> Self { [INFO] [stderr] 90 | Self::new() [INFO] [stderr] 91 | } [INFO] [stderr] 92 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: Could not compile `easy-bluez`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/api.rs:159:32 [INFO] [stderr] | [INFO] [stderr] 159 | scan_interval: self.scan_interval.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.scan_interval` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/api.rs:160:32 [INFO] [stderr] | [INFO] [stderr] 160 | scan_duration: self.scan_duration.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.scan_duration` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: you are implementing `Hash` explicitly but have derived `PartialEq` [INFO] [stderr] --> src/lib.rs:27:1 [INFO] [stderr] | [INFO] [stderr] 27 | / impl Hash for BtMacAddress { [INFO] [stderr] 28 | | fn hash(&self, state: &mut H) { [INFO] [stderr] 29 | | self.0.as_bytes().hash(state) [INFO] [stderr] 30 | | } [INFO] [stderr] 31 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/lib.rs:50:48 [INFO] [stderr] | [INFO] [stderr] 50 | #[derive(Clone, Deserialize, Serialize, Debug, PartialEq, Eq)] [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `easy-bluez`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "b8340a7f2b4935b3284956bc62ae9b46f0b74c9126c721adb11316c57d404656"` [INFO] running `"docker" "rm" "-f" "b8340a7f2b4935b3284956bc62ae9b46f0b74c9126c721adb11316c57d404656"` [INFO] [stdout] b8340a7f2b4935b3284956bc62ae9b46f0b74c9126c721adb11316c57d404656