[INFO] crate easter 0.0.5 is already in cache [INFO] extracting crate easter 0.0.5 into work/ex/clippy-test-run/sources/stable/reg/easter/0.0.5 [INFO] extracting crate easter 0.0.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/easter/0.0.5 [INFO] validating manifest of easter-0.0.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of easter-0.0.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing easter-0.0.5 [INFO] removed path dependency joker from easter-0.0.5 [INFO] finished frobbing easter-0.0.5 [INFO] frobbed toml for easter-0.0.5 written to work/ex/clippy-test-run/sources/stable/reg/easter/0.0.5/Cargo.toml [INFO] started frobbing easter-0.0.5 [INFO] removed path dependency joker from easter-0.0.5 [INFO] finished frobbing easter-0.0.5 [INFO] frobbed toml for easter-0.0.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/easter/0.0.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting easter-0.0.5 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/easter/0.0.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a1ad0c99ff981b76744d69552d1d70a2508ba4833da9051a83ffc1691d0ec273 [INFO] running `"docker" "start" "-a" "a1ad0c99ff981b76744d69552d1d70a2508ba4833da9051a83ffc1691d0ec273"` [INFO] [stderr] Checking unjson v0.0.5 [INFO] [stderr] Checking joker v0.0.5 [INFO] [stderr] Checking easter v0.0.5 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/id.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | location: location, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `location` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/id.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | name: name [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/punc.rs:59:48 [INFO] [stderr] | [INFO] [stderr] 59 | Ok(tag) => Ok(Op { location: None, tag: tag }), [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cover.rs:71:23 [INFO] [stderr] | [INFO] [stderr] 71 | Ok(PropPatt { location: location, key: key, patt: patt }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `location` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cover.rs:71:43 [INFO] [stderr] | [INFO] [stderr] 71 | Ok(PropPatt { location: location, key: key, patt: patt }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cover.rs:71:53 [INFO] [stderr] | [INFO] [stderr] 71 | Ok(PropPatt { location: location, key: key, patt: patt }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `patt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/id.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | location: location, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `location` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/id.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | name: name [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/punc.rs:59:48 [INFO] [stderr] | [INFO] [stderr] 59 | Ok(tag) => Ok(Op { location: None, tag: tag }), [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cover.rs:71:23 [INFO] [stderr] | [INFO] [stderr] 71 | Ok(PropPatt { location: location, key: key, patt: patt }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `location` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cover.rs:71:43 [INFO] [stderr] | [INFO] [stderr] 71 | Ok(PropPatt { location: location, key: key, patt: patt }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cover.rs:71:53 [INFO] [stderr] | [INFO] [stderr] 71 | Ok(PropPatt { location: location, key: key, patt: patt }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `patt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/stmt.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | For(Option, Option>, Option, Option, Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/stmt.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | For(Option, Option>, Option, Option, Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/stmt.rs:293:5 [INFO] [stderr] | [INFO] [stderr] 293 | Stmt(Stmt) [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 293 | Stmt(Box) [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/expr.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | / match self { [INFO] [stderr] 158 | | &Expr::This(_) => fmt.write_str("This"), [INFO] [stderr] 159 | | &Expr::Id(ref id) => fmt.debug_tuple("Id").field(id).finish(), [INFO] [stderr] 160 | | &Expr::Arr(_, ref elts) => fmt.debug_tuple("Arr").field(elts).finish(), [INFO] [stderr] ... | [INFO] [stderr] 187 | | &Expr::String(_, ref lit) => fmt.debug_tuple("String").field(lit).finish() [INFO] [stderr] 188 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 157 | match *self { [INFO] [stderr] 158 | Expr::This(_) => fmt.write_str("This"), [INFO] [stderr] 159 | Expr::Id(ref id) => fmt.debug_tuple("Id").field(id).finish(), [INFO] [stderr] 160 | Expr::Arr(_, ref elts) => fmt.debug_tuple("Arr").field(elts).finish(), [INFO] [stderr] 161 | Expr::Obj(_, ref props) => fmt.debug_tuple("Obj").field(props).finish(), [INFO] [stderr] 162 | Expr::Fun(ref fun) => fmt.debug_tuple("Fun").field(fun).finish(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/stmt.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | For(Option, Option>, Option, Option, Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/stmt.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | For(Option, Option>, Option, Option, Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/cover.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | / match self { [INFO] [stderr] 17 | | &Error::InvalidAssignTarget(_) => { [INFO] [stderr] 18 | | fmt.write_str("invalid assignment pattern") [INFO] [stderr] 19 | | } [INFO] [stderr] ... | [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 16 | match *self { [INFO] [stderr] 17 | Error::InvalidAssignTarget(_) => { [INFO] [stderr] 18 | fmt.write_str("invalid assignment pattern") [INFO] [stderr] 19 | } [INFO] [stderr] 20 | Error::InvalidPropPatt(_) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/stmt.rs:293:5 [INFO] [stderr] | [INFO] [stderr] 293 | Stmt(Stmt) [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 293 | Stmt(Box) [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/expr.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | / match self { [INFO] [stderr] 158 | | &Expr::This(_) => fmt.write_str("This"), [INFO] [stderr] 159 | | &Expr::Id(ref id) => fmt.debug_tuple("Id").field(id).finish(), [INFO] [stderr] 160 | | &Expr::Arr(_, ref elts) => fmt.debug_tuple("Arr").field(elts).finish(), [INFO] [stderr] ... | [INFO] [stderr] 187 | | &Expr::String(_, ref lit) => fmt.debug_tuple("String").field(lit).finish() [INFO] [stderr] 188 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 157 | match *self { [INFO] [stderr] 158 | Expr::This(_) => fmt.write_str("This"), [INFO] [stderr] 159 | Expr::Id(ref id) => fmt.debug_tuple("Id").field(id).finish(), [INFO] [stderr] 160 | Expr::Arr(_, ref elts) => fmt.debug_tuple("Arr").field(elts).finish(), [INFO] [stderr] 161 | Expr::Obj(_, ref props) => fmt.debug_tuple("Obj").field(props).finish(), [INFO] [stderr] 162 | Expr::Fun(ref fun) => fmt.debug_tuple("Fun").field(fun).finish(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/cover.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | / match self { [INFO] [stderr] 17 | | &Error::InvalidAssignTarget(_) => { [INFO] [stderr] 18 | | fmt.write_str("invalid assignment pattern") [INFO] [stderr] 19 | | } [INFO] [stderr] ... | [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 16 | match *self { [INFO] [stderr] 17 | Error::InvalidAssignTarget(_) => { [INFO] [stderr] 18 | fmt.write_str("invalid assignment pattern") [INFO] [stderr] 19 | } [INFO] [stderr] 20 | Error::InvalidPropPatt(_) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.57s [INFO] running `"docker" "inspect" "a1ad0c99ff981b76744d69552d1d70a2508ba4833da9051a83ffc1691d0ec273"` [INFO] running `"docker" "rm" "-f" "a1ad0c99ff981b76744d69552d1d70a2508ba4833da9051a83ffc1691d0ec273"` [INFO] [stdout] a1ad0c99ff981b76744d69552d1d70a2508ba4833da9051a83ffc1691d0ec273