[INFO] crate eagre-asn1 0.3.0 is already in cache [INFO] extracting crate eagre-asn1 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/eagre-asn1/0.3.0 [INFO] extracting crate eagre-asn1 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/eagre-asn1/0.3.0 [INFO] validating manifest of eagre-asn1-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of eagre-asn1-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing eagre-asn1-0.3.0 [INFO] finished frobbing eagre-asn1-0.3.0 [INFO] frobbed toml for eagre-asn1-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/eagre-asn1/0.3.0/Cargo.toml [INFO] started frobbing eagre-asn1-0.3.0 [INFO] finished frobbing eagre-asn1-0.3.0 [INFO] frobbed toml for eagre-asn1-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/eagre-asn1/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting eagre-asn1-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/eagre-asn1/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5ddb9e0254dce47f5c9bab7dde7d5077d7c0c6f82e381c485a91fa581f136034 [INFO] running `"docker" "start" "-a" "5ddb9e0254dce47f5c9bab7dde7d5077d7c0c6f82e381c485a91fa581f136034"` [INFO] [stderr] Checking eagre-asn1 v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/der/intermediate.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | class: class, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `class` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/der/intermediate.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | tag: tag, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/der/intermediate.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | class: class, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `class` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/der/intermediate.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | content_type: content_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `content_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/der/intermediate.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | tag: tag, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/der/intermediate.rs:111:13 [INFO] [stderr] | [INFO] [stderr] 111 | class: class, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `class` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/der/intermediate.rs:112:13 [INFO] [stderr] | [INFO] [stderr] 112 | content_type: content_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `content_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/der/intermediate.rs:113:13 [INFO] [stderr] | [INFO] [stderr] 113 | tag: tag, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/any.rs:60:18 [INFO] [stderr] | [INFO] [stderr] 60 | Ok(Any { i: i }) [INFO] [stderr] | ^^^^ help: replace it with: `i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/der/intermediate.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | class: class, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `class` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/der/intermediate.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | tag: tag, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/der/intermediate.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | class: class, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `class` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/der/intermediate.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | content_type: content_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `content_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/der/intermediate.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | tag: tag, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/der/intermediate.rs:111:13 [INFO] [stderr] | [INFO] [stderr] 111 | class: class, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `class` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/der/intermediate.rs:112:13 [INFO] [stderr] | [INFO] [stderr] 112 | content_type: content_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `content_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/der/intermediate.rs:113:13 [INFO] [stderr] | [INFO] [stderr] 113 | tag: tag, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/any.rs:60:18 [INFO] [stderr] | [INFO] [stderr] 60 | Ok(Any { i: i }) [INFO] [stderr] | ^^^^ help: replace it with: `i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/der/tag.rs:26:31 [INFO] [stderr] | [INFO] [stderr] 26 | try!(w.write_u8(((tag >> i * 7) & 0x7F) as u8 | [INFO] [stderr] | ^^^^^^^^^^^^ help: consider parenthesizing your expression: `tag >> (i * 7)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/der/tag.rs:74:20 [INFO] [stderr] | [INFO] [stderr] 74 | tag |= (byte & 0x7f) << 7 * (bytes.len() - i - 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(byte & 0x7f) << (7 * (bytes.len() - i - 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/der/length.rs:17:30 [INFO] [stderr] | [INFO] [stderr] 17 | try!(w.write_u8((length >> i * 8) as u8 & 0xFF)); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `length >> (i * 8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/der/length.rs:40:23 [INFO] [stderr] | [INFO] [stderr] 40 | length |= byte << i * 8; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider parenthesizing your expression: `byte << (i * 8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/der/mod.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | pub mod der; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/der/der.rs:158:21 [INFO] [stderr] | [INFO] [stderr] 158 | value = 0xffffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/der/der.rs:168:35 [INFO] [stderr] | [INFO] [stderr] 168 | value = value & !(0xff << i * 8); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider parenthesizing your expression: `0xff << (i * 8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/der/der.rs:172:29 [INFO] [stderr] | [INFO] [stderr] 172 | value = value | (byte as i32) << i * 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(byte as i32) << (i * 8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/der/tag.rs:26:31 [INFO] [stderr] | [INFO] [stderr] 26 | try!(w.write_u8(((tag >> i * 7) & 0x7F) as u8 | [INFO] [stderr] | ^^^^^^^^^^^^ help: consider parenthesizing your expression: `tag >> (i * 7)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/der/tag.rs:74:20 [INFO] [stderr] | [INFO] [stderr] 74 | tag |= (byte & 0x7f) << 7 * (bytes.len() - i - 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(byte & 0x7f) << (7 * (bytes.len() - i - 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/der/length.rs:17:30 [INFO] [stderr] | [INFO] [stderr] 17 | try!(w.write_u8((length >> i * 8) as u8 & 0xFF)); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `length >> (i * 8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/der/length.rs:40:23 [INFO] [stderr] | [INFO] [stderr] 40 | length |= byte << i * 8; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider parenthesizing your expression: `byte << (i * 8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/der/mod.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | pub mod der; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/der/der.rs:158:21 [INFO] [stderr] | [INFO] [stderr] 158 | value = 0xffffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/der/der.rs:168:35 [INFO] [stderr] | [INFO] [stderr] 168 | value = value & !(0xff << i * 8); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider parenthesizing your expression: `0xff << (i * 8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/der/der.rs:172:29 [INFO] [stderr] | [INFO] [stderr] 172 | value = value | (byte as i32) << i * 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(byte as i32) << (i * 8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/der/test.rs:36:52 [INFO] [stderr] | [INFO] [stderr] 36 | assert_eq!(stream.get(0).unwrap().clone(), 0b10000001); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/xer.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | try!(stream.write(b"<")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/xer.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | try!(stream.write(self.xer_name().as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/xer.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | try!(stream.write(b">")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/xer.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | try!(stream.write(b" src/xer.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | try!(stream.write(self.xer_name().as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/xer.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | try!(stream.write(b">")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/xer.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | / try!(stream.write(match self { [INFO] [stderr] 25 | | &true => "True".as_bytes(), [INFO] [stderr] 26 | | &false => "False".as_bytes(), [INFO] [stderr] 27 | | })); [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/xer.rs:24:27 [INFO] [stderr] | [INFO] [stderr] 24 | try!(stream.write(match self { [INFO] [stderr] | ___________________________^ [INFO] [stderr] 25 | | &true => "True".as_bytes(), [INFO] [stderr] 26 | | &false => "False".as_bytes(), [INFO] [stderr] 27 | | })); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 24 | try!(stream.write(match *self { [INFO] [stderr] 25 | true => "True".as_bytes(), [INFO] [stderr] 26 | false => "False".as_bytes(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/xer.rs:25:22 [INFO] [stderr] | [INFO] [stderr] 25 | &true => "True".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"True"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/xer.rs:26:23 [INFO] [stderr] | [INFO] [stderr] 26 | &false => "False".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"False"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/xer.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | try!(stream.write(self.as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/xer.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | try!(stream.write(format!("{}", self).as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/der/tag.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | / let mut tag: u32 = 0; [INFO] [stderr] 57 | | if (first_byte as u32 & 31) != 31 { [INFO] [stderr] 58 | | tag = first_byte as u32 & 31; [INFO] [stderr] 59 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 75 | | } [INFO] [stderr] 76 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let tag = if (first_byte as u32 & 31) != 31 { first_byte as u32 & 31 } else { ..; 0 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/der/tag.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | if (first_byte as u32 & 31) != 31 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(first_byte)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/der/tag.rs:58:15 [INFO] [stderr] | [INFO] [stderr] 58 | tag = first_byte as u32 & 31; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(first_byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/der/tag.rs:69:32 [INFO] [stderr] | [INFO] [stderr] 69 | if (7 * bytes.len()) > (u32::max_value() as f64).log2() as usize { // Afl found [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(u32::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/der/tag.rs:73:24 [INFO] [stderr] | [INFO] [stderr] 73 | let byte = bytes.get(i).unwrap().clone() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes.get(i).unwrap().clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/der/tag.rs:73:24 [INFO] [stderr] | [INFO] [stderr] 73 | let byte = bytes.get(i).unwrap().clone() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*bytes.get(i).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/der/tag.rs:73:24 [INFO] [stderr] | [INFO] [stderr] 73 | let byte = bytes.get(i).unwrap().clone() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `bytes[i]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(length >> i * 8) as u8` [INFO] [stderr] --> src/der/length.rs:17:29 [INFO] [stderr] | [INFO] [stderr] 17 | try!(w.write_u8((length >> i * 8) as u8 & 0xFF)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/der/length.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | if (length_length as u64 * 8) > (usize::max_value() as f64).log2() as u64 { // Afl found [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(length_length)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/der/intermediate.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | try!(w.write(&self.content)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/der/intermediate.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | try!(w.write(&data)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/der/intermediate.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | try!(w.write(&self.content)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/der/der.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | / match self { [INFO] [stderr] 100 | | &true => try!(w.write_u8(0xFF)), [INFO] [stderr] 101 | | &false => try!(w.write_u8(0x00)), [INFO] [stderr] 102 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 99 | match *self { [INFO] [stderr] 100 | true => try!(w.write_u8(0xFF)), [INFO] [stderr] 101 | false => try!(w.write_u8(0x00)), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/der/der.rs:136:70 [INFO] [stderr] | [INFO] [stderr] 136 | (bytes[i + 1] == 0xff || bytes[i + 1] & 0x80 == 0x80) { [INFO] [stderr] | ______________________________________________________________________^ [INFO] [stderr] 137 | | bytes.remove(i); [INFO] [stderr] 138 | | } else { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/der/der.rs:133:64 [INFO] [stderr] | [INFO] [stderr] 133 | (bytes[i + 1] == 0 || bytes[i + 1] & 0x80 == 0) { [INFO] [stderr] | ________________________________________________________________^ [INFO] [stderr] 134 | | bytes.remove(i); [INFO] [stderr] 135 | | } else if bytes[i] == 0xff && i != (bytes.len() - 1) && [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/der/der.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | try!(w.write(&bytes)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/der/der.rs:168:17 [INFO] [stderr] | [INFO] [stderr] 168 | value = value & !(0xff << i * 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `value &= !(0xff << i * 8)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/der/der.rs:172:13 [INFO] [stderr] | [INFO] [stderr] 172 | value = value | (byte as i32) << i * 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `value |= (byte as i32) << i * 8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/der/der.rs:172:29 [INFO] [stderr] | [INFO] [stderr] 172 | value = value | (byte as i32) << i * 8; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/der/der.rs:192:9 [INFO] [stderr] | [INFO] [stderr] 192 | try!(w.write(self.as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/der/der.rs:214:9 [INFO] [stderr] | [INFO] [stderr] 214 | try!(w.write(self.as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/der/der.rs:262:9 [INFO] [stderr] | [INFO] [stderr] 262 | try!(w.write(self)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/types/strings.rs:51:1 [INFO] [stderr] | [INFO] [stderr] 51 | string_type!(NumericString); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/types/strings.rs:52:1 [INFO] [stderr] | [INFO] [stderr] 52 | string_type!(PrintableString); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/types/strings.rs:53:1 [INFO] [stderr] | [INFO] [stderr] 53 | string_type!(T61String); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/types/strings.rs:54:1 [INFO] [stderr] | [INFO] [stderr] 54 | string_type!(VideotexString); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/types/strings.rs:55:1 [INFO] [stderr] | [INFO] [stderr] 55 | string_type!(IA5String); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/types/strings.rs:56:1 [INFO] [stderr] | [INFO] [stderr] 56 | string_type!(GraphicString); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/types/strings.rs:57:1 [INFO] [stderr] | [INFO] [stderr] 57 | string_type!(VisibleString); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/types/strings.rs:58:1 [INFO] [stderr] | [INFO] [stderr] 58 | string_type!(GeneralString); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/types/strings.rs:59:1 [INFO] [stderr] | [INFO] [stderr] 59 | string_type!(UniversalString); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/types/strings.rs:60:1 [INFO] [stderr] | [INFO] [stderr] 60 | string_type!(CharacterString); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 27 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `eagre-asn1`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/xer.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | try!(stream.write(b"<")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/xer.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | try!(stream.write(self.xer_name().as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/xer.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | try!(stream.write(b">")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/xer.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | try!(stream.write(b" src/xer.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | try!(stream.write(self.xer_name().as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/xer.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | try!(stream.write(b">")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/xer.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | / try!(stream.write(match self { [INFO] [stderr] 25 | | &true => "True".as_bytes(), [INFO] [stderr] 26 | | &false => "False".as_bytes(), [INFO] [stderr] 27 | | })); [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/xer.rs:24:27 [INFO] [stderr] | [INFO] [stderr] 24 | try!(stream.write(match self { [INFO] [stderr] | ___________________________^ [INFO] [stderr] 25 | | &true => "True".as_bytes(), [INFO] [stderr] 26 | | &false => "False".as_bytes(), [INFO] [stderr] 27 | | })); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 24 | try!(stream.write(match *self { [INFO] [stderr] 25 | true => "True".as_bytes(), [INFO] [stderr] 26 | false => "False".as_bytes(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/xer.rs:25:22 [INFO] [stderr] | [INFO] [stderr] 25 | &true => "True".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"True"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/xer.rs:26:23 [INFO] [stderr] | [INFO] [stderr] 26 | &false => "False".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"False"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/xer.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | try!(stream.write(self.as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/xer.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | try!(stream.write(format!("{}", self).as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/der/tag.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | / let mut tag: u32 = 0; [INFO] [stderr] 57 | | if (first_byte as u32 & 31) != 31 { [INFO] [stderr] 58 | | tag = first_byte as u32 & 31; [INFO] [stderr] 59 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 75 | | } [INFO] [stderr] 76 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let tag = if (first_byte as u32 & 31) != 31 { first_byte as u32 & 31 } else { ..; 0 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/der/tag.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | if (first_byte as u32 & 31) != 31 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(first_byte)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/der/tag.rs:58:15 [INFO] [stderr] | [INFO] [stderr] 58 | tag = first_byte as u32 & 31; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(first_byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/der/tag.rs:69:32 [INFO] [stderr] | [INFO] [stderr] 69 | if (7 * bytes.len()) > (u32::max_value() as f64).log2() as usize { // Afl found [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(u32::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/der/tag.rs:73:24 [INFO] [stderr] | [INFO] [stderr] 73 | let byte = bytes.get(i).unwrap().clone() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes.get(i).unwrap().clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/der/tag.rs:73:24 [INFO] [stderr] | [INFO] [stderr] 73 | let byte = bytes.get(i).unwrap().clone() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*bytes.get(i).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/der/tag.rs:73:24 [INFO] [stderr] | [INFO] [stderr] 73 | let byte = bytes.get(i).unwrap().clone() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `bytes[i]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(length >> i * 8) as u8` [INFO] [stderr] --> src/der/length.rs:17:29 [INFO] [stderr] | [INFO] [stderr] 17 | try!(w.write_u8((length >> i * 8) as u8 & 0xFF)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/der/length.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | if (length_length as u64 * 8) > (usize::max_value() as f64).log2() as u64 { // Afl found [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(length_length)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/der/intermediate.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | try!(w.write(&self.content)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/der/intermediate.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | try!(w.write(&data)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/der/intermediate.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | try!(w.write(&self.content)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/der/der.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | / match self { [INFO] [stderr] 100 | | &true => try!(w.write_u8(0xFF)), [INFO] [stderr] 101 | | &false => try!(w.write_u8(0x00)), [INFO] [stderr] 102 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 99 | match *self { [INFO] [stderr] 100 | true => try!(w.write_u8(0xFF)), [INFO] [stderr] 101 | false => try!(w.write_u8(0x00)), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/der/der.rs:136:70 [INFO] [stderr] | [INFO] [stderr] 136 | (bytes[i + 1] == 0xff || bytes[i + 1] & 0x80 == 0x80) { [INFO] [stderr] | ______________________________________________________________________^ [INFO] [stderr] 137 | | bytes.remove(i); [INFO] [stderr] 138 | | } else { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/der/der.rs:133:64 [INFO] [stderr] | [INFO] [stderr] 133 | (bytes[i + 1] == 0 || bytes[i + 1] & 0x80 == 0) { [INFO] [stderr] | ________________________________________________________________^ [INFO] [stderr] 134 | | bytes.remove(i); [INFO] [stderr] 135 | | } else if bytes[i] == 0xff && i != (bytes.len() - 1) && [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/der/der.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | try!(w.write(&bytes)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/der/der.rs:168:17 [INFO] [stderr] | [INFO] [stderr] 168 | value = value & !(0xff << i * 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `value &= !(0xff << i * 8)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/der/der.rs:172:13 [INFO] [stderr] | [INFO] [stderr] 172 | value = value | (byte as i32) << i * 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `value |= (byte as i32) << i * 8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/der/der.rs:172:29 [INFO] [stderr] | [INFO] [stderr] 172 | value = value | (byte as i32) << i * 8; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/der/der.rs:192:9 [INFO] [stderr] | [INFO] [stderr] 192 | try!(w.write(self.as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/der/der.rs:214:9 [INFO] [stderr] | [INFO] [stderr] 214 | try!(w.write(self.as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/der/der.rs:262:9 [INFO] [stderr] | [INFO] [stderr] 262 | try!(w.write(self)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/der/test.rs:17:12 [INFO] [stderr] | [INFO] [stderr] 17 | if let Ok(_) = der_decode_tag_bytes(&mut stream) { [INFO] [stderr] | _____- ^^^^^ [INFO] [stderr] 18 | | panic!("This is illegal!"); [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____- help: try this: `if der_decode_tag_bytes(&mut stream).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/der/test.rs:27:20 [INFO] [stderr] | [INFO] [stderr] 27 | assert_eq!(stream.get(0).unwrap().clone(), i as u8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&stream[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/der/test.rs:36:20 [INFO] [stderr] | [INFO] [stderr] 36 | assert_eq!(stream.get(0).unwrap().clone(), 0b10000001); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&stream[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/der/test.rs:37:20 [INFO] [stderr] | [INFO] [stderr] 37 | assert_eq!(stream.get(1).unwrap().clone(), i as u8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&stream[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/der/test.rs:68:14 [INFO] [stderr] | [INFO] [stderr] 68 | for i in vec![::std::i32::MAX, 65535, 8, 1, 0, -1, -8, -65535, -::std::i32::MAX] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[::std::i32::MAX, 65535, 8, 1, 0, -1, -8, -65535, -::std::i32::MAX]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/der/test.rs:76:12 [INFO] [stderr] | [INFO] [stderr] 76 | if let Ok(_) = i32::der_from_bytes(data) { [INFO] [stderr] | _____- ^^^^^ [INFO] [stderr] 77 | | panic!("Decoded too big Integer"); [INFO] [stderr] 78 | | } [INFO] [stderr] | |_____- help: try this: `if i32::der_from_bytes(data).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/der/test.rs:96:20 [INFO] [stderr] | [INFO] [stderr] 96 | assert_eq!(vec.get(i).unwrap().to_string(), ret.get(i).unwrap().clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try this: `vec[i]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/der/test.rs:96:53 [INFO] [stderr] | [INFO] [stderr] 96 | assert_eq!(vec.get(i).unwrap().to_string(), ret.get(i).unwrap().clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try this: `ret[i]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/der/test.rs:105:20 [INFO] [stderr] | [INFO] [stderr] 105 | assert_eq!(vec.get(i).unwrap().clone(), ret.get(i).unwrap().clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try this: `vec[i]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/der/test.rs:105:49 [INFO] [stderr] | [INFO] [stderr] 105 | assert_eq!(vec.get(i).unwrap().clone(), ret.get(i).unwrap().clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try this: `ret[i]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/der/macros.rs:273:22 [INFO] [stderr] | [INFO] [stderr] 273 | try!(match self { [INFO] [stderr] | ______________________^ [INFO] [stderr] 274 | | $(&$enum_name::$enum_variant => $enum_name::$enum_variant as i32,)+ [INFO] [stderr] 275 | | }.der_encode(w)); [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/der/test.rs:144:1 [INFO] [stderr] | [INFO] [stderr] 144 | der_enumerated!(TestEnum, Alpha, Beta, Gamma); [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/der/macros.rs:283:17 [INFO] [stderr] | [INFO] [stderr] 283 | / let mut result = Err(io::Error::new(io::ErrorKind::InvalidInput, "Unknown enum variant")); [INFO] [stderr] 284 | | $( [INFO] [stderr] 285 | | if val == $enum_name::$enum_variant as i32 { [INFO] [stderr] 286 | | result = Ok($enum_name::$enum_variant); [INFO] [stderr] 287 | | } [INFO] [stderr] | |_____________________^ help: it is more idiomatic to write: `let result = if val == $enum_name::$enum_variant as i32 { Ok($enum_name::$enum_variant) } else { Err(io::Error::new(io::ErrorKind::InvalidInput, "Unknown enum variant")) };` [INFO] [stderr] | [INFO] [stderr] ::: src/der/test.rs:144:1 [INFO] [stderr] | [INFO] [stderr] 144 | der_enumerated!(TestEnum, Alpha, Beta, Gamma); [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/der/macros.rs:166:17 [INFO] [stderr] | [INFO] [stderr] 166 | / match self { [INFO] [stderr] 167 | | $(&$choice_name::$variant_name(ref val) => { [INFO] [stderr] 168 | | let i = try!(val.der_intermediate()); [INFO] [stderr] 169 | | match stringify!($tagtype) { [INFO] [stderr] ... | [INFO] [stderr] 187 | | },)+ [INFO] [stderr] 188 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/der/test.rs:161:1 [INFO] [stderr] | [INFO] [stderr] 161 | / der_choice!{TestChoice: [INFO] [stderr] 162 | | Alpha: NOTAG TYPE i32, [INFO] [stderr] 163 | | Beta: EXPLICIT TAG CONTEXT 42; TYPE bool, [INFO] [stderr] 164 | | Gamma: IMPLICIT TAG APPLICATION 397; TYPE String, [INFO] [stderr] 165 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/types/null.rs:34:23 [INFO] [stderr] | [INFO] [stderr] 34 | assert_eq!(&0x05, stream.get(0).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&stream[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/types/null.rs:35:23 [INFO] [stderr] | [INFO] [stderr] 35 | assert_eq!(&0x00, stream.get(1).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&stream[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/types/strings.rs:51:1 [INFO] [stderr] | [INFO] [stderr] 51 | string_type!(NumericString); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/types/strings.rs:52:1 [INFO] [stderr] | [INFO] [stderr] 52 | string_type!(PrintableString); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/types/strings.rs:53:1 [INFO] [stderr] | [INFO] [stderr] 53 | string_type!(T61String); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/types/strings.rs:54:1 [INFO] [stderr] | [INFO] [stderr] 54 | string_type!(VideotexString); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/types/strings.rs:55:1 [INFO] [stderr] | [INFO] [stderr] 55 | string_type!(IA5String); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/types/strings.rs:56:1 [INFO] [stderr] | [INFO] [stderr] 56 | string_type!(GraphicString); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/types/strings.rs:57:1 [INFO] [stderr] | [INFO] [stderr] 57 | string_type!(VisibleString); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/types/strings.rs:58:1 [INFO] [stderr] | [INFO] [stderr] 58 | string_type!(GeneralString); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/types/strings.rs:59:1 [INFO] [stderr] | [INFO] [stderr] 59 | string_type!(UniversalString); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/types/strings.rs:60:1 [INFO] [stderr] | [INFO] [stderr] 60 | string_type!(CharacterString); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 27 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `eagre-asn1`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "5ddb9e0254dce47f5c9bab7dde7d5077d7c0c6f82e381c485a91fa581f136034"` [INFO] running `"docker" "rm" "-f" "5ddb9e0254dce47f5c9bab7dde7d5077d7c0c6f82e381c485a91fa581f136034"` [INFO] [stdout] 5ddb9e0254dce47f5c9bab7dde7d5077d7c0c6f82e381c485a91fa581f136034