[INFO] crate dynstack 0.1.0 is already in cache [INFO] extracting crate dynstack 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/dynstack/0.1.0 [INFO] extracting crate dynstack 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dynstack/0.1.0 [INFO] validating manifest of dynstack-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dynstack-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dynstack-0.1.0 [INFO] finished frobbing dynstack-0.1.0 [INFO] frobbed toml for dynstack-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/dynstack/0.1.0/Cargo.toml [INFO] started frobbing dynstack-0.1.0 [INFO] finished frobbing dynstack-0.1.0 [INFO] frobbed toml for dynstack-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dynstack/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dynstack-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/dynstack/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c3233f00421f58b7131a4de752675573b02995d3232b02f574e73279d80a9433 [INFO] running `"docker" "start" "-a" "c3233f00421f58b7131a4de752675573b02995d3232b02f574e73279d80a9433"` [INFO] [stderr] Checking cast v0.1.0 [INFO] [stderr] Checking dynstack v0.1.0 (/opt/crater/workdir) [INFO] [stderr] Checking criterion-plot v0.1.3 [INFO] [stderr] Checking criterion-stats v0.1.3 [INFO] [stderr] warning: item `DynStack` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:119:1 [INFO] [stderr] | [INFO] [stderr] 119 | / impl DynStack { [INFO] [stderr] 120 | | fn base_layout() -> Layout { [INFO] [stderr] 121 | | unsafe { Layout::from_size_align_unchecked(16, 16) } [INFO] [stderr] 122 | | } [INFO] [stderr] ... | [INFO] [stderr] 212 | | } [INFO] [stderr] 213 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `DynStack` [INFO] [stderr] --> src/lib.rs:124:5 [INFO] [stderr] | [INFO] [stderr] 124 | / pub fn new() -> Self { [INFO] [stderr] 125 | | Self { [INFO] [stderr] 126 | | offs_table: Vec::new(), [INFO] [stderr] 127 | | dyn_data: unsafe { alloc(Self::base_layout()) }, [INFO] [stderr] ... | [INFO] [stderr] 131 | | } [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 119 | impl Default for DynStack { [INFO] [stderr] 120 | fn default() -> Self { [INFO] [stderr] 121 | Self::new() [INFO] [stderr] 122 | } [INFO] [stderr] 123 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:183:5 [INFO] [stderr] | [INFO] [stderr] 183 | / pub fn get<'a>(&'a self, index: usize) -> Option<&'a T> { [INFO] [stderr] 184 | | let item = self.offs_table.get(index)?; [INFO] [stderr] 185 | | let components = [self.dyn_data as usize + item.0, item.1]; [INFO] [stderr] 186 | | let out = unsafe { &*recomp_fat(components) }; [INFO] [stderr] 187 | | Some(out) [INFO] [stderr] 188 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:191:5 [INFO] [stderr] | [INFO] [stderr] 191 | / pub fn get_mut<'a>(&'a mut self, index: usize) -> Option<&'a mut T> { [INFO] [stderr] 192 | | let item = self.offs_table.get(index)?; [INFO] [stderr] 193 | | let components = [self.dyn_data as usize + item.0, item.1]; [INFO] [stderr] 194 | | let out = unsafe { &mut *recomp_fat_mut(components) }; [INFO] [stderr] 195 | | Some(out) [INFO] [stderr] 196 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:199:5 [INFO] [stderr] | [INFO] [stderr] 199 | / pub fn peek<'a>(&'a self) -> Option<&'a T> { [INFO] [stderr] 200 | | self.get(self.len() - 1) [INFO] [stderr] 201 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:204:5 [INFO] [stderr] | [INFO] [stderr] 204 | / pub fn peek_mut<'a>(&'a mut self) -> Option<&'a mut T> { [INFO] [stderr] 205 | | let index = self.len() - 1; [INFO] [stderr] 206 | | self.get_mut(index) [INFO] [stderr] 207 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] Checking criterion v0.1.2 [INFO] [stderr] warning: item `DynStack` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:119:1 [INFO] [stderr] | [INFO] [stderr] 119 | / impl DynStack { [INFO] [stderr] 120 | | fn base_layout() -> Layout { [INFO] [stderr] 121 | | unsafe { Layout::from_size_align_unchecked(16, 16) } [INFO] [stderr] 122 | | } [INFO] [stderr] ... | [INFO] [stderr] 212 | | } [INFO] [stderr] 213 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `DynStack` [INFO] [stderr] --> src/lib.rs:124:5 [INFO] [stderr] | [INFO] [stderr] 124 | / pub fn new() -> Self { [INFO] [stderr] 125 | | Self { [INFO] [stderr] 126 | | offs_table: Vec::new(), [INFO] [stderr] 127 | | dyn_data: unsafe { alloc(Self::base_layout()) }, [INFO] [stderr] ... | [INFO] [stderr] 131 | | } [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 119 | impl Default for DynStack { [INFO] [stderr] 120 | fn default() -> Self { [INFO] [stderr] 121 | Self::new() [INFO] [stderr] 122 | } [INFO] [stderr] 123 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:183:5 [INFO] [stderr] | [INFO] [stderr] 183 | / pub fn get<'a>(&'a self, index: usize) -> Option<&'a T> { [INFO] [stderr] 184 | | let item = self.offs_table.get(index)?; [INFO] [stderr] 185 | | let components = [self.dyn_data as usize + item.0, item.1]; [INFO] [stderr] 186 | | let out = unsafe { &*recomp_fat(components) }; [INFO] [stderr] 187 | | Some(out) [INFO] [stderr] 188 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:191:5 [INFO] [stderr] | [INFO] [stderr] 191 | / pub fn get_mut<'a>(&'a mut self, index: usize) -> Option<&'a mut T> { [INFO] [stderr] 192 | | let item = self.offs_table.get(index)?; [INFO] [stderr] 193 | | let components = [self.dyn_data as usize + item.0, item.1]; [INFO] [stderr] 194 | | let out = unsafe { &mut *recomp_fat_mut(components) }; [INFO] [stderr] 195 | | Some(out) [INFO] [stderr] 196 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:199:5 [INFO] [stderr] | [INFO] [stderr] 199 | / pub fn peek<'a>(&'a self) -> Option<&'a T> { [INFO] [stderr] 200 | | self.get(self.len() - 1) [INFO] [stderr] 201 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:204:5 [INFO] [stderr] | [INFO] [stderr] 204 | / pub fn peek_mut<'a>(&'a mut self) -> Option<&'a mut T> { [INFO] [stderr] 205 | | let index = self.len() - 1; [INFO] [stderr] 206 | | self.get_mut(index) [INFO] [stderr] 207 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::forget` with a value that implements Copy. Forgetting a copy leaves the original intact. [INFO] [stderr] --> src/lib.rs:288:9 [INFO] [stderr] | [INFO] [stderr] 288 | ::std::mem::forget(t); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 299 | dyn_push!(stack, 1u8); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::forget_copy)] on by default [INFO] [stderr] note: argument has type u8 [INFO] [stderr] --> src/lib.rs:288:28 [INFO] [stderr] | [INFO] [stderr] 288 | ::std::mem::forget(t); [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 299 | dyn_push!(stack, 1u8); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#forget_copy [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::forget` with a value that implements Copy. Forgetting a copy leaves the original intact. [INFO] [stderr] --> src/lib.rs:288:9 [INFO] [stderr] | [INFO] [stderr] 288 | ::std::mem::forget(t); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 300 | dyn_push!(stack, 1u32); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: argument has type u32 [INFO] [stderr] --> src/lib.rs:288:28 [INFO] [stderr] | [INFO] [stderr] 288 | ::std::mem::forget(t); [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 300 | dyn_push!(stack, 1u32); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#forget_copy [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::forget` with a value that implements Copy. Forgetting a copy leaves the original intact. [INFO] [stderr] --> src/lib.rs:288:9 [INFO] [stderr] | [INFO] [stderr] 288 | ::std::mem::forget(t); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 301 | dyn_push!(stack, 1u16); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: argument has type u16 [INFO] [stderr] --> src/lib.rs:288:28 [INFO] [stderr] | [INFO] [stderr] 288 | ::std::mem::forget(t); [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 301 | dyn_push!(stack, 1u16); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#forget_copy [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::forget` with a value that implements Copy. Forgetting a copy leaves the original intact. [INFO] [stderr] --> src/lib.rs:288:9 [INFO] [stderr] | [INFO] [stderr] 288 | ::std::mem::forget(t); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 302 | dyn_push!(stack, 1u64); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: argument has type u64 [INFO] [stderr] --> src/lib.rs:288:28 [INFO] [stderr] | [INFO] [stderr] 288 | ::std::mem::forget(t); [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 302 | dyn_push!(stack, 1u64); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#forget_copy [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::forget` with a value that implements Copy. Forgetting a copy leaves the original intact. [INFO] [stderr] --> src/lib.rs:288:9 [INFO] [stderr] | [INFO] [stderr] 288 | ::std::mem::forget(t); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 338 | dyn_push!(stack, move || i); [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: argument has type [closure@src/lib.rs:338:26: 338:35 i:usize] [INFO] [stderr] --> src/lib.rs:288:28 [INFO] [stderr] | [INFO] [stderr] 288 | ::std::mem::forget(t); [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 338 | dyn_push!(stack, move || i); [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#forget_copy [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `dynstack`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> benches/comparisons.rs:15:27 [INFO] [stderr] | [INFO] [stderr] 15 | vec.push(Box::new(0xF00BAAusize)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x00F0_0BAAusize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> benches/comparisons.rs:17:27 [INFO] [stderr] | [INFO] [stderr] 17 | vec.push(Box::new(0xBA7123AAu32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0xBA71_23AAu32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> benches/comparisons.rs:25:26 [INFO] [stderr] | [INFO] [stderr] 25 | dyn_push!(stack, 0xF00BAAusize); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x00F0_0BAAusize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> benches/comparisons.rs:27:26 [INFO] [stderr] | [INFO] [stderr] 27 | dyn_push!(stack, 0xBA7123AAu32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0xBA71_23AAu32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::forget` with a value that implements Copy. Forgetting a copy leaves the original intact. [INFO] [stderr] --> benches/comparisons.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | dyn_push!(stack, 0xF00BAAusize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::forget_copy)] on by default [INFO] [stderr] note: argument has type usize [INFO] [stderr] --> benches/comparisons.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | dyn_push!(stack, 0xF00BAAusize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#forget_copy [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::forget` with a value that implements Copy. Forgetting a copy leaves the original intact. [INFO] [stderr] --> benches/comparisons.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | dyn_push!(stack, 0xABBAu16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: argument has type u16 [INFO] [stderr] --> benches/comparisons.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | dyn_push!(stack, 0xABBAu16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#forget_copy [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::forget` with a value that implements Copy. Forgetting a copy leaves the original intact. [INFO] [stderr] --> benches/comparisons.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | dyn_push!(stack, 0xBA7123AAu32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: argument has type u32 [INFO] [stderr] --> benches/comparisons.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | dyn_push!(stack, 0xBA7123AAu32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#forget_copy [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::forget` with a value that implements Copy. Forgetting a copy leaves the original intact. [INFO] [stderr] --> benches/comparisons.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | dyn_push!(stack, 12u8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: argument has type u8 [INFO] [stderr] --> benches/comparisons.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | dyn_push!(stack, 12u8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#forget_copy [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> benches/comparisons.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | n = (stack.get(i).unwrap())(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `stack[i]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::forget` with a value that implements Copy. Forgetting a copy leaves the original intact. [INFO] [stderr] --> benches/comparisons.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | dyn_push!(stack, move || n - 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: argument has type [closure@benches/comparisons.rs:53:30: 53:43 n:usize] [INFO] [stderr] --> benches/comparisons.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | dyn_push!(stack, move || n - 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#forget_copy [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> benches/comparisons.rs:69:35 [INFO] [stderr] | [INFO] [stderr] 69 | fn pseudorecursive(state: &mut Box usize>, n: usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut Fn() -> usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::forget` with a value that implements Copy. Forgetting a copy leaves the original intact. [INFO] [stderr] --> benches/comparisons.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | dyn_push!(stack, move || n - 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: argument has type [closure@benches/comparisons.rs:85:30: 85:43 n:usize] [INFO] [stderr] --> benches/comparisons.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | dyn_push!(stack, move || n - 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#forget_copy [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 6 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `dynstack`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "c3233f00421f58b7131a4de752675573b02995d3232b02f574e73279d80a9433"` [INFO] running `"docker" "rm" "-f" "c3233f00421f58b7131a4de752675573b02995d3232b02f574e73279d80a9433"` [INFO] [stdout] c3233f00421f58b7131a4de752675573b02995d3232b02f574e73279d80a9433