[INFO] crate dynpool 0.0.1 is already in cache [INFO] extracting crate dynpool 0.0.1 into work/ex/clippy-test-run/sources/stable/reg/dynpool/0.0.1 [INFO] extracting crate dynpool 0.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dynpool/0.0.1 [INFO] validating manifest of dynpool-0.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dynpool-0.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dynpool-0.0.1 [INFO] removed 4 missing examples [INFO] finished frobbing dynpool-0.0.1 [INFO] frobbed toml for dynpool-0.0.1 written to work/ex/clippy-test-run/sources/stable/reg/dynpool/0.0.1/Cargo.toml [INFO] started frobbing dynpool-0.0.1 [INFO] removed 4 missing examples [INFO] finished frobbing dynpool-0.0.1 [INFO] frobbed toml for dynpool-0.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dynpool/0.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dynpool-0.0.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/dynpool/0.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 98ec659aa60452e1d022a212ba087a195578d9ae61e52ba79cde0383efac3b39 [INFO] running `"docker" "start" "-a" "98ec659aa60452e1d022a212ba087a195578d9ae61e52ba79cde0383efac3b39"` [INFO] [stderr] warning: An explicit [[example]] section is specified in Cargo.toml which currently [INFO] [stderr] disables Cargo from automatically inferring other example targets. [INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following [INFO] [stderr] files will be included as a example target: [INFO] [stderr] [INFO] [stderr] * /opt/crater/workdir/examples/background.rs [INFO] [stderr] * /opt/crater/workdir/examples/smasher.rs [INFO] [stderr] * /opt/crater/workdir/examples/foreground.rs [INFO] [stderr] * /opt/crater/workdir/examples/builtins.rs [INFO] [stderr] [INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be [INFO] [stderr] ready to be compiled as a example target today. You can future-proof yourself [INFO] [stderr] and disable this warning by adding `autoexamples = false` to your [package] [INFO] [stderr] section. You may also move the files to a location where Cargo would not [INFO] [stderr] automatically infer them to be a target, such as in subfolders. [INFO] [stderr] [INFO] [stderr] For more information on this warning you can consult [INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330 [INFO] [stderr] Checking backoff v0.1.2 [INFO] [stderr] Checking dynpool v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/builtins.rs:271:63 [INFO] [stderr] | [INFO] [stderr] 271 | Some((at, scale)) if now - *at < self.rate => return *scale, [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `*scale` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/internal.rs:327:32 [INFO] [stderr] | [INFO] [stderr] 327 | if let Err(_) = share.onclose.wait_timeout( [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 327 | if share.onclose.wait_timeout( [INFO] [stderr] 328 | blocker, [INFO] [stderr] 329 | Duration::from_millis(10), [INFO] [stderr] 330 | ).is_err(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/lib.rs:204:13 [INFO] [stderr] | [INFO] [stderr] 204 | *self.data.onclose.wait(self.data.onclose_mutex.lock().unwrap()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.data.onclose.wait(self.data.onclose_mutex.lock().unwrap()).unwrap();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/builtins.rs:271:63 [INFO] [stderr] | [INFO] [stderr] 271 | Some((at, scale)) if now - *at < self.rate => return *scale, [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `*scale` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/internal.rs:327:32 [INFO] [stderr] | [INFO] [stderr] 327 | if let Err(_) = share.onclose.wait_timeout( [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 327 | if share.onclose.wait_timeout( [INFO] [stderr] 328 | blocker, [INFO] [stderr] 329 | Duration::from_millis(10), [INFO] [stderr] 330 | ).is_err(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/lib.rs:204:13 [INFO] [stderr] | [INFO] [stderr] 204 | *self.data.onclose.wait(self.data.onclose_mutex.lock().unwrap()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.data.onclose.wait(self.data.onclose_mutex.lock().unwrap()).unwrap();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.35s [INFO] running `"docker" "inspect" "98ec659aa60452e1d022a212ba087a195578d9ae61e52ba79cde0383efac3b39"` [INFO] running `"docker" "rm" "-f" "98ec659aa60452e1d022a212ba087a195578d9ae61e52ba79cde0383efac3b39"` [INFO] [stdout] 98ec659aa60452e1d022a212ba087a195578d9ae61e52ba79cde0383efac3b39