[INFO] crate dynomite 0.1.4 is already in cache [INFO] extracting crate dynomite 0.1.4 into work/ex/clippy-test-run/sources/stable/reg/dynomite/0.1.4 [INFO] extracting crate dynomite 0.1.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dynomite/0.1.4 [INFO] validating manifest of dynomite-0.1.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dynomite-0.1.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dynomite-0.1.4 [INFO] finished frobbing dynomite-0.1.4 [INFO] frobbed toml for dynomite-0.1.4 written to work/ex/clippy-test-run/sources/stable/reg/dynomite/0.1.4/Cargo.toml [INFO] started frobbing dynomite-0.1.4 [INFO] finished frobbing dynomite-0.1.4 [INFO] frobbed toml for dynomite-0.1.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dynomite/0.1.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dynomite-0.1.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/dynomite/0.1.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 782ffa9e7fd59ecfc6f4a5e056b9e6a864eb23a482253d988a42cacee030d1b4 [INFO] running `"docker" "start" "-a" "782ffa9e7fd59ecfc6f4a5e056b9e6a864eb23a482253d988a42cacee030d1b4"` [INFO] [stderr] Checking rusoto_credential v0.13.0 [INFO] [stderr] Checking rusoto_core v0.34.0 [INFO] [stderr] Checking rusoto_dynamodb v0.34.0 [INFO] [stderr] Checking dynomite v0.1.4 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:342:17 [INFO] [stderr] | [INFO] [stderr] 342 | collected [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 357 | numeric_collection_attr!(u16 => HashSet); [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:341:33 [INFO] [stderr] | [INFO] [stderr] 341 | let collected = results.drain(..).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 357 | numeric_collection_attr!(u16 => HashSet); [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:342:17 [INFO] [stderr] | [INFO] [stderr] 342 | collected [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 358 | numeric_collection_attr!(u16 => Vec); [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:341:33 [INFO] [stderr] | [INFO] [stderr] 341 | let collected = results.drain(..).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 358 | numeric_collection_attr!(u16 => Vec); [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:342:17 [INFO] [stderr] | [INFO] [stderr] 342 | collected [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 359 | numeric_collection_attr!(u32 => HashSet); [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:341:33 [INFO] [stderr] | [INFO] [stderr] 341 | let collected = results.drain(..).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 359 | numeric_collection_attr!(u32 => HashSet); [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:342:17 [INFO] [stderr] | [INFO] [stderr] 342 | collected [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 360 | numeric_collection_attr!(u32 => Vec); [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:341:33 [INFO] [stderr] | [INFO] [stderr] 341 | let collected = results.drain(..).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 360 | numeric_collection_attr!(u32 => Vec); [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:342:17 [INFO] [stderr] | [INFO] [stderr] 342 | collected [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 361 | numeric_collection_attr!(i32 => HashSet); [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:341:33 [INFO] [stderr] | [INFO] [stderr] 341 | let collected = results.drain(..).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 361 | numeric_collection_attr!(i32 => HashSet); [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:342:17 [INFO] [stderr] | [INFO] [stderr] 342 | collected [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 362 | numeric_collection_attr!(i32 => Vec); [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:341:33 [INFO] [stderr] | [INFO] [stderr] 341 | let collected = results.drain(..).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 362 | numeric_collection_attr!(i32 => Vec); [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:342:17 [INFO] [stderr] | [INFO] [stderr] 342 | collected [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 363 | numeric_collection_attr!(i64 => HashSet); [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:341:33 [INFO] [stderr] | [INFO] [stderr] 341 | let collected = results.drain(..).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 363 | numeric_collection_attr!(i64 => HashSet); [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:342:17 [INFO] [stderr] | [INFO] [stderr] 342 | collected [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 364 | numeric_collection_attr!(i64 => Vec); [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:341:33 [INFO] [stderr] | [INFO] [stderr] 341 | let collected = results.drain(..).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 364 | numeric_collection_attr!(i64 => Vec); [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:342:17 [INFO] [stderr] | [INFO] [stderr] 342 | collected [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 365 | numeric_collection_attr!(f32 => Vec); [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:341:33 [INFO] [stderr] | [INFO] [stderr] 341 | let collected = results.drain(..).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 365 | numeric_collection_attr!(f32 => Vec); [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:342:17 [INFO] [stderr] | [INFO] [stderr] 342 | collected [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 366 | numeric_collection_attr!(f64 => Vec); [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:341:33 [INFO] [stderr] | [INFO] [stderr] 341 | let collected = results.drain(..).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 366 | numeric_collection_attr!(f64 => Vec); [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:342:17 [INFO] [stderr] | [INFO] [stderr] 342 | collected [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 357 | numeric_collection_attr!(u16 => HashSet); [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:341:33 [INFO] [stderr] | [INFO] [stderr] 341 | let collected = results.drain(..).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 357 | numeric_collection_attr!(u16 => HashSet); [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:342:17 [INFO] [stderr] | [INFO] [stderr] 342 | collected [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 358 | numeric_collection_attr!(u16 => Vec); [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:341:33 [INFO] [stderr] | [INFO] [stderr] 341 | let collected = results.drain(..).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 358 | numeric_collection_attr!(u16 => Vec); [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:342:17 [INFO] [stderr] | [INFO] [stderr] 342 | collected [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 359 | numeric_collection_attr!(u32 => HashSet); [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:341:33 [INFO] [stderr] | [INFO] [stderr] 341 | let collected = results.drain(..).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 359 | numeric_collection_attr!(u32 => HashSet); [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:342:17 [INFO] [stderr] | [INFO] [stderr] 342 | collected [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 360 | numeric_collection_attr!(u32 => Vec); [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:341:33 [INFO] [stderr] | [INFO] [stderr] 341 | let collected = results.drain(..).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 360 | numeric_collection_attr!(u32 => Vec); [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:342:17 [INFO] [stderr] | [INFO] [stderr] 342 | collected [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 361 | numeric_collection_attr!(i32 => HashSet); [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:341:33 [INFO] [stderr] | [INFO] [stderr] 341 | let collected = results.drain(..).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 361 | numeric_collection_attr!(i32 => HashSet); [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:342:17 [INFO] [stderr] | [INFO] [stderr] 342 | collected [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 362 | numeric_collection_attr!(i32 => Vec); [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:341:33 [INFO] [stderr] | [INFO] [stderr] 341 | let collected = results.drain(..).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 362 | numeric_collection_attr!(i32 => Vec); [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:342:17 [INFO] [stderr] | [INFO] [stderr] 342 | collected [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 363 | numeric_collection_attr!(i64 => HashSet); [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:341:33 [INFO] [stderr] | [INFO] [stderr] 341 | let collected = results.drain(..).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 363 | numeric_collection_attr!(i64 => HashSet); [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:342:17 [INFO] [stderr] | [INFO] [stderr] 342 | collected [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 364 | numeric_collection_attr!(i64 => Vec); [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:341:33 [INFO] [stderr] | [INFO] [stderr] 341 | let collected = results.drain(..).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 364 | numeric_collection_attr!(i64 => Vec); [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:342:17 [INFO] [stderr] | [INFO] [stderr] 342 | collected [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 365 | numeric_collection_attr!(f32 => Vec); [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:341:33 [INFO] [stderr] | [INFO] [stderr] 341 | let collected = results.drain(..).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 365 | numeric_collection_attr!(f32 => Vec); [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:342:17 [INFO] [stderr] | [INFO] [stderr] 342 | collected [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 366 | numeric_collection_attr!(f64 => Vec); [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:341:33 [INFO] [stderr] | [INFO] [stderr] 341 | let collected = results.drain(..).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 366 | numeric_collection_attr!(f64 => Vec); [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: impl for `HashSet` should be generalized over different hashers [INFO] [stderr] --> src/lib.rs:220:20 [INFO] [stderr] | [INFO] [stderr] 220 | impl Attribute for HashSet { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 220 | impl Attribute for HashSet { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: impl for `HashSet` should be generalized over different hashers [INFO] [stderr] --> src/lib.rs:235:20 [INFO] [stderr] | [INFO] [stderr] 235 | impl Attribute for HashSet> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 235 | impl Attribute for HashSet, S> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: impl for `HashSet` should be generalized over different hashers [INFO] [stderr] --> src/lib.rs:220:20 [INFO] [stderr] | [INFO] [stderr] 220 | impl Attribute for HashSet { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 220 | impl Attribute for HashSet { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: impl for `HashSet` should be generalized over different hashers [INFO] [stderr] --> src/lib.rs:235:20 [INFO] [stderr] | [INFO] [stderr] 235 | impl Attribute for HashSet> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 235 | impl Attribute for HashSet, S> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 37.77s [INFO] running `"docker" "inspect" "782ffa9e7fd59ecfc6f4a5e056b9e6a864eb23a482253d988a42cacee030d1b4"` [INFO] running `"docker" "rm" "-f" "782ffa9e7fd59ecfc6f4a5e056b9e6a864eb23a482253d988a42cacee030d1b4"` [INFO] [stdout] 782ffa9e7fd59ecfc6f4a5e056b9e6a864eb23a482253d988a42cacee030d1b4