[INFO] crate dynasmrt 0.2.3 is already in cache
[INFO] extracting crate dynasmrt 0.2.3 into work/ex/clippy-test-run/sources/stable/reg/dynasmrt/0.2.3
[INFO] extracting crate dynasmrt 0.2.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dynasmrt/0.2.3
[INFO] validating manifest of dynasmrt-0.2.3 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of dynasmrt-0.2.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing dynasmrt-0.2.3
[INFO] finished frobbing dynasmrt-0.2.3
[INFO] frobbed toml for dynasmrt-0.2.3 written to work/ex/clippy-test-run/sources/stable/reg/dynasmrt/0.2.3/Cargo.toml
[INFO] started frobbing dynasmrt-0.2.3
[INFO] finished frobbing dynasmrt-0.2.3
[INFO] frobbed toml for dynasmrt-0.2.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dynasmrt/0.2.3/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting dynasmrt-0.2.3 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/dynasmrt/0.2.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] bad18f84cf71bd1f14077a884626ebff3489fe6744824795fc0d3ca184222b4c
[INFO] running `"docker" "start" "-a" "bad18f84cf71bd1f14077a884626ebff3489fe6744824795fc0d3ca184222b4c"`
[INFO] [stderr]     Checking dynasmrt v0.2.3 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/common.rs:41:13
[INFO] [stderr]    |
[INFO] [stderr] 41 |             execbuffer_addr: execbuffer_addr
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `execbuffer_addr`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/common.rs:169:13
[INFO] [stderr]     |
[INFO] [stderr] 169 |             buffer: buffer,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `buffer`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/x64.rs:49:13
[INFO] [stderr]    |
[INFO] [stderr] 49 |             offset: offset
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `offset`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/x64.rs:208:17
[INFO] [stderr]     |
[INFO] [stderr] 208 |                 base: base,
[INFO] [stderr]     |                 ^^^^^^^^^^ help: replace it with: `base`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/x86.rs:63:13
[INFO] [stderr]    |
[INFO] [stderr] 63 |             offset: offset
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `offset`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/x86.rs:282:17
[INFO] [stderr]     |
[INFO] [stderr] 282 |                 base: base,
[INFO] [stderr]     |                 ^^^^^^^^^^ help: replace it with: `base`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:75:13
[INFO] [stderr]    |
[INFO] [stderr] 75 |             length: length,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `length`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:91:13
[INFO] [stderr]    |
[INFO] [stderr] 91 |             length: length,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `length`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/common.rs:41:13
[INFO] [stderr]    |
[INFO] [stderr] 41 |             execbuffer_addr: execbuffer_addr
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `execbuffer_addr`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/common.rs:169:13
[INFO] [stderr]     |
[INFO] [stderr] 169 |             buffer: buffer,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `buffer`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/x64.rs:49:13
[INFO] [stderr]    |
[INFO] [stderr] 49 |             offset: offset
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `offset`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/x64.rs:208:17
[INFO] [stderr]     |
[INFO] [stderr] 208 |                 base: base,
[INFO] [stderr]     |                 ^^^^^^^^^^ help: replace it with: `base`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/x86.rs:63:13
[INFO] [stderr]    |
[INFO] [stderr] 63 |             offset: offset
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `offset`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/x86.rs:282:17
[INFO] [stderr]     |
[INFO] [stderr] 282 |                 base: base,
[INFO] [stderr]     |                 ^^^^^^^^^^ help: replace it with: `base`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:75:13
[INFO] [stderr]    |
[INFO] [stderr] 75 |             length: length,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `length`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:91:13
[INFO] [stderr]    |
[INFO] [stderr] 91 |             length: length,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `length`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]    --> src/common.rs:268:16
[INFO] [stderr]     |
[INFO] [stderr] 268 |           if let Some(_) = self.global_labels.insert(name, offset) {
[INFO] [stderr]     |  _________-      ^^^^^^^
[INFO] [stderr] 269 | |             panic!("Duplicate global label '{}'", name);
[INFO] [stderr] 270 | |         }
[INFO] [stderr]     | |_________- help: try this: `if self.global_labels.insert(name, offset).is_some()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/x64.rs:23:17
[INFO] [stderr]    |
[INFO] [stderr] 23 |     fn in_bytes(&self) -> usize {
[INFO] [stderr]    |                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/x86.rs:22:17
[INFO] [stderr]    |
[INFO] [stderr] 22 |     fn in_bytes(&self) -> usize {
[INFO] [stderr]    |                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/x86.rs:252:46
[INFO] [stderr]     |
[INFO] [stderr] 252 |                     RelocationSize::Byte  => slice[0] as u32,
[INFO] [stderr]     |                                              ^^^^^^^^^^^^^^^ help: try: `u32::from(slice[0])`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/x86.rs:253:46
[INFO] [stderr]     |
[INFO] [stderr] 253 |                     RelocationSize::Word  => LittleEndian::read_u16(slice) as u32,
[INFO] [stderr]     |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(LittleEndian::read_u16(slice))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]    --> src/common.rs:268:16
[INFO] [stderr]     |
[INFO] [stderr] 268 |           if let Some(_) = self.global_labels.insert(name, offset) {
[INFO] [stderr]     |  _________-      ^^^^^^^
[INFO] [stderr] 269 | |             panic!("Duplicate global label '{}'", name);
[INFO] [stderr] 270 | |         }
[INFO] [stderr]     | |_________- help: try this: `if self.global_labels.insert(name, offset).is_some()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/x64.rs:23:17
[INFO] [stderr]    |
[INFO] [stderr] 23 |     fn in_bytes(&self) -> usize {
[INFO] [stderr]    |                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/x86.rs:22:17
[INFO] [stderr]    |
[INFO] [stderr] 22 |     fn in_bytes(&self) -> usize {
[INFO] [stderr]    |                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/x86.rs:252:46
[INFO] [stderr]     |
[INFO] [stderr] 252 |                     RelocationSize::Byte  => slice[0] as u32,
[INFO] [stderr]     |                                              ^^^^^^^^^^^^^^^ help: try: `u32::from(slice[0])`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/x86.rs:253:46
[INFO] [stderr]     |
[INFO] [stderr] 253 |                     RelocationSize::Word  => LittleEndian::read_u16(slice) as u32,
[INFO] [stderr]     |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(LittleEndian::read_u16(slice))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.34s
[INFO] running `"docker" "inspect" "bad18f84cf71bd1f14077a884626ebff3489fe6744824795fc0d3ca184222b4c"`
[INFO] running `"docker" "rm" "-f" "bad18f84cf71bd1f14077a884626ebff3489fe6744824795fc0d3ca184222b4c"`
[INFO] [stdout] bad18f84cf71bd1f14077a884626ebff3489fe6744824795fc0d3ca184222b4c