[INFO] crate dynamic_reload 0.3.0 is already in cache [INFO] extracting crate dynamic_reload 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/dynamic_reload/0.3.0 [INFO] extracting crate dynamic_reload 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dynamic_reload/0.3.0 [INFO] validating manifest of dynamic_reload-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dynamic_reload-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dynamic_reload-0.3.0 [INFO] finished frobbing dynamic_reload-0.3.0 [INFO] frobbed toml for dynamic_reload-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/dynamic_reload/0.3.0/Cargo.toml [INFO] started frobbing dynamic_reload-0.3.0 [INFO] finished frobbing dynamic_reload-0.3.0 [INFO] frobbed toml for dynamic_reload-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dynamic_reload/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dynamic_reload-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/dynamic_reload/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0d4e4c6a25707b352b1b4db29a471874069bb2910ba02b7982e16cceaa9730f9 [INFO] running `"docker" "start" "-a" "0d4e4c6a25707b352b1b4db29a471874069bb2910ba02b7982e16cceaa9730f9"` [INFO] [stderr] Compiling dynamic_reload v0.3.0 (/opt/crater/workdir) [INFO] [stderr] Checking filetime v0.1.15 [INFO] [stderr] Checking inotify v0.2.3 [INFO] [stderr] Checking miow v0.1.5 [INFO] [stderr] Checking mio v0.5.1 [INFO] [stderr] Checking notify v2.6.3 [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/lib.rs:218:36 [INFO] [stderr] | [INFO] [stderr] 218 | pub fn update(&mut self, ref update_call: F, data: &mut T) where F: Fn(&mut T, UpdateState, Option<&Arc>) [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:220:9 [INFO] [stderr] | [INFO] [stderr] 220 | / match self.watch_recv.try_recv() { [INFO] [stderr] 221 | | Ok(file) => { [INFO] [stderr] 222 | | Self::reload_libs(self, [INFO] [stderr] 223 | | file.path.as_ref().unwrap(), [INFO] [stderr] ... | [INFO] [stderr] 227 | | _ => (), [INFO] [stderr] 228 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 220 | if let Ok(file) = self.watch_recv.try_recv() { [INFO] [stderr] 221 | Self::reload_libs(self, [INFO] [stderr] 222 | file.path.as_ref().unwrap(), [INFO] [stderr] 223 | update_call, [INFO] [stderr] 224 | data) [INFO] [stderr] 225 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/lib.rs:233:26 [INFO] [stderr] | [INFO] [stderr] 233 | ref update_call: F, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/lib.rs:248:25 [INFO] [stderr] | [INFO] [stderr] 248 | ref update_call: F, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:336:33 [INFO] [stderr] | [INFO] [stderr] 336 | fn search_current_dir(name: &String) -> Option { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:340:43 [INFO] [stderr] | [INFO] [stderr] 340 | fn search_relative_paths(&self, name: &String) -> Option { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:358:61 [INFO] [stderr] | [INFO] [stderr] 358 | fn search_backwards_from_file(path: &PathBuf, lib_name: &String) -> Option { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:371:44 [INFO] [stderr] | [INFO] [stderr] 371 | fn search_backwards_from_exe(lib_name: &String) -> Option { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/lib.rs:372:24 [INFO] [stderr] | [INFO] [stderr] 372 | let exe_path = env::current_exe().unwrap_or(PathBuf::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `env::current_exe().unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/lib.rs:484:5 [INFO] [stderr] | [INFO] [stderr] 484 | / fn ne(&self, other: &Lib) -> bool { [INFO] [stderr] 485 | | self.original_path != other.original_path [INFO] [stderr] 486 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::partialeq_ne_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/lib.rs:218:36 [INFO] [stderr] | [INFO] [stderr] 218 | pub fn update(&mut self, ref update_call: F, data: &mut T) where F: Fn(&mut T, UpdateState, Option<&Arc>) [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:220:9 [INFO] [stderr] | [INFO] [stderr] 220 | / match self.watch_recv.try_recv() { [INFO] [stderr] 221 | | Ok(file) => { [INFO] [stderr] 222 | | Self::reload_libs(self, [INFO] [stderr] 223 | | file.path.as_ref().unwrap(), [INFO] [stderr] ... | [INFO] [stderr] 227 | | _ => (), [INFO] [stderr] 228 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 220 | if let Ok(file) = self.watch_recv.try_recv() { [INFO] [stderr] 221 | Self::reload_libs(self, [INFO] [stderr] 222 | file.path.as_ref().unwrap(), [INFO] [stderr] 223 | update_call, [INFO] [stderr] 224 | data) [INFO] [stderr] 225 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/lib.rs:233:26 [INFO] [stderr] | [INFO] [stderr] 233 | ref update_call: F, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/lib.rs:248:25 [INFO] [stderr] | [INFO] [stderr] 248 | ref update_call: F, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:336:33 [INFO] [stderr] | [INFO] [stderr] 336 | fn search_current_dir(name: &String) -> Option { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:340:43 [INFO] [stderr] | [INFO] [stderr] 340 | fn search_relative_paths(&self, name: &String) -> Option { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:358:61 [INFO] [stderr] | [INFO] [stderr] 358 | fn search_backwards_from_file(path: &PathBuf, lib_name: &String) -> Option { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:371:44 [INFO] [stderr] | [INFO] [stderr] 371 | fn search_backwards_from_exe(lib_name: &String) -> Option { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/lib.rs:372:24 [INFO] [stderr] | [INFO] [stderr] 372 | let exe_path = env::current_exe().unwrap_or(PathBuf::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `env::current_exe().unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/lib.rs:484:5 [INFO] [stderr] | [INFO] [stderr] 484 | / fn ne(&self, other: &Lib) -> bool { [INFO] [stderr] 485 | | self.original_path != other.original_path [INFO] [stderr] 486 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::partialeq_ne_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> examples/example.rs:63:12 [INFO] [stderr] | [INFO] [stderr] 63 | if plugs.plugins.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!plugs.plugins.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.10s [INFO] running `"docker" "inspect" "0d4e4c6a25707b352b1b4db29a471874069bb2910ba02b7982e16cceaa9730f9"` [INFO] running `"docker" "rm" "-f" "0d4e4c6a25707b352b1b4db29a471874069bb2910ba02b7982e16cceaa9730f9"` [INFO] [stdout] 0d4e4c6a25707b352b1b4db29a471874069bb2910ba02b7982e16cceaa9730f9