[INFO] crate dym 1.0.1 is already in cache [INFO] extracting crate dym 1.0.1 into work/ex/clippy-test-run/sources/stable/reg/dym/1.0.1 [INFO] extracting crate dym 1.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dym/1.0.1 [INFO] validating manifest of dym-1.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dym-1.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dym-1.0.1 [INFO] finished frobbing dym-1.0.1 [INFO] frobbed toml for dym-1.0.1 written to work/ex/clippy-test-run/sources/stable/reg/dym/1.0.1/Cargo.toml [INFO] started frobbing dym-1.0.1 [INFO] finished frobbing dym-1.0.1 [INFO] frobbed toml for dym-1.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dym/1.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dym-1.0.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/dym/1.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c8826b32114f2498fe899a93df1d1500e9f4af44e232dbf0c4eb369bbf2e7e12 [INFO] running `"docker" "start" "-a" "c8826b32114f2498fe899a93df1d1500e9f4af44e232dbf0c4eb369bbf2e7e12"` [INFO] [stderr] Checking dym v1.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pattern.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | pattern: pattern, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `pattern` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pattern.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | pattern: pattern, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `pattern` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/trie/mod.rs:70:17 [INFO] [stderr] | [INFO] [stderr] 70 | return self.recurse_pattern(iter, next_node, trail); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.recurse_pattern(iter, next_node, trail)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/trie/mod.rs:82:17 [INFO] [stderr] | [INFO] [stderr] 82 | return words; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `words` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/trie/node.rs:20:30 [INFO] [stderr] | [INFO] [stderr] 20 | self.nodes.entry(ch).or_insert(Node::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Node::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/trie/node.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | / pub fn get_node<'a>(&'a self, ch: char) -> Option<&'a Node> { [INFO] [stderr] 25 | | self.nodes.get(&ch) [INFO] [stderr] 26 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/trie/mod.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | / match matcher { [INFO] [stderr] 61 | | // descend only into the branch corresponding to char c [INFO] [stderr] 62 | | &CharMatcher::Exact(c) => { [INFO] [stderr] 63 | | let iter = iter.clone(); [INFO] [stderr] ... | [INFO] [stderr] 83 | | } [INFO] [stderr] 84 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 60 | match *matcher { [INFO] [stderr] 61 | // descend only into the branch corresponding to char c [INFO] [stderr] 62 | CharMatcher::Exact(c) => { [INFO] [stderr] 63 | let iter = iter.clone(); [INFO] [stderr] 64 | let next_node = node.get_node(c); [INFO] [stderr] 65 | if next_node == None { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Lexicon` [INFO] [stderr] --> src/lib.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> Self { [INFO] [stderr] 16 | | Lexicon { [INFO] [stderr] 17 | | words: Trie::new(), [INFO] [stderr] 18 | | } [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | impl Default for Lexicon { [INFO] [stderr] 13 | fn default() -> Self { [INFO] [stderr] 14 | Self::new() [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/trie/mod.rs:70:17 [INFO] [stderr] | [INFO] [stderr] 70 | return self.recurse_pattern(iter, next_node, trail); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.recurse_pattern(iter, next_node, trail)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/trie/mod.rs:82:17 [INFO] [stderr] | [INFO] [stderr] 82 | return words; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `words` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> examples/spellchecker.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/trie/node.rs:20:30 [INFO] [stderr] | [INFO] [stderr] 20 | self.nodes.entry(ch).or_insert(Node::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Node::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/trie/node.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | / pub fn get_node<'a>(&'a self, ch: char) -> Option<&'a Node> { [INFO] [stderr] 25 | | self.nodes.get(&ch) [INFO] [stderr] 26 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/trie/mod.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | / match matcher { [INFO] [stderr] 61 | | // descend only into the branch corresponding to char c [INFO] [stderr] 62 | | &CharMatcher::Exact(c) => { [INFO] [stderr] 63 | | let iter = iter.clone(); [INFO] [stderr] ... | [INFO] [stderr] 83 | | } [INFO] [stderr] 84 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 60 | match *matcher { [INFO] [stderr] 61 | // descend only into the branch corresponding to char c [INFO] [stderr] 62 | CharMatcher::Exact(c) => { [INFO] [stderr] 63 | let iter = iter.clone(); [INFO] [stderr] 64 | let next_node = node.get_node(c); [INFO] [stderr] 65 | if next_node == None { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Lexicon` [INFO] [stderr] --> src/lib.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> Self { [INFO] [stderr] 16 | | Lexicon { [INFO] [stderr] 17 | | words: Trie::new(), [INFO] [stderr] 18 | | } [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | impl Default for Lexicon { [INFO] [stderr] 13 | fn default() -> Self { [INFO] [stderr] 14 | Self::new() [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> examples/commands.rs:8:24 [INFO] [stderr] | [INFO] [stderr] 8 | lexicon.insert_all(&vec![ [INFO] [stderr] | ________________________^ [INFO] [stderr] 9 | | "config", "help", "init", "clone", "add", "status", "diff", [INFO] [stderr] 10 | | "commit", "reset", "rm", "mv", "branch", "checkout", "merge", [INFO] [stderr] 11 | | "mergetool", "log", "stash", "tag", "fetch", "pull", "push", [INFO] [stderr] ... | [INFO] [stderr] 15 | | "filter-branch", "instaweb", "archive", "bundle" [INFO] [stderr] 16 | | ]); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] help: you can use a slice directly [INFO] [stderr] | [INFO] [stderr] 8 | lexicon.insert_all(&["config", "help", "init", "clone", "add", "status", "diff", [INFO] [stderr] 9 | "commit", "reset", "rm", "mv", "branch", "checkout", "merge", [INFO] [stderr] 10 | "mergetool", "log", "stash", "tag", "fetch", "pull", "push", [INFO] [stderr] 11 | "remote", "submodule", "show", "log", "diff", "shortlog", [INFO] [stderr] 12 | "describe", "apply", "cherry-pick", "diff", "rebase", "revert", [INFO] [stderr] 13 | "bisect", "blame", "grep", "clean", "gc","fsck", "reflog", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.54s [INFO] running `"docker" "inspect" "c8826b32114f2498fe899a93df1d1500e9f4af44e232dbf0c4eb369bbf2e7e12"` [INFO] running `"docker" "rm" "-f" "c8826b32114f2498fe899a93df1d1500e9f4af44e232dbf0c4eb369bbf2e7e12"` [INFO] [stdout] c8826b32114f2498fe899a93df1d1500e9f4af44e232dbf0c4eb369bbf2e7e12