[INFO] crate dwarfdump 0.1.0 is already in cache [INFO] extracting crate dwarfdump 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/dwarfdump/0.1.0 [INFO] extracting crate dwarfdump 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dwarfdump/0.1.0 [INFO] validating manifest of dwarfdump-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dwarfdump-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dwarfdump-0.1.0 [INFO] finished frobbing dwarfdump-0.1.0 [INFO] frobbed toml for dwarfdump-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/dwarfdump/0.1.0/Cargo.toml [INFO] started frobbing dwarfdump-0.1.0 [INFO] finished frobbing dwarfdump-0.1.0 [INFO] frobbed toml for dwarfdump-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dwarfdump/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dwarfdump-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/dwarfdump/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 51e1b6a3531c86bb60577e4a2d8c4dd6f3543b51a78acd877f36e55ad9168363 [INFO] running `"docker" "start" "-a" "51e1b6a3531c86bb60577e4a2d8c4dd6f3543b51a78acd877f36e55ad9168363"` [INFO] [stderr] Checking leb128 v0.2.3 [INFO] [stderr] Checking object v0.3.0 [INFO] [stderr] Checking gimli v0.13.0 [INFO] [stderr] Checking dwarfdump v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | str: str, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | unit: unit, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `unit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:202:17 [INFO] [stderr] | [INFO] [stderr] 202 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:203:17 [INFO] [stderr] | [INFO] [stderr] 203 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:204:17 [INFO] [stderr] | [INFO] [stderr] 204 | modifiers: modifiers [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `modifiers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:271:13 [INFO] [stderr] | [INFO] [stderr] 271 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:272:13 [INFO] [stderr] | [INFO] [stderr] 272 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:273:13 [INFO] [stderr] | [INFO] [stderr] 273 | modifiers: modifiers [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `modifiers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | str: str, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | unit: unit, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `unit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:202:17 [INFO] [stderr] | [INFO] [stderr] 202 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:203:17 [INFO] [stderr] | [INFO] [stderr] 203 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:204:17 [INFO] [stderr] | [INFO] [stderr] 204 | modifiers: modifiers [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `modifiers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:271:13 [INFO] [stderr] | [INFO] [stderr] 271 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:272:13 [INFO] [stderr] | [INFO] [stderr] 272 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:273:13 [INFO] [stderr] | [INFO] [stderr] 273 | modifiers: modifiers [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `modifiers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/parser.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | / if entry.tag() == gimli::DW_TAG_subprogram { [INFO] [stderr] 49 | | if entry.attr(gimli::DW_AT_external).expect("reading external").is_some() && [INFO] [stderr] 50 | | entry.attr(gimli::DW_AT_prototyped).expect("reading prototyped").is_some() { [INFO] [stderr] 51 | | let function = parser.parse_function(&entry); [INFO] [stderr] ... | [INFO] [stderr] 54 | | } [INFO] [stderr] 55 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 48 | if entry.tag() == gimli::DW_TAG_subprogram && entry.attr(gimli::DW_AT_external).expect("reading external").is_some() && [INFO] [stderr] 49 | entry.attr(gimli::DW_AT_prototyped).expect("reading prototyped").is_some() { [INFO] [stderr] 50 | let function = parser.parse_function(&entry); [INFO] [stderr] 51 | let symbol = function.name.as_ref().expect("reading name").clone(); [INFO] [stderr] 52 | symbols.functions.insert(symbol, function); [INFO] [stderr] 53 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/parser.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | / if entry.tag() == gimli::DW_TAG_subprogram { [INFO] [stderr] 49 | | if entry.attr(gimli::DW_AT_external).expect("reading external").is_some() && [INFO] [stderr] 50 | | entry.attr(gimli::DW_AT_prototyped).expect("reading prototyped").is_some() { [INFO] [stderr] 51 | | let function = parser.parse_function(&entry); [INFO] [stderr] ... | [INFO] [stderr] 54 | | } [INFO] [stderr] 55 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 48 | if entry.tag() == gimli::DW_TAG_subprogram && entry.attr(gimli::DW_AT_external).expect("reading external").is_some() && [INFO] [stderr] 49 | entry.attr(gimli::DW_AT_prototyped).expect("reading prototyped").is_some() { [INFO] [stderr] 50 | let function = parser.parse_function(&entry); [INFO] [stderr] 51 | let symbol = function.name.as_ref().expect("reading name").clone(); [INFO] [stderr] 52 | symbols.functions.insert(symbol, function); [INFO] [stderr] 53 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/parser.rs:95:24 [INFO] [stderr] | [INFO] [stderr] 95 | let unit = self.unit.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.unit` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/parser.rs:121:20 [INFO] [stderr] | [INFO] [stderr] 121 | let unit = self.unit.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.unit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/parser.rs:212:20 [INFO] [stderr] | [INFO] [stderr] 212 | let unit = self.unit.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.unit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/parser.rs:228:52 [INFO] [stderr] | [INFO] [stderr] 228 | gimli::DW_TAG_pointer_type => Some(modifiers.push(Modifier::Pointer)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 228 | gimli::DW_TAG_pointer_type => Some(()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/parser.rs:229:54 [INFO] [stderr] | [INFO] [stderr] 229 | gimli::DW_TAG_reference_type => Some(modifiers.push(Modifier::Reference)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 229 | gimli::DW_TAG_reference_type => Some(()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/parser.rs:230:50 [INFO] [stderr] | [INFO] [stderr] 230 | gimli::DW_TAG_const_type => Some(modifiers.push(Modifier::Const)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 230 | gimli::DW_TAG_const_type => Some(()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/parser.rs:231:53 [INFO] [stderr] | [INFO] [stderr] 231 | gimli::DW_TAG_volatile_type => Some(modifiers.push(Modifier::Volatile)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 231 | gimli::DW_TAG_volatile_type => Some(()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/parser.rs:232:53 [INFO] [stderr] | [INFO] [stderr] 232 | gimli::DW_TAG_restrict_type => Some(modifiers.push(Modifier::Restrict)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 232 | gimli::DW_TAG_restrict_type => Some(()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/parser.rs:266:43 [INFO] [stderr] | [INFO] [stderr] 266 | name = self.parse_name(entry).unwrap_or(String::from("void")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from("void"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | / match m { [INFO] [stderr] 148 | | &Modifier::Pointer => s + "*", [INFO] [stderr] 149 | | &Modifier::Reference => s + "&", [INFO] [stderr] 150 | | &Modifier::Const => s + " const", [INFO] [stderr] 151 | | &Modifier::Volatile => s + " volatile", [INFO] [stderr] 152 | | &Modifier::Restrict => s + " restrict" [INFO] [stderr] 153 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 147 | match *m { [INFO] [stderr] 148 | Modifier::Pointer => s + "*", [INFO] [stderr] 149 | Modifier::Reference => s + "&", [INFO] [stderr] 150 | Modifier::Const => s + " const", [INFO] [stderr] 151 | Modifier::Volatile => s + " volatile", [INFO] [stderr] 152 | Modifier::Restrict => s + " restrict" [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/parser.rs:95:24 [INFO] [stderr] | [INFO] [stderr] 95 | let unit = self.unit.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.unit` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/parser.rs:121:20 [INFO] [stderr] | [INFO] [stderr] 121 | let unit = self.unit.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.unit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/bin/main.rs:48:17 [INFO] [stderr] | [INFO] [stderr] 48 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/parser.rs:212:20 [INFO] [stderr] | [INFO] [stderr] 212 | let unit = self.unit.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.unit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/parser.rs:228:52 [INFO] [stderr] | [INFO] [stderr] 228 | gimli::DW_TAG_pointer_type => Some(modifiers.push(Modifier::Pointer)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 228 | gimli::DW_TAG_pointer_type => Some(()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/parser.rs:229:54 [INFO] [stderr] | [INFO] [stderr] 229 | gimli::DW_TAG_reference_type => Some(modifiers.push(Modifier::Reference)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 229 | gimli::DW_TAG_reference_type => Some(()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/parser.rs:230:50 [INFO] [stderr] | [INFO] [stderr] 230 | gimli::DW_TAG_const_type => Some(modifiers.push(Modifier::Const)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 230 | gimli::DW_TAG_const_type => Some(()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/parser.rs:231:53 [INFO] [stderr] | [INFO] [stderr] 231 | gimli::DW_TAG_volatile_type => Some(modifiers.push(Modifier::Volatile)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 231 | gimli::DW_TAG_volatile_type => Some(()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/parser.rs:232:53 [INFO] [stderr] | [INFO] [stderr] 232 | gimli::DW_TAG_restrict_type => Some(modifiers.push(Modifier::Restrict)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 232 | gimli::DW_TAG_restrict_type => Some(()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/parser.rs:266:43 [INFO] [stderr] | [INFO] [stderr] 266 | name = self.parse_name(entry).unwrap_or(String::from("void")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from("void"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | / match m { [INFO] [stderr] 148 | | &Modifier::Pointer => s + "*", [INFO] [stderr] 149 | | &Modifier::Reference => s + "&", [INFO] [stderr] 150 | | &Modifier::Const => s + " const", [INFO] [stderr] 151 | | &Modifier::Volatile => s + " volatile", [INFO] [stderr] 152 | | &Modifier::Restrict => s + " restrict" [INFO] [stderr] 153 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 147 | match *m { [INFO] [stderr] 148 | Modifier::Pointer => s + "*", [INFO] [stderr] 149 | Modifier::Reference => s + "&", [INFO] [stderr] 150 | Modifier::Const => s + " const", [INFO] [stderr] 151 | Modifier::Volatile => s + " volatile", [INFO] [stderr] 152 | Modifier::Restrict => s + " restrict" [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/bin/main.rs:48:17 [INFO] [stderr] | [INFO] [stderr] 48 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.72s [INFO] running `"docker" "inspect" "51e1b6a3531c86bb60577e4a2d8c4dd6f3543b51a78acd877f36e55ad9168363"` [INFO] running `"docker" "rm" "-f" "51e1b6a3531c86bb60577e4a2d8c4dd6f3543b51a78acd877f36e55ad9168363"` [INFO] [stdout] 51e1b6a3531c86bb60577e4a2d8c4dd6f3543b51a78acd877f36e55ad9168363