[INFO] crate dwarf_x86 0.1.0 is already in cache [INFO] extracting crate dwarf_x86 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/dwarf_x86/0.1.0 [INFO] extracting crate dwarf_x86 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dwarf_x86/0.1.0 [INFO] validating manifest of dwarf_x86-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dwarf_x86-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dwarf_x86-0.1.0 [INFO] finished frobbing dwarf_x86-0.1.0 [INFO] frobbed toml for dwarf_x86-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/dwarf_x86/0.1.0/Cargo.toml [INFO] started frobbing dwarf_x86-0.1.0 [INFO] finished frobbing dwarf_x86-0.1.0 [INFO] frobbed toml for dwarf_x86-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dwarf_x86/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dwarf_x86-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/dwarf_x86/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a6081d8d9c1fce12fea2271223a1d24a51c0f11e1f55d5bcde113d569b439dca [INFO] running `"docker" "start" "-a" "a6081d8d9c1fce12fea2271223a1d24a51c0f11e1f55d5bcde113d569b439dca"` [INFO] [stderr] Checking leb128 v0.2.3 [INFO] [stderr] Checking gimli v0.14.0 [INFO] [stderr] Checking dwarf_x86 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:213:9 [INFO] [stderr] | [INFO] [stderr] 213 | endianess: endianess, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `endianess` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:213:9 [INFO] [stderr] | [INFO] [stderr] 213 | endianess: endianess, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `endianess` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | / return Some(Argument { [INFO] [stderr] 67 | | name: arg_name.unwrap(), [INFO] [stderr] 68 | | location: location.unwrap(), [INFO] [stderr] 69 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 66 | Some(Argument { [INFO] [stderr] 67 | name: arg_name.unwrap(), [INFO] [stderr] 68 | location: location.unwrap(), [INFO] [stderr] 69 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:115:5 [INFO] [stderr] | [INFO] [stderr] 115 | / return Function { [INFO] [stderr] 116 | | name: func_name.unwrap(), [INFO] [stderr] 117 | | arguments: args, [INFO] [stderr] 118 | | start_address: start_address.unwrap(), [INFO] [stderr] 119 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 115 | Function { [INFO] [stderr] 116 | name: func_name.unwrap(), [INFO] [stderr] 117 | arguments: args, [INFO] [stderr] 118 | start_address: start_address.unwrap(), [INFO] [stderr] 119 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:127:9 [INFO] [stderr] | [INFO] [stderr] 127 | return gimli::DebugInfo::new(&debug_info.data, self.endianess); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `gimli::DebugInfo::new(&debug_info.data, self.endianess)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:134:9 [INFO] [stderr] | [INFO] [stderr] 134 | return gimli::DebugAbbrev::new(&debug_abbrev.data, self.endianess); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `gimli::DebugAbbrev::new(&debug_abbrev.data, self.endianess)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:139:9 [INFO] [stderr] | [INFO] [stderr] 139 | return gimli::DebugStr::new(&debug_str.data, self.endianess); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `gimli::DebugStr::new(&debug_str.data, self.endianess)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:168:9 [INFO] [stderr] | [INFO] [stderr] 168 | return functions; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `functions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:210:5 [INFO] [stderr] | [INFO] [stderr] 210 | / return Ok(Executable { [INFO] [stderr] 211 | | path: path::PathBuf::from(path), [INFO] [stderr] 212 | | file: elf_file, [INFO] [stderr] 213 | | endianess: endianess, [INFO] [stderr] 214 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 210 | Ok(Executable { [INFO] [stderr] 211 | path: path::PathBuf::from(path), [INFO] [stderr] 212 | file: elf_file, [INFO] [stderr] 213 | endianess: endianess, [INFO] [stderr] 214 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | / return Some(Argument { [INFO] [stderr] 67 | | name: arg_name.unwrap(), [INFO] [stderr] 68 | | location: location.unwrap(), [INFO] [stderr] 69 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 66 | Some(Argument { [INFO] [stderr] 67 | name: arg_name.unwrap(), [INFO] [stderr] 68 | location: location.unwrap(), [INFO] [stderr] 69 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:115:5 [INFO] [stderr] | [INFO] [stderr] 115 | / return Function { [INFO] [stderr] 116 | | name: func_name.unwrap(), [INFO] [stderr] 117 | | arguments: args, [INFO] [stderr] 118 | | start_address: start_address.unwrap(), [INFO] [stderr] 119 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 115 | Function { [INFO] [stderr] 116 | name: func_name.unwrap(), [INFO] [stderr] 117 | arguments: args, [INFO] [stderr] 118 | start_address: start_address.unwrap(), [INFO] [stderr] 119 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:127:9 [INFO] [stderr] | [INFO] [stderr] 127 | return gimli::DebugInfo::new(&debug_info.data, self.endianess); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `gimli::DebugInfo::new(&debug_info.data, self.endianess)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:134:9 [INFO] [stderr] | [INFO] [stderr] 134 | return gimli::DebugAbbrev::new(&debug_abbrev.data, self.endianess); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `gimli::DebugAbbrev::new(&debug_abbrev.data, self.endianess)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:139:9 [INFO] [stderr] | [INFO] [stderr] 139 | return gimli::DebugStr::new(&debug_str.data, self.endianess); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `gimli::DebugStr::new(&debug_str.data, self.endianess)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:168:9 [INFO] [stderr] | [INFO] [stderr] 168 | return functions; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `functions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:210:5 [INFO] [stderr] | [INFO] [stderr] 210 | / return Ok(Executable { [INFO] [stderr] 211 | | path: path::PathBuf::from(path), [INFO] [stderr] 212 | | file: elf_file, [INFO] [stderr] 213 | | endianess: endianess, [INFO] [stderr] 214 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 210 | Ok(Executable { [INFO] [stderr] 211 | path: path::PathBuf::from(path), [INFO] [stderr] 212 | file: elf_file, [INFO] [stderr] 213 | endianess: endianess, [INFO] [stderr] 214 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/dwarf_utils.rs:15:8 [INFO] [stderr] | [INFO] [stderr] 15 | if dwarf_loc.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `dwarf_loc.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/dwarf_utils.rs:15:8 [INFO] [stderr] | [INFO] [stderr] 15 | if dwarf_loc.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `dwarf_loc.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:107:9 [INFO] [stderr] | [INFO] [stderr] 107 | / match argument { [INFO] [stderr] 108 | | Some(argument) => { [INFO] [stderr] 109 | | args.push(argument); [INFO] [stderr] 110 | | } [INFO] [stderr] 111 | | _ => {} [INFO] [stderr] 112 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 107 | if let Some(argument) = argument { [INFO] [stderr] 108 | args.push(argument); [INFO] [stderr] 109 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:107:9 [INFO] [stderr] | [INFO] [stderr] 107 | / match argument { [INFO] [stderr] 108 | | Some(argument) => { [INFO] [stderr] 109 | | args.push(argument); [INFO] [stderr] 110 | | } [INFO] [stderr] 111 | | _ => {} [INFO] [stderr] 112 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 107 | if let Some(argument) = argument { [INFO] [stderr] 108 | args.push(argument); [INFO] [stderr] 109 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.72s [INFO] running `"docker" "inspect" "a6081d8d9c1fce12fea2271223a1d24a51c0f11e1f55d5bcde113d569b439dca"` [INFO] running `"docker" "rm" "-f" "a6081d8d9c1fce12fea2271223a1d24a51c0f11e1f55d5bcde113d569b439dca"` [INFO] [stdout] a6081d8d9c1fce12fea2271223a1d24a51c0f11e1f55d5bcde113d569b439dca