[INFO] crate dwarf-term 0.2.0 is already in cache [INFO] extracting crate dwarf-term 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/dwarf-term/0.2.0 [INFO] extracting crate dwarf-term 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dwarf-term/0.2.0 [INFO] validating manifest of dwarf-term-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dwarf-term-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dwarf-term-0.2.0 [INFO] finished frobbing dwarf-term-0.2.0 [INFO] frobbed toml for dwarf-term-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/dwarf-term/0.2.0/Cargo.toml [INFO] started frobbing dwarf-term-0.2.0 [INFO] finished frobbing dwarf-term-0.2.0 [INFO] frobbed toml for dwarf-term-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dwarf-term/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dwarf-term-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/dwarf-term/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7d55fa89523cd44e60d929f0bb14f579031335f0aac5165532405c75c6e0451c [INFO] running `"docker" "start" "-a" "7d55fa89523cd44e60d929f0bb14f579031335f0aac5165532405c75c6e0451c"` [INFO] [stderr] Checking retro-pixel v0.3.2 [INFO] [stderr] Checking glutin v0.17.0 [INFO] [stderr] Checking glium v0.22.0 [INFO] [stderr] Checking dwarf-term v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:99:87 [INFO] [stderr] | [INFO] [stderr] 99 | let display = Display::new(window_builder, context_builder, &events_loop).map_err(|e| DwarfTermGliumError::DisplayCreationError(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `DwarfTermGliumError::DisplayCreationError` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:103:84 [INFO] [stderr] | [INFO] [stderr] 103 | let program = Program::from_source(&display, VERT_SRC, FRAG_SRC, None).map_err(|e| DwarfTermGliumError::ProgramCreationError(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `DwarfTermGliumError::ProgramCreationError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:112:15 [INFO] [stderr] | [INFO] [stderr] 112 | ).map_err(|e| DwarfTermGliumError::TextureCreationError(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `DwarfTermGliumError::TextureCreationError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:239:15 [INFO] [stderr] | [INFO] [stderr] 239 | ).map_err(|e| DwarfTermGliumError::TextureCreationError(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `DwarfTermGliumError::TextureCreationError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:248:15 [INFO] [stderr] | [INFO] [stderr] 248 | ).map_err(|e| DwarfTermGliumError::TextureCreationError(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `DwarfTermGliumError::TextureCreationError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:257:15 [INFO] [stderr] | [INFO] [stderr] 257 | ).map_err(|e| DwarfTermGliumError::TextureCreationError(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `DwarfTermGliumError::TextureCreationError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:258:77 [INFO] [stderr] | [INFO] [stderr] 258 | let vertex_buffer = VertexBuffer::new(&self.display, &VERTICES).map_err(|e| DwarfTermGliumError::BufferCreationError(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `DwarfTermGliumError::BufferCreationError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:286:41 [INFO] [stderr] | [INFO] [stderr] 286 | Ok(()) => target.finish().map_err(|e| DwarfTermGliumError::SwapBuffersError(e)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `DwarfTermGliumError::SwapBuffersError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:99:87 [INFO] [stderr] | [INFO] [stderr] 99 | let display = Display::new(window_builder, context_builder, &events_loop).map_err(|e| DwarfTermGliumError::DisplayCreationError(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `DwarfTermGliumError::DisplayCreationError` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:103:84 [INFO] [stderr] | [INFO] [stderr] 103 | let program = Program::from_source(&display, VERT_SRC, FRAG_SRC, None).map_err(|e| DwarfTermGliumError::ProgramCreationError(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `DwarfTermGliumError::ProgramCreationError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:112:15 [INFO] [stderr] | [INFO] [stderr] 112 | ).map_err(|e| DwarfTermGliumError::TextureCreationError(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `DwarfTermGliumError::TextureCreationError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:239:15 [INFO] [stderr] | [INFO] [stderr] 239 | ).map_err(|e| DwarfTermGliumError::TextureCreationError(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `DwarfTermGliumError::TextureCreationError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:248:15 [INFO] [stderr] | [INFO] [stderr] 248 | ).map_err(|e| DwarfTermGliumError::TextureCreationError(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `DwarfTermGliumError::TextureCreationError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:257:15 [INFO] [stderr] | [INFO] [stderr] 257 | ).map_err(|e| DwarfTermGliumError::TextureCreationError(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `DwarfTermGliumError::TextureCreationError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:258:77 [INFO] [stderr] | [INFO] [stderr] 258 | let vertex_buffer = VertexBuffer::new(&self.display, &VERTICES).map_err(|e| DwarfTermGliumError::BufferCreationError(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `DwarfTermGliumError::BufferCreationError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:286:41 [INFO] [stderr] | [INFO] [stderr] 286 | Ok(()) => target.finish().map_err(|e| DwarfTermGliumError::SwapBuffersError(e)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `DwarfTermGliumError::SwapBuffersError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> examples/term_test.rs:35:30 [INFO] [stderr] | [INFO] [stderr] 35 | term.poll_events(|event| match event { [INFO] [stderr] | ______________________________^ [INFO] [stderr] 36 | | Event::WindowEvent { event: win_event, .. } => match win_event { [INFO] [stderr] 37 | | WindowEvent::CloseRequested [INFO] [stderr] 38 | | | WindowEvent::KeyboardInput { [INFO] [stderr] ... | [INFO] [stderr] 89 | | _ => {} [INFO] [stderr] 90 | | }); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 35 | term.poll_events(|event| if let Event::WindowEvent { event: win_event, .. } = event { match win_event { [INFO] [stderr] 36 | WindowEvent::CloseRequested [INFO] [stderr] 37 | | WindowEvent::KeyboardInput { [INFO] [stderr] 38 | input: [INFO] [stderr] 39 | KeyboardInput { [INFO] [stderr] 40 | state: ElementState::Pressed, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> examples/term_test.rs:81:14 [INFO] [stderr] | [INFO] [stderr] 81 | } => match key { [INFO] [stderr] | ______________^ [INFO] [stderr] 82 | | VirtualKeyCode::Tab => { [INFO] [stderr] 83 | | tab_held = false; [INFO] [stderr] 84 | | } [INFO] [stderr] 85 | | _ => {} [INFO] [stderr] 86 | | }, [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 81 | } => if let VirtualKeyCode::Tab = key { [INFO] [stderr] 82 | tab_held = false; [INFO] [stderr] 83 | }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the variable `total` is used as a loop counter. Consider using `for (total, item) in ids.iter_mut().enumerate()` or similar iterators [INFO] [stderr] --> examples/term_test.rs:95:32 [INFO] [stderr] | [INFO] [stderr] 95 | for (_x, _y, ref_mut) in ids.iter_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> examples/term_test.rs:101:7 [INFO] [stderr] | [INFO] [stderr] 101 | / term [INFO] [stderr] 102 | | .get_id_mut((watcher_position.0 as usize, watcher_position.1 as usize)) [INFO] [stderr] 103 | | .map(|mut_ref| *mut_ref = b'@'); [INFO] [stderr] | |_______________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 101 | if let Some(mut_ref) = term [INFO] [stderr] 102 | .get_id_mut((watcher_position.0 as usize, watcher_position.1 as usize)) { ... } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 33.48s [INFO] running `"docker" "inspect" "7d55fa89523cd44e60d929f0bb14f579031335f0aac5165532405c75c6e0451c"` [INFO] running `"docker" "rm" "-f" "7d55fa89523cd44e60d929f0bb14f579031335f0aac5165532405c75c6e0451c"` [INFO] [stdout] 7d55fa89523cd44e60d929f0bb14f579031335f0aac5165532405c75c6e0451c