[INFO] crate dvi 0.1.0 is already in cache [INFO] extracting crate dvi 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/dvi/0.1.0 [INFO] extracting crate dvi 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dvi/0.1.0 [INFO] validating manifest of dvi-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dvi-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dvi-0.1.0 [INFO] finished frobbing dvi-0.1.0 [INFO] frobbed toml for dvi-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/dvi/0.1.0/Cargo.toml [INFO] started frobbing dvi-0.1.0 [INFO] finished frobbing dvi-0.1.0 [INFO] frobbed toml for dvi-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dvi/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dvi-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/dvi/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 43cf9df81e96fed77d9045168591b5ca2a7e25d49132dfa1f122724c6da1d5a1 [INFO] running `"docker" "start" "-a" "43cf9df81e96fed77d9045168591b5ca2a7e25d49132dfa1f122724c6da1d5a1"` [INFO] [stderr] Checking dvi v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/dumper.rs:246:27 [INFO] [stderr] | [INFO] [stderr] 246 | write_small!(unsigned (data.len() as u32), writer => 239, 240, 241, 242)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/dumper.rs:246:27 [INFO] [stderr] | [INFO] [stderr] 246 | write_small!(unsigned (data.len() as u32), writer => 239, 240, 241, 242)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/dumper.rs:246:27 [INFO] [stderr] | [INFO] [stderr] 246 | write_small!(unsigned (data.len() as u32), writer => 239, 240, 241, 242)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/dumper.rs:246:27 [INFO] [stderr] | [INFO] [stderr] 246 | write_small!(unsigned (data.len() as u32), writer => 239, 240, 241, 242)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:531:27 [INFO] [stderr] | [INFO] [stderr] 531 | checksum: 0xdeadbeef, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdead_beef` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:539:27 [INFO] [stderr] | [INFO] [stderr] 539 | checksum: 0xdeadbeef, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdead_beef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:546:25 [INFO] [stderr] | [INFO] [stderr] 546 | number: 0xfafafa, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00fa_fafa` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:547:27 [INFO] [stderr] | [INFO] [stderr] 547 | checksum: 0xdeadbeef, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdead_beef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:554:25 [INFO] [stderr] | [INFO] [stderr] 554 | number: 0xfafafafa, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xfafa_fafa` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:555:27 [INFO] [stderr] | [INFO] [stderr] 555 | checksum: 0xdeadbeef, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdead_beef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:557:30 [INFO] [stderr] | [INFO] [stderr] 557 | design_size: 0x100000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:601:31 [INFO] [stderr] | [INFO] [stderr] 601 | post_pointer: 0xffffff, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:11:75 [INFO] [stderr] | [INFO] [stderr] 11 | Some(&op) if op <= 127 => IResult::Done(&i[1..], Instruction::Set(op as u32)), [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(op)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:13:57 [INFO] [stderr] | [INFO] [stderr] 13 | => IResult::Done(&i[1..], Instruction::Font((op - 171) as u32)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(op - 171)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | / named!(parse_complex, switch!(be_u8, [INFO] [stderr] 20 | | // Set [INFO] [stderr] 21 | | 128 => map!(be_u8, |ch| Instruction::Set(ch as u32)) | [INFO] [stderr] 22 | | 129 => map!(be_u16, |ch| Instruction::Set(ch as u32)) | [INFO] [stderr] ... | [INFO] [stderr] 267 | | ) [INFO] [stderr] 268 | | )); [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:21:46 [INFO] [stderr] | [INFO] [stderr] 21 | 128 => map!(be_u8, |ch| Instruction::Set(ch as u32)) | [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(ch)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:22:47 [INFO] [stderr] | [INFO] [stderr] 22 | 129 => map!(be_u16, |ch| Instruction::Set(ch as u32)) | [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(ch)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:23:25 [INFO] [stderr] | [INFO] [stderr] 23 | 130 => map!(be_u24, |ch| Instruction::Set(ch)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Instruction::Set` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:24:25 [INFO] [stderr] | [INFO] [stderr] 24 | 131 => map!(be_u32, |ch| Instruction::Set(ch)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Instruction::Set` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:32:46 [INFO] [stderr] | [INFO] [stderr] 32 | 133 => map!(be_u8, |ch| Instruction::Put(ch as u32)) | [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(ch)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:33:47 [INFO] [stderr] | [INFO] [stderr] 33 | 134 => map!(be_u16, |ch| Instruction::Put(ch as u32)) | [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(ch)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:34:25 [INFO] [stderr] | [INFO] [stderr] 34 | 135 => map!(be_u24, |ch| Instruction::Put(ch)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Instruction::Put` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:35:25 [INFO] [stderr] | [INFO] [stderr] 35 | 136 => map!(be_u32, |ch| Instruction::Put(ch)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Instruction::Put` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:11:75 [INFO] [stderr] | [INFO] [stderr] 11 | Some(&op) if op <= 127 => IResult::Done(&i[1..], Instruction::Set(op as u32)), [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(op)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:13:57 [INFO] [stderr] | [INFO] [stderr] 13 | => IResult::Done(&i[1..], Instruction::Font((op - 171) as u32)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(op - 171)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:66:47 [INFO] [stderr] | [INFO] [stderr] 66 | 143 => map!(be_i8, |a| Instruction::Right(a as i32)) | [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:67:48 [INFO] [stderr] | [INFO] [stderr] 67 | 144 => map!(be_i16, |a| Instruction::Right(a as i32)) | [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:68:25 [INFO] [stderr] | [INFO] [stderr] 68 | 145 => map!(be_i24, |a| Instruction::Right(a)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Instruction::Right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:69:25 [INFO] [stderr] | [INFO] [stderr] 69 | 146 => map!(be_i32, |a| Instruction::Right(a)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Instruction::Right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:72:48 [INFO] [stderr] | [INFO] [stderr] 72 | 148 => map!(be_i8, |a| Instruction::W(Some(a as i32))) | [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:73:49 [INFO] [stderr] | [INFO] [stderr] 73 | 149 => map!(be_i16, |a| Instruction::W(Some(a as i32))) | [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:78:48 [INFO] [stderr] | [INFO] [stderr] 78 | 153 => map!(be_i8, |a| Instruction::X(Some(a as i32))) | [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:79:49 [INFO] [stderr] | [INFO] [stderr] 79 | 154 => map!(be_i16, |a| Instruction::X(Some(a as i32))) | [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:83:46 [INFO] [stderr] | [INFO] [stderr] 83 | 157 => map!(be_i8, |a| Instruction::Down(a as i32)) | [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:84:47 [INFO] [stderr] | [INFO] [stderr] 84 | 158 => map!(be_i16, |a| Instruction::Down(a as i32)) | [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:85:25 [INFO] [stderr] | [INFO] [stderr] 85 | 159 => map!(be_i24, |a| Instruction::Down(a)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Instruction::Down` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:86:25 [INFO] [stderr] | [INFO] [stderr] 86 | 160 => map!(be_i32, |a| Instruction::Down(a)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Instruction::Down` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:89:48 [INFO] [stderr] | [INFO] [stderr] 89 | 162 => map!(be_i8, |a| Instruction::Y(Some(a as i32))) | [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:90:49 [INFO] [stderr] | [INFO] [stderr] 90 | 163 => map!(be_i16, |a| Instruction::Y(Some(a as i32))) | [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:95:48 [INFO] [stderr] | [INFO] [stderr] 95 | 167 => map!(be_i8, |a| Instruction::Z(Some(a as i32))) | [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:96:49 [INFO] [stderr] | [INFO] [stderr] 96 | 168 => map!(be_i16, |a| Instruction::Z(Some(a as i32))) | [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:100:46 [INFO] [stderr] | [INFO] [stderr] 100 | 235 => map!(be_u8, |f| Instruction::Font(f as u32)) | [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:101:47 [INFO] [stderr] | [INFO] [stderr] 101 | 236 => map!(be_u16, |f| Instruction::Font(f as u32)) | [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:102:25 [INFO] [stderr] | [INFO] [stderr] 102 | 237 => map!(be_u24, |f| Instruction::Font(f)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Instruction::Font` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:103:25 [INFO] [stderr] | [INFO] [stderr] 103 | 238 => map!(be_u32, |f| Instruction::Font(f)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Instruction::Font` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:141:25 [INFO] [stderr] | [INFO] [stderr] 141 | number: number as u32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(number)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:165:25 [INFO] [stderr] | [INFO] [stderr] 165 | number: number as u32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(number)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | / named!(parse_complex, switch!(be_u8, [INFO] [stderr] 20 | | // Set [INFO] [stderr] 21 | | 128 => map!(be_u8, |ch| Instruction::Set(ch as u32)) | [INFO] [stderr] 22 | | 129 => map!(be_u16, |ch| Instruction::Set(ch as u32)) | [INFO] [stderr] ... | [INFO] [stderr] 267 | | ) [INFO] [stderr] 268 | | )); [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:21:46 [INFO] [stderr] | [INFO] [stderr] 21 | 128 => map!(be_u8, |ch| Instruction::Set(ch as u32)) | [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(ch)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:22:47 [INFO] [stderr] | [INFO] [stderr] 22 | 129 => map!(be_u16, |ch| Instruction::Set(ch as u32)) | [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(ch)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:23:25 [INFO] [stderr] | [INFO] [stderr] 23 | 130 => map!(be_u24, |ch| Instruction::Set(ch)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Instruction::Set` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:24:25 [INFO] [stderr] | [INFO] [stderr] 24 | 131 => map!(be_u32, |ch| Instruction::Set(ch)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Instruction::Set` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:32:46 [INFO] [stderr] | [INFO] [stderr] 32 | 133 => map!(be_u8, |ch| Instruction::Put(ch as u32)) | [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(ch)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:33:47 [INFO] [stderr] | [INFO] [stderr] 33 | 134 => map!(be_u16, |ch| Instruction::Put(ch as u32)) | [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(ch)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:34:25 [INFO] [stderr] | [INFO] [stderr] 34 | 135 => map!(be_u24, |ch| Instruction::Put(ch)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Instruction::Put` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:35:25 [INFO] [stderr] | [INFO] [stderr] 35 | 136 => map!(be_u32, |ch| Instruction::Put(ch)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Instruction::Put` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:66:47 [INFO] [stderr] | [INFO] [stderr] 66 | 143 => map!(be_i8, |a| Instruction::Right(a as i32)) | [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:67:48 [INFO] [stderr] | [INFO] [stderr] 67 | 144 => map!(be_i16, |a| Instruction::Right(a as i32)) | [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:68:25 [INFO] [stderr] | [INFO] [stderr] 68 | 145 => map!(be_i24, |a| Instruction::Right(a)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Instruction::Right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:69:25 [INFO] [stderr] | [INFO] [stderr] 69 | 146 => map!(be_i32, |a| Instruction::Right(a)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Instruction::Right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:72:48 [INFO] [stderr] | [INFO] [stderr] 72 | 148 => map!(be_i8, |a| Instruction::W(Some(a as i32))) | [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/dumper.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | / match i { [INFO] [stderr] 93 | | &Instruction::Set(ch) => dump_set(ch, writer), [INFO] [stderr] 94 | | &Instruction::SetRule(a, b) => dump_set_rule(a, b, writer), [INFO] [stderr] 95 | | &Instruction::Put(ch) => dump_put(ch, writer), [INFO] [stderr] ... | [INFO] [stderr] 134 | | } => dump_postpost(post_pointer, ident, two_two_three, writer), [INFO] [stderr] 135 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 92 | match *i { [INFO] [stderr] 93 | Instruction::Set(ch) => dump_set(ch, writer), [INFO] [stderr] 94 | Instruction::SetRule(a, b) => dump_set_rule(a, b, writer), [INFO] [stderr] 95 | Instruction::Put(ch) => dump_put(ch, writer), [INFO] [stderr] 96 | Instruction::PutRule(a, b) => dump_put_rule(a, b, writer), [INFO] [stderr] 97 | Instruction::Nop => writer.write_u8(138), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:73:49 [INFO] [stderr] | [INFO] [stderr] 73 | 149 => map!(be_i16, |a| Instruction::W(Some(a as i32))) | [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:78:48 [INFO] [stderr] | [INFO] [stderr] 78 | 153 => map!(be_i8, |a| Instruction::X(Some(a as i32))) | [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:79:49 [INFO] [stderr] | [INFO] [stderr] 79 | 154 => map!(be_i16, |a| Instruction::X(Some(a as i32))) | [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:83:46 [INFO] [stderr] | [INFO] [stderr] 83 | 157 => map!(be_i8, |a| Instruction::Down(a as i32)) | [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:84:47 [INFO] [stderr] | [INFO] [stderr] 84 | 158 => map!(be_i16, |a| Instruction::Down(a as i32)) | [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:85:25 [INFO] [stderr] | [INFO] [stderr] 85 | 159 => map!(be_i24, |a| Instruction::Down(a)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Instruction::Down` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:86:25 [INFO] [stderr] | [INFO] [stderr] 86 | 160 => map!(be_i32, |a| Instruction::Down(a)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Instruction::Down` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:89:48 [INFO] [stderr] | [INFO] [stderr] 89 | 162 => map!(be_i8, |a| Instruction::Y(Some(a as i32))) | [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:90:49 [INFO] [stderr] | [INFO] [stderr] 90 | 163 => map!(be_i16, |a| Instruction::Y(Some(a as i32))) | [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:95:48 [INFO] [stderr] | [INFO] [stderr] 95 | 167 => map!(be_i8, |a| Instruction::Z(Some(a as i32))) | [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:96:49 [INFO] [stderr] | [INFO] [stderr] 96 | 168 => map!(be_i16, |a| Instruction::Z(Some(a as i32))) | [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:100:46 [INFO] [stderr] | [INFO] [stderr] 100 | 235 => map!(be_u8, |f| Instruction::Font(f as u32)) | [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:101:47 [INFO] [stderr] | [INFO] [stderr] 101 | 236 => map!(be_u16, |f| Instruction::Font(f as u32)) | [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:102:25 [INFO] [stderr] | [INFO] [stderr] 102 | 237 => map!(be_u24, |f| Instruction::Font(f)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Instruction::Font` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:103:25 [INFO] [stderr] | [INFO] [stderr] 103 | 238 => map!(be_u32, |f| Instruction::Font(f)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Instruction::Font` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:141:25 [INFO] [stderr] | [INFO] [stderr] 141 | number: number as u32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(number)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:165:25 [INFO] [stderr] | [INFO] [stderr] 165 | number: number as u32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(number)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/dumper.rs:276:5 [INFO] [stderr] | [INFO] [stderr] 276 | / match def.directory { [INFO] [stderr] 277 | | Some(ref d) => writer.write_all(&d[..])?, [INFO] [stderr] 278 | | None => {}, [INFO] [stderr] 279 | | }; [INFO] [stderr] | |_____^ help: try this: `if let Some(ref d) = def.directory { writer.write_all(&d[..])? }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/dumper.rs:289:32 [INFO] [stderr] | [INFO] [stderr] 289 | comment: &Vec, [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/dumper.rs:303:1 [INFO] [stderr] | [INFO] [stderr] 303 | / fn dump_post(final_bop_pointer: i32, [INFO] [stderr] 304 | | numerator: u32, [INFO] [stderr] 305 | | denominator: u32, [INFO] [stderr] 306 | | magnification: u32, [INFO] [stderr] ... | [INFO] [stderr] 321 | | Ok(()) [INFO] [stderr] 322 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/dumper.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | / match i { [INFO] [stderr] 93 | | &Instruction::Set(ch) => dump_set(ch, writer), [INFO] [stderr] 94 | | &Instruction::SetRule(a, b) => dump_set_rule(a, b, writer), [INFO] [stderr] 95 | | &Instruction::Put(ch) => dump_put(ch, writer), [INFO] [stderr] ... | [INFO] [stderr] 134 | | } => dump_postpost(post_pointer, ident, two_two_three, writer), [INFO] [stderr] 135 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 92 | match *i { [INFO] [stderr] 93 | Instruction::Set(ch) => dump_set(ch, writer), [INFO] [stderr] 94 | Instruction::SetRule(a, b) => dump_set_rule(a, b, writer), [INFO] [stderr] 95 | Instruction::Put(ch) => dump_put(ch, writer), [INFO] [stderr] 96 | Instruction::PutRule(a, b) => dump_put_rule(a, b, writer), [INFO] [stderr] 97 | Instruction::Nop => writer.write_u8(138), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/dumper.rs:276:5 [INFO] [stderr] | [INFO] [stderr] 276 | / match def.directory { [INFO] [stderr] 277 | | Some(ref d) => writer.write_all(&d[..])?, [INFO] [stderr] 278 | | None => {}, [INFO] [stderr] 279 | | }; [INFO] [stderr] | |_____^ help: try this: `if let Some(ref d) = def.directory { writer.write_all(&d[..])? }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/dumper.rs:289:32 [INFO] [stderr] | [INFO] [stderr] 289 | comment: &Vec, [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/dumper.rs:303:1 [INFO] [stderr] | [INFO] [stderr] 303 | / fn dump_post(final_bop_pointer: i32, [INFO] [stderr] 304 | | numerator: u32, [INFO] [stderr] 305 | | denominator: u32, [INFO] [stderr] 306 | | magnification: u32, [INFO] [stderr] ... | [INFO] [stderr] 321 | | Ok(()) [INFO] [stderr] 322 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:402:32 [INFO] [stderr] | [INFO] [stderr] 402 | Instruction::Right(0x7fu8 as i32), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(0x7fu8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:403:32 [INFO] [stderr] | [INFO] [stderr] 403 | Instruction::Right(0x7f_ffu16 as i32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(0x7f_ffu16)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.15s [INFO] running `"docker" "inspect" "43cf9df81e96fed77d9045168591b5ca2a7e25d49132dfa1f122724c6da1d5a1"` [INFO] running `"docker" "rm" "-f" "43cf9df81e96fed77d9045168591b5ca2a7e25d49132dfa1f122724c6da1d5a1"` [INFO] [stdout] 43cf9df81e96fed77d9045168591b5ca2a7e25d49132dfa1f122724c6da1d5a1