[INFO] crate durationfmt 0.1.1 is already in cache [INFO] extracting crate durationfmt 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/durationfmt/0.1.1 [INFO] extracting crate durationfmt 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/durationfmt/0.1.1 [INFO] validating manifest of durationfmt-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of durationfmt-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing durationfmt-0.1.1 [INFO] finished frobbing durationfmt-0.1.1 [INFO] frobbed toml for durationfmt-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/durationfmt/0.1.1/Cargo.toml [INFO] started frobbing durationfmt-0.1.1 [INFO] finished frobbing durationfmt-0.1.1 [INFO] frobbed toml for durationfmt-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/durationfmt/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting durationfmt-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/durationfmt/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 03dcbd1d9e819b739e69519d2af5935749d16b581fef2f1ff88e162aea919bba [INFO] running `"docker" "start" "-a" "03dcbd1d9e819b739e69519d2af5935749d16b581fef2f1ff88e162aea919bba"` [INFO] [stderr] Checking durationfmt v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:77:3 [INFO] [stderr] | [INFO] [stderr] 77 | return String::from_utf8_lossy(&buf[w..]).into_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from_utf8_lossy(&buf[w..]).into_owned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: value assigned to `prec` is never read [INFO] [stderr] --> src/lib.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | let mut prec = 0; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:46:46 [INFO] [stderr] | [INFO] [stderr] 46 | let (mut w, u) = fmt_frac(&mut buf[..w], nanos as u64, prec); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(nanos)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:55:44 [INFO] [stderr] | [INFO] [stderr] 55 | let (mut w, _) = fmt_frac(&mut buf[..w], nanos as u64, 9); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(nanos)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:77:3 [INFO] [stderr] | [INFO] [stderr] 77 | return String::from_utf8_lossy(&buf[w..]).into_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from_utf8_lossy(&buf[w..]).into_owned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/lib.rs:136:52 [INFO] [stderr] | [INFO] [stderr] 136 | assert_eq!("2.2ms", to_string(Duration::new(0, 2200_000))); [INFO] [stderr] | ^^^^^^^^ help: consider: `2_200_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:153:10 [INFO] [stderr] | [INFO] [stderr] 153 | (2562047 * 60 * 60) + (47 * 60) + 16, [INFO] [stderr] | ^^^^^^^ help: consider: `2_562_047` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: value assigned to `prec` is never read [INFO] [stderr] --> src/lib.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | let mut prec = 0; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:46:46 [INFO] [stderr] | [INFO] [stderr] 46 | let (mut w, u) = fmt_frac(&mut buf[..w], nanos as u64, prec); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(nanos)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:55:44 [INFO] [stderr] | [INFO] [stderr] 55 | let (mut w, _) = fmt_frac(&mut buf[..w], nanos as u64, 9); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(nanos)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.18s [INFO] running `"docker" "inspect" "03dcbd1d9e819b739e69519d2af5935749d16b581fef2f1ff88e162aea919bba"` [INFO] running `"docker" "rm" "-f" "03dcbd1d9e819b739e69519d2af5935749d16b581fef2f1ff88e162aea919bba"` [INFO] [stdout] 03dcbd1d9e819b739e69519d2af5935749d16b581fef2f1ff88e162aea919bba