[INFO] crate duration-parser 0.2.0 is already in cache
[INFO] extracting crate duration-parser 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/duration-parser/0.2.0
[INFO] extracting crate duration-parser 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/duration-parser/0.2.0
[INFO] validating manifest of duration-parser-0.2.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of duration-parser-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing duration-parser-0.2.0
[INFO] finished frobbing duration-parser-0.2.0
[INFO] frobbed toml for duration-parser-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/duration-parser/0.2.0/Cargo.toml
[INFO] started frobbing duration-parser-0.2.0
[INFO] finished frobbing duration-parser-0.2.0
[INFO] frobbed toml for duration-parser-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/duration-parser/0.2.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting duration-parser-0.2.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/duration-parser/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] c30688c95dd267bea63922681ee25506c1016c8f38a3f9432ef51720440e7c83
[INFO] running `"docker" "start" "-a" "c30688c95dd267bea63922681ee25506c1016c8f38a3f9432ef51720440e7c83"`
[INFO] [stderr]     Checking duration-parser v0.2.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parse.rs:11:2
[INFO] [stderr]    |
[INFO] [stderr] 11 |       return match units.as_ref() {
[INFO] [stderr]    |  _____^
[INFO] [stderr] 12 | |         "s" => Ok(1),
[INFO] [stderr] 13 | |         "m" => Ok(SEC_IN_MIN),
[INFO] [stderr] 14 | |         "h" => Ok(SEC_IN_HR),
[INFO] [stderr] ...  |
[INFO] [stderr] 18 | |         _ => Err(Error::UnknownSuffix)
[INFO] [stderr] 19 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 11 |     match units.as_ref() {
[INFO] [stderr] 12 |         "s" => Ok(1),
[INFO] [stderr] 13 |         "m" => Ok(SEC_IN_MIN),
[INFO] [stderr] 14 |         "h" => Ok(SEC_IN_HR),
[INFO] [stderr] 15 |         "d" => Ok(SEC_IN_DAY),
[INFO] [stderr] 16 |         "w" => Ok(SEC_IN_WK),
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parse.rs:61:2
[INFO] [stderr]    |
[INFO] [stderr] 61 |     return Ok(total_duration_in_ms);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(total_duration_in_ms)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this call to `as_ref` does nothing
[INFO] [stderr]   --> src/parse.rs:11:15
[INFO] [stderr]    |
[INFO] [stderr] 11 |     return match units.as_ref() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^ help: try this: `units`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_asref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/parse.rs:22:32
[INFO] [stderr]    |
[INFO] [stderr] 22 | pub fn parse_duration(string : &String) -> Result<u64, Error> {
[INFO] [stderr]    |                                ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parse.rs:11:2
[INFO] [stderr]    |
[INFO] [stderr] 11 |       return match units.as_ref() {
[INFO] [stderr]    |  _____^
[INFO] [stderr] 12 | |         "s" => Ok(1),
[INFO] [stderr] 13 | |         "m" => Ok(SEC_IN_MIN),
[INFO] [stderr] 14 | |         "h" => Ok(SEC_IN_HR),
[INFO] [stderr] ...  |
[INFO] [stderr] 18 | |         _ => Err(Error::UnknownSuffix)
[INFO] [stderr] 19 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 11 |     match units.as_ref() {
[INFO] [stderr] 12 |         "s" => Ok(1),
[INFO] [stderr] 13 |         "m" => Ok(SEC_IN_MIN),
[INFO] [stderr] 14 |         "h" => Ok(SEC_IN_HR),
[INFO] [stderr] 15 |         "d" => Ok(SEC_IN_DAY),
[INFO] [stderr] 16 |         "w" => Ok(SEC_IN_WK),
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parse.rs:61:2
[INFO] [stderr]    |
[INFO] [stderr] 61 |     return Ok(total_duration_in_ms);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(total_duration_in_ms)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this call to `as_ref` does nothing
[INFO] [stderr]   --> src/parse.rs:11:15
[INFO] [stderr]    |
[INFO] [stderr] 11 |     return match units.as_ref() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^ help: try this: `units`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_asref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/parse.rs:22:32
[INFO] [stderr]    |
[INFO] [stderr] 22 | pub fn parse_duration(string : &String) -> Result<u64, Error> {
[INFO] [stderr]    |                                ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `60`
[INFO] [stderr]   --> src/test.rs:15:23
[INFO] [stderr]    |
[INFO] [stderr] 15 |                 assert!(result == 1 * 60*60*24*365 + 2 * 60*60*24*7 + 5 * 60*60*24 + 3 * 60*60 + 42 * 60 + 10);
[INFO] [stderr]    |                                   ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.38s
[INFO] running `"docker" "inspect" "c30688c95dd267bea63922681ee25506c1016c8f38a3f9432ef51720440e7c83"`
[INFO] running `"docker" "rm" "-f" "c30688c95dd267bea63922681ee25506c1016c8f38a3f9432ef51720440e7c83"`
[INFO] [stdout] c30688c95dd267bea63922681ee25506c1016c8f38a3f9432ef51720440e7c83