[INFO] crate duniter-rs-wotb 0.4.0 is already in cache [INFO] extracting crate duniter-rs-wotb 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/duniter-rs-wotb/0.4.0 [INFO] extracting crate duniter-rs-wotb 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/duniter-rs-wotb/0.4.0 [INFO] validating manifest of duniter-rs-wotb-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of duniter-rs-wotb-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing duniter-rs-wotb-0.4.0 [INFO] finished frobbing duniter-rs-wotb-0.4.0 [INFO] frobbed toml for duniter-rs-wotb-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/duniter-rs-wotb/0.4.0/Cargo.toml [INFO] started frobbing duniter-rs-wotb-0.4.0 [INFO] finished frobbing duniter-rs-wotb-0.4.0 [INFO] frobbed toml for duniter-rs-wotb-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/duniter-rs-wotb/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting duniter-rs-wotb-0.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/duniter-rs-wotb/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 22efb4dfb00ead24e8f7fd9897e09493f40ae16ba3bdeafd88a6d58203793d0f [INFO] running `"docker" "start" "-a" "22efb4dfb00ead24e8f7fd9897e09493f40ae16ba3bdeafd88a6d58203793d0f"` [INFO] [stderr] Checking duniter-rs-wotb v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:298:20 [INFO] [stderr] | [INFO] [stderr] 298 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 299 | | if check { [INFO] [stderr] 300 | | result.reached += 1; [INFO] [stderr] 301 | | } [INFO] [stderr] 302 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 298 | } else if check { [INFO] [stderr] 299 | result.reached += 1; [INFO] [stderr] 300 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:466:16 [INFO] [stderr] | [INFO] [stderr] 466 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 467 | | if *from < *to { [INFO] [stderr] 468 | | // split `nodes` in two part to allow borrowing 2 nodes at the same time [INFO] [stderr] 469 | | let (start, end) = self.nodes.split_at_mut(*to); [INFO] [stderr] ... | [INFO] [stderr] 475 | | } [INFO] [stderr] 476 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 466 | } else if *from < *to { [INFO] [stderr] 467 | // split `nodes` in two part to allow borrowing 2 nodes at the same time [INFO] [stderr] 468 | let (start, end) = self.nodes.split_at_mut(*to); [INFO] [stderr] 469 | start[*from].link_to(&mut end[0], self.max_cert) [INFO] [stderr] 470 | } else { [INFO] [stderr] 471 | // split `nodes` in two part to allow borrowing 2 nodes at the same time [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:485:16 [INFO] [stderr] | [INFO] [stderr] 485 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 486 | | if *from < *to { [INFO] [stderr] 487 | | // split `nodes` in two part to allow borrowing 2 nodes at the same time [INFO] [stderr] 488 | | let (start, end) = self.nodes.split_at_mut(*to); [INFO] [stderr] ... | [INFO] [stderr] 494 | | } [INFO] [stderr] 495 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 485 | } else if *from < *to { [INFO] [stderr] 486 | // split `nodes` in two part to allow borrowing 2 nodes at the same time [INFO] [stderr] 487 | let (start, end) = self.nodes.split_at_mut(*to); [INFO] [stderr] 488 | start[*from].unlink_to(&mut end[0]) [INFO] [stderr] 489 | } else { [INFO] [stderr] 490 | // split `nodes` in two part to allow borrowing 2 nodes at the same time [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:298:20 [INFO] [stderr] | [INFO] [stderr] 298 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 299 | | if check { [INFO] [stderr] 300 | | result.reached += 1; [INFO] [stderr] 301 | | } [INFO] [stderr] 302 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 298 | } else if check { [INFO] [stderr] 299 | result.reached += 1; [INFO] [stderr] 300 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:466:16 [INFO] [stderr] | [INFO] [stderr] 466 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 467 | | if *from < *to { [INFO] [stderr] 468 | | // split `nodes` in two part to allow borrowing 2 nodes at the same time [INFO] [stderr] 469 | | let (start, end) = self.nodes.split_at_mut(*to); [INFO] [stderr] ... | [INFO] [stderr] 475 | | } [INFO] [stderr] 476 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 466 | } else if *from < *to { [INFO] [stderr] 467 | // split `nodes` in two part to allow borrowing 2 nodes at the same time [INFO] [stderr] 468 | let (start, end) = self.nodes.split_at_mut(*to); [INFO] [stderr] 469 | start[*from].link_to(&mut end[0], self.max_cert) [INFO] [stderr] 470 | } else { [INFO] [stderr] 471 | // split `nodes` in two part to allow borrowing 2 nodes at the same time [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:485:16 [INFO] [stderr] | [INFO] [stderr] 485 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 486 | | if *from < *to { [INFO] [stderr] 487 | | // split `nodes` in two part to allow borrowing 2 nodes at the same time [INFO] [stderr] 488 | | let (start, end) = self.nodes.split_at_mut(*to); [INFO] [stderr] ... | [INFO] [stderr] 494 | | } [INFO] [stderr] 495 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 485 | } else if *from < *to { [INFO] [stderr] 486 | // split `nodes` in two part to allow borrowing 2 nodes at the same time [INFO] [stderr] 487 | let (start, end) = self.nodes.split_at_mut(*to); [INFO] [stderr] 488 | start[*from].unlink_to(&mut end[0]) [INFO] [stderr] 489 | } else { [INFO] [stderr] 490 | // split `nodes` in two part to allow borrowing 2 nodes at the same time [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/lib.rs:204:16 [INFO] [stderr] | [INFO] [stderr] 204 | if let Err(_) = file.read_to_end(&mut content) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 205 | | return None; [INFO] [stderr] 206 | | } [INFO] [stderr] | |_________- help: try this: `if file.read_to_end(&mut content).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:236:12 [INFO] [stderr] | [INFO] [stderr] 236 | if self.nodes.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.nodes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:305:31 [INFO] [stderr] | [INFO] [stderr] 305 | result.outdistanced = (result.success as f64) < x_percent * (result.sentries as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(result.success)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:305:69 [INFO] [stderr] | [INFO] [stderr] 305 | result.outdistanced = (result.success as f64) < x_percent * (result.sentries as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(result.sentries)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/lib.rs:340:5 [INFO] [stderr] | [INFO] [stderr] 340 | / fn lookup( [INFO] [stderr] 341 | | &self, [INFO] [stderr] 342 | | source: NodeId, [INFO] [stderr] 343 | | target: NodeId, [INFO] [stderr] ... | [INFO] [stderr] 385 | | } [INFO] [stderr] 386 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/lib.rs:204:16 [INFO] [stderr] | [INFO] [stderr] 204 | if let Err(_) = file.read_to_end(&mut content) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 205 | | return None; [INFO] [stderr] 206 | | } [INFO] [stderr] | |_________- help: try this: `if file.read_to_end(&mut content).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:236:12 [INFO] [stderr] | [INFO] [stderr] 236 | if self.nodes.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.nodes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:305:31 [INFO] [stderr] | [INFO] [stderr] 305 | result.outdistanced = (result.success as f64) < x_percent * (result.sentries as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(result.success)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:305:69 [INFO] [stderr] | [INFO] [stderr] 305 | result.outdistanced = (result.success as f64) < x_percent * (result.sentries as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(result.sentries)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/lib.rs:340:5 [INFO] [stderr] | [INFO] [stderr] 340 | / fn lookup( [INFO] [stderr] 341 | | &self, [INFO] [stderr] 342 | | source: NodeId, [INFO] [stderr] 343 | | target: NodeId, [INFO] [stderr] ... | [INFO] [stderr] 385 | | } [INFO] [stderr] 386 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 30 [INFO] [stderr] --> src/lib.rs:531:5 [INFO] [stderr] | [INFO] [stderr] 531 | / fn node_tests() { [INFO] [stderr] 532 | | // Correct node id [INFO] [stderr] 533 | | assert_eq!(*Node::new(1).id(), 1); [INFO] [stderr] 534 | | [INFO] [stderr] ... | [INFO] [stderr] 586 | | assert!(node2.has_link_from(&node1)); [INFO] [stderr] 587 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 112 [INFO] [stderr] --> src/lib.rs:591:5 [INFO] [stderr] | [INFO] [stderr] 591 | / fn wot_tests() { [INFO] [stderr] 592 | | let mut wot = WebOfTrust::new(3); [INFO] [stderr] 593 | | [INFO] [stderr] 594 | | // should have an initial size of 0 [INFO] [stderr] ... | [INFO] [stderr] 825 | | [INFO] [stderr] 826 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.11s [INFO] running `"docker" "inspect" "22efb4dfb00ead24e8f7fd9897e09493f40ae16ba3bdeafd88a6d58203793d0f"` [INFO] running `"docker" "rm" "-f" "22efb4dfb00ead24e8f7fd9897e09493f40ae16ba3bdeafd88a6d58203793d0f"` [INFO] [stdout] 22efb4dfb00ead24e8f7fd9897e09493f40ae16ba3bdeafd88a6d58203793d0f