[INFO] crate dudect-bencher 0.3.0 is already in cache [INFO] extracting crate dudect-bencher 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/dudect-bencher/0.3.0 [INFO] extracting crate dudect-bencher 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dudect-bencher/0.3.0 [INFO] validating manifest of dudect-bencher-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dudect-bencher-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dudect-bencher-0.3.0 [INFO] finished frobbing dudect-bencher-0.3.0 [INFO] frobbed toml for dudect-bencher-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/dudect-bencher/0.3.0/Cargo.toml [INFO] started frobbing dudect-bencher-0.3.0 [INFO] finished frobbing dudect-bencher-0.3.0 [INFO] frobbed toml for dudect-bencher-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dudect-bencher/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dudect-bencher-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/dudect-bencher/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a86a2d6a1cdc5c592fcd31ee46b8d5a85c9e379793b163db4ad69724cc8b9559 [INFO] running `"docker" "start" "-a" "a86a2d6a1cdc5c592fcd31ee46b8d5a85c9e379793b163db4ad69724cc8b9559"` [INFO] [stderr] Checking dudect-bencher v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/ctbench.rs:301:31 [INFO] [stderr] | [INFO] [stderr] 301 | cb.file_out.as_mut().map(|mut f| { [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ctbench.rs:70:25 [INFO] [stderr] | [INFO] [stderr] 70 | fn go(&mut self, f: &BenchFn) -> stats::CtSummary { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `BenchFn` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ctbench.rs:224:58 [INFO] [stderr] | [INFO] [stderr] 224 | let filtered_names = filtered_benches.iter().map(|b| b.name.clone()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `b.name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ctbench.rs:247:12 [INFO] [stderr] | [INFO] [stderr] 247 | if filtered_benches.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `filtered_benches.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ctbench.rs:248:13 [INFO] [stderr] | [INFO] [stderr] 248 | / match filter { [INFO] [stderr] 249 | | &Some(ref f) => panic!("No benchmark matching '{}' was found", f), [INFO] [stderr] 250 | | &None => return Ok(()), [INFO] [stderr] 251 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 248 | match *filter { [INFO] [stderr] 249 | Some(ref f) => panic!("No benchmark matching '{}' was found", f), [INFO] [stderr] 250 | None => return Ok(()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/ctbench.rs:261:46 [INFO] [stderr] | [INFO] [stderr] 261 | let seed = bench.seed.unwrap_or_else(|| CtBencher::rand_seed()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `CtBencher::rand_seed` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/ctbench.rs:284:51 [INFO] [stderr] | [INFO] [stderr] 284 | let seed = bench.seed.unwrap_or_else(|| CtBencher::rand_seed()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `CtBencher::rand_seed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ctbench.rs:296:54 [INFO] [stderr] | [INFO] [stderr] 296 | fn run_bench_with_bencher(name: &BenchName, benchfn: &BenchFn, cb: &mut CtBencher) -> MonitorMsg { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `BenchFn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/ctbench.rs:301:5 [INFO] [stderr] | [INFO] [stderr] 301 | cb.file_out.as_mut().map(|mut f| { [INFO] [stderr] | _____^ [INFO] [stderr] | |_____| [INFO] [stderr] | || [INFO] [stderr] 302 | || for (x, y) in samples_iter { [INFO] [stderr] 303 | || write!(f, "\n{},0,{}", name.0, x).expect("Error writing data to file"); [INFO] [stderr] 304 | || write!(f, "\n{},0,{}", name.0, y).expect("Error writing data to file"); [INFO] [stderr] 305 | || } [INFO] [stderr] 306 | || }); [INFO] [stderr] | ||______^- help: try this: `if let Some(mut f) = cb.file_out.as_mut() { ... }` [INFO] [stderr] | |_______| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ctbench.rs:308:6 [INFO] [stderr] | [INFO] [stderr] 308 | (name.clone(), summ) [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ctbench.rs:315:16 [INFO] [stderr] | [INFO] [stderr] 315 | filtered = match filter { [INFO] [stderr] | ________________^ [INFO] [stderr] 316 | | &None => filtered, [INFO] [stderr] 317 | | &Some(ref filter) => { [INFO] [stderr] 318 | | filtered.into_iter() [INFO] [stderr] ... | [INFO] [stderr] 321 | | } [INFO] [stderr] 322 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 315 | filtered = match *filter { [INFO] [stderr] 316 | None => filtered, [INFO] [stderr] 317 | Some(ref filter) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ctbench.rs:367:45 [INFO] [stderr] | [INFO] [stderr] 367 | dur.as_secs() * 1_000_000_000 + (dur.subsec_nanos() as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(dur.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/stats.rs:51:21 [INFO] [stderr] | [INFO] [stderr] 51 | } else if x < y { [INFO] [stderr] | _____________________^ [INFO] [stderr] 52 | | Less [INFO] [stderr] 53 | | } else if x == y { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/stats.rs:49:26 [INFO] [stderr] | [INFO] [stderr] 49 | } else if x.is_nan() { [INFO] [stderr] | __________________________^ [INFO] [stderr] 50 | | Less [INFO] [stderr] 51 | | } else if x < y { [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/stats.rs:53:15 [INFO] [stderr] | [INFO] [stderr] 53 | } else if x == y { [INFO] [stderr] | ^^^^^^ help: consider comparing them within some error: `(x - y).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/stats.rs:53:15 [INFO] [stderr] | [INFO] [stderr] 53 | } else if x == y { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/stats.rs:71:8 [INFO] [stderr] | [INFO] [stderr] 71 | if pct == hundred { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider comparing them within some error: `(pct - hundred).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/stats.rs:71:8 [INFO] [stderr] | [INFO] [stderr] 71 | if pct == hundred { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `percentiles` [INFO] [stderr] --> src/stats.rs:93:14 [INFO] [stderr] | [INFO] [stderr] 93 | for i in 0..100 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 93 | for (i, ) in percentiles.iter_mut().enumerate().take(100) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/ctbench.rs:301:31 [INFO] [stderr] | [INFO] [stderr] 301 | cb.file_out.as_mut().map(|mut f| { [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] error: Could not compile `dudect-bencher`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ctbench.rs:70:25 [INFO] [stderr] | [INFO] [stderr] 70 | fn go(&mut self, f: &BenchFn) -> stats::CtSummary { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `BenchFn` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ctbench.rs:224:58 [INFO] [stderr] | [INFO] [stderr] 224 | let filtered_names = filtered_benches.iter().map(|b| b.name.clone()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `b.name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ctbench.rs:247:12 [INFO] [stderr] | [INFO] [stderr] 247 | if filtered_benches.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `filtered_benches.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ctbench.rs:248:13 [INFO] [stderr] | [INFO] [stderr] 248 | / match filter { [INFO] [stderr] 249 | | &Some(ref f) => panic!("No benchmark matching '{}' was found", f), [INFO] [stderr] 250 | | &None => return Ok(()), [INFO] [stderr] 251 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 248 | match *filter { [INFO] [stderr] 249 | Some(ref f) => panic!("No benchmark matching '{}' was found", f), [INFO] [stderr] 250 | None => return Ok(()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/ctbench.rs:261:46 [INFO] [stderr] | [INFO] [stderr] 261 | let seed = bench.seed.unwrap_or_else(|| CtBencher::rand_seed()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `CtBencher::rand_seed` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/ctbench.rs:284:51 [INFO] [stderr] | [INFO] [stderr] 284 | let seed = bench.seed.unwrap_or_else(|| CtBencher::rand_seed()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `CtBencher::rand_seed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ctbench.rs:296:54 [INFO] [stderr] | [INFO] [stderr] 296 | fn run_bench_with_bencher(name: &BenchName, benchfn: &BenchFn, cb: &mut CtBencher) -> MonitorMsg { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `BenchFn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/ctbench.rs:301:5 [INFO] [stderr] | [INFO] [stderr] 301 | cb.file_out.as_mut().map(|mut f| { [INFO] [stderr] | _____^ [INFO] [stderr] | |_____| [INFO] [stderr] | || [INFO] [stderr] 302 | || for (x, y) in samples_iter { [INFO] [stderr] 303 | || write!(f, "\n{},0,{}", name.0, x).expect("Error writing data to file"); [INFO] [stderr] 304 | || write!(f, "\n{},0,{}", name.0, y).expect("Error writing data to file"); [INFO] [stderr] 305 | || } [INFO] [stderr] 306 | || }); [INFO] [stderr] | ||______^- help: try this: `if let Some(mut f) = cb.file_out.as_mut() { ... }` [INFO] [stderr] | |_______| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ctbench.rs:308:6 [INFO] [stderr] | [INFO] [stderr] 308 | (name.clone(), summ) [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ctbench.rs:315:16 [INFO] [stderr] | [INFO] [stderr] 315 | filtered = match filter { [INFO] [stderr] | ________________^ [INFO] [stderr] 316 | | &None => filtered, [INFO] [stderr] 317 | | &Some(ref filter) => { [INFO] [stderr] 318 | | filtered.into_iter() [INFO] [stderr] ... | [INFO] [stderr] 321 | | } [INFO] [stderr] 322 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 315 | filtered = match *filter { [INFO] [stderr] 316 | None => filtered, [INFO] [stderr] 317 | Some(ref filter) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ctbench.rs:367:45 [INFO] [stderr] | [INFO] [stderr] 367 | dur.as_secs() * 1_000_000_000 + (dur.subsec_nanos() as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(dur.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/stats.rs:51:21 [INFO] [stderr] | [INFO] [stderr] 51 | } else if x < y { [INFO] [stderr] | _____________________^ [INFO] [stderr] 52 | | Less [INFO] [stderr] 53 | | } else if x == y { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/stats.rs:49:26 [INFO] [stderr] | [INFO] [stderr] 49 | } else if x.is_nan() { [INFO] [stderr] | __________________________^ [INFO] [stderr] 50 | | Less [INFO] [stderr] 51 | | } else if x < y { [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/stats.rs:53:15 [INFO] [stderr] | [INFO] [stderr] 53 | } else if x == y { [INFO] [stderr] | ^^^^^^ help: consider comparing them within some error: `(x - y).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/stats.rs:53:15 [INFO] [stderr] | [INFO] [stderr] 53 | } else if x == y { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/stats.rs:71:8 [INFO] [stderr] | [INFO] [stderr] 71 | if pct == hundred { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider comparing them within some error: `(pct - hundred).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/stats.rs:71:8 [INFO] [stderr] | [INFO] [stderr] 71 | if pct == hundred { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `percentiles` [INFO] [stderr] --> src/stats.rs:93:14 [INFO] [stderr] | [INFO] [stderr] 93 | for i in 0..100 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 93 | for (i, ) in percentiles.iter_mut().enumerate().take(100) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `dudect-bencher`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "a86a2d6a1cdc5c592fcd31ee46b8d5a85c9e379793b163db4ad69724cc8b9559"` [INFO] running `"docker" "rm" "-f" "a86a2d6a1cdc5c592fcd31ee46b8d5a85c9e379793b163db4ad69724cc8b9559"` [INFO] [stdout] a86a2d6a1cdc5c592fcd31ee46b8d5a85c9e379793b163db4ad69724cc8b9559