[INFO] crate duckduckgeo 0.1.0 is already in cache [INFO] extracting crate duckduckgeo 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/duckduckgeo/0.1.0 [INFO] extracting crate duckduckgeo 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/duckduckgeo/0.1.0 [INFO] validating manifest of duckduckgeo-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of duckduckgeo-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing duckduckgeo-0.1.0 [INFO] finished frobbing duckduckgeo-0.1.0 [INFO] frobbed toml for duckduckgeo-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/duckduckgeo/0.1.0/Cargo.toml [INFO] started frobbing duckduckgeo-0.1.0 [INFO] finished frobbing duckduckgeo-0.1.0 [INFO] frobbed toml for duckduckgeo-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/duckduckgeo/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting duckduckgeo-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/duckduckgeo/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 00386f239a141dbdda5e278a36ef3d47fae58d4f5772179a74882689c99936f1 [INFO] running `"docker" "start" "-a" "00386f239a141dbdda5e278a36ef3d47fae58d4f5772179a74882689c99936f1"` [INFO] [stderr] Checking axgeom v1.0.5 [INFO] [stderr] Checking duckduckgeo v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:98:5 [INFO] [stderr] | [INFO] [stderr] 98 | return Ok(()) [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:125:5 [INFO] [stderr] | [INFO] [stderr] 125 | return Ok(()) [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:279:14 [INFO] [stderr] | [INFO] [stderr] 279 | }else{ [INFO] [stderr] | ______________^ [INFO] [stderr] 280 | | if ray.dir[1]==N::zero(){ [INFO] [stderr] 281 | | if ray.point[1]==line{ [INFO] [stderr] 282 | | Some(N::zero()) [INFO] [stderr] ... | [INFO] [stderr] 294 | | } [INFO] [stderr] 295 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 279 | }elseif ray.dir[1]==N::zero(){ [INFO] [stderr] 280 | if ray.point[1]==line{ [INFO] [stderr] 281 | Some(N::zero()) [INFO] [stderr] 282 | }else{ [INFO] [stderr] 283 | None [INFO] [stderr] 284 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:344:13 [INFO] [stderr] | [INFO] [stderr] 344 | return IntersectsBotResult::Hit(tmin); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `IntersectsBotResult::Hit(tmin)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:346:13 [INFO] [stderr] | [INFO] [stderr] 346 | return IntersectsBotResult::NoHit; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `IntersectsBotResult::NoHit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:310:14 [INFO] [stderr] | [INFO] [stderr] 310 | }else{ [INFO] [stderr] | ______________^ [INFO] [stderr] 311 | | if point[0] < x1 || point[0] > x2 { [INFO] [stderr] 312 | | return IntersectsBotResult::NoHit; // parallel AND outside box : no intersection possible [INFO] [stderr] 313 | | }else{ [INFO] [stderr] ... | [INFO] [stderr] 316 | | } [INFO] [stderr] 317 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 310 | }elseif point[0] < x1 || point[0] > x2 { [INFO] [stderr] 311 | return IntersectsBotResult::NoHit; // parallel AND outside box : no intersection possible [INFO] [stderr] 312 | }else{ [INFO] [stderr] 313 | return IntersectsBotResult::Hit(N::zero()) //TODO i think this is wrong? [INFO] [stderr] 314 | //(N::zero(),matt) [INFO] [stderr] 315 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:325:14 [INFO] [stderr] | [INFO] [stderr] 325 | }else{ [INFO] [stderr] | ______________^ [INFO] [stderr] 326 | | if point[1] < y1 || point[1] > y2 { [INFO] [stderr] 327 | | return IntersectsBotResult::NoHit; // parallel AND outside box : no intersection possible [INFO] [stderr] 328 | | }else{ [INFO] [stderr] 329 | | (tmin,tlen) [INFO] [stderr] 330 | | } [INFO] [stderr] 331 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 325 | }elseif point[1] < y1 || point[1] > y2 { [INFO] [stderr] 326 | return IntersectsBotResult::NoHit; // parallel AND outside box : no intersection possible [INFO] [stderr] 327 | }else{ [INFO] [stderr] 328 | (tmin,tlen) [INFO] [stderr] 329 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:98:5 [INFO] [stderr] | [INFO] [stderr] 98 | return Ok(()) [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:125:5 [INFO] [stderr] | [INFO] [stderr] 125 | return Ok(()) [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:279:14 [INFO] [stderr] | [INFO] [stderr] 279 | }else{ [INFO] [stderr] | ______________^ [INFO] [stderr] 280 | | if ray.dir[1]==N::zero(){ [INFO] [stderr] 281 | | if ray.point[1]==line{ [INFO] [stderr] 282 | | Some(N::zero()) [INFO] [stderr] ... | [INFO] [stderr] 294 | | } [INFO] [stderr] 295 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 279 | }elseif ray.dir[1]==N::zero(){ [INFO] [stderr] 280 | if ray.point[1]==line{ [INFO] [stderr] 281 | Some(N::zero()) [INFO] [stderr] 282 | }else{ [INFO] [stderr] 283 | None [INFO] [stderr] 284 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:344:13 [INFO] [stderr] | [INFO] [stderr] 344 | return IntersectsBotResult::Hit(tmin); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `IntersectsBotResult::Hit(tmin)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:346:13 [INFO] [stderr] | [INFO] [stderr] 346 | return IntersectsBotResult::NoHit; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `IntersectsBotResult::NoHit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:310:14 [INFO] [stderr] | [INFO] [stderr] 310 | }else{ [INFO] [stderr] | ______________^ [INFO] [stderr] 311 | | if point[0] < x1 || point[0] > x2 { [INFO] [stderr] 312 | | return IntersectsBotResult::NoHit; // parallel AND outside box : no intersection possible [INFO] [stderr] 313 | | }else{ [INFO] [stderr] ... | [INFO] [stderr] 316 | | } [INFO] [stderr] 317 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 310 | }elseif point[0] < x1 || point[0] > x2 { [INFO] [stderr] 311 | return IntersectsBotResult::NoHit; // parallel AND outside box : no intersection possible [INFO] [stderr] 312 | }else{ [INFO] [stderr] 313 | return IntersectsBotResult::Hit(N::zero()) //TODO i think this is wrong? [INFO] [stderr] 314 | //(N::zero(),matt) [INFO] [stderr] 315 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:325:14 [INFO] [stderr] | [INFO] [stderr] 325 | }else{ [INFO] [stderr] | ______________^ [INFO] [stderr] 326 | | if point[1] < y1 || point[1] > y2 { [INFO] [stderr] 327 | | return IntersectsBotResult::NoHit; // parallel AND outside box : no intersection possible [INFO] [stderr] 328 | | }else{ [INFO] [stderr] 329 | | (tmin,tlen) [INFO] [stderr] 330 | | } [INFO] [stderr] 331 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 325 | }elseif point[1] < y1 || point[1] > y2 { [INFO] [stderr] 326 | return IntersectsBotResult::NoHit; // parallel AND outside box : no intersection possible [INFO] [stderr] 327 | }else{ [INFO] [stderr] 328 | (tmin,tlen) [INFO] [stderr] 329 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.73s [INFO] running `"docker" "inspect" "00386f239a141dbdda5e278a36ef3d47fae58d4f5772179a74882689c99936f1"` [INFO] running `"docker" "rm" "-f" "00386f239a141dbdda5e278a36ef3d47fae58d4f5772179a74882689c99936f1"` [INFO] [stdout] 00386f239a141dbdda5e278a36ef3d47fae58d4f5772179a74882689c99936f1