[INFO] crate dua 1.1.0 is already in cache [INFO] extracting crate dua 1.1.0 into work/ex/clippy-test-run/sources/stable/reg/dua/1.1.0 [INFO] extracting crate dua 1.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dua/1.1.0 [INFO] validating manifest of dua-1.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dua-1.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dua-1.1.0 [INFO] finished frobbing dua-1.1.0 [INFO] frobbed toml for dua-1.1.0 written to work/ex/clippy-test-run/sources/stable/reg/dua/1.1.0/Cargo.toml [INFO] started frobbing dua-1.1.0 [INFO] finished frobbing dua-1.1.0 [INFO] frobbed toml for dua-1.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dua/1.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dua-1.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/dua/1.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2da2c350175859ca1cac402089bf8f37a5d17f452ce004fa01b82fecb41fea73 [INFO] running `"docker" "start" "-a" "2da2c350175859ca1cac402089bf8f37a5d17f452ce004fa01b82fecb41fea73"` [INFO] [stderr] Checking dua v1.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/displayer.rs:19:21 [INFO] [stderr] | [INFO] [stderr] 19 | Displayer { dt: dt, num: num, depth: depth } [INFO] [stderr] | ^^^^^^ help: replace it with: `dt` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/displayer.rs:19:29 [INFO] [stderr] | [INFO] [stderr] 19 | Displayer { dt: dt, num: num, depth: depth } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/displayer.rs:19:39 [INFO] [stderr] | [INFO] [stderr] 19 | Displayer { dt: dt, num: num, depth: depth } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `depth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/displayer.rs:19:21 [INFO] [stderr] | [INFO] [stderr] 19 | Displayer { dt: dt, num: num, depth: depth } [INFO] [stderr] | ^^^^^^ help: replace it with: `dt` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/displayer.rs:19:29 [INFO] [stderr] | [INFO] [stderr] 19 | Displayer { dt: dt, num: num, depth: depth } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/displayer.rs:19:39 [INFO] [stderr] | [INFO] [stderr] 19 | Displayer { dt: dt, num: num, depth: depth } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `depth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/du.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | return Entry(name, EntryData::File { size: m.len() }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Entry(name, EntryData::File { size: m.len() })` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/du.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | / return Entry(name, EntryData::Directory { [INFO] [stderr] 85 | | size: total_size, [INFO] [stderr] 86 | | children: v }); [INFO] [stderr] | |_______________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 84 | Entry(name, EntryData::Directory { [INFO] [stderr] 85 | size: total_size, [INFO] [stderr] 86 | children: v }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/du.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | return Entry(name, EntryData::Other); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Entry(name, EntryData::Other)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/du.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | return Entry(name, EntryData::File { size: m.len() }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Entry(name, EntryData::File { size: m.len() })` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/du.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | / return Entry(name, EntryData::Directory { [INFO] [stderr] 85 | | size: total_size, [INFO] [stderr] 86 | | children: v }); [INFO] [stderr] | |_______________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 84 | Entry(name, EntryData::Directory { [INFO] [stderr] 85 | size: total_size, [INFO] [stderr] 86 | children: v }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/du.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | return Entry(name, EntryData::Other); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Entry(name, EntryData::Other)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/displayer.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | / match data { [INFO] [stderr] 69 | | &EntryData::Directory{..} => { print!("/"); }, [INFO] [stderr] 70 | | &EntryData::OtherFs => { print!(" [X]"); }, [INFO] [stderr] 71 | | &EntryData::Other => { print!(" [?]"); }, [INFO] [stderr] ... | [INFO] [stderr] 81 | | _ => {} [INFO] [stderr] 82 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 68 | match *data { [INFO] [stderr] 69 | EntryData::Directory{..} => { print!("/"); }, [INFO] [stderr] 70 | EntryData::OtherFs => { print!(" [X]"); }, [INFO] [stderr] 71 | EntryData::Other => { print!(" [?]"); }, [INFO] [stderr] 72 | EntryData::Error(ref error) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/displayer.rs:94:21 [INFO] [stderr] | [INFO] [stderr] 94 | n = n-1; [INFO] [stderr] | ^^^^^^^ help: replace it with: `n -= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/du.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | / match data { [INFO] [stderr] 25 | | &EntryData::File{size} => size, [INFO] [stderr] 26 | | &EntryData::Directory{size, ..} => size, [INFO] [stderr] 27 | | _ => 0 [INFO] [stderr] 28 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 24 | match *data { [INFO] [stderr] 25 | EntryData::File{size} => size, [INFO] [stderr] 26 | EntryData::Directory{size, ..} => size, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/displayer.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | / match data { [INFO] [stderr] 69 | | &EntryData::Directory{..} => { print!("/"); }, [INFO] [stderr] 70 | | &EntryData::OtherFs => { print!(" [X]"); }, [INFO] [stderr] 71 | | &EntryData::Other => { print!(" [?]"); }, [INFO] [stderr] ... | [INFO] [stderr] 81 | | _ => {} [INFO] [stderr] 82 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 68 | match *data { [INFO] [stderr] 69 | EntryData::Directory{..} => { print!("/"); }, [INFO] [stderr] 70 | EntryData::OtherFs => { print!(" [X]"); }, [INFO] [stderr] 71 | EntryData::Other => { print!(" [?]"); }, [INFO] [stderr] 72 | EntryData::Error(ref error) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/displayer.rs:94:21 [INFO] [stderr] | [INFO] [stderr] 94 | n = n-1; [INFO] [stderr] | ^^^^^^^ help: replace it with: `n -= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/du.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | / match data { [INFO] [stderr] 25 | | &EntryData::File{size} => size, [INFO] [stderr] 26 | | &EntryData::Directory{size, ..} => size, [INFO] [stderr] 27 | | _ => 0 [INFO] [stderr] 28 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 24 | match *data { [INFO] [stderr] 25 | EntryData::File{size} => size, [INFO] [stderr] 26 | EntryData::Directory{size, ..} => size, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.86s [INFO] running `"docker" "inspect" "2da2c350175859ca1cac402089bf8f37a5d17f452ce004fa01b82fecb41fea73"` [INFO] running `"docker" "rm" "-f" "2da2c350175859ca1cac402089bf8f37a5d17f452ce004fa01b82fecb41fea73"` [INFO] [stdout] 2da2c350175859ca1cac402089bf8f37a5d17f452ce004fa01b82fecb41fea73