[INFO] crate dtree 0.1.0 is already in cache
[INFO] extracting crate dtree 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/dtree/0.1.0
[INFO] extracting crate dtree 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dtree/0.1.0
[INFO] validating manifest of dtree-0.1.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of dtree-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing dtree-0.1.0
[INFO] finished frobbing dtree-0.1.0
[INFO] frobbed toml for dtree-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/dtree/0.1.0/Cargo.toml
[INFO] started frobbing dtree-0.1.0
[INFO] finished frobbing dtree-0.1.0
[INFO] frobbed toml for dtree-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dtree/0.1.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting dtree-0.1.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/dtree/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 86eabb7f131efd2fa0bceb06888665ac1a7d0658e76c19a913fd0a71ea2f7437
[INFO] running `"docker" "start" "-a" "86eabb7f131efd2fa0bceb06888665ac1a7d0658e76c19a913fd0a71ea2f7437"`
[INFO] [stderr]     Checking dtree v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parser.rs:21:9
[INFO] [stderr]    |
[INFO] [stderr] 21 | /         return self.parent == other.parent && self.description == other.description &&
[INFO] [stderr] 22 | |             self.opt_name == other.opt_name && self.dest == other.dest;
[INFO] [stderr]    | |_______________________________________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 21 |         self.parent == other.parent && self.description == other.description &&
[INFO] [stderr] 22 |             self.opt_name == other.opt_name && self.dest == other.dest
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parser.rs:34:9
[INFO] [stderr]    |
[INFO] [stderr] 34 |         return self.description == other.description && self.name == other.name;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.description == other.description && self.name == other.name`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parser.rs:57:5
[INFO] [stderr]    |
[INFO] [stderr] 57 |     return IResult::Done(&input_u8[bytes_i..], &input[0..bytes_i - last_size + 1])
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `IResult::Done(&input_u8[bytes_i..], &input[0..bytes_i - last_size + 1])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]   --> src/parser.rs:49:12
[INFO] [stderr]    |
[INFO] [stderr] 49 |         if (!c.is_alphabetic() && !c.is_numeric() && c != '_' && c != '-') {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:126:5
[INFO] [stderr]     |
[INFO] [stderr] 126 |     return IResult::Done(&b""[..], s);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `IResult::Done(&b""[..], s)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:244:5
[INFO] [stderr]     |
[INFO] [stderr] 244 |     return IResult::Done(in_mut, Tree { sections });
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `IResult::Done(in_mut, Tree { sections })`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:252:32
[INFO] [stderr]     |
[INFO] [stderr] 252 |         IResult::Done(_, t) => return Result::Ok(t),
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Result::Ok(t)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:253:30
[INFO] [stderr]     |
[INFO] [stderr] 253 |         IResult::Error(e) => return Result::Err(Box::new(e)),
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Result::Err(Box::new(e))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:254:35
[INFO] [stderr]     |
[INFO] [stderr] 254 |         IResult::Incomplete(i) => return Result::Err(Box::new(i))
[INFO] [stderr]     |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Result::Err(Box::new(i))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parser.rs:21:9
[INFO] [stderr]    |
[INFO] [stderr] 21 | /         return self.parent == other.parent && self.description == other.description &&
[INFO] [stderr] 22 | |             self.opt_name == other.opt_name && self.dest == other.dest;
[INFO] [stderr]    | |_______________________________________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 21 |         self.parent == other.parent && self.description == other.description &&
[INFO] [stderr] 22 |             self.opt_name == other.opt_name && self.dest == other.dest
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parser.rs:34:9
[INFO] [stderr]    |
[INFO] [stderr] 34 |         return self.description == other.description && self.name == other.name;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.description == other.description && self.name == other.name`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parser.rs:57:5
[INFO] [stderr]    |
[INFO] [stderr] 57 |     return IResult::Done(&input_u8[bytes_i..], &input[0..bytes_i - last_size + 1])
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `IResult::Done(&input_u8[bytes_i..], &input[0..bytes_i - last_size + 1])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]   --> src/parser.rs:49:12
[INFO] [stderr]    |
[INFO] [stderr] 49 |         if (!c.is_alphabetic() && !c.is_numeric() && c != '_' && c != '-') {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:126:5
[INFO] [stderr]     |
[INFO] [stderr] 126 |     return IResult::Done(&b""[..], s);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `IResult::Done(&b""[..], s)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:244:5
[INFO] [stderr]     |
[INFO] [stderr] 244 |     return IResult::Done(in_mut, Tree { sections });
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `IResult::Done(in_mut, Tree { sections })`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:252:32
[INFO] [stderr]     |
[INFO] [stderr] 252 |         IResult::Done(_, t) => return Result::Ok(t),
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Result::Ok(t)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:253:30
[INFO] [stderr]     |
[INFO] [stderr] 253 |         IResult::Error(e) => return Result::Err(Box::new(e)),
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Result::Err(Box::new(e))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:254:35
[INFO] [stderr]     |
[INFO] [stderr] 254 |         IResult::Incomplete(i) => return Result::Err(Box::new(i))
[INFO] [stderr]     |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Result::Err(Box::new(i))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/parser.rs:57:55
[INFO] [stderr]    |
[INFO] [stderr] 57 |     return IResult::Done(&input_u8[bytes_i..], &input[0..bytes_i - last_size + 1])
[INFO] [stderr]    |                                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=bytes_i - last_size`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]    --> src/parser.rs:97:5
[INFO] [stderr]     |
[INFO] [stderr] 97  | /     loop {
[INFO] [stderr] 98  | |
[INFO] [stderr] 99  | |         let c = match iter.next() {
[INFO] [stderr] 100 | |             Some(n) => n,
[INFO] [stderr] ...   |
[INFO] [stderr] 123 | |         s.push(c);
[INFO] [stderr] 124 | |     }
[INFO] [stderr]     | |_____^ help: try: `while let Some(n) = iter.next() { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/parser.rs:57:55
[INFO] [stderr]    |
[INFO] [stderr] 57 |     return IResult::Done(&input_u8[bytes_i..], &input[0..bytes_i - last_size + 1])
[INFO] [stderr]    |                                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=bytes_i - last_size`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]    --> src/parser.rs:97:5
[INFO] [stderr]     |
[INFO] [stderr] 97  | /     loop {
[INFO] [stderr] 98  | |
[INFO] [stderr] 99  | |         let c = match iter.next() {
[INFO] [stderr] 100 | |             Some(n) => n,
[INFO] [stderr] ...   |
[INFO] [stderr] 123 | |         s.push(c);
[INFO] [stderr] 124 | |     }
[INFO] [stderr]     | |_____^ help: try: `while let Some(n) = iter.next() { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/bin.rs:56:41
[INFO] [stderr]    |
[INFO] [stderr] 56 |                 &(String::from("\n") + &String::from(" ".repeat(name.len() + 3))) ));
[INFO] [stderr]    |                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `" ".repeat(name.len() + 3)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/bin.rs:68:9
[INFO] [stderr]    |
[INFO] [stderr] 68 | /         match current_section.mappings.get(&input) {
[INFO] [stderr] 69 | |             Some(mapping) => {
[INFO] [stderr] 70 | |                 current_section = match dtree.sections.get(&mapping.to) {
[INFO] [stderr] 71 | |                     Some(n) => n,
[INFO] [stderr] ...  |
[INFO] [stderr] 75 | |             None => {}
[INFO] [stderr] 76 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 68 |         if let Some(mapping) = current_section.mappings.get(&input) {
[INFO] [stderr] 69 |     current_section = match dtree.sections.get(&mapping.to) {
[INFO] [stderr] 70 |         Some(n) => n,
[INFO] [stderr] 71 |         None => panic!("Internal error: invalid to reference")
[INFO] [stderr] 72 |     };
[INFO] [stderr] 73 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/bin.rs:56:41
[INFO] [stderr]    |
[INFO] [stderr] 56 |                 &(String::from("\n") + &String::from(" ".repeat(name.len() + 3))) ));
[INFO] [stderr]    |                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `" ".repeat(name.len() + 3)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/bin.rs:68:9
[INFO] [stderr]    |
[INFO] [stderr] 68 | /         match current_section.mappings.get(&input) {
[INFO] [stderr] 69 | |             Some(mapping) => {
[INFO] [stderr] 70 | |                 current_section = match dtree.sections.get(&mapping.to) {
[INFO] [stderr] 71 | |                     Some(n) => n,
[INFO] [stderr] ...  |
[INFO] [stderr] 75 | |             None => {}
[INFO] [stderr] 76 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 68 |         if let Some(mapping) = current_section.mappings.get(&input) {
[INFO] [stderr] 69 |     current_section = match dtree.sections.get(&mapping.to) {
[INFO] [stderr] 70 |         Some(n) => n,
[INFO] [stderr] 71 |         None => panic!("Internal error: invalid to reference")
[INFO] [stderr] 72 |     };
[INFO] [stderr] 73 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.73s
[INFO] running `"docker" "inspect" "86eabb7f131efd2fa0bceb06888665ac1a7d0658e76c19a913fd0a71ea2f7437"`
[INFO] running `"docker" "rm" "-f" "86eabb7f131efd2fa0bceb06888665ac1a7d0658e76c19a913fd0a71ea2f7437"`
[INFO] [stdout] 86eabb7f131efd2fa0bceb06888665ac1a7d0658e76c19a913fd0a71ea2f7437