[INFO] crate ds1307 0.2.0 is already in cache [INFO] extracting crate ds1307 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/ds1307/0.2.0 [INFO] extracting crate ds1307 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ds1307/0.2.0 [INFO] validating manifest of ds1307-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ds1307-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ds1307-0.2.0 [INFO] finished frobbing ds1307-0.2.0 [INFO] frobbed toml for ds1307-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/ds1307/0.2.0/Cargo.toml [INFO] started frobbing ds1307-0.2.0 [INFO] finished frobbing ds1307-0.2.0 [INFO] frobbed toml for ds1307-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ds1307/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ds1307-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ds1307/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bc4375ab953b23d812bbec4667ebeb58047e9310d4e9d3764cb46d310a21396a [INFO] running `"docker" "start" "-a" "bc4375ab953b23d812bbec4667ebeb58047e9310d4e9d3764cb46d310a21396a"` [INFO] [stderr] Checking embedded-hal v0.2.2 [INFO] [stderr] Checking nix v0.6.0 [INFO] [stderr] Checking sysfs_gpio v0.5.3 [INFO] [stderr] Checking embedded-hal-mock v0.2.0 [INFO] [stderr] Checking ds1307 v0.2.0 (/opt/crater/workdir) [INFO] [stderr] error: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/datetime.rs:91:19 [INFO] [stderr] | [INFO] [stderr] 91 | Ok(2000 + (year as u16)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(year)` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/datetime.rs:4:9 [INFO] [stderr] | [INFO] [stderr] 4 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::cast_lossless)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/datetime.rs:101:29 [INFO] [stderr] | [INFO] [stderr] 101 | year: 2000 + (packed_bcd_to_decimal(data[Register::YEAR as usize]) as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(packed_bcd_to_decimal(data[Register::YEAR as usize]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/run.rs:14:23 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn is_running(&mut self) -> Result> { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/run.rs:3:9 [INFO] [stderr] | [INFO] [stderr] 3 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::wrong_self_convention)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] error: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/square_wave.rs:24:42 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn is_square_wave_output_enabled(&mut self) -> Result> { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/square_wave.rs:4:9 [INFO] [stderr] | [INFO] [stderr] 4 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] error: manual implementation of an assign operation [INFO] [stderr] --> src/square_wave.rs:85:17 [INFO] [stderr] | [INFO] [stderr] 85 | data = data | BitFlags::OUTRATERS0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data |= BitFlags::OUTRATERS0` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/square_wave.rs:4:9 [INFO] [stderr] | [INFO] [stderr] 4 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::assign_op_pattern)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: manual implementation of an assign operation [INFO] [stderr] --> src/square_wave.rs:88:17 [INFO] [stderr] | [INFO] [stderr] 88 | data = data | BitFlags::OUTRATERS1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data |= BitFlags::OUTRATERS1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:230:34 [INFO] [stderr] | [INFO] [stderr] 230 | fn is_register_bit_flag_high(&mut self, address: u8, bitmask: u8) -> Result> { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:155:9 [INFO] [stderr] | [INFO] [stderr] 155 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] error: aborting due to 7 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `ds1307`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "bc4375ab953b23d812bbec4667ebeb58047e9310d4e9d3764cb46d310a21396a"` [INFO] running `"docker" "rm" "-f" "bc4375ab953b23d812bbec4667ebeb58047e9310d4e9d3764cb46d310a21396a"` [INFO] [stdout] bc4375ab953b23d812bbec4667ebeb58047e9310d4e9d3764cb46d310a21396a