[INFO] crate dropbox-dir 1.0.0 is already in cache [INFO] extracting crate dropbox-dir 1.0.0 into work/ex/clippy-test-run/sources/stable/reg/dropbox-dir/1.0.0 [INFO] extracting crate dropbox-dir 1.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dropbox-dir/1.0.0 [INFO] validating manifest of dropbox-dir-1.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dropbox-dir-1.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dropbox-dir-1.0.0 [INFO] finished frobbing dropbox-dir-1.0.0 [INFO] frobbed toml for dropbox-dir-1.0.0 written to work/ex/clippy-test-run/sources/stable/reg/dropbox-dir/1.0.0/Cargo.toml [INFO] started frobbing dropbox-dir-1.0.0 [INFO] finished frobbing dropbox-dir-1.0.0 [INFO] frobbed toml for dropbox-dir-1.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dropbox-dir/1.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dropbox-dir-1.0.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/dropbox-dir/1.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0d5ab81278bb2012f5a799d59335b770fdc85979c5f08523a1004118a1a691f3 [INFO] running `"docker" "start" "-a" "0d5ab81278bb2012f5a799d59335b770fdc85979c5f08523a1004118a1a691f3"` [INFO] [stderr] Checking dropbox-dir v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:140:13 [INFO] [stderr] | [INFO] [stderr] 140 | target: target, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `target` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:140:13 [INFO] [stderr] | [INFO] [stderr] 140 | target: target, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `target` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/lib.rs:14:22 [INFO] [stderr] | [INFO] [stderr] 14 | let home = match env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/lib.rs:14:22 [INFO] [stderr] | [INFO] [stderr] 14 | let home = match env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/bin.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | / let mut exit_status = 0; [INFO] [stderr] 53 | | if !mode_business { [INFO] [stderr] 54 | | let prefix = if mode_all { "personal: " } else { "" }; [INFO] [stderr] 55 | | exit_status = print_path(prefix, SmartPath::new_personal(added_path)); [INFO] [stderr] 56 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let exit_status = if !mode_business { ..; print_path(prefix, SmartPath::new_personal(added_path)) } else { 0 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/bin.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | / let mut exit_status = 0; [INFO] [stderr] 53 | | if !mode_business { [INFO] [stderr] 54 | | let prefix = if mode_all { "personal: " } else { "" }; [INFO] [stderr] 55 | | exit_status = print_path(prefix, SmartPath::new_personal(added_path)); [INFO] [stderr] 56 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let exit_status = if !mode_business { ..; print_path(prefix, SmartPath::new_personal(added_path)) } else { 0 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.07s [INFO] running `"docker" "inspect" "0d5ab81278bb2012f5a799d59335b770fdc85979c5f08523a1004118a1a691f3"` [INFO] running `"docker" "rm" "-f" "0d5ab81278bb2012f5a799d59335b770fdc85979c5f08523a1004118a1a691f3"` [INFO] [stdout] 0d5ab81278bb2012f5a799d59335b770fdc85979c5f08523a1004118a1a691f3