[INFO] crate drm-macros 0.0.1 is already in cache [INFO] extracting crate drm-macros 0.0.1 into work/ex/clippy-test-run/sources/stable/reg/drm-macros/0.0.1 [INFO] extracting crate drm-macros 0.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/drm-macros/0.0.1 [INFO] validating manifest of drm-macros-0.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of drm-macros-0.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing drm-macros-0.0.1 [INFO] finished frobbing drm-macros-0.0.1 [INFO] frobbed toml for drm-macros-0.0.1 written to work/ex/clippy-test-run/sources/stable/reg/drm-macros/0.0.1/Cargo.toml [INFO] started frobbing drm-macros-0.0.1 [INFO] finished frobbing drm-macros-0.0.1 [INFO] frobbed toml for drm-macros-0.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/drm-macros/0.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting drm-macros-0.0.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/drm-macros/0.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 37822aaf58c2d4ec53cf377a8d3fc80c2fbc3241091761d25a9d3fb74135ac24 [INFO] running `"docker" "start" "-a" "37822aaf58c2d4ec53cf377a8d3fc80c2fbc3241091761d25a9d3fb74135ac24"` [INFO] [stderr] Checking drm-macros v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `ty` [INFO] [stderr] --> src/lib.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | let ty = syn::Ident::new(get_attr(&ast.attrs, "HandleType")); [INFO] [stderr] | ^^ help: consider using `_ty` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:10:10 [INFO] [stderr] | [INFO] [stderr] 10 | .expect(format!("Requires '{}' attribute", name).as_str()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Requires '{}' attribute", name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:12:15 [INFO] [stderr] | [INFO] [stderr] 12 | let lit = match &attr.value { [INFO] [stderr] | _______________^ [INFO] [stderr] 13 | | &syn::MetaItem::NameValue(_, ref lit) => lit, [INFO] [stderr] 14 | | _ => panic!("Invalid attribute meta item") [INFO] [stderr] 15 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 12 | let lit = match attr.value { [INFO] [stderr] 13 | syn::MetaItem::NameValue(_, ref lit) => lit, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / match lit { [INFO] [stderr] 18 | | &syn::Lit::Str(ref val, _) => val.clone(), [INFO] [stderr] 19 | | _ => panic!("Invalid attribute value type") [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 17 | match *lit { [INFO] [stderr] 18 | syn::Lit::Str(ref val, _) => val.clone(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ty` [INFO] [stderr] --> src/lib.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | let ty = syn::Ident::new(get_attr(&ast.attrs, "HandleType")); [INFO] [stderr] | ^^ help: consider using `_ty` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:10:10 [INFO] [stderr] | [INFO] [stderr] 10 | .expect(format!("Requires '{}' attribute", name).as_str()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Requires '{}' attribute", name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:12:15 [INFO] [stderr] | [INFO] [stderr] 12 | let lit = match &attr.value { [INFO] [stderr] | _______________^ [INFO] [stderr] 13 | | &syn::MetaItem::NameValue(_, ref lit) => lit, [INFO] [stderr] 14 | | _ => panic!("Invalid attribute meta item") [INFO] [stderr] 15 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 12 | let lit = match attr.value { [INFO] [stderr] 13 | syn::MetaItem::NameValue(_, ref lit) => lit, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / match lit { [INFO] [stderr] 18 | | &syn::Lit::Str(ref val, _) => val.clone(), [INFO] [stderr] 19 | | _ => panic!("Invalid attribute value type") [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 17 | match *lit { [INFO] [stderr] 18 | syn::Lit::Str(ref val, _) => val.clone(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.11s [INFO] running `"docker" "inspect" "37822aaf58c2d4ec53cf377a8d3fc80c2fbc3241091761d25a9d3fb74135ac24"` [INFO] running `"docker" "rm" "-f" "37822aaf58c2d4ec53cf377a8d3fc80c2fbc3241091761d25a9d3fb74135ac24"` [INFO] [stdout] 37822aaf58c2d4ec53cf377a8d3fc80c2fbc3241091761d25a9d3fb74135ac24