[INFO] crate drill 0.4.1 is already in cache [INFO] extracting crate drill 0.4.1 into work/ex/clippy-test-run/sources/stable/reg/drill/0.4.1 [INFO] extracting crate drill 0.4.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/drill/0.4.1 [INFO] validating manifest of drill-0.4.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of drill-0.4.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing drill-0.4.1 [INFO] finished frobbing drill-0.4.1 [INFO] frobbed toml for drill-0.4.1 written to work/ex/clippy-test-run/sources/stable/reg/drill/0.4.1/Cargo.toml [INFO] started frobbing drill-0.4.1 [INFO] finished frobbing drill-0.4.1 [INFO] frobbed toml for drill-0.4.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/drill/0.4.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting drill-0.4.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/drill/0.4.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 64d4c90d0a552754f112af23b446f14667a5d6b7b3cecafc9cefb7e77f4e974c [INFO] running `"docker" "start" "-a" "64d4c90d0a552754f112af23b446f14667a5d6b7b3cecafc9cefb7e77f4e974c"` [INFO] [stderr] Checking drill v0.4.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:30:7 [INFO] [stderr] | [INFO] [stderr] 30 | base: base, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `base` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:31:7 [INFO] [stderr] | [INFO] [stderr] 31 | threads: threads, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `threads` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:32:7 [INFO] [stderr] | [INFO] [stderr] 32 | iterations: iterations, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `iterations` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:33:7 [INFO] [stderr] | [INFO] [stderr] 33 | no_check_certificate: no_check_certificate, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `no_check_certificate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:34:7 [INFO] [stderr] | [INFO] [stderr] 34 | rampup: rampup, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `rampup` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpolator.rs:16:7 [INFO] [stderr] | [INFO] [stderr] 16 | context: context, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `context` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpolator.rs:17:7 [INFO] [stderr] | [INFO] [stderr] 17 | responses: responses [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `responses` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/benchmark.rs:59:3 [INFO] [stderr] | [INFO] [stderr] 59 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/checker.rs:37:3 [INFO] [stderr] | [INFO] [stderr] 37 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/actions/request.rs:67:7 [INFO] [stderr] | [INFO] [stderr] 67 | method: method, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `method` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/actions/request.rs:68:7 [INFO] [stderr] | [INFO] [stderr] 68 | headers: headers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `headers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/actions/request.rs:70:7 [INFO] [stderr] | [INFO] [stderr] 70 | with_item: with_item, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `with_item` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/expandable/include.rs:34:31 [INFO] [stderr] | [INFO] [stderr] 34 | println!("{} {}", "Node missing on config:", accessor_id); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/expandable/include.rs:35:28 [INFO] [stderr] | [INFO] [stderr] 35 | println!("{}", "Exiting."); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:121:3 [INFO] [stderr] | [INFO] [stderr] 121 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:30:7 [INFO] [stderr] | [INFO] [stderr] 30 | base: base, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `base` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:31:7 [INFO] [stderr] | [INFO] [stderr] 31 | threads: threads, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `threads` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:32:7 [INFO] [stderr] | [INFO] [stderr] 32 | iterations: iterations, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `iterations` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:33:7 [INFO] [stderr] | [INFO] [stderr] 33 | no_check_certificate: no_check_certificate, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `no_check_certificate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:34:7 [INFO] [stderr] | [INFO] [stderr] 34 | rampup: rampup, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `rampup` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpolator.rs:16:7 [INFO] [stderr] | [INFO] [stderr] 16 | context: context, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `context` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpolator.rs:17:7 [INFO] [stderr] | [INFO] [stderr] 17 | responses: responses [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `responses` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/benchmark.rs:59:3 [INFO] [stderr] | [INFO] [stderr] 59 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/checker.rs:37:3 [INFO] [stderr] | [INFO] [stderr] 37 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/actions/request.rs:67:7 [INFO] [stderr] | [INFO] [stderr] 67 | method: method, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `method` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/actions/request.rs:68:7 [INFO] [stderr] | [INFO] [stderr] 68 | headers: headers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `headers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/actions/request.rs:70:7 [INFO] [stderr] | [INFO] [stderr] 70 | with_item: with_item, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `with_item` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/expandable/include.rs:34:31 [INFO] [stderr] | [INFO] [stderr] 34 | println!("{} {}", "Node missing on config:", accessor_id); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/expandable/include.rs:35:28 [INFO] [stderr] | [INFO] [stderr] 35 | println!("{}", "Exiting."); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:121:3 [INFO] [stderr] | [INFO] [stderr] 121 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/interpolator.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | return Some(value[cap_tail[0]].to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(value[cap_tail[0]].to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:53:3 [INFO] [stderr] | [INFO] [stderr] 53 | / return App::new("drill") [INFO] [stderr] 54 | | .version(crate_version!()) [INFO] [stderr] 55 | | .about("HTTP load testing application written in Rust inspired by Ansible syntax") [INFO] [stderr] 56 | | .arg(Arg::with_name("benchmark") [INFO] [stderr] ... | [INFO] [stderr] 89 | | .takes_value(false)) [INFO] [stderr] 90 | | .get_matches(); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 53 | App::new("drill") [INFO] [stderr] 54 | .version(crate_version!()) [INFO] [stderr] 55 | .about("HTTP load testing application written in Rust inspired by Ansible syntax") [INFO] [stderr] 56 | .arg(Arg::with_name("benchmark") [INFO] [stderr] 57 | .help("Sets the benchmark file") [INFO] [stderr] 58 | .long("benchmark") [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/interpolator.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | return Some(value[cap_tail[0]].to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(value[cap_tail[0]].to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:53:3 [INFO] [stderr] | [INFO] [stderr] 53 | / return App::new("drill") [INFO] [stderr] 54 | | .version(crate_version!()) [INFO] [stderr] 55 | | .about("HTTP load testing application written in Rust inspired by Ansible syntax") [INFO] [stderr] 56 | | .arg(Arg::with_name("benchmark") [INFO] [stderr] ... | [INFO] [stderr] 89 | | .takes_value(false)) [INFO] [stderr] 90 | | .get_matches(); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 53 | App::new("drill") [INFO] [stderr] 54 | .version(crate_version!()) [INFO] [stderr] 55 | .about("HTTP load testing application written in Rust inspired by Ansible syntax") [INFO] [stderr] 56 | .arg(Arg::with_name("benchmark") [INFO] [stderr] 57 | .help("Sets the benchmark file") [INFO] [stderr] 58 | .long("benchmark") [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/interpolator.rs:21:30 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn resolve(&self, url: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/benchmark.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | Err(_) => panic!("arrrgh"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/reader.rs:22:3 [INFO] [stderr] | [INFO] [stderr] 22 | / match file.read_to_string(&mut content) { [INFO] [stderr] 23 | | Err(why) => panic!("couldn't read {}: {}", display, why), [INFO] [stderr] 24 | | Ok(_) => {}, [INFO] [stderr] 25 | | } [INFO] [stderr] | |___^ help: try this: `if let Err(why) = file.read_to_string(&mut content) { panic!("couldn't read {}: {}", display, why) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/checker.rs:10:30 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn compare(list_reports: &Vec>, filepath: &str, threshold: &str) -> Result<(), i32> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/checker.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | Err(_) => panic!("arrrgh"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/interpolator.rs:21:30 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn resolve(&self, url: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/actions/request.rs:170:47 [INFO] [stderr] | [INFO] [stderr] 170 | let value = String::from(cookie.split(";").next().unwrap()); [INFO] [stderr] | ^^^ help: try using a char instead: `';'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:93:30 [INFO] [stderr] | [INFO] [stderr] 93 | fn show_stats (list_reports: &Vec>, stats_option: bool, duration: f64) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:99:45 [INFO] [stderr] | [INFO] [stderr] 99 | group_by_status.entry(req.status / 100).or_insert(Vec::new()).push(req); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:117:54 [INFO] [stderr] | [INFO] [stderr] 117 | let successful_requests = group_by_status.entry(2).or_insert(Vec::new()).len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/benchmark.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | Err(_) => panic!("arrrgh"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/reader.rs:22:3 [INFO] [stderr] | [INFO] [stderr] 22 | / match file.read_to_string(&mut content) { [INFO] [stderr] 23 | | Err(why) => panic!("couldn't read {}: {}", display, why), [INFO] [stderr] 24 | | Ok(_) => {}, [INFO] [stderr] 25 | | } [INFO] [stderr] | |___^ help: try this: `if let Err(why) = file.read_to_string(&mut content) { panic!("couldn't read {}: {}", display, why) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:133:37 [INFO] [stderr] | [INFO] [stderr] 133 | fn compare_benchmark (list_reports: &Vec>, compare_path_option: Option<&str>, threshold_option: Option<&str>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/checker.rs:10:30 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn compare(list_reports: &Vec>, filepath: &str, threshold: &str) -> Result<(), i32> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/checker.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | Err(_) => panic!("arrrgh"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/actions/request.rs:170:47 [INFO] [stderr] | [INFO] [stderr] 170 | let value = String::from(cookie.split(";").next().unwrap()); [INFO] [stderr] | ^^^ help: try using a char instead: `';'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:93:30 [INFO] [stderr] | [INFO] [stderr] 93 | fn show_stats (list_reports: &Vec>, stats_option: bool, duration: f64) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:99:45 [INFO] [stderr] | [INFO] [stderr] 99 | group_by_status.entry(req.status / 100).or_insert(Vec::new()).push(req); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:117:54 [INFO] [stderr] | [INFO] [stderr] 117 | let successful_requests = group_by_status.entry(2).or_insert(Vec::new()).len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:133:37 [INFO] [stderr] | [INFO] [stderr] 133 | fn compare_benchmark (list_reports: &Vec>, compare_path_option: Option<&str>, threshold_option: Option<&str>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.39s [INFO] running `"docker" "inspect" "64d4c90d0a552754f112af23b446f14667a5d6b7b3cecafc9cefb7e77f4e974c"` [INFO] running `"docker" "rm" "-f" "64d4c90d0a552754f112af23b446f14667a5d6b7b3cecafc9cefb7e77f4e974c"` [INFO] [stdout] 64d4c90d0a552754f112af23b446f14667a5d6b7b3cecafc9cefb7e77f4e974c