[INFO] crate draw_queue 0.1.1 is already in cache [INFO] extracting crate draw_queue 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/draw_queue/0.1.1 [INFO] extracting crate draw_queue 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/draw_queue/0.1.1 [INFO] validating manifest of draw_queue-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of draw_queue-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing draw_queue-0.1.1 [INFO] finished frobbing draw_queue-0.1.1 [INFO] frobbed toml for draw_queue-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/draw_queue/0.1.1/Cargo.toml [INFO] started frobbing draw_queue-0.1.1 [INFO] finished frobbing draw_queue-0.1.1 [INFO] frobbed toml for draw_queue-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/draw_queue/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting draw_queue-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/draw_queue/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fa221713223fc8754d04d37b1dc33310c0577ff4ef88ff3e618b2f91f8b788e7 [INFO] running `"docker" "start" "-a" "fa221713223fc8754d04d37b1dc33310c0577ff4ef88ff3e618b2f91f8b788e7"` [INFO] [stderr] Checking draw_queue v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> lib.rs:52:10 [INFO] [stderr] | [INFO] [stderr] 52 | }else [INFO] [stderr] | __________^ [INFO] [stderr] 53 | | if self.objects.len() < ni { [INFO] [stderr] | |________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::suspicious_else_formatting)] on by default [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> lib.rs:52:10 [INFO] [stderr] | [INFO] [stderr] 52 | }else [INFO] [stderr] | __________^ [INFO] [stderr] 53 | | if self.objects.len() < ni { [INFO] [stderr] | |________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::suspicious_else_formatting)] on by default [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Queue` [INFO] [stderr] --> lib.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / pub fn new() -> Queue { [INFO] [stderr] 35 | | Queue { [INFO] [stderr] 36 | | objects: Vec::new(), [INFO] [stderr] 37 | | indices: Vec::new(), [INFO] [stderr] 38 | | } [INFO] [stderr] 39 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 26 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> lib.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | / pub fn iter<'a>(&'a self) -> QueueIter<'a, T> { [INFO] [stderr] 71 | | assert!(self.is_ready()); [INFO] [stderr] 72 | | QueueIter { [INFO] [stderr] 73 | | objects: &self.objects, [INFO] [stderr] 74 | | id_iter: self.indices.iter(), [INFO] [stderr] 75 | | } [INFO] [stderr] 76 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Queue` [INFO] [stderr] --> lib.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / pub fn new() -> Queue { [INFO] [stderr] 35 | | Queue { [INFO] [stderr] 36 | | objects: Vec::new(), [INFO] [stderr] 37 | | indices: Vec::new(), [INFO] [stderr] 38 | | } [INFO] [stderr] 39 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 26 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> lib.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | / pub fn iter<'a>(&'a self) -> QueueIter<'a, T> { [INFO] [stderr] 71 | | assert!(self.is_ready()); [INFO] [stderr] 72 | | QueueIter { [INFO] [stderr] 73 | | objects: &self.objects, [INFO] [stderr] 74 | | id_iter: self.indices.iter(), [INFO] [stderr] 75 | | } [INFO] [stderr] 76 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.95s [INFO] running `"docker" "inspect" "fa221713223fc8754d04d37b1dc33310c0577ff4ef88ff3e618b2f91f8b788e7"` [INFO] running `"docker" "rm" "-f" "fa221713223fc8754d04d37b1dc33310c0577ff4ef88ff3e618b2f91f8b788e7"` [INFO] [stdout] fa221713223fc8754d04d37b1dc33310c0577ff4ef88ff3e618b2f91f8b788e7