[INFO] crate download_sdl2 0.0.3 is already in cache [INFO] extracting crate download_sdl2 0.0.3 into work/ex/clippy-test-run/sources/stable/reg/download_sdl2/0.0.3 [INFO] extracting crate download_sdl2 0.0.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/download_sdl2/0.0.3 [INFO] validating manifest of download_sdl2-0.0.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of download_sdl2-0.0.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing download_sdl2-0.0.3 [INFO] finished frobbing download_sdl2-0.0.3 [INFO] frobbed toml for download_sdl2-0.0.3 written to work/ex/clippy-test-run/sources/stable/reg/download_sdl2/0.0.3/Cargo.toml [INFO] started frobbing download_sdl2-0.0.3 [INFO] finished frobbing download_sdl2-0.0.3 [INFO] frobbed toml for download_sdl2-0.0.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/download_sdl2/0.0.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting download_sdl2-0.0.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/download_sdl2/0.0.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 445a54f9069be4a3f7be2f4d63a946ee746f1c22a980f47712215743268b324f [INFO] running `"docker" "start" "-a" "445a54f9069be4a3f7be2f4d63a946ee746f1c22a980f47712215743268b324f"` [INFO] [stderr] Checking zip v0.3.3 [INFO] [stderr] Checking download_sdl2 v0.0.3 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:22:22 [INFO] [stderr] | [INFO] [stderr] 22 | const SDL2_VERSION: &'static str = "2.0.8"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:23:28 [INFO] [stderr] | [INFO] [stderr] 23 | const SDL2_IMAGE_VERSION: &'static str = "2.0.3"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:24:26 [INFO] [stderr] | [INFO] [stderr] 24 | const SDL2_TTF_VERSION: &'static str = "2.0.14"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:22:22 [INFO] [stderr] | [INFO] [stderr] 22 | const SDL2_VERSION: &'static str = "2.0.8"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:23:28 [INFO] [stderr] | [INFO] [stderr] 23 | const SDL2_IMAGE_VERSION: &'static str = "2.0.3"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:24:26 [INFO] [stderr] | [INFO] [stderr] 24 | const SDL2_TTF_VERSION: &'static str = "2.0.14"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/lib.rs:209:45 [INFO] [stderr] | [INFO] [stderr] 209 | for &(ref url, label, dir) in downloads.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/lib.rs:216:9 [INFO] [stderr] | [INFO] [stderr] 216 | zipfile.extension().map(|ext| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 217 | || // println!("ext: {:?}", ext); [INFO] [stderr] 218 | || if ext == OsStr::new("zip") { [INFO] [stderr] 219 | || let _ = unzip_file(&zipfile, &target_dir); [INFO] [stderr] ... || [INFO] [stderr] 222 | || } [INFO] [stderr] 223 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(ext) = zipfile.extension() { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `download_sdl2`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/lib.rs:209:45 [INFO] [stderr] | [INFO] [stderr] 209 | for &(ref url, label, dir) in downloads.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/lib.rs:216:9 [INFO] [stderr] | [INFO] [stderr] 216 | zipfile.extension().map(|ext| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 217 | || // println!("ext: {:?}", ext); [INFO] [stderr] 218 | || if ext == OsStr::new("zip") { [INFO] [stderr] 219 | || let _ = unzip_file(&zipfile, &target_dir); [INFO] [stderr] ... || [INFO] [stderr] 222 | || } [INFO] [stderr] 223 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(ext) = zipfile.extension() { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `download_sdl2`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "445a54f9069be4a3f7be2f4d63a946ee746f1c22a980f47712215743268b324f"` [INFO] running `"docker" "rm" "-f" "445a54f9069be4a3f7be2f4d63a946ee746f1c22a980f47712215743268b324f"` [INFO] [stdout] 445a54f9069be4a3f7be2f4d63a946ee746f1c22a980f47712215743268b324f