[INFO] crate double 0.2.2 is already in cache [INFO] extracting crate double 0.2.2 into work/ex/clippy-test-run/sources/stable/reg/double/0.2.2 [INFO] extracting crate double 0.2.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/double/0.2.2 [INFO] validating manifest of double-0.2.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of double-0.2.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing double-0.2.2 [INFO] finished frobbing double-0.2.2 [INFO] frobbed toml for double-0.2.2 written to work/ex/clippy-test-run/sources/stable/reg/double/0.2.2/Cargo.toml [INFO] started frobbing double-0.2.2 [INFO] finished frobbing double-0.2.2 [INFO] frobbed toml for double-0.2.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/double/0.2.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting double-0.2.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/double/0.2.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c1e3881189d8cd71fb658ed3108246b39547380bde363387d1cec08360922442 [INFO] running `"docker" "start" "-a" "c1e3881189d8cd71fb658ed3108246b39547380bde363387d1cec08360922442"` [INFO] [stderr] Compiling double v0.2.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mock.rs:790:13 [INFO] [stderr] | [INFO] [stderr] 790 | pattern_index_to_match_indices: pattern_index_to_match_indices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pattern_index_to_match_indices` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mock.rs:813:13 [INFO] [stderr] | [INFO] [stderr] 813 | pattern_index_to_match_indices: pattern_index_to_match_indices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pattern_index_to_match_indices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mock.rs:790:13 [INFO] [stderr] | [INFO] [stderr] 790 | pattern_index_to_match_indices: pattern_index_to_match_indices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pattern_index_to_match_indices` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mock.rs:813:13 [INFO] [stderr] | [INFO] [stderr] 813 | pattern_index_to_match_indices: pattern_index_to_match_indices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pattern_index_to_match_indices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/mock.rs:917:13 [INFO] [stderr] | [INFO] [stderr] 917 | (0..self.num_expectations)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/mock.rs:917:13 [INFO] [stderr] | [INFO] [stderr] 917 | (0..self.num_expectations)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/mock.rs:917:13 [INFO] [stderr] | [INFO] [stderr] 917 | (0..self.num_expectations)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/mock.rs:917:13 [INFO] [stderr] | [INFO] [stderr] 917 | (0..self.num_expectations)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> /opt/crater/target/debug/build/double-99740cb264a5adcc/out/matcher_generated.rs:75:19 [INFO] [stderr] | [INFO] [stderr] 75 | arg_matchers: ( [INFO] [stderr] | ___________________^ [INFO] [stderr] 76 | | &Fn(&A) -> bool, [INFO] [stderr] 77 | | &Fn(&B) -> bool, [INFO] [stderr] 78 | | &Fn(&C) -> bool [INFO] [stderr] 79 | | )) -> bool { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> /opt/crater/target/debug/build/double-99740cb264a5adcc/out/matcher_generated.rs:94:19 [INFO] [stderr] | [INFO] [stderr] 94 | arg_matchers: ( [INFO] [stderr] | ___________________^ [INFO] [stderr] 95 | | &Fn(&A) -> bool, [INFO] [stderr] 96 | | &Fn(&B) -> bool, [INFO] [stderr] 97 | | &Fn(&C) -> bool, [INFO] [stderr] 98 | | &Fn(&D) -> bool [INFO] [stderr] 99 | | )) -> bool { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> /opt/crater/target/debug/build/double-99740cb264a5adcc/out/matcher_generated.rs:116:19 [INFO] [stderr] | [INFO] [stderr] 116 | arg_matchers: ( [INFO] [stderr] | ___________________^ [INFO] [stderr] 117 | | &Fn(&A) -> bool, [INFO] [stderr] 118 | | &Fn(&B) -> bool, [INFO] [stderr] 119 | | &Fn(&C) -> bool, [INFO] [stderr] 120 | | &Fn(&D) -> bool, [INFO] [stderr] 121 | | &Fn(&E) -> bool [INFO] [stderr] 122 | | )) -> bool { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> /opt/crater/target/debug/build/double-99740cb264a5adcc/out/matcher_generated.rs:141:19 [INFO] [stderr] | [INFO] [stderr] 141 | arg_matchers: ( [INFO] [stderr] | ___________________^ [INFO] [stderr] 142 | | &Fn(&A) -> bool, [INFO] [stderr] 143 | | &Fn(&B) -> bool, [INFO] [stderr] 144 | | &Fn(&C) -> bool, [INFO] [stderr] ... | [INFO] [stderr] 147 | | &Fn(&F) -> bool [INFO] [stderr] 148 | | )) -> bool { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> /opt/crater/target/debug/build/double-99740cb264a5adcc/out/matcher_generated.rs:169:19 [INFO] [stderr] | [INFO] [stderr] 169 | arg_matchers: ( [INFO] [stderr] | ___________________^ [INFO] [stderr] 170 | | &Fn(&A) -> bool, [INFO] [stderr] 171 | | &Fn(&B) -> bool, [INFO] [stderr] 172 | | &Fn(&C) -> bool, [INFO] [stderr] ... | [INFO] [stderr] 176 | | &Fn(&G) -> bool [INFO] [stderr] 177 | | )) -> bool { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> /opt/crater/target/debug/build/double-99740cb264a5adcc/out/matcher_generated.rs:200:19 [INFO] [stderr] | [INFO] [stderr] 200 | arg_matchers: ( [INFO] [stderr] | ___________________^ [INFO] [stderr] 201 | | &Fn(&A) -> bool, [INFO] [stderr] 202 | | &Fn(&B) -> bool, [INFO] [stderr] 203 | | &Fn(&C) -> bool, [INFO] [stderr] ... | [INFO] [stderr] 208 | | &Fn(&H) -> bool [INFO] [stderr] 209 | | )) -> bool { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> /opt/crater/target/debug/build/double-99740cb264a5adcc/out/matcher_generated.rs:234:19 [INFO] [stderr] | [INFO] [stderr] 234 | arg_matchers: ( [INFO] [stderr] | ___________________^ [INFO] [stderr] 235 | | &Fn(&A) -> bool, [INFO] [stderr] 236 | | &Fn(&B) -> bool, [INFO] [stderr] 237 | | &Fn(&C) -> bool, [INFO] [stderr] ... | [INFO] [stderr] 243 | | &Fn(&I) -> bool [INFO] [stderr] 244 | | )) -> bool { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> /opt/crater/target/debug/build/double-99740cb264a5adcc/out/matcher_generated.rs:271:19 [INFO] [stderr] | [INFO] [stderr] 271 | arg_matchers: ( [INFO] [stderr] | ___________________^ [INFO] [stderr] 272 | | &Fn(&A) -> bool, [INFO] [stderr] 273 | | &Fn(&B) -> bool, [INFO] [stderr] 274 | | &Fn(&C) -> bool, [INFO] [stderr] ... | [INFO] [stderr] 281 | | &Fn(&J) -> bool [INFO] [stderr] 282 | | )) -> bool { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> /opt/crater/target/debug/build/double-99740cb264a5adcc/out/matcher_generated.rs:311:19 [INFO] [stderr] | [INFO] [stderr] 311 | arg_matchers: ( [INFO] [stderr] | ___________________^ [INFO] [stderr] 312 | | &Fn(&A) -> bool, [INFO] [stderr] 313 | | &Fn(&B) -> bool, [INFO] [stderr] 314 | | &Fn(&C) -> bool, [INFO] [stderr] ... | [INFO] [stderr] 322 | | &Fn(&K) -> bool [INFO] [stderr] 323 | | )) -> bool { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/matcher.rs:94:20 [INFO] [stderr] | [INFO] [stderr] 94 | pub fn f32_eq(arg: &f32, target_val: f32) -> bool { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `f32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/matcher.rs:104:20 [INFO] [stderr] | [INFO] [stderr] 104 | pub fn f64_eq(arg: &f64, target_val: f64) -> bool { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/matcher.rs:117:34 [INFO] [stderr] | [INFO] [stderr] 117 | pub fn nan_sensitive_f32_eq(arg: &f32, target_val: f32) -> bool { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/matcher.rs:130:34 [INFO] [stderr] | [INFO] [stderr] 130 | pub fn nan_sensitive_f64_eq(arg: &f64, target_val: f64) -> bool { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/mock.rs:34:10 [INFO] [stderr] | [INFO] [stderr] 34 | fns: Ref R>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/mock.rs:35:15 [INFO] [stderr] | [INFO] [stderr] 35 | closures: Ref R>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/mock.rs:122:17 [INFO] [stderr] | [INFO] [stderr] 122 | let ref mut sequence = *self.return_value_sequence.borrow_mut(); [INFO] [stderr] | ----^^^^^^^^^^^^^^^^-------------------------------------------- help: try: `let sequence = &mut (*self.return_value_sequence.borrow_mut());` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/mock.rs:781:26 [INFO] [stderr] | [INFO] [stderr] 781 | .or_insert(vec!()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec!())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/mock.rs:804:26 [INFO] [stderr] | [INFO] [stderr] 804 | .or_insert(vec!()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec!())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/mock.rs:919:13 [INFO] [stderr] | [INFO] [stderr] 919 | / self.pattern_index_to_match_indices [INFO] [stderr] 920 | | .keys() [INFO] [stderr] 921 | | .map(|k| k.clone())); [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 919 | self.pattern_index_to_match_indices [INFO] [stderr] 920 | .keys().cloned()); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/mock.rs:921:22 [INFO] [stderr] | [INFO] [stderr] 921 | .map(|k| k.clone())); [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*k` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/mock.rs:923:13 [INFO] [stderr] | [INFO] [stderr] 923 | / expected_indices [INFO] [stderr] 924 | | .difference(&expected_indices_matched) [INFO] [stderr] 925 | | .map(|i| i.clone())); [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 923 | expected_indices [INFO] [stderr] 924 | .difference(&expected_indices_matched).cloned()); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/mock.rs:925:22 [INFO] [stderr] | [INFO] [stderr] 925 | .map(|i| i.clone())); [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/mock.rs:932:9 [INFO] [stderr] | [INFO] [stderr] 932 | unmatched_expectation_indices.len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `unmatched_expectation_indices.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/mock.rs:1020:39 [INFO] [stderr] | [INFO] [stderr] 1020 | fn generate_permutations(constraints: &Vec>) -> Vec> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/mock.rs:1035:18 [INFO] [stderr] | [INFO] [stderr] 1035 | constraints: &Vec>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/mock.rs:1040:49 [INFO] [stderr] | [INFO] [stderr] 1040 | permutation_buffer[current_index] = val.clone(); [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> /opt/crater/target/debug/build/double-99740cb264a5adcc/out/matcher_generated.rs:75:19 [INFO] [stderr] | [INFO] [stderr] 75 | arg_matchers: ( [INFO] [stderr] | ___________________^ [INFO] [stderr] 76 | | &Fn(&A) -> bool, [INFO] [stderr] 77 | | &Fn(&B) -> bool, [INFO] [stderr] 78 | | &Fn(&C) -> bool [INFO] [stderr] 79 | | )) -> bool { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> /opt/crater/target/debug/build/double-99740cb264a5adcc/out/matcher_generated.rs:94:19 [INFO] [stderr] | [INFO] [stderr] 94 | arg_matchers: ( [INFO] [stderr] | ___________________^ [INFO] [stderr] 95 | | &Fn(&A) -> bool, [INFO] [stderr] 96 | | &Fn(&B) -> bool, [INFO] [stderr] 97 | | &Fn(&C) -> bool, [INFO] [stderr] 98 | | &Fn(&D) -> bool [INFO] [stderr] 99 | | )) -> bool { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> /opt/crater/target/debug/build/double-99740cb264a5adcc/out/matcher_generated.rs:116:19 [INFO] [stderr] | [INFO] [stderr] 116 | arg_matchers: ( [INFO] [stderr] | ___________________^ [INFO] [stderr] 117 | | &Fn(&A) -> bool, [INFO] [stderr] 118 | | &Fn(&B) -> bool, [INFO] [stderr] 119 | | &Fn(&C) -> bool, [INFO] [stderr] 120 | | &Fn(&D) -> bool, [INFO] [stderr] 121 | | &Fn(&E) -> bool [INFO] [stderr] 122 | | )) -> bool { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> /opt/crater/target/debug/build/double-99740cb264a5adcc/out/matcher_generated.rs:141:19 [INFO] [stderr] | [INFO] [stderr] 141 | arg_matchers: ( [INFO] [stderr] | ___________________^ [INFO] [stderr] 142 | | &Fn(&A) -> bool, [INFO] [stderr] 143 | | &Fn(&B) -> bool, [INFO] [stderr] 144 | | &Fn(&C) -> bool, [INFO] [stderr] ... | [INFO] [stderr] 147 | | &Fn(&F) -> bool [INFO] [stderr] 148 | | )) -> bool { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> /opt/crater/target/debug/build/double-99740cb264a5adcc/out/matcher_generated.rs:169:19 [INFO] [stderr] | [INFO] [stderr] 169 | arg_matchers: ( [INFO] [stderr] | ___________________^ [INFO] [stderr] 170 | | &Fn(&A) -> bool, [INFO] [stderr] 171 | | &Fn(&B) -> bool, [INFO] [stderr] 172 | | &Fn(&C) -> bool, [INFO] [stderr] ... | [INFO] [stderr] 176 | | &Fn(&G) -> bool [INFO] [stderr] 177 | | )) -> bool { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> /opt/crater/target/debug/build/double-99740cb264a5adcc/out/matcher_generated.rs:200:19 [INFO] [stderr] | [INFO] [stderr] 200 | arg_matchers: ( [INFO] [stderr] | ___________________^ [INFO] [stderr] 201 | | &Fn(&A) -> bool, [INFO] [stderr] 202 | | &Fn(&B) -> bool, [INFO] [stderr] 203 | | &Fn(&C) -> bool, [INFO] [stderr] ... | [INFO] [stderr] 208 | | &Fn(&H) -> bool [INFO] [stderr] 209 | | )) -> bool { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> /opt/crater/target/debug/build/double-99740cb264a5adcc/out/matcher_generated.rs:234:19 [INFO] [stderr] | [INFO] [stderr] 234 | arg_matchers: ( [INFO] [stderr] | ___________________^ [INFO] [stderr] 235 | | &Fn(&A) -> bool, [INFO] [stderr] 236 | | &Fn(&B) -> bool, [INFO] [stderr] 237 | | &Fn(&C) -> bool, [INFO] [stderr] ... | [INFO] [stderr] 243 | | &Fn(&I) -> bool [INFO] [stderr] 244 | | )) -> bool { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> /opt/crater/target/debug/build/double-99740cb264a5adcc/out/matcher_generated.rs:271:19 [INFO] [stderr] | [INFO] [stderr] 271 | arg_matchers: ( [INFO] [stderr] | ___________________^ [INFO] [stderr] 272 | | &Fn(&A) -> bool, [INFO] [stderr] 273 | | &Fn(&B) -> bool, [INFO] [stderr] 274 | | &Fn(&C) -> bool, [INFO] [stderr] ... | [INFO] [stderr] 281 | | &Fn(&J) -> bool [INFO] [stderr] 282 | | )) -> bool { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> /opt/crater/target/debug/build/double-99740cb264a5adcc/out/matcher_generated.rs:311:19 [INFO] [stderr] | [INFO] [stderr] 311 | arg_matchers: ( [INFO] [stderr] | ___________________^ [INFO] [stderr] 312 | | &Fn(&A) -> bool, [INFO] [stderr] 313 | | &Fn(&B) -> bool, [INFO] [stderr] 314 | | &Fn(&C) -> bool, [INFO] [stderr] ... | [INFO] [stderr] 322 | | &Fn(&K) -> bool [INFO] [stderr] 323 | | )) -> bool { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/matcher.rs:94:20 [INFO] [stderr] | [INFO] [stderr] 94 | pub fn f32_eq(arg: &f32, target_val: f32) -> bool { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `f32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/matcher.rs:104:20 [INFO] [stderr] | [INFO] [stderr] 104 | pub fn f64_eq(arg: &f64, target_val: f64) -> bool { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/matcher.rs:117:34 [INFO] [stderr] | [INFO] [stderr] 117 | pub fn nan_sensitive_f32_eq(arg: &f32, target_val: f32) -> bool { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/matcher.rs:130:34 [INFO] [stderr] | [INFO] [stderr] 130 | pub fn nan_sensitive_f64_eq(arg: &f64, target_val: f64) -> bool { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/mock.rs:34:10 [INFO] [stderr] | [INFO] [stderr] 34 | fns: Ref R>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/mock.rs:35:15 [INFO] [stderr] | [INFO] [stderr] 35 | closures: Ref R>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/mock.rs:122:17 [INFO] [stderr] | [INFO] [stderr] 122 | let ref mut sequence = *self.return_value_sequence.borrow_mut(); [INFO] [stderr] | ----^^^^^^^^^^^^^^^^-------------------------------------------- help: try: `let sequence = &mut (*self.return_value_sequence.borrow_mut());` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/mock.rs:781:26 [INFO] [stderr] | [INFO] [stderr] 781 | .or_insert(vec!()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec!())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/mock.rs:804:26 [INFO] [stderr] | [INFO] [stderr] 804 | .or_insert(vec!()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec!())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/mock.rs:919:13 [INFO] [stderr] | [INFO] [stderr] 919 | / self.pattern_index_to_match_indices [INFO] [stderr] 920 | | .keys() [INFO] [stderr] 921 | | .map(|k| k.clone())); [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 919 | self.pattern_index_to_match_indices [INFO] [stderr] 920 | .keys().cloned()); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/mock.rs:921:22 [INFO] [stderr] | [INFO] [stderr] 921 | .map(|k| k.clone())); [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*k` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/mock.rs:923:13 [INFO] [stderr] | [INFO] [stderr] 923 | / expected_indices [INFO] [stderr] 924 | | .difference(&expected_indices_matched) [INFO] [stderr] 925 | | .map(|i| i.clone())); [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 923 | expected_indices [INFO] [stderr] 924 | .difference(&expected_indices_matched).cloned()); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/mock.rs:925:22 [INFO] [stderr] | [INFO] [stderr] 925 | .map(|i| i.clone())); [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/mock.rs:932:9 [INFO] [stderr] | [INFO] [stderr] 932 | unmatched_expectation_indices.len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `unmatched_expectation_indices.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/mock.rs:1020:39 [INFO] [stderr] | [INFO] [stderr] 1020 | fn generate_permutations(constraints: &Vec>) -> Vec> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/mock.rs:1035:18 [INFO] [stderr] | [INFO] [stderr] 1035 | constraints: &Vec>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/mock.rs:1040:49 [INFO] [stderr] | [INFO] [stderr] 1040 | permutation_buffer[current_index] = val.clone(); [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> examples/function.rs:36:26 [INFO] [stderr] | [INFO] [stderr] 36 | mock.use_closure_for((3), Box::new(|x| x * 2)); [INFO] [stderr] | ^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> examples/macro.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | (42), [INFO] [stderr] | ^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> examples/macro.rs:104:40 [INFO] [stderr] | [INFO] [stderr] 104 | store.delete_user.return_value_for((42), Ok(())); [INFO] [stderr] | ^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> examples/pattern_matching.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | matcher!( p!(eq, 42) ) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> examples/pattern_matching.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | matcher!( p!(gt, 84) ) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> examples/pattern_matching.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | matcher!( p!(between_inc, 42, 84) ) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> examples/pattern_matching.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | matcher!( p!(between_exc, 42, 84) ) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> examples/pattern_matching.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | matcher!( p!(not, p!(gt, 84)) ) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> examples/pattern_matching.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | matcher!( p!(not, p!(gt, 0)) ) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> examples/pattern_matching.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | matcher!( p!(all_of, vec!(p!(gt, 40), p!(lt, 90))) ) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> examples/pattern_matching.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | matcher!( p!(all_of, vec!(p!(gt, 40), p!(lt, 42))) ) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> examples/pattern_matching.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | matcher!( p!(any_of, vec!(p!(lt, 100), p!(gt, 200))) ) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> examples/pattern_matching.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | matcher!( p!(any_of, vec!(p!(lt, 5), p!(gt, 200))) ) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> examples/pattern_matching.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | matcher!( p!(eq, 42), p!(eq, false) ) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> examples/pattern_matching.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | matcher!( p!(eq, 42), p!(eq, false) ) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> examples/pattern_matching.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | matcher!( p!(is_ok, p!(ge, 50)) ) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> examples/pattern_matching.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | matcher!( p!(is_err, p!(contains, "sad")) ) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> examples/pattern_matching.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | matcher!( p!(is_err, p!(contains, "happy")) ) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> examples/pattern_matching.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | / matcher!( [INFO] [stderr] 86 | | p!(is_ok, [INFO] [stderr] 87 | | p!(all_of, vec!( [INFO] [stderr] 88 | | p!(ge, 50), [INFO] [stderr] 89 | | p!(le, 60))))) [INFO] [stderr] | |__________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.15s [INFO] running `"docker" "inspect" "c1e3881189d8cd71fb658ed3108246b39547380bde363387d1cec08360922442"` [INFO] running `"docker" "rm" "-f" "c1e3881189d8cd71fb658ed3108246b39547380bde363387d1cec08360922442"` [INFO] [stdout] c1e3881189d8cd71fb658ed3108246b39547380bde363387d1cec08360922442