[INFO] crate dots 0.2.1 is already in cache
[INFO] extracting crate dots 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/dots/0.2.1
[INFO] extracting crate dots 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dots/0.2.1
[INFO] validating manifest of dots-0.2.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of dots-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing dots-0.2.1
[INFO] finished frobbing dots-0.2.1
[INFO] frobbed toml for dots-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/dots/0.2.1/Cargo.toml
[INFO] started frobbing dots-0.2.1
[INFO] finished frobbing dots-0.2.1
[INFO] frobbed toml for dots-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dots/0.2.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting dots-0.2.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/dots/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] be137f65f949cc029658462990fc240ceec22f909d4b096baed6bc4e96c32800
[INFO] running `"docker" "start" "-a" "be137f65f949cc029658462990fc240ceec22f909d4b096baed6bc4e96c32800"`
[INFO] [stderr]     Checking dots v0.2.1 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/dots.rs:14:18
[INFO] [stderr]    |
[INFO] [stderr] 14 |         Ok(Dot { package: package, path: path.to_path_buf() })
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^ help: replace it with: `package`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/install.rs:15:48
[INFO] [stderr]    |
[INFO] [stderr] 15 |         ResolveError { anchor: anchor.clone(), kind: kind }
[INFO] [stderr]    |                                                ^^^^^^^^^^ help: replace it with: `kind`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/utils/links.rs:12:18
[INFO] [stderr]    |
[INFO] [stderr] 12 |         Anchor { path: path, kind: kind }
[INFO] [stderr]    |                  ^^^^^^^^^^ help: replace it with: `path`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/utils/links.rs:12:30
[INFO] [stderr]    |
[INFO] [stderr] 12 |         Anchor { path: path, kind: kind }
[INFO] [stderr]    |                              ^^^^^^^^^^ help: replace it with: `kind`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/dots.rs:14:18
[INFO] [stderr]    |
[INFO] [stderr] 14 |         Ok(Dot { package: package, path: path.to_path_buf() })
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^ help: replace it with: `package`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/install.rs:15:48
[INFO] [stderr]    |
[INFO] [stderr] 15 |         ResolveError { anchor: anchor.clone(), kind: kind }
[INFO] [stderr]    |                                                ^^^^^^^^^^ help: replace it with: `kind`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/utils/links.rs:12:18
[INFO] [stderr]    |
[INFO] [stderr] 12 |         Anchor { path: path, kind: kind }
[INFO] [stderr]    |                  ^^^^^^^^^^ help: replace it with: `path`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/utils/links.rs:12:30
[INFO] [stderr]    |
[INFO] [stderr] 12 |         Anchor { path: path, kind: kind }
[INFO] [stderr]    |                              ^^^^^^^^^^ help: replace it with: `kind`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/dots.rs:29:11
[INFO] [stderr]    |
[INFO] [stderr] 29 |     match env::home_dir() {
[INFO] [stderr]    |           ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]    --> src/install.rs:136:23
[INFO] [stderr]     |
[INFO] [stderr] 136 |                 match std::env::home_dir() {
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/dots.rs:29:11
[INFO] [stderr]    |
[INFO] [stderr] 29 |     match env::home_dir() {
[INFO] [stderr]    |           ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]    --> src/install.rs:136:23
[INFO] [stderr]     |
[INFO] [stderr] 136 |                 match std::env::home_dir() {
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `simple`
[INFO] [stderr]   --> src/install.rs:18:5
[INFO] [stderr]    |
[INFO] [stderr] 18 |     fn simple(anchor: &Anchor, message: &str) -> ResolveError {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variant is never constructed: `Simple`
[INFO] [stderr]   --> src/install.rs:30:5
[INFO] [stderr]    |
[INFO] [stderr] 30 |     Simple(String)
[INFO] [stderr]    |     ^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/dots.rs:107:9
[INFO] [stderr]     |
[INFO] [stderr] 107 | /         match Dot::new(path.as_path()) {
[INFO] [stderr] 108 | |             Ok(dot) => dots.push(dot),
[INFO] [stderr] 109 | |             Err(_) => {}
[INFO] [stderr] 110 | |         }
[INFO] [stderr]     | |_________^ help: try this: `if let Ok(dot) = Dot::new(path.as_path()) { dots.push(dot) }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/install.rs:98:46
[INFO] [stderr]    |
[INFO] [stderr] 98 |     fn resolve(&self, root: &PathBuf, force: &bool) -> Result<Action, ResolveError> {
[INFO] [stderr]    |                                              ^^^^^ help: consider passing by value instead: `bool`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/install.rs:131:44
[INFO] [stderr]     |
[INFO] [stderr] 131 |     fn resolve_dest (dest: &Anchor, force: &bool) -> Result<Anchor, ResolveError> {
[INFO] [stderr]     |                                            ^^^^^ help: consider passing by value instead: `bool`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/install.rs:139:32
[INFO] [stderr]     |
[INFO] [stderr] 139 |                             if old.len() > 0 { old + "/" + comp.as_os_str().to_str().unwrap() }
[INFO] [stderr]     |                                ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!old.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/install.rs:214:25
[INFO] [stderr]     |
[INFO] [stderr] 214 | /                         match err.kind {
[INFO] [stderr] 215 | |                             ResolveErrorKind::AlreadyExists => suggest_force = true,
[INFO] [stderr] 216 | |                             _ => {}
[INFO] [stderr] 217 | |                         }
[INFO] [stderr]     | |_________________________^ help: try this: `if let ResolveErrorKind::AlreadyExists = err.kind { suggest_force = true }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/main.rs:41:9
[INFO] [stderr]    |
[INFO] [stderr] 41 |         format!("{}", indented)
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `indented.to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `simple`
[INFO] [stderr]   --> src/install.rs:18:5
[INFO] [stderr]    |
[INFO] [stderr] 18 |     fn simple(anchor: &Anchor, message: &str) -> ResolveError {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variant is never constructed: `Simple`
[INFO] [stderr]   --> src/install.rs:30:5
[INFO] [stderr]    |
[INFO] [stderr] 30 |     Simple(String)
[INFO] [stderr]    |     ^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/dots.rs:107:9
[INFO] [stderr]     |
[INFO] [stderr] 107 | /         match Dot::new(path.as_path()) {
[INFO] [stderr] 108 | |             Ok(dot) => dots.push(dot),
[INFO] [stderr] 109 | |             Err(_) => {}
[INFO] [stderr] 110 | |         }
[INFO] [stderr]     | |_________^ help: try this: `if let Ok(dot) = Dot::new(path.as_path()) { dots.push(dot) }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/install.rs:98:46
[INFO] [stderr]    |
[INFO] [stderr] 98 |     fn resolve(&self, root: &PathBuf, force: &bool) -> Result<Action, ResolveError> {
[INFO] [stderr]    |                                              ^^^^^ help: consider passing by value instead: `bool`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/install.rs:131:44
[INFO] [stderr]     |
[INFO] [stderr] 131 |     fn resolve_dest (dest: &Anchor, force: &bool) -> Result<Anchor, ResolveError> {
[INFO] [stderr]     |                                            ^^^^^ help: consider passing by value instead: `bool`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/install.rs:139:32
[INFO] [stderr]     |
[INFO] [stderr] 139 |                             if old.len() > 0 { old + "/" + comp.as_os_str().to_str().unwrap() }
[INFO] [stderr]     |                                ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!old.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/install.rs:214:25
[INFO] [stderr]     |
[INFO] [stderr] 214 | /                         match err.kind {
[INFO] [stderr] 215 | |                             ResolveErrorKind::AlreadyExists => suggest_force = true,
[INFO] [stderr] 216 | |                             _ => {}
[INFO] [stderr] 217 | |                         }
[INFO] [stderr]     | |_________________________^ help: try this: `if let ResolveErrorKind::AlreadyExists = err.kind { suggest_force = true }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/main.rs:41:9
[INFO] [stderr]    |
[INFO] [stderr] 41 |         format!("{}", indented)
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `indented.to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3.09s
[INFO] running `"docker" "inspect" "be137f65f949cc029658462990fc240ceec22f909d4b096baed6bc4e96c32800"`
[INFO] running `"docker" "rm" "-f" "be137f65f949cc029658462990fc240ceec22f909d4b096baed6bc4e96c32800"`
[INFO] [stdout] be137f65f949cc029658462990fc240ceec22f909d4b096baed6bc4e96c32800