[INFO] crate dotr 0.4.0 is already in cache [INFO] extracting crate dotr 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/dotr/0.4.0 [INFO] extracting crate dotr 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dotr/0.4.0 [INFO] validating manifest of dotr-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dotr-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dotr-0.4.0 [INFO] finished frobbing dotr-0.4.0 [INFO] frobbed toml for dotr-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/dotr/0.4.0/Cargo.toml [INFO] started frobbing dotr-0.4.0 [INFO] finished frobbing dotr-0.4.0 [INFO] frobbed toml for dotr-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dotr/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dotr-0.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/dotr/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e0029b8d0f2f0da819567c153d847690d0d3a9b0fc4e9baee7f461b2e2af8a9b [INFO] running `"docker" "start" "-a" "e0029b8d0f2f0da819567c153d847690d0d3a9b0fc4e9baee7f461b2e2af8a9b"` [INFO] [stderr] Compiling slog v2.4.1 [INFO] [stderr] Checking slog-term v2.4.0 [INFO] [stderr] Checking slog-async v2.3.0 [INFO] [stderr] Checking dotr v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin.rs:422:13 [INFO] [stderr] | [INFO] [stderr] 422 | dst_dir: dst_dir, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `dst_dir` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin.rs:423:13 [INFO] [stderr] | [INFO] [stderr] 423 | src_dir: src_dir, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `src_dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin.rs:425:13 [INFO] [stderr] | [INFO] [stderr] 425 | dry_run: dry_run, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `dry_run` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin.rs:426:13 [INFO] [stderr] | [INFO] [stderr] 426 | force: force, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `force` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin.rs:427:13 [INFO] [stderr] | [INFO] [stderr] 427 | log: log, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `log` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin.rs:422:13 [INFO] [stderr] | [INFO] [stderr] 422 | dst_dir: dst_dir, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `dst_dir` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin.rs:423:13 [INFO] [stderr] | [INFO] [stderr] 423 | src_dir: src_dir, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `src_dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin.rs:425:13 [INFO] [stderr] | [INFO] [stderr] 425 | dry_run: dry_run, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `dry_run` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin.rs:426:13 [INFO] [stderr] | [INFO] [stderr] 426 | force: force, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `force` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin.rs:427:13 [INFO] [stderr] | [INFO] [stderr] 427 | log: log, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `log` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | return true [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bin.rs:173:24 [INFO] [stderr] | [INFO] [stderr] 173 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 174 | | if !self.dry_run { [INFO] [stderr] 175 | | trace!(log, "Creating a base directory (if doesn't exist)"); [INFO] [stderr] 176 | | fs::create_dir_all(dst.parent().unwrap())?; [INFO] [stderr] 177 | | } [INFO] [stderr] 178 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 173 | } else if !self.dry_run { [INFO] [stderr] 174 | trace!(log, "Creating a base directory (if doesn't exist)"); [INFO] [stderr] 175 | fs::create_dir_all(dst.parent().unwrap())?; [INFO] [stderr] 176 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bin.rs:202:24 [INFO] [stderr] | [INFO] [stderr] 202 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 203 | | if !self.dry_run { [INFO] [stderr] 204 | | trace!(log, "Creating a base directory (if doesn't exist)"); [INFO] [stderr] 205 | | fs::create_dir_all(dst.parent().unwrap())?; [INFO] [stderr] 206 | | } [INFO] [stderr] 207 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 202 | } else if !self.dry_run { [INFO] [stderr] 203 | trace!(log, "Creating a base directory (if doesn't exist)"); [INFO] [stderr] 204 | fs::create_dir_all(dst.parent().unwrap())?; [INFO] [stderr] 205 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bin.rs:261:28 [INFO] [stderr] | [INFO] [stderr] 261 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 262 | | if dst_metadata.file_type().is_file() { [INFO] [stderr] 263 | | warn!(log, "Destination already exists and is a file"); [INFO] [stderr] 264 | | continue; [INFO] [stderr] ... | [INFO] [stderr] 283 | | } [INFO] [stderr] 284 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 261 | } else if dst_metadata.file_type().is_file() { [INFO] [stderr] 262 | warn!(log, "Destination already exists and is a file"); [INFO] [stderr] 263 | continue; [INFO] [stderr] 264 | } else if dst_metadata.file_type().is_dir() { [INFO] [stderr] 265 | warn!(log, "Destination already exists and is a directory"); [INFO] [stderr] 266 | continue; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bin.rs:276:36 [INFO] [stderr] | [INFO] [stderr] 276 | } else { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 277 | | if !self.dry_run { [INFO] [stderr] 278 | | fs::remove_file(&dst)?; [INFO] [stderr] 279 | | } [INFO] [stderr] 280 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 276 | } else if !self.dry_run { [INFO] [stderr] 277 | fs::remove_file(&dst)?; [INFO] [stderr] 278 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bin.rs:301:28 [INFO] [stderr] | [INFO] [stderr] 301 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 302 | | if dst_metadata.file_type().is_file() { [INFO] [stderr] 303 | | warn!(log, "Destination already exists and is a file"); [INFO] [stderr] 304 | | continue; [INFO] [stderr] ... | [INFO] [stderr] 324 | | } [INFO] [stderr] 325 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 301 | } else if dst_metadata.file_type().is_file() { [INFO] [stderr] 302 | warn!(log, "Destination already exists and is a file"); [INFO] [stderr] 303 | continue; [INFO] [stderr] 304 | } else if dst_metadata.file_type().is_dir() { [INFO] [stderr] 305 | warn!(log, "Destination already exists and is a directory"); [INFO] [stderr] 306 | continue; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bin.rs:317:36 [INFO] [stderr] | [INFO] [stderr] 317 | } else { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 318 | | if !self.dry_run { [INFO] [stderr] 319 | | fs::remove_file(&dst)?; [INFO] [stderr] 320 | | } [INFO] [stderr] 321 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 317 | } else if !self.dry_run { [INFO] [stderr] 318 | fs::remove_file(&dst)?; [INFO] [stderr] 319 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bin.rs:413:16 [INFO] [stderr] | [INFO] [stderr] 413 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 414 | | if let Some(home) = env::var_os("HOME") { [INFO] [stderr] 415 | | Path::new(&home).into() [INFO] [stderr] 416 | | } else { [INFO] [stderr] 417 | | return Err(io::Error::new(io::ErrorKind::NotFound, "$HOME not set")); [INFO] [stderr] 418 | | } [INFO] [stderr] 419 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 413 | } else if let Some(home) = env::var_os("HOME") { [INFO] [stderr] 414 | Path::new(&home).into() [INFO] [stderr] 415 | } else { [INFO] [stderr] 416 | return Err(io::Error::new(io::ErrorKind::NotFound, "$HOME not set")); [INFO] [stderr] 417 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | return true [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bin.rs:173:24 [INFO] [stderr] | [INFO] [stderr] 173 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 174 | | if !self.dry_run { [INFO] [stderr] 175 | | trace!(log, "Creating a base directory (if doesn't exist)"); [INFO] [stderr] 176 | | fs::create_dir_all(dst.parent().unwrap())?; [INFO] [stderr] 177 | | } [INFO] [stderr] 178 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 173 | } else if !self.dry_run { [INFO] [stderr] 174 | trace!(log, "Creating a base directory (if doesn't exist)"); [INFO] [stderr] 175 | fs::create_dir_all(dst.parent().unwrap())?; [INFO] [stderr] 176 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bin.rs:202:24 [INFO] [stderr] | [INFO] [stderr] 202 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 203 | | if !self.dry_run { [INFO] [stderr] 204 | | trace!(log, "Creating a base directory (if doesn't exist)"); [INFO] [stderr] 205 | | fs::create_dir_all(dst.parent().unwrap())?; [INFO] [stderr] 206 | | } [INFO] [stderr] 207 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 202 | } else if !self.dry_run { [INFO] [stderr] 203 | trace!(log, "Creating a base directory (if doesn't exist)"); [INFO] [stderr] 204 | fs::create_dir_all(dst.parent().unwrap())?; [INFO] [stderr] 205 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bin.rs:261:28 [INFO] [stderr] | [INFO] [stderr] 261 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 262 | | if dst_metadata.file_type().is_file() { [INFO] [stderr] 263 | | warn!(log, "Destination already exists and is a file"); [INFO] [stderr] 264 | | continue; [INFO] [stderr] ... | [INFO] [stderr] 283 | | } [INFO] [stderr] 284 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 261 | } else if dst_metadata.file_type().is_file() { [INFO] [stderr] 262 | warn!(log, "Destination already exists and is a file"); [INFO] [stderr] 263 | continue; [INFO] [stderr] 264 | } else if dst_metadata.file_type().is_dir() { [INFO] [stderr] 265 | warn!(log, "Destination already exists and is a directory"); [INFO] [stderr] 266 | continue; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bin.rs:276:36 [INFO] [stderr] | [INFO] [stderr] 276 | } else { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 277 | | if !self.dry_run { [INFO] [stderr] 278 | | fs::remove_file(&dst)?; [INFO] [stderr] 279 | | } [INFO] [stderr] 280 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 276 | } else if !self.dry_run { [INFO] [stderr] 277 | fs::remove_file(&dst)?; [INFO] [stderr] 278 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bin.rs:301:28 [INFO] [stderr] | [INFO] [stderr] 301 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 302 | | if dst_metadata.file_type().is_file() { [INFO] [stderr] 303 | | warn!(log, "Destination already exists and is a file"); [INFO] [stderr] 304 | | continue; [INFO] [stderr] ... | [INFO] [stderr] 324 | | } [INFO] [stderr] 325 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 301 | } else if dst_metadata.file_type().is_file() { [INFO] [stderr] 302 | warn!(log, "Destination already exists and is a file"); [INFO] [stderr] 303 | continue; [INFO] [stderr] 304 | } else if dst_metadata.file_type().is_dir() { [INFO] [stderr] 305 | warn!(log, "Destination already exists and is a directory"); [INFO] [stderr] 306 | continue; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bin.rs:317:36 [INFO] [stderr] | [INFO] [stderr] 317 | } else { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 318 | | if !self.dry_run { [INFO] [stderr] 319 | | fs::remove_file(&dst)?; [INFO] [stderr] 320 | | } [INFO] [stderr] 321 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 317 | } else if !self.dry_run { [INFO] [stderr] 318 | fs::remove_file(&dst)?; [INFO] [stderr] 319 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bin.rs:413:16 [INFO] [stderr] | [INFO] [stderr] 413 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 414 | | if let Some(home) = env::var_os("HOME") { [INFO] [stderr] 415 | | Path::new(&home).into() [INFO] [stderr] 416 | | } else { [INFO] [stderr] 417 | | return Err(io::Error::new(io::ErrorKind::NotFound, "$HOME not set")); [INFO] [stderr] 418 | | } [INFO] [stderr] 419 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 413 | } else if let Some(home) = env::var_os("HOME") { [INFO] [stderr] 414 | Path::new(&home).into() [INFO] [stderr] 415 | } else { [INFO] [stderr] 416 | return Err(io::Error::new(io::ErrorKind::NotFound, "$HOME not set")); [INFO] [stderr] 417 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 38 [INFO] [stderr] --> src/bin.rs:102:5 [INFO] [stderr] | [INFO] [stderr] 102 | / fn link(&self, src_base: &Path, dst_base: &Path) -> io::Result<()> { [INFO] [stderr] 103 | | info!(self.log, "Starting link operation"; "src" => src_base.display(), "dst" => dst_base.display()); [INFO] [stderr] 104 | | [INFO] [stderr] 105 | | if !dst_base.exists() { [INFO] [stderr] ... | [INFO] [stderr] 217 | | Ok(()) [INFO] [stderr] 218 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 40 [INFO] [stderr] --> src/bin.rs:219:5 [INFO] [stderr] | [INFO] [stderr] 219 | / fn unlink(&self, src_base: &Path, dst_base: &Path) -> io::Result<()> { [INFO] [stderr] 220 | | info!(self.log, "Starting unlink operation"; "src" => src_base.display(), "dst" => dst_base.display()); [INFO] [stderr] 221 | | [INFO] [stderr] 222 | | let dst_base = dst_base.canonicalize()?; [INFO] [stderr] ... | [INFO] [stderr] 335 | | Ok(()) [INFO] [stderr] 336 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 38 [INFO] [stderr] --> src/bin.rs:102:5 [INFO] [stderr] | [INFO] [stderr] 102 | / fn link(&self, src_base: &Path, dst_base: &Path) -> io::Result<()> { [INFO] [stderr] 103 | | info!(self.log, "Starting link operation"; "src" => src_base.display(), "dst" => dst_base.display()); [INFO] [stderr] 104 | | [INFO] [stderr] 105 | | if !dst_base.exists() { [INFO] [stderr] ... | [INFO] [stderr] 217 | | Ok(()) [INFO] [stderr] 218 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 40 [INFO] [stderr] --> src/bin.rs:219:5 [INFO] [stderr] | [INFO] [stderr] 219 | / fn unlink(&self, src_base: &Path, dst_base: &Path) -> io::Result<()> { [INFO] [stderr] 220 | | info!(self.log, "Starting unlink operation"; "src" => src_base.display(), "dst" => dst_base.display()); [INFO] [stderr] 221 | | [INFO] [stderr] 222 | | let dst_base = dst_base.canonicalize()?; [INFO] [stderr] ... | [INFO] [stderr] 335 | | Ok(()) [INFO] [stderr] 336 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.31s [INFO] running `"docker" "inspect" "e0029b8d0f2f0da819567c153d847690d0d3a9b0fc4e9baee7f461b2e2af8a9b"` [INFO] running `"docker" "rm" "-f" "e0029b8d0f2f0da819567c153d847690d0d3a9b0fc4e9baee7f461b2e2af8a9b"` [INFO] [stdout] e0029b8d0f2f0da819567c153d847690d0d3a9b0fc4e9baee7f461b2e2af8a9b