[INFO] crate dotproperties 0.1.0 is already in cache [INFO] extracting crate dotproperties 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/dotproperties/0.1.0 [INFO] extracting crate dotproperties 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dotproperties/0.1.0 [INFO] validating manifest of dotproperties-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dotproperties-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dotproperties-0.1.0 [INFO] finished frobbing dotproperties-0.1.0 [INFO] frobbed toml for dotproperties-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/dotproperties/0.1.0/Cargo.toml [INFO] started frobbing dotproperties-0.1.0 [INFO] finished frobbing dotproperties-0.1.0 [INFO] frobbed toml for dotproperties-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dotproperties/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dotproperties-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/dotproperties/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 396178768c15fefda6cb2d467fc64889dca1476ace675d127857095658fdee76 [INFO] running `"docker" "start" "-a" "396178768c15fefda6cb2d467fc64889dca1476ace675d127857095658fdee76"` [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] Checking dotproperties v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parsers/utf16.rs:74:27 [INFO] [stderr] | [INFO] [stderr] 74 | ::std::char::from_u32(v as u32).expect("All BMP code units are valid characters") [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(v)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/mod.rs:162:1 [INFO] [stderr] | [INFO] [stderr] 162 | / named!(comment_line<()>, [INFO] [stderr] 163 | | do_parse!( [INFO] [stderr] 164 | | eat_whitespaces >> [INFO] [stderr] 165 | | one_of!("#!") >> [INFO] [stderr] ... | [INFO] [stderr] 169 | | ) [INFO] [stderr] 170 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parsers/utf16.rs:74:27 [INFO] [stderr] | [INFO] [stderr] 74 | ::std::char::from_u32(v as u32).expect("All BMP code units are valid characters") [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(v)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/mod.rs:162:1 [INFO] [stderr] | [INFO] [stderr] 162 | / named!(comment_line<()>, [INFO] [stderr] 163 | | do_parse!( [INFO] [stderr] 164 | | eat_whitespaces >> [INFO] [stderr] 165 | | one_of!("#!") >> [INFO] [stderr] ... | [INFO] [stderr] 169 | | ) [INFO] [stderr] 170 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 35 [INFO] [stderr] --> src/parsers/mod.rs:295:5 [INFO] [stderr] | [INFO] [stderr] 295 | / fn test_key_value_line() { [INFO] [stderr] 296 | | // Basic cases [INFO] [stderr] 297 | | assert_done!(key_value_line(b"hello=world\n"), (String::from("hello"), String::from("world"))); [INFO] [stderr] 298 | | assert_done!(key_value_line(b"hello=world"), (String::from("hello"), String::from("world"))); [INFO] [stderr] ... | [INFO] [stderr] 342 | | assert_done!(key_value_line(b"vw 1\\\n2"), (String::from("vw"), String::from("12"))); [INFO] [stderr] 343 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/parsers/mod.rs:366:5 [INFO] [stderr] | [INFO] [stderr] 366 | / fn test_comment() { [INFO] [stderr] 367 | | [INFO] [stderr] 368 | | // Comments starting with # [INFO] [stderr] 369 | | assert_done!(comment_line(b"#hello\n"), ()); [INFO] [stderr] ... | [INFO] [stderr] 400 | | assert_done_partial!(comment_line(b"# \t \r\nhello"), (), b"hello"); [INFO] [stderr] 401 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.41s [INFO] running `"docker" "inspect" "396178768c15fefda6cb2d467fc64889dca1476ace675d127857095658fdee76"` [INFO] running `"docker" "rm" "-f" "396178768c15fefda6cb2d467fc64889dca1476ace675d127857095658fdee76"` [INFO] [stdout] 396178768c15fefda6cb2d467fc64889dca1476ace675d127857095658fdee76