[INFO] crate dotfilesctl 0.1.0 is already in cache [INFO] extracting crate dotfilesctl 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/dotfilesctl/0.1.0 [INFO] extracting crate dotfilesctl 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dotfilesctl/0.1.0 [INFO] validating manifest of dotfilesctl-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dotfilesctl-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dotfilesctl-0.1.0 [INFO] finished frobbing dotfilesctl-0.1.0 [INFO] frobbed toml for dotfilesctl-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/dotfilesctl/0.1.0/Cargo.toml [INFO] started frobbing dotfilesctl-0.1.0 [INFO] finished frobbing dotfilesctl-0.1.0 [INFO] frobbed toml for dotfilesctl-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dotfilesctl/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dotfilesctl-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/dotfilesctl/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 930af68de4e2de5026d691c2eb603f9507eca435747080c2daa227da6c4036d5 [INFO] running `"docker" "start" "-a" "930af68de4e2de5026d691c2eb603f9507eca435747080c2daa227da6c4036d5"` [INFO] [stderr] Checking proptest v0.4.2 [INFO] [stderr] Checking dotfilesctl v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/config.rs:29:41 [INFO] [stderr] | [INFO] [stderr] 29 | match self.home.clone().or_else(env::home_dir) { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `canonicalize_light` [INFO] [stderr] --> src/paths.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn canonicalize_light>(path: P) -> PathBuf { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/config.rs:29:41 [INFO] [stderr] | [INFO] [stderr] 29 | match self.home.clone().or_else(env::home_dir) { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/dotfiles.rs:281:28 [INFO] [stderr] | [INFO] [stderr] 281 | File::create(path).expect(msg.as_ref()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| { let msg = msg.as_ref(); panic!(msg) }))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/dotfiles.rs:296:33 [INFO] [stderr] | [INFO] [stderr] 296 | unix::symlink(src, dst).expect(msg.as_ref()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| { let msg = msg.as_ref(); panic!(msg) }))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/dotfiles.rs:302:28 [INFO] [stderr] | [INFO] [stderr] 302 | File::create(path).expect(msg.as_ref()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| { let msg = msg.as_ref(); panic!(msg) }))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 16.18s [INFO] running `"docker" "inspect" "930af68de4e2de5026d691c2eb603f9507eca435747080c2daa227da6c4036d5"` [INFO] running `"docker" "rm" "-f" "930af68de4e2de5026d691c2eb603f9507eca435747080c2daa227da6c4036d5"` [INFO] [stdout] 930af68de4e2de5026d691c2eb603f9507eca435747080c2daa227da6c4036d5