[INFO] crate dotenv 0.13.0 is already in cache [INFO] extracting crate dotenv 0.13.0 into work/ex/clippy-test-run/sources/stable/reg/dotenv/0.13.0 [INFO] extracting crate dotenv 0.13.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dotenv/0.13.0 [INFO] validating manifest of dotenv-0.13.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dotenv-0.13.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dotenv-0.13.0 [INFO] finished frobbing dotenv-0.13.0 [INFO] frobbed toml for dotenv-0.13.0 written to work/ex/clippy-test-run/sources/stable/reg/dotenv/0.13.0/Cargo.toml [INFO] started frobbing dotenv-0.13.0 [INFO] finished frobbing dotenv-0.13.0 [INFO] frobbed toml for dotenv-0.13.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dotenv/0.13.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dotenv-0.13.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/dotenv/0.13.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d323336f9c90d9a3201d68f86ed66299330463d24397aa818f4bfe5e947ea210 [INFO] running `"docker" "start" "-a" "d323336f9c90d9a3201d68f86ed66299330463d24397aa818f4bfe5e947ea210"` [INFO] [stderr] Checking failure v0.1.5 [INFO] [stderr] Checking dotenv v0.13.0 (/opt/crater/workdir) [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/parse.rs:28:21 [INFO] [stderr] | [INFO] [stderr] 28 | .map_or(Err(Error::LineParse(line.into()).into()), |captures| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Error::LineParse(line.into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/parse.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | Err(Error::LineParse(input.to_owned()).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Error::LineParse(input.to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/parse.rs:28:21 [INFO] [stderr] | [INFO] [stderr] 28 | .map_or(Err(Error::LineParse(line.into()).into()), |captures| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Error::LineParse(line.into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/parse.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | Err(Error::LineParse(input.to_owned()).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Error::LineParse(input.to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/parse.rs:147:37 [INFO] [stderr] | [INFO] [stderr] 147 | let actual_iter = Iter::new(r#" [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 148 | | KEY=1 [INFO] [stderr] 149 | | KEY2="2" [INFO] [stderr] 150 | | KEY3='3' [INFO] [stderr] ... | [INFO] [stderr] 157 | | export SHELL_LOVER=1 [INFO] [stderr] 158 | | "#.as_bytes()); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 147 | let actual_iter = Iter::new(br#" [INFO] [stderr] 148 | KEY=1 [INFO] [stderr] 149 | KEY2="2" [INFO] [stderr] 150 | KEY3='3' [INFO] [stderr] 151 | KEY4='fo ur' [INFO] [stderr] 152 | KEY5="fi ve" [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/parse.rs:186:63 [INFO] [stderr] | [INFO] [stderr] 186 | let result: Result> = Iter::new(r#" [INFO] [stderr] | _______________________________________________________________^ [INFO] [stderr] 187 | | # foo=bar [INFO] [stderr] 188 | | # "#.as_bytes()).collect(); [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 186 | let result: Result> = Iter::new(br#" [INFO] [stderr] 187 | # foo=bar [INFO] [stderr] 188 | # "#).collect(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/parse.rs:194:37 [INFO] [stderr] | [INFO] [stderr] 194 | let actual_iter = Iter::new(r#" [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 195 | | invalid [INFO] [stderr] 196 | | KEY =val [INFO] [stderr] 197 | | KEY2= val [INFO] [stderr] 198 | | very bacon = yes indeed [INFO] [stderr] 199 | | =value"#.as_bytes()); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 194 | let actual_iter = Iter::new(br#" [INFO] [stderr] 195 | invalid [INFO] [stderr] 196 | KEY =val [INFO] [stderr] 197 | KEY2= val [INFO] [stderr] 198 | very bacon = yes indeed [INFO] [stderr] 199 | =value"#); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/parse.rs:211:37 [INFO] [stderr] | [INFO] [stderr] 211 | let actual_iter = Iter::new(r#" [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 212 | | KEY=my\ cool\ value [INFO] [stderr] 213 | | KEY2=\$sweet [INFO] [stderr] 214 | | KEY3="awesome stuff \"mang\"" [INFO] [stderr] ... | [INFO] [stderr] 217 | | KEY6="lol" #well you see when I say lol wh [INFO] [stderr] 218 | | "#.as_bytes()); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 211 | let actual_iter = Iter::new(br#" [INFO] [stderr] 212 | KEY=my\ cool\ value [INFO] [stderr] 213 | KEY2=\$sweet [INFO] [stderr] 214 | KEY3="awesome stuff \"mang\"" [INFO] [stderr] 215 | KEY4='sweet $\fgs'\''fds' [INFO] [stderr] 216 | KEY5="'\"yay\\"\ "stuff" [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/parse.rs:238:37 [INFO] [stderr] | [INFO] [stderr] 238 | let actual_iter = Iter::new(r#" [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 239 | | KEY=my uncool value [INFO] [stderr] 240 | | KEY2=$notcool [INFO] [stderr] 241 | | KEY3="why [INFO] [stderr] 242 | | KEY4='please stop'' [INFO] [stderr] 243 | | KEY5=h\8u [INFO] [stderr] 244 | | "#.as_bytes()); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 238 | let actual_iter = Iter::new(br#" [INFO] [stderr] 239 | KEY=my uncool value [INFO] [stderr] 240 | KEY2=$notcool [INFO] [stderr] 241 | KEY3="why [INFO] [stderr] 242 | KEY4='please stop'' [INFO] [stderr] 243 | KEY5=h\8u [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.69s [INFO] running `"docker" "inspect" "d323336f9c90d9a3201d68f86ed66299330463d24397aa818f4bfe5e947ea210"` [INFO] running `"docker" "rm" "-f" "d323336f9c90d9a3201d68f86ed66299330463d24397aa818f4bfe5e947ea210"` [INFO] [stdout] d323336f9c90d9a3201d68f86ed66299330463d24397aa818f4bfe5e947ea210