[INFO] crate dot_vox 4.0.0 is already in cache [INFO] extracting crate dot_vox 4.0.0 into work/ex/clippy-test-run/sources/stable/reg/dot_vox/4.0.0 [INFO] extracting crate dot_vox 4.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dot_vox/4.0.0 [INFO] validating manifest of dot_vox-4.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dot_vox-4.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dot_vox-4.0.0 [INFO] finished frobbing dot_vox-4.0.0 [INFO] frobbed toml for dot_vox-4.0.0 written to work/ex/clippy-test-run/sources/stable/reg/dot_vox/4.0.0/Cargo.toml [INFO] started frobbing dot_vox-4.0.0 [INFO] finished frobbing dot_vox-4.0.0 [INFO] frobbed toml for dot_vox-4.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dot_vox/4.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dot_vox-4.0.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/dot_vox/4.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b81aec82de150119a31629b8a9883d9377453a73fe403c7b00e0248a5bd8a77d [INFO] running `"docker" "start" "-a" "b81aec82de150119a31629b8a9883d9377453a73fe403c7b00e0248a5bd8a77d"` [INFO] [stderr] Checking avow v0.2.0 [INFO] [stderr] Checking dot_vox v4.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:198:13 [INFO] [stderr] | [INFO] [stderr] 198 | palette: palette, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `palette` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:199:13 [INFO] [stderr] | [INFO] [stderr] 199 | materials: materials, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `materials` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:198:13 [INFO] [stderr] | [INFO] [stderr] 198 | palette: palette, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `palette` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:199:13 [INFO] [stderr] | [INFO] [stderr] 199 | materials: materials, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `materials` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parser.rs:8:22 [INFO] [stderr] | [INFO] [stderr] 8 | const MAGIC_NUMBER: &'static str = "VOX "; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:43:16 [INFO] [stderr] | [INFO] [stderr] 43 | let res = ((i[3] as u32) << 24) + ((i[2] as u32) << 16) + ((i[1] as u32) << 8) + i[0] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(i[3])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:43:40 [INFO] [stderr] | [INFO] [stderr] 43 | let res = ((i[3] as u32) << 24) + ((i[2] as u32) << 16) + ((i[1] as u32) << 8) + i[0] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(i[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:43:64 [INFO] [stderr] | [INFO] [stderr] 43 | let res = ((i[3] as u32) << 24) + ((i[2] as u32) << 16) + ((i[1] as u32) << 8) + i[0] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(i[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:43:86 [INFO] [stderr] | [INFO] [stderr] 43 | let res = ((i[3] as u32) << 24) + ((i[2] as u32) << 16) + ((i[1] as u32) << 8) + i[0] as u32; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(i[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parser.rs:8:22 [INFO] [stderr] | [INFO] [stderr] 8 | const MAGIC_NUMBER: &'static str = "VOX "; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:43:16 [INFO] [stderr] | [INFO] [stderr] 43 | let res = ((i[3] as u32) << 24) + ((i[2] as u32) << 16) + ((i[1] as u32) << 8) + i[0] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(i[3])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:43:40 [INFO] [stderr] | [INFO] [stderr] 43 | let res = ((i[3] as u32) << 24) + ((i[2] as u32) << 16) + ((i[1] as u32) << 8) + i[0] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(i[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:43:64 [INFO] [stderr] | [INFO] [stderr] 43 | let res = ((i[3] as u32) << 24) + ((i[2] as u32) << 16) + ((i[1] as u32) << 8) + i[0] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(i[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:43:86 [INFO] [stderr] | [INFO] [stderr] 43 | let res = ((i[3] as u32) << 24) + ((i[2] as u32) << 16) + ((i[1] as u32) << 8) + i[0] as u32; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(i[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:168:53 [INFO] [stderr] | [INFO] [stderr] 168 | static ref DEFAULT_MATERIALS: Vec = (0..256).into_iter() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..256)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _log =` [INFO] [stderr] --> src/lib.rs:247:9 [INFO] [stderr] | [INFO] [stderr] 247 | let _log = env_logger::init(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.32s [INFO] running `"docker" "inspect" "b81aec82de150119a31629b8a9883d9377453a73fe403c7b00e0248a5bd8a77d"` [INFO] running `"docker" "rm" "-f" "b81aec82de150119a31629b8a9883d9377453a73fe403c7b00e0248a5bd8a77d"` [INFO] [stdout] b81aec82de150119a31629b8a9883d9377453a73fe403c7b00e0248a5bd8a77d