[INFO] crate dot_json 0.2.0 is already in cache [INFO] extracting crate dot_json 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/dot_json/0.2.0 [INFO] extracting crate dot_json 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dot_json/0.2.0 [INFO] validating manifest of dot_json-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dot_json-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dot_json-0.2.0 [INFO] finished frobbing dot_json-0.2.0 [INFO] frobbed toml for dot_json-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/dot_json/0.2.0/Cargo.toml [INFO] started frobbing dot_json-0.2.0 [INFO] finished frobbing dot_json-0.2.0 [INFO] frobbed toml for dot_json-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dot_json/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dot_json-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/dot_json/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fa6aee2325f21480bf091e4bbf041a167b194eab54763cd7728eb026681a4e1c [INFO] running `"docker" "start" "-a" "fa6aee2325f21480bf091e4bbf041a167b194eab54763cd7728eb026681a4e1c"` [INFO] [stderr] Checking dot_json v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:8:84 [INFO] [stderr] | [INFO] [stderr] 8 | fn traverse_dot(src: &Map, dest: &mut Map, inc_path: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 8 | fn traverse_dot(src: &Map, dest: &mut Map, inc_path: &[String]) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] help: change `inc_path.clone()` to [INFO] [stderr] | [INFO] [stderr] 11| let mut path = inc_path.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | / match value { [INFO] [stderr] 16 | | &Value::Array(ref a) => { [INFO] [stderr] 17 | | traverse_dot(&arr_to_dot_map(&a), dest, &path); [INFO] [stderr] 18 | | }, [INFO] [stderr] ... | [INFO] [stderr] 33 | | }, [INFO] [stderr] 34 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 15 | match *value { [INFO] [stderr] 16 | Value::Array(ref a) => { [INFO] [stderr] 17 | traverse_dot(&arr_to_dot_map(&a), dest, &path); [INFO] [stderr] 18 | }, [INFO] [stderr] 19 | Value::Object(ref m) => { [INFO] [stderr] 20 | traverse_dot(m, dest, &path); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:104:28 [INFO] [stderr] | [INFO] [stderr] 104 | pub fn arr_to_dot_map(src: &Vec) -> Map { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Value]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the variable `cnt` is used as a loop counter. Consider using `for (cnt, item) in src.enumerate()` or similar iterators [INFO] [stderr] --> src/lib.rs:108:14 [INFO] [stderr] | [INFO] [stderr] 108 | for v in src { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:173:5 [INFO] [stderr] | [INFO] [stderr] 173 | / match src { [INFO] [stderr] 174 | | &Value::Array(ref a) => Value::Object(arr_to_dot_map(a)), [INFO] [stderr] 175 | | &Value::Object(ref m) => Value::Object(map_to_dot_map(m)), [INFO] [stderr] 176 | | &Value::Null => Value::Null, [INFO] [stderr] ... | [INFO] [stderr] 179 | | &Value::Bool(ref b) => Value::Bool(*b), [INFO] [stderr] 180 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 173 | match *src { [INFO] [stderr] 174 | Value::Array(ref a) => Value::Object(arr_to_dot_map(a)), [INFO] [stderr] 175 | Value::Object(ref m) => Value::Object(map_to_dot_map(m)), [INFO] [stderr] 176 | Value::Null => Value::Null, [INFO] [stderr] 177 | Value::String(ref s) => Value::String(s.clone()), [INFO] [stderr] 178 | Value::Number(ref n) => Value::Number(n.clone()), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:8:84 [INFO] [stderr] | [INFO] [stderr] 8 | fn traverse_dot(src: &Map, dest: &mut Map, inc_path: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 8 | fn traverse_dot(src: &Map, dest: &mut Map, inc_path: &[String]) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] help: change `inc_path.clone()` to [INFO] [stderr] | [INFO] [stderr] 11| let mut path = inc_path.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | / match value { [INFO] [stderr] 16 | | &Value::Array(ref a) => { [INFO] [stderr] 17 | | traverse_dot(&arr_to_dot_map(&a), dest, &path); [INFO] [stderr] 18 | | }, [INFO] [stderr] ... | [INFO] [stderr] 33 | | }, [INFO] [stderr] 34 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 15 | match *value { [INFO] [stderr] 16 | Value::Array(ref a) => { [INFO] [stderr] 17 | traverse_dot(&arr_to_dot_map(&a), dest, &path); [INFO] [stderr] 18 | }, [INFO] [stderr] 19 | Value::Object(ref m) => { [INFO] [stderr] 20 | traverse_dot(m, dest, &path); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:104:28 [INFO] [stderr] | [INFO] [stderr] 104 | pub fn arr_to_dot_map(src: &Vec) -> Map { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Value]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the variable `cnt` is used as a loop counter. Consider using `for (cnt, item) in src.enumerate()` or similar iterators [INFO] [stderr] --> src/lib.rs:108:14 [INFO] [stderr] | [INFO] [stderr] 108 | for v in src { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:173:5 [INFO] [stderr] | [INFO] [stderr] 173 | / match src { [INFO] [stderr] 174 | | &Value::Array(ref a) => Value::Object(arr_to_dot_map(a)), [INFO] [stderr] 175 | | &Value::Object(ref m) => Value::Object(map_to_dot_map(m)), [INFO] [stderr] 176 | | &Value::Null => Value::Null, [INFO] [stderr] ... | [INFO] [stderr] 179 | | &Value::Bool(ref b) => Value::Bool(*b), [INFO] [stderr] 180 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 173 | match *src { [INFO] [stderr] 174 | Value::Array(ref a) => Value::Object(arr_to_dot_map(a)), [INFO] [stderr] 175 | Value::Object(ref m) => Value::Object(map_to_dot_map(m)), [INFO] [stderr] 176 | Value::Null => Value::Null, [INFO] [stderr] 177 | Value::String(ref s) => Value::String(s.clone()), [INFO] [stderr] 178 | Value::Number(ref n) => Value::Number(n.clone()), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.22s [INFO] running `"docker" "inspect" "fa6aee2325f21480bf091e4bbf041a167b194eab54763cd7728eb026681a4e1c"` [INFO] running `"docker" "rm" "-f" "fa6aee2325f21480bf091e4bbf041a167b194eab54763cd7728eb026681a4e1c"` [INFO] [stdout] fa6aee2325f21480bf091e4bbf041a167b194eab54763cd7728eb026681a4e1c