[INFO] crate dot 0.1.4 is already in cache
[INFO] extracting crate dot 0.1.4 into work/ex/clippy-test-run/sources/stable/reg/dot/0.1.4
[INFO] extracting crate dot 0.1.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dot/0.1.4
[INFO] validating manifest of dot-0.1.4 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of dot-0.1.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing dot-0.1.4
[INFO] finished frobbing dot-0.1.4
[INFO] frobbed toml for dot-0.1.4 written to work/ex/clippy-test-run/sources/stable/reg/dot/0.1.4/Cargo.toml
[INFO] started frobbing dot-0.1.4
[INFO] finished frobbing dot-0.1.4
[INFO] frobbed toml for dot-0.1.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dot/0.1.4/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting dot-0.1.4 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/dot/0.1.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 3ce15189fcc308cf4126cf7a02d74a65a365184ae8ace10206d475952d1ea64c
[INFO] running `"docker" "start" "-a" "3ce15189fcc308cf4126cf7a02d74a65a365184ae8ace10206d475952d1ea64c"`
[INFO] [stderr]     Checking dot v0.1.4 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:406:23
[INFO] [stderr]     |
[INFO] [stderr] 406 |         return Ok(Id{ name: name });
[INFO] [stderr]     |                       ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/lib.rs:939:9
[INFO] [stderr]     |
[INFO] [stderr] 939 |         write!(w, "\n")
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]     --> src/lib.rs:1080:13
[INFO] [stderr]      |
[INFO] [stderr] 1080 |             from: from,
[INFO] [stderr]      |             ^^^^^^^^^^ help: replace it with: `from`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]     --> src/lib.rs:1081:13
[INFO] [stderr]      |
[INFO] [stderr] 1081 |             to: to,
[INFO] [stderr]      |             ^^^^^^ help: replace it with: `to`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]     --> src/lib.rs:1082:13
[INFO] [stderr]      |
[INFO] [stderr] 1082 |             label: label,
[INFO] [stderr]      |             ^^^^^^^^^^^^ help: replace it with: `label`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]     --> src/lib.rs:1083:13
[INFO] [stderr]      |
[INFO] [stderr] 1083 |             style: style,
[INFO] [stderr]      |             ^^^^^^^^^^^^ help: replace it with: `style`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]     --> src/lib.rs:1086:13
[INFO] [stderr]      |
[INFO] [stderr] 1086 |             color: color,
[INFO] [stderr]      |             ^^^^^^^^^^^^ help: replace it with: `color`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]     --> src/lib.rs:1094:13
[INFO] [stderr]      |
[INFO] [stderr] 1094 |             from: from,
[INFO] [stderr]      |             ^^^^^^^^^^ help: replace it with: `from`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]     --> src/lib.rs:1095:13
[INFO] [stderr]      |
[INFO] [stderr] 1095 |             to: to,
[INFO] [stderr]      |             ^^^^^^ help: replace it with: `to`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]     --> src/lib.rs:1096:13
[INFO] [stderr]      |
[INFO] [stderr] 1096 |             label: label,
[INFO] [stderr]      |             ^^^^^^^^^^^^ help: replace it with: `label`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]     --> src/lib.rs:1097:13
[INFO] [stderr]      |
[INFO] [stderr] 1097 |             style: style,
[INFO] [stderr]      |             ^^^^^^^^^^^^ help: replace it with: `style`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]     --> src/lib.rs:1098:13
[INFO] [stderr]      |
[INFO] [stderr] 1098 |             start_arrow: start_arrow,
[INFO] [stderr]      |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start_arrow`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]     --> src/lib.rs:1099:13
[INFO] [stderr]      |
[INFO] [stderr] 1099 |             end_arrow: end_arrow,
[INFO] [stderr]      |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `end_arrow`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]     --> src/lib.rs:1100:13
[INFO] [stderr]      |
[INFO] [stderr] 1100 |             color: color,
[INFO] [stderr]      |             ^^^^^^^^^^^^ help: replace it with: `color`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]     --> src/lib.rs:1165:17
[INFO] [stderr]      |
[INFO] [stderr] 1165 |                 name: name,
[INFO] [stderr]      |                 ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]     --> src/lib.rs:1167:17
[INFO] [stderr]      |
[INFO] [stderr] 1167 |                 edges: edges,
[INFO] [stderr]      |                 ^^^^^^^^^^^^ help: replace it with: `edges`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]     --> src/lib.rs:1553:17
[INFO] [stderr]      |
[INFO] [stderr] 1553 |                 name: name,
[INFO] [stderr]      |                 ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]     --> src/lib.rs:1554:17
[INFO] [stderr]      |
[INFO] [stderr] 1554 |                 nodes: nodes,
[INFO] [stderr]      |                 ^^^^^^^^^^^^ help: replace it with: `nodes`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]     --> src/lib.rs:1555:17
[INFO] [stderr]      |
[INFO] [stderr] 1555 |                 edges: edges,
[INFO] [stderr]      |                 ^^^^^^^^^^^^ help: replace it with: `edges`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]     --> src/lib.rs:1556:17
[INFO] [stderr]      |
[INFO] [stderr] 1556 |                 kind: kind,
[INFO] [stderr]      |                 ^^^^^^^^^^ help: replace it with: `kind`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:406:23
[INFO] [stderr]     |
[INFO] [stderr] 406 |         return Ok(Id{ name: name });
[INFO] [stderr]     |                       ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/lib.rs:939:9
[INFO] [stderr]     |
[INFO] [stderr] 939 |         write!(w, "\n")
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]     --> src/lib.rs:1080:13
[INFO] [stderr]      |
[INFO] [stderr] 1080 |             from: from,
[INFO] [stderr]      |             ^^^^^^^^^^ help: replace it with: `from`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]     --> src/lib.rs:1081:13
[INFO] [stderr]      |
[INFO] [stderr] 1081 |             to: to,
[INFO] [stderr]      |             ^^^^^^ help: replace it with: `to`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]     --> src/lib.rs:1082:13
[INFO] [stderr]      |
[INFO] [stderr] 1082 |             label: label,
[INFO] [stderr]      |             ^^^^^^^^^^^^ help: replace it with: `label`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]     --> src/lib.rs:1083:13
[INFO] [stderr]      |
[INFO] [stderr] 1083 |             style: style,
[INFO] [stderr]      |             ^^^^^^^^^^^^ help: replace it with: `style`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]     --> src/lib.rs:1086:13
[INFO] [stderr]      |
[INFO] [stderr] 1086 |             color: color,
[INFO] [stderr]      |             ^^^^^^^^^^^^ help: replace it with: `color`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]     --> src/lib.rs:1094:13
[INFO] [stderr]      |
[INFO] [stderr] 1094 |             from: from,
[INFO] [stderr]      |             ^^^^^^^^^^ help: replace it with: `from`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]     --> src/lib.rs:1095:13
[INFO] [stderr]      |
[INFO] [stderr] 1095 |             to: to,
[INFO] [stderr]      |             ^^^^^^ help: replace it with: `to`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]     --> src/lib.rs:1096:13
[INFO] [stderr]      |
[INFO] [stderr] 1096 |             label: label,
[INFO] [stderr]      |             ^^^^^^^^^^^^ help: replace it with: `label`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]     --> src/lib.rs:1097:13
[INFO] [stderr]      |
[INFO] [stderr] 1097 |             style: style,
[INFO] [stderr]      |             ^^^^^^^^^^^^ help: replace it with: `style`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]     --> src/lib.rs:1098:13
[INFO] [stderr]      |
[INFO] [stderr] 1098 |             start_arrow: start_arrow,
[INFO] [stderr]      |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start_arrow`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]     --> src/lib.rs:1099:13
[INFO] [stderr]      |
[INFO] [stderr] 1099 |             end_arrow: end_arrow,
[INFO] [stderr]      |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `end_arrow`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]     --> src/lib.rs:1100:13
[INFO] [stderr]      |
[INFO] [stderr] 1100 |             color: color,
[INFO] [stderr]      |             ^^^^^^^^^^^^ help: replace it with: `color`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]     --> src/lib.rs:1165:17
[INFO] [stderr]      |
[INFO] [stderr] 1165 |                 name: name,
[INFO] [stderr]      |                 ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]     --> src/lib.rs:1167:17
[INFO] [stderr]      |
[INFO] [stderr] 1167 |                 edges: edges,
[INFO] [stderr]      |                 ^^^^^^^^^^^^ help: replace it with: `edges`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]     --> src/lib.rs:1553:17
[INFO] [stderr]      |
[INFO] [stderr] 1553 |                 name: name,
[INFO] [stderr]      |                 ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]     --> src/lib.rs:1554:17
[INFO] [stderr]      |
[INFO] [stderr] 1554 |                 nodes: nodes,
[INFO] [stderr]      |                 ^^^^^^^^^^^^ help: replace it with: `nodes`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]     --> src/lib.rs:1555:17
[INFO] [stderr]      |
[INFO] [stderr] 1555 |                 edges: edges,
[INFO] [stderr]      |                 ^^^^^^^^^^^^ help: replace it with: `edges`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]     --> src/lib.rs:1556:17
[INFO] [stderr]      |
[INFO] [stderr] 1556 |                 kind: kind,
[INFO] [stderr]      |                 ^^^^^^^^^^ help: replace it with: `kind`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:564:9
[INFO] [stderr]     |
[INFO] [stderr] 564 | /         match self {
[INFO] [stderr] 565 | |             &LabelStr(ref s) => format!("\"{}\"", LabelText::escape_default(s)),
[INFO] [stderr] 566 | |             &EscStr(ref s) => format!("\"{}\"", LabelText::escape_str(&s[..])),
[INFO] [stderr] 567 | |             &HtmlStr(ref s) => format!("<{}>", s),
[INFO] [stderr] 568 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 564 |         match *self {
[INFO] [stderr] 565 |             LabelStr(ref s) => format!("\"{}\"", LabelText::escape_default(s)),
[INFO] [stderr] 566 |             EscStr(ref s) => format!("\"{}\"", LabelText::escape_str(&s[..])),
[INFO] [stderr] 567 |             HtmlStr(ref s) => format!("<{}>", s),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:800:26
[INFO] [stderr]     |
[INFO] [stderr] 800 |     pub fn to_dot_string(&self) -> String {
[INFO] [stderr]     |                          ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:852:16
[INFO] [stderr]     |
[INFO] [stderr] 852 |     fn keyword(&self) -> &'static str {
[INFO] [stderr]     |                ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:860:15
[INFO] [stderr]     |
[INFO] [stderr] 860 |     fn edgeop(&self) -> &'static str {
[INFO] [stderr]     |               ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:564:9
[INFO] [stderr]     |
[INFO] [stderr] 564 | /         match self {
[INFO] [stderr] 565 | |             &LabelStr(ref s) => format!("\"{}\"", LabelText::escape_default(s)),
[INFO] [stderr] 566 | |             &EscStr(ref s) => format!("\"{}\"", LabelText::escape_str(&s[..])),
[INFO] [stderr] 567 | |             &HtmlStr(ref s) => format!("<{}>", s),
[INFO] [stderr] 568 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 564 |         match *self {
[INFO] [stderr] 565 |             LabelStr(ref s) => format!("\"{}\"", LabelText::escape_default(s)),
[INFO] [stderr] 566 |             EscStr(ref s) => format!("\"{}\"", LabelText::escape_str(&s[..])),
[INFO] [stderr] 567 |             HtmlStr(ref s) => format!("<{}>", s),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:800:26
[INFO] [stderr]     |
[INFO] [stderr] 800 |     pub fn to_dot_string(&self) -> String {
[INFO] [stderr]     |                          ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:852:16
[INFO] [stderr]     |
[INFO] [stderr] 852 |     fn keyword(&self) -> &'static str {
[INFO] [stderr]     |                ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:860:15
[INFO] [stderr]     |
[INFO] [stderr] 860 |     fn edgeop(&self) -> &'static str {
[INFO] [stderr]     |               ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]     --> src/lib.rs:1143:64
[INFO] [stderr]      |
[INFO] [stderr] 1143 |                 AllNodesLabelled(lbls) => lbls.into_iter().map(|l| Some(l)).collect(),
[INFO] [stderr]      |                                                                ^^^^^^^^^^^ help: remove closure as shown: `Some`
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]     --> src/lib.rs:1149:13
[INFO] [stderr]      |
[INFO] [stderr] 1149 | /             match self {
[INFO] [stderr] 1150 | |                 &UnlabelledNodes(len) => len,
[INFO] [stderr] 1151 | |                 &AllNodesLabelled(ref lbls) => lbls.len(),
[INFO] [stderr] 1152 | |                 &SomeNodesLabelled(ref lbls) => lbls.len(),
[INFO] [stderr] 1153 | |             }
[INFO] [stderr]      | |_____________^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]      |
[INFO] [stderr] 1149 |             match *self {
[INFO] [stderr] 1150 |                 UnlabelledNodes(len) => len,
[INFO] [stderr] 1151 |                 AllNodesLabelled(ref lbls) => lbls.len(),
[INFO] [stderr] 1152 |                 SomeNodesLabelled(ref lbls) => lbls.len(),
[INFO] [stderr]      |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]     --> src/lib.rs:1185:23
[INFO] [stderr]      |
[INFO] [stderr] 1185 |     fn id_name<'a>(n: &Node) -> Id<'a> {
[INFO] [stderr]      |                       ^^^^^ help: consider passing by value instead: `Node`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]     --> src/lib.rs:1529:9
[INFO] [stderr]      |
[INFO] [stderr] 1529 | /         match id2 {
[INFO] [stderr] 1530 | |             Ok(_) => panic!("graphviz id suddenly allows spaces, brackets and stuff"),
[INFO] [stderr] 1531 | |             Err(..) => {}
[INFO] [stderr] 1532 | |         }
[INFO] [stderr]      | |_________^ help: try this: `if let Ok(_) = id2 { panic!("graphviz id suddenly allows spaces, brackets and stuff") }`
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.15s
[INFO] running `"docker" "inspect" "3ce15189fcc308cf4126cf7a02d74a65a365184ae8ace10206d475952d1ea64c"`
[INFO] running `"docker" "rm" "-f" "3ce15189fcc308cf4126cf7a02d74a65a365184ae8ace10206d475952d1ea64c"`
[INFO] [stdout] 3ce15189fcc308cf4126cf7a02d74a65a365184ae8ace10206d475952d1ea64c