[INFO] crate doq 0.1.0 is already in cache [INFO] extracting crate doq 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/doq/0.1.0 [INFO] extracting crate doq 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/doq/0.1.0 [INFO] validating manifest of doq-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of doq-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing doq-0.1.0 [INFO] finished frobbing doq-0.1.0 [INFO] frobbed toml for doq-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/doq/0.1.0/Cargo.toml [INFO] started frobbing doq-0.1.0 [INFO] finished frobbing doq-0.1.0 [INFO] frobbed toml for doq-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/doq/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting doq-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/doq/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] af3a74a55ef39d747ec6049fe2cc45543d054d20b24a139e583acc39d844d4c7 [INFO] running `"docker" "start" "-a" "af3a74a55ef39d747ec6049fe2cc45543d054d20b24a139e583acc39d844d4c7"` [INFO] [stderr] Checking close_enough v0.2.1 [INFO] [stderr] Checking doq v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:201:28 [INFO] [stderr] | [INFO] [stderr] 201 | let home = std::env::home_dir().or_fail("Failed to find home directory"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:201:28 [INFO] [stderr] | [INFO] [stderr] 201 | let home = std::env::home_dir().or_fail("Failed to find home directory"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:208:17 [INFO] [stderr] | [INFO] [stderr] 208 | PathBuf::from(config.schedule_file) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `config.schedule_file` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/main.rs:225:16 [INFO] [stderr] | [INFO] [stderr] 225 | if schedule.tasks.iter().find(|t| t.name == name).is_some() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|t| t.name == name).is_some()` with `any(|t| t.name == name)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:260:31 [INFO] [stderr] | [INFO] [stderr] 260 | let proceed = match yes [INFO] [stderr] | _______________________________^ [INFO] [stderr] 261 | | { [INFO] [stderr] 262 | | true => true, [INFO] [stderr] 263 | | false => [INFO] [stderr] ... | [INFO] [stderr] 271 | | } [INFO] [stderr] 272 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 260 | let proceed = if yes { true } else { [INFO] [stderr] 261 | println!("Mark task '{}' as done on {}? (y/N) ", task.name, date); [INFO] [stderr] 262 | let mut buffer = String::new(); [INFO] [stderr] 263 | std::io::stdin().read_line(&mut buffer).or_fail("Failed to read from stdin"); [INFO] [stderr] 264 | [INFO] [stderr] 265 | let command = buffer.trim().to_lowercase(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:337:42 [INFO] [stderr] | [INFO] [stderr] 337 | (yellow, format!("(Due today)")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"(Due today)".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:208:17 [INFO] [stderr] | [INFO] [stderr] 208 | PathBuf::from(config.schedule_file) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `config.schedule_file` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/main.rs:225:16 [INFO] [stderr] | [INFO] [stderr] 225 | if schedule.tasks.iter().find(|t| t.name == name).is_some() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|t| t.name == name).is_some()` with `any(|t| t.name == name)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:260:31 [INFO] [stderr] | [INFO] [stderr] 260 | let proceed = match yes [INFO] [stderr] | _______________________________^ [INFO] [stderr] 261 | | { [INFO] [stderr] 262 | | true => true, [INFO] [stderr] 263 | | false => [INFO] [stderr] ... | [INFO] [stderr] 271 | | } [INFO] [stderr] 272 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 260 | let proceed = if yes { true } else { [INFO] [stderr] 261 | println!("Mark task '{}' as done on {}? (y/N) ", task.name, date); [INFO] [stderr] 262 | let mut buffer = String::new(); [INFO] [stderr] 263 | std::io::stdin().read_line(&mut buffer).or_fail("Failed to read from stdin"); [INFO] [stderr] 264 | [INFO] [stderr] 265 | let command = buffer.trim().to_lowercase(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:337:42 [INFO] [stderr] | [INFO] [stderr] 337 | (yellow, format!("(Due today)")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"(Due today)".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.01s [INFO] running `"docker" "inspect" "af3a74a55ef39d747ec6049fe2cc45543d054d20b24a139e583acc39d844d4c7"` [INFO] running `"docker" "rm" "-f" "af3a74a55ef39d747ec6049fe2cc45543d054d20b24a139e583acc39d844d4c7"` [INFO] [stdout] af3a74a55ef39d747ec6049fe2cc45543d054d20b24a139e583acc39d844d4c7