[INFO] crate dono 2.0.0 is already in cache
[INFO] extracting crate dono 2.0.0 into work/ex/clippy-test-run/sources/stable/reg/dono/2.0.0
[INFO] extracting crate dono 2.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dono/2.0.0
[INFO] validating manifest of dono-2.0.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of dono-2.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing dono-2.0.0
[INFO] finished frobbing dono-2.0.0
[INFO] frobbed toml for dono-2.0.0 written to work/ex/clippy-test-run/sources/stable/reg/dono/2.0.0/Cargo.toml
[INFO] started frobbing dono-2.0.0
[INFO] finished frobbing dono-2.0.0
[INFO] frobbed toml for dono-2.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dono/2.0.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting dono-2.0.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/dono/2.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] aee450945b4af6098621c246b218ffd74f39a92992588ee6c2c497aedb8030f9
[INFO] running `"docker" "start" "-a" "aee450945b4af6098621c246b218ffd74f39a92992588ee6c2c497aedb8030f9"`
[INFO] [stderr]     Checking os_type v0.5.0
[INFO] [stderr]     Checking dono v2.0.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/labels.rs:184:21
[INFO] [stderr]     |
[INFO] [stderr] 184 |                     persisted: persisted
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `persisted`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/labels.rs:184:21
[INFO] [stderr]     |
[INFO] [stderr] 184 |                     persisted: persisted
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `persisted`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]    --> src/labels.rs:237:30
[INFO] [stderr]     |
[INFO] [stderr] 237 |     let mut home_directory = env::home_dir().unwrap();
[INFO] [stderr]     |                              ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]    --> src/labels.rs:237:30
[INFO] [stderr]     |
[INFO] [stderr] 237 |     let mut home_directory = env::home_dir().unwrap();
[INFO] [stderr]     |                              ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/labels.rs:25:23
[INFO] [stderr]    |
[INFO] [stderr] 25 |     pub fn new(label: &String) -> Label {
[INFO] [stderr]    |                       ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/labels.rs:33:29
[INFO] [stderr]    |
[INFO] [stderr] 33 |     pub fn new_saved(label: &String) -> Label {
[INFO] [stderr]    |                             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/labels.rs:25:23
[INFO] [stderr]    |
[INFO] [stderr] 25 |     pub fn new(label: &String) -> Label {
[INFO] [stderr]    |                       ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/labels.rs:33:29
[INFO] [stderr]    |
[INFO] [stderr] 33 |     pub fn new_saved(label: &String) -> Label {
[INFO] [stderr]    |                             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/labels.rs:117:44
[INFO] [stderr]     |
[INFO] [stderr] 117 |     fn write_to_store(&self, store_string: &String) -> Result<bool, DonoError> {
[INFO] [stderr]     |                                            ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary
[INFO] [stderr]    --> src/labels.rs:137:5
[INFO] [stderr]     |
[INFO] [stderr] 137 | /     fn ne(&self, other: &Label) -> bool {
[INFO] [stderr] 138 | |         !self.eq(other)
[INFO] [stderr] 139 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::partialeq_ne_impl)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/labels.rs:117:44
[INFO] [stderr]     |
[INFO] [stderr] 117 |     fn write_to_store(&self, store_string: &String) -> Result<bool, DonoError> {
[INFO] [stderr]     |                                            ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary
[INFO] [stderr]    --> src/labels.rs:137:5
[INFO] [stderr]     |
[INFO] [stderr] 137 | /     fn ne(&self, other: &Label) -> bool {
[INFO] [stderr] 138 | |         !self.eq(other)
[INFO] [stderr] 139 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::partialeq_ne_impl)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Dono`
[INFO] [stderr]    --> src/lib.rs:92:5
[INFO] [stderr]     |
[INFO] [stderr] 92  | /     pub fn new() -> Dono {
[INFO] [stderr] 93  | |         Dono {
[INFO] [stderr] 94  | |             min_key_length: 17,
[INFO] [stderr] 95  | |             derived_key_length: 64,
[INFO] [stderr] ...   |
[INFO] [stderr] 127 | |         }
[INFO] [stderr] 128 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 17  | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/lib.rs:131:21
[INFO] [stderr]     |
[INFO] [stderr] 131 |         &self, key: &String, label: &String
[INFO] [stderr]     |                     ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/lib.rs:131:37
[INFO] [stderr]     |
[INFO] [stderr] 131 |         &self, key: &String, label: &String
[INFO] [stderr]     |                                     ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/lib.rs:140:49
[INFO] [stderr]     |
[INFO] [stderr] 140 |     fn number_of_iterations_for_key(&self, key: &String
[INFO] [stderr]     |                                                 ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/lib.rs:169:21
[INFO] [stderr]     |
[INFO] [stderr] 169 |         &self, key: &String, label: &String
[INFO] [stderr]     |                     ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/lib.rs:169:37
[INFO] [stderr]     |
[INFO] [stderr] 169 |         &self, key: &String, label: &String
[INFO] [stderr]     |                                     ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Dono`
[INFO] [stderr]    --> src/lib.rs:92:5
[INFO] [stderr]     |
[INFO] [stderr] 92  | /     pub fn new() -> Dono {
[INFO] [stderr] 93  | |         Dono {
[INFO] [stderr] 94  | |             min_key_length: 17,
[INFO] [stderr] 95  | |             derived_key_length: 64,
[INFO] [stderr] ...   |
[INFO] [stderr] 127 | |         }
[INFO] [stderr] 128 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 17  | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/lib.rs:131:21
[INFO] [stderr]     |
[INFO] [stderr] 131 |         &self, key: &String, label: &String
[INFO] [stderr]     |                     ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/lib.rs:131:37
[INFO] [stderr]     |
[INFO] [stderr] 131 |         &self, key: &String, label: &String
[INFO] [stderr]     |                                     ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/lib.rs:140:49
[INFO] [stderr]     |
[INFO] [stderr] 140 |     fn number_of_iterations_for_key(&self, key: &String
[INFO] [stderr]     |                                                 ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/lib.rs:169:21
[INFO] [stderr]     |
[INFO] [stderr] 169 |         &self, key: &String, label: &String
[INFO] [stderr]     |                     ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/lib.rs:169:37
[INFO] [stderr]     |
[INFO] [stderr] 169 |         &self, key: &String, label: &String
[INFO] [stderr]     |                                     ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]    --> tests/labels.rs:264:30
[INFO] [stderr]     |
[INFO] [stderr] 264 |     let mut home_directory = env::home_dir().unwrap();
[INFO] [stderr]     |                              ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> tests/labels.rs:106:9
[INFO] [stderr]     |
[INFO] [stderr] 106 |     let mut label = labels.last_mut().unwrap();
[INFO] [stderr]     |         ----^^^^^
[INFO] [stderr]     |         |
[INFO] [stderr]     |         help: remove this `mut`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 5.02s
[INFO] running `"docker" "inspect" "aee450945b4af6098621c246b218ffd74f39a92992588ee6c2c497aedb8030f9"`
[INFO] running `"docker" "rm" "-f" "aee450945b4af6098621c246b218ffd74f39a92992588ee6c2c497aedb8030f9"`
[INFO] [stdout] aee450945b4af6098621c246b218ffd74f39a92992588ee6c2c497aedb8030f9